Re: [dpdk-dev] [PATCH v3 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2019-01-04 Thread Eelco Chaudron
On 21 Dec 2018, at 17:15, Dumitrescu, Cristian wrote: Hi Eelco, +/** trTCM parameters per metered traffic flow. The CIR, EIT, CBS and EBS Small typo here: EIT to be replaced by EIR. +parameters only count bytes of IP packets and do not include link specific +headers. The CBS and EBS

Re: [dpdk-dev] [PATCH v3 1/2] lib/librte_meter: add RFC4115 trTCM meter support

2018-12-21 Thread Dumitrescu, Cristian
Hi Eelco, > > +/** trTCM parameters per metered traffic flow. The CIR, EIT, CBS and EBS Small typo here: EIT to be replaced by EIR. > +parameters only count bytes of IP packets and do not include link specific > +headers. The CBS and EBS need to be greater than zero if CIR and EIR are > +none