Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Ananyev, Konstantin
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Wednesday, April 25, 2018 5:44 PM > To: Ananyev, Konstantin > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > olivier.m...@6wind.com; dev@dpdk.org; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com > Subject: Re: [P

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 01:16:38PM +, Ananyev, Konstantin wrote: > > > > > > On Mon, Apr 23, 2018 at 11:53:04AM +, Ananyev, Konstantin wrote: > > [...] > > > > @@ -693,9 +711,14 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > > > > #define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTAC

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Ananyev, Konstantin
> > On Mon, Apr 23, 2018 at 11:53:04AM +, Ananyev, Konstantin wrote: > [...] > > > @@ -693,9 +711,14 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > > > #define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > > > /** > > > + * Returns TRUE if given mbuf has external buffer

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Olivier Matz
Hi, On Mon, Apr 23, 2018 at 06:29:57PM -0700, Yongseok Koh wrote: > On Mon, Apr 23, 2018 at 06:18:43PM +0200, Olivier Matz wrote: > > I'm a bit afraid about ABI breakage, we need to check that a > > 18.02-compiled application still works well with this change. > > I had the same concern so I made

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Yongseok Koh
On Mon, Apr 23, 2018 at 11:53:04AM +, Ananyev, Konstantin wrote: [...] > > @@ -693,9 +711,14 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > > #define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > /** > > + * Returns TRUE if given mbuf has external buffer, or FALSE otherwi

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Yongseok Koh
On Mon, Apr 23, 2018 at 06:18:43PM +0200, Olivier Matz wrote: > Hi Yongseok, > > Please see some comments below. > > On Wed, Apr 18, 2018 at 06:11:04PM -0700, Yongseok Koh wrote: > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer i

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Olivier Matz
Hi Yongseok, Please see some comments below. On Wed, Apr 18, 2018 at 06:11:04PM -0700, Yongseok Koh wrote: > This patch introduces a new way of attaching an external buffer to a mbuf. > > Attaching an external buffer is quite similar to mbuf indirection in > replacing buffer addresses and length

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Ananyev, Konstantin
> > This patch introduces a new way of attaching an external buffer to a mbuf. > > Attaching an external buffer is quite similar to mbuf indirection in > replacing buffer addresses and length of a mbuf, but a few differences: > - As refcnt of a direct mbuf is at least 2, the buffer area of a