Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-05-08 Thread Medvedkin, Vladimir
Hi Honnappa, Thanks for the comments. On 29/04/2020 22:29, Honnappa Nagarahalli wrote: Hi Vladimir, I am not sure which way the decision is made, but few comments inline. Please use C11 built-ins for synchronization. -Original Message- From: dev On Behalf Of Vladimir Medvedk

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-05-08 Thread Medvedkin, Vladimir
Hi Konstantin, Thanks for review, On 23/04/2020 14:31, Ananyev, Konstantin wrote: Hi Vladimir, Apologies for late review. My comments below. K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. This table is hash function agnostic so user must provide precalculated hash s

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-29 Thread Honnappa Nagarahalli
Hi Vladimir, I am not sure which way the decision is made, but few comments inline. Please use C11 built-ins for synchronization. > -Original Message- > From: dev On Behalf Of Vladimir Medvedkin > Sent: Wednesday, April 15, 2020 1:17 PM > To: dev@dpdk.org > Cc: konstantin.anan...

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-23 Thread Ananyev, Konstantin
Hi Vladimir, Apologies for late review. My comments below. > K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. > This table is hash function agnostic so user must provide > precalculated hash signature for add/delete/lookup operations. > > Signed-off-by: Vladimir Medvedki

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-16 Thread Medvedkin, Vladimir
Hi Mattias, -Original Message- From: Mattias Rönnblom Sent: Wednesday, April 15, 2020 8:00 PM To: Medvedkin, Vladimir ; dev@dpdk.org Cc: Ananyev, Konstantin ; Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce Subject: Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library On

Re: [dpdk-dev] [PATCH v3 1/4] hash: add k32v64 hash library

2020-04-15 Thread Mattias Rönnblom
On 2020-04-15 20:17, Vladimir Medvedkin wrote: > K32V64 hash is a hash table that supports 32 bit keys and 64 bit values. > This table is hash function agnostic so user must provide > precalculated hash signature for add/delete/lookup operations. > > Signed-off-by: Vladimir Medvedkin > --- > lib