Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, On Tue, 18 Apr 2017 19:15:51 +0800, "Tan, Jianfeng" wrote: > On 4/18/2017 4:50 PM, Olivier MATZ wrote: > > Hi Jianfeng, > > > > On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" > > wrote: > >> Hi Olivier, > >> > >> If I understand it correctly, this patch is to shift log leve

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Tan, Jianfeng
On 4/18/2017 4:50 PM, Olivier MATZ wrote: Hi Jianfeng, On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: Hi Olivier, If I understand it correctly, this patch is to shift log level setting earlier. But we did not remove the one in eal_parse_common_option(). So we can see this param

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: > Hi Olivier, > > If I understand it correctly, this patch is to shift log level setting > earlier. But we did not remove the one in eal_parse_common_option(). So > we can see this parameter will be analyzed twice. Does i

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-18 Thread Olivier MATZ
Hi Jianfeng, Ferruh, Thank you for spotting these issues. I'm on it, I will send a patch to fix them asap. Olivier On Fri, 14 Apr 2017 16:32:57 +0100, Ferruh Yigit wrote: > Hi Olivier, > > On 4/4/2017 5:40 PM, Olivier Matz wrote: > > Example of use: > > ./app/test-pmd --log-level='pmd\.i40e

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-14 Thread Ferruh Yigit
On 4/4/2017 5:40 PM, Olivier Matz wrote: > Example of use: > ./app/test-pmd --log-level='pmd\.i40e.*,8' > > This enables debug logs for all dynamic logs whose type starts with > 'pmd.i40e'. > > Signed-off-by: Olivier Matz <...> > + > + printf("set log level %s,%lu\n", > +

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-14 Thread Ferruh Yigit
Hi Olivier, On 4/4/2017 5:40 PM, Olivier Matz wrote: > Example of use: > ./app/test-pmd --log-level='pmd\.i40e.*,8' > > This enables debug logs for all dynamic logs whose type starts with > 'pmd.i40e'. > > Signed-off-by: Olivier Matz <...> > index f0ded185b..d98d56d2f 100644 > --- a/lib

Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup

2017-04-13 Thread Tan, Jianfeng
Hi Olivier, If I understand it correctly, this patch is to shift log level setting earlier. But we did not remove the one in eal_parse_common_option(). So we can see this parameter will be analyzed twice. Does it make sense to remove analysis of log level in eal_parse_common_option()? Thanks