Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 5:27 PM, Bruce Richardson wrote: On Fri, Apr 27, 2018 at 04:55:51PM +0100, Burakov, Anatoly wrote: On 27-Apr-18 4:21 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: Normally, tailq entry should have a valid fd by the time we attempt to

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 04:55:51PM +0100, Burakov, Anatoly wrote: > On 27-Apr-18 4:21 PM, Bruce Richardson wrote: > > On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: > > > Normally, tailq entry should have a valid fd by the time we attempt > > > to map the segment. However, in case

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 4:21 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: Normally, tailq entry should have a valid fd by the time we attempt to map the segment. However, in case it doesn't, we're leaking fd, so fix it. Coverity issue: 272570 Fixes: 2a04139

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Bruce Richardson
On Fri, Apr 27, 2018 at 04:49:03PM +0100, Burakov, Anatoly wrote: > On 27-Apr-18 4:21 PM, Bruce Richardson wrote: > > On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: > > > Normally, tailq entry should have a valid fd by the time we attempt > > > to map the segment. However, in case

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 4:21 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: Normally, tailq entry should have a valid fd by the time we attempt to map the segment. However, in case it doesn't, we're leaking fd, so fix it. Coverity issue: 272570 Fixes: 2a04139

Re: [dpdk-dev] [PATCH v3 5/9] mem: fix potential resource leak

2018-04-27 Thread Bruce Richardson
On Wed, Apr 25, 2018 at 10:56:43AM +0100, Anatoly Burakov wrote: > Normally, tailq entry should have a valid fd by the time we attempt > to map the segment. However, in case it doesn't, we're leaking fd, > so fix it. > > Coverity issue: 272570 > > Fixes: 2a04139f66b4 ("eal: add single file segmen