Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-04-01 Thread Stephen Hemminger
On Wed, 31 Mar 2021 04:19:14 + Honnappa Nagarahalli wrote: > > +__rte_experimental > > +static inline void > Minor, this API does not need to be inline. Unfortunately, it has to be inline otherwise Gcc warns about unused static function in every file that doesn't use it.

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-03-31 Thread Stephen Hemminger
On Wed, 31 Mar 2021 04:19:14 + Honnappa Nagarahalli wrote: > > + > > + rte_pflock_write_lock(&sl); > > + /* this message should be the last message of test */ > > + printf("Global write lock taken on main core %u\n", rte_lcore_id()); > > + rte_pflock_write_unlock(&sl); > > + > > + r

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-03-30 Thread Honnappa Nagarahalli
Few minor comments, overall looks good. Tested on few Arm platforms. > > This is a new type of reader-writer lock that provides better fairness > guarantees which better suited for typical DPDK applications. > A pflock has two ticket pools, one for readers and one for writers. > > Phase fair r

Re: [dpdk-dev] [PATCH v4] pflock: add phase-fair reader writer locks

2021-03-29 Thread Stephen Hemminger
On Mon, 29 Mar 2021 22:00:47 -0700 Stephen Hemminger wrote: > This is a new type of reader-writer lock that provides better fairness > guarantees which better suited for typical DPDK applications. > A pflock has two ticket pools, one for readers and one > for writers. > > Phase fair reader write