Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev

2018-04-20 Thread Thomas Monjalon
20/04/2018 15:23, Arnon Warshavsky: > > > > Lots of "!= 0"'s - you might gather by now that I don't like them :-) > > > > No way. Would have never guessed that :) > Sure. When in Rome.. It is a matter of taste. I like the explicit "!= 0". At least, explicit NULL comparisons are recommended in the

Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev

2018-04-20 Thread Arnon Warshavsky
> > Lots of "!= 0"'s - you might gather by now that I don't like them :-) > No way. Would have never guessed that :) Sure. When in Rome.. > > hmm, I'm wondering should void __rte_experimental > rte_eth_dev_owner_delete change to return an int, now that there is a > fail case and it is still expe

Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev

2018-04-19 Thread Kevin Traynor
On 04/19/2018 07:01 AM, Arnon Warshavsky wrote: > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_ether/rte_ethdev.c | 36 +--- > 1 file changed, 25 insertions(+), 11 deletions(-)