Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 09:36, David Marchand wrote: On Thu, Dec 12, 2019 at 9:43 AM David Marchand wrote: You missed some drivers, which makes my tests fail right away: $ for file in $(find lib/ drivers/ -name "*.map") do pattern=$(basename ${file/_version.map}) [ $(find lib/ drivers/ -name "*$pa

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread Laatz, Kevin
On 12/12/2019 08:43, David Marchand wrote: On 11/12/2019 19:21, Kevin Laatz wrote: This patch adds the .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread David Marchand
On Thu, Dec 12, 2019 at 9:43 AM David Marchand wrote: > You missed some drivers, which makes my tests fail right away: > > $ for file in $(find lib/ drivers/ -name "*.map") > do > pattern=$(basename ${file/_version.map}) > [ $(find lib/ drivers/ -name "*$pattern*.dump" |wc -l) = 0 ] || > c

Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI

2019-12-12 Thread David Marchand
On 11/12/2019 19:21, Kevin Laatz wrote: > This patch adds the .dump files generated for the v20.0 ABI. These files > will be used to compare the ABI during the meson build when the > compat_checks meson is enabled. If there is a mismatch between the .dump > files (the baseline, ie. current stabl