Re: [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var

2018-05-17 Thread Bruce Richardson
On Thu, May 17, 2018 at 10:17:04PM +0800, Andy Green wrote: > > > On 05/17/2018 09:54 PM, Bruce Richardson wrote: > > On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote: > > > Signed-off-by: Andy Green > > > --- > > > lib/librte_ethdev/rte_ethdev.h | 25 +++-- > >

Re: [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var

2018-05-17 Thread Andy Green
On 05/17/2018 09:54 PM, Bruce Richardson wrote: On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote: Signed-off-by: Andy Green --- lib/librte_ethdev/rte_ethdev.h | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) While I dislike the changes below,

Re: [dpdk-dev] [PATCH v4 15/23] rte_ethdev.h: align sign and scope of temp var

2018-05-17 Thread Bruce Richardson
On Mon, May 14, 2018 at 01:10:43PM +0800, Andy Green wrote: > Signed-off-by: Andy Green > --- > lib/librte_ethdev/rte_ethdev.h | 25 +++-- > 1 file changed, 15 insertions(+), 10 deletions(-) > While I dislike the changes below, since I believe it's always more readable to