Hello Harman,
This patch looks good to me, there are just some tiny comments inline.
2021-10-20 00:05 (UTC+0530), Harman Kalra:
> [...]
> +/* Macros to check for valid port */
> +#define CHECK_VALID_INTR_HANDLE(intr_handle) do { \
> + if (intr_handle == NULL) { \
> + RTE_LOG(ERR,
2021-10-20 08:14 (UTC+0200), David Marchand:
> [...]
>
> AFAIU, eal_common_interrupts.c hosts those new symbols and this file
> is compiled for Windows (from common/meson.build update), so all intr
> symbols are available.
>
> There is no reason to filter interrupts symbols for Windows, is there?
On Tue, Oct 19, 2021 at 8:36 PM Harman Kalra wrote:
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index 38f7de83e1..7112dbc146 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -109,18 +109,10 @@ DPDK_22 {
> rte_hexdump;
> rte_hypervisor_get;
>
3 matches
Mail list logo
