Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-16 Thread Lukasz Wojciechowski
W dniu 16.10.2020 o 17:42, Honnappa Nagarahalli pisze: > > >> W dniu 16.10.2020 o 14:43, Lukasz Wojciechowski pisze: >>> Hi Honnappa, >>> >>> Thank you for your answer. >>> In the current v7 version I followed your advise and used RELAXED memory >> model. >>> And it works without any issues. I g

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-16 Thread Honnappa Nagarahalli
> > W dniu 16.10.2020 o 14:43, Lukasz Wojciechowski pisze: > > Hi Honnappa, > > > > Thank you for your answer. > > In the current v7 version I followed your advise and used RELAXED memory > model. > > And it works without any issues. I guess after fixing other issues found > since v4 the distrib

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-16 Thread Lukasz Wojciechowski
W dniu 16.10.2020 o 14:43, Lukasz Wojciechowski pisze: > Hi Honnappa, > > Thank you for your answer. > In the current v7 version I followed your advise and used RELAXED memory > model. > And it works without any issues. I guess after fixing other issues found > since v4 the distributor works mo

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-16 Thread Lukasz Wojciechowski
Hi Honnappa, Thank you for your answer. In the current v7 version I followed your advise and used RELAXED memory model. And it works without any issues. I guess after fixing other issues found since v4 the distributor works more stable. I didn't have time to rearrange all tests in the way I propo

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-15 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > Many thanks for the review! > > I'll write my answers here not inline as it would be easier to read them in > one > place, I think. > So first of all I agree with you in 2 things: > 1) all uses of statistics must be atomic and lack of that caused most of the > problems >

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-08 Thread Lukasz Wojciechowski
Hi Honappa, I pushed v5 of the patches today. However all I fixed in this patch is replacing memset to loop of operations on atomic. I didn't move clearing and checking the statistics out of the test yet (to make sure no worker is running). After fixing few more distributor issues I wasn't abl

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-02 Thread Lukasz Wojciechowski
Hi Honnappa, Many thanks for the review! I'll write my answers here not inline as it would be easier to read them in one place, I think. So first of all I agree with you in 2 things: 1) all uses of statistics must be atomic and lack of that caused most of the problems 2) it would be better to r

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-09-28 Thread Honnappa Nagarahalli
> > Statistics of handled packets are cleared and read on main lcore, while they > are increased in workers handlers on different lcores. > > Without synchronization occasionally showed invalid values. > This patch uses atomic acquire/release mechanisms to synchronize. In general, load-acquire