Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

On 05/01/2017 01:31, Yang, Qiming wrote: [..] + if (strcmp(drvinfo->driver, "net_ixgbe") == 0) Do you need this check. I think it is not good idea to add this kind of checks into ethtool app. Why not just print "%d.%d.%d %#X, major, minor, patch, etrack" for all cases ? > Qiming: because

Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

-Original Message- From: Yigit, Ferruh Sent: Wednesday, January 4, 2017 10:01 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Helin ; Horton, Remy Subject: Re: [PATCH v4 5/5] ethtool: dispaly firmware version On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch enhances the ethtool exam

Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version

On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch enhances the ethtool example to support to show > firmware version, in the same way that the Linux kernel > ethtool does. > > Signed-off-by: Qiming Yang <...> > > @@ -61,6 +67,12 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct > ethtool_