Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2018-01-08 Thread Yuanhan Liu
On Wed, Dec 13, 2017 at 09:51:05AM +0100, Maxime Coquelin wrote: > Hi, > > This fifth revision fixes bug reported by Tiwei, dev->virtqueue[$idx] > wasn't reset to NULL at vq freeing time. Applied to dpdk-next-virtio. Thanks. --yliu > > Having QEMU started with mq=on but guest driver no

Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-13 Thread Laszlo Ersek
On 12/13/17 11:24, Paolo Bonzini wrote: > On 13/12/2017 11:11, Maxime Coquelin wrote: >>> Hi Maxime, >>> >>> I think this series is wrong from the virtio spec's point of view.  If >>> the driver requests VIRTIO_NET_F_MQ, that does not mean "the driver >>> knows about multiqueue", it only means that

Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-13 Thread Paolo Bonzini
On 13/12/2017 11:11, Maxime Coquelin wrote: >> Hi Maxime, >> >> I think this series is wrong from the virtio spec's point of view.  If >> the driver requests VIRTIO_NET_F_MQ, that does not mean "the driver >> knows about multiqueue", it only means that "the driver wants to read >> max_virtqueue_pai

Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-13 Thread Maxime Coquelin
Hi Paolo, On 12/13/2017 10:15 AM, Paolo Bonzini wrote: On 13/12/2017 09:51, Maxime Coquelin wrote: This series fixes this by destroying all but first queue pair in the backend if VIRTIO_NET_F_MQ isn't negotiated. First patches makes sure that VHOST_USER_SET_FEATURES request doesn't change Virti

Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-13 Thread Paolo Bonzini
On 13/12/2017 09:51, Maxime Coquelin wrote: > This series fixes this by destroying all but first queue pair in > the backend if VIRTIO_NET_F_MQ isn't negotiated. First patches > makes sure that VHOST_USER_SET_FEATURES request doesn't change > Virtio features while the device is running, which shoul