Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

Hi Thomas, On 10/25/2017 2:18 AM, Thomas Monjalon wrote: Can you squash this patch with the one bringing the lib? Ok will do that. Will need to move the cryptodev/mbuf/ethdev/net patches before the library patch. +DEPDIRS-librte_cryptodev += librte_ether I don't like this dependency. Why

Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

On 10/24/2017 7:45 PM, Akhil Goyal wrote: Signed-off-by: Akhil Goyal Signed-off-by: Radu Nicolau --- config/common_base | 5 + lib/Makefile | 5 + mk/rte.app.mk | 1 + 3 files changed, 11 insertions(+) diff --git a/config/common_base b/config/common_base index d9471e8..f5d0

Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

Can you squash this patch with the one bringing the lib? > +DEPDIRS-librte_cryptodev += librte_ether I don't like this dependency. Why is it needed? > +DIRS-$(CONFIG_RTE_LIBRTE_SECURITY) += librte_security > +DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf > +DEPDIRS