Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-08 Thread Ferruh Yigit
On 10/8/2020 9:44 AM, Ophir Munk wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, October 7, 2020 7:25 PM To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu <...> Only when user set via "--geneve-port=N", it is the port for testpmd to parse (same for 'geneve_udp_port' global var

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-08 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 7, 2020 7:25 PM > To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu <...> > Only when user set via "--geneve-port=N", it is the port for testpmd to parse > (same for 'geneve_udp_port' global variable), but when user give comman

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-07 Thread Ferruh Yigit
On 10/7/2020 3:52 PM, Ophir Munk wrote: Hi Ferruh, Please find comments inline. -Original Message- From: Ferruh Yigit Sent: Tuesday, October 6, 2020 5:31 PM To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu <...> uint16_t vxlan_gpe_udp_port = 4790; +uint16_t geneve_udp_port = RTE_GENEVE_

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-07 Thread Ophir Munk
Hi Ferruh, Please find comments inline. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 6, 2020 5:31 PM > To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu <...> > > > > uint16_t vxlan_gpe_udp_port = 4790; > > +uint16_t geneve_udp_port = RTE_GENEVE_DEFAULT_PORT; > > > > Ther

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-06 Thread Ferruh Yigit
On 9/18/2020 3:17 PM, Ophir Munk wrote: From: Ophir Munk GENEVE is a widely used tunneling protocol in modern Virtualized Networks. testpmd already supports parsing of several tunneling protocols including VXLAN, VXLAN-GPE, GRE. This commit adds GENEVE parsing of inner protocols (IPv4-0x0800, I