Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-30 Thread Igor Ryzhov
On Thu, Aug 26, 2021 at 9:06 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Aug 2021 20:46:47 +0300 > Igor Ryzhov wrote: > > > Could you please clarify where exactly do I need to use rtnl lock? > > From what I understand, netif_carrier_on/off can be called without the > lo

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Stephen Hemminger
On Thu, 26 Aug 2021 20:46:47 +0300 Igor Ryzhov wrote: > Could you please clarify where exactly do I need to use rtnl lock? > From what I understand, netif_carrier_on/off can be called without the lock. Just a basic concern. The new stuff looks ok. If you follow what current upstream virtio is do

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Igor Ryzhov
Could you please clarify where exactly do I need to use rtnl lock? >From what I understand, netif_carrier_on/off can be called without the lock. On Thu, Aug 26, 2021 at 8:15 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Aug 2021 18:19:09 +0300 > Igor Ryzhov wrote: > > >

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Stephen Hemminger
On Thu, 26 Aug 2021 18:19:09 +0300 Igor Ryzhov wrote: > > +static int > +kni_ioctl_link(struct net *net, uint32_t ioctl_num, > + unsigned long ioctl_param) > +{ > + struct kni_net *knet = net_generic(net, kni_net_id); > + int ret = -EINVAL; > + struct kni_dev *dev, *n; >