Re: [dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
> > +static inline void > > +isb(void) > > +{ > > + asm volatile("isb" : : : "memory"); } > > NAK. > > Don't export badly named stuff like this. > Just use asm volatile("isb" : : : "memory") in rte_rdtsc_precise or which file I should use to define this maco > > + > > +static inline voi

Re: [dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread David Marchand
On Wed, Mar 11, 2020 at 8:24 AM Linhaifeng wrote: > > In order to get more accurate the cntvct_el0 reading, > SW must invoke isb and arch_counter_enforce_ordering. > > Reference of linux kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ > linux.git/tree/arch/arm64/include/asm/arc