On 12/26/2017 2:06 AM, Stephen Hemminger wrote:
On Thu, 2 Nov 2017 04:16:44 +0800
Jeff Guo wrote:
+int
+rte_dev_bind_driver(const char *dev_name, const char *drv_type) {
Bracket left after declaration.
thanks.
+ snprintf(drv_override_path, sizeof(drv_override_path),
+
On Thu, 2 Nov 2017 04:16:44 +0800
Jeff Guo wrote:
> +int
> +rte_dev_bind_driver(const char *dev_name, const char *drv_type) {
Bracket left after declaration.
> + snprintf(drv_override_path, sizeof(drv_override_path),
> + "/sys/bus/pci/devices/%s/driver_override", dev_name);
>
On 11/2/2017 5:41 AM, Stephen Hemminger wrote:
On Thu, 2 Nov 2017 04:16:44 +0800
Jeff Guo wrote:
+
+static int
+dev_uev_parse(const char *buf, struct rte_eal_uevent *event)
+{
+ char action[RTE_EAL_UEVENT_MSG_LEN];
+ char subsystem[RTE_EAL_UEVENT_MSG_LEN];
+ char dev_path[
Thanks Stephen for your eye on review, would collect other comment and refine
it better in next version.
Best regards,
Jeff Guo
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Thursday, November 2, 2017 5:42 AM
To: Guo, Jia
Cc: Richardson, Bruce ; Y
On Thu, 2 Nov 2017 04:16:44 +0800
Jeff Guo wrote:
> +
> +static int
> +dev_uev_parse(const char *buf, struct rte_eal_uevent *event)
> +{
> + char action[RTE_EAL_UEVENT_MSG_LEN];
> + char subsystem[RTE_EAL_UEVENT_MSG_LEN];
> + char dev_path[RTE_EAL_UEVENT_MSG_LEN];
> + char pci_sl
On Thu, 2 Nov 2017 04:16:44 +0800
Jeff Guo wrote:
>
> +/* Map pci device */
> +int
> +rte_pci_remap_device(struct rte_pci_device *dev)
> +{
> + int ret = -1;
Please don't always initialize variables. It is unnecessary, and with
modern compilers a bad habit since it defeats the uninitailiz
6 matches
Mail list logo
