Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-20 Thread Dumitrescu, Cristian
Hi Pavan, Same ask as for the first patch: -Do not change existing code in rte_reciprocal.[hc]: no _u32 suffix, please -Do not add lots of CR+LF to existing code > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, September 6, 2017 11:2

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 6, 2017 4:37 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Kevin Traynor ; Dumitrescu, Cristian > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Stephen Hemminger
On Wed, 6 Sep 2017 20:11:34 +0530 Pavan Nikhilesh Bhagavatula wrote: > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > > From: Pavan Bhagavatula > > > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. Th

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Kevin Traynor
On 09/06/2017 03:41 PM, Pavan Nikhilesh Bhagavatula wrote: > On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: >> On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: >>> From: Pavan Bhagavatula >>> >>> Currently, rte_reciprocal only supports unsigned 32bit divisors. This >>> commit adds su

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Pavan Nikhilesh Bhagavatula
On Wed, Sep 06, 2017 at 01:28:24PM +0100, Kevin Traynor wrote: > On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > > From: Pavan Bhagavatula > > > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > > commit adds support for unsigned 64bit divisors. > > > > Rename unsigned 32b

Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-06 Thread Kevin Traynor
On 09/06/2017 11:21 AM, Pavan Nikhilesh wrote: > From: Pavan Bhagavatula > > Currently, rte_reciprocal only supports unsigned 32bit divisors. This > commit adds support for unsigned 64bit divisors. > > Rename unsigned 32bit specific functions appropriately and update > librte_sched accordingly.