Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

On Wed, Oct 24, 2018 at 6:18 PM Stephen Hemminger wrote: > > > > > > This seems like an overly wordy message which should really be in the > > > documentation > > > not a billboard in the code. > > > > > > In my opinion, having verbose messages is unhelpful since it just clutters > > > the experi

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

On Wed, 24 Oct 2018 17:56:50 -0300 Dan Gora wrote: > On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger > wrote: > > > + pid = getpid(); > > > + RTE_LOG(INFO, APP, "\n"); > > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > > + RTE_LOG(INFO, APP, "kill -SIGUSR1

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger wrote: > > + pid = getpid(); > > + RTE_LOG(INFO, APP, "\n"); > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > > + RTE_LOG(INFO, APP, "Show KNI Statisti

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

On Wed, 24 Oct 2018 17:27:18 -0300 Dan Gora wrote: > + pid = getpid(); > + RTE_LOG(INFO, APP, "\n"); > + RTE_LOG(INFO, APP, "KNI Running\n"); > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > + RTE_LOG(INFO, APP, "Show KNI Statistics.\n"); > +