Re: [dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-30 Thread Bruce Richardson
On Fri, Jun 30, 2017 at 06:46:31PM +0200, Jan Blunck wrote: > On Fri, Jun 30, 2017 at 11:16 AM, Thomas Monjalon wrote: > > 29/06/2017 20:21, Jan Blunck: > >> +static int > >> +bus_find_device(const struct rte_bus *bus, const void *_dev) > >> +{ > >> + struct rte_device *dev; > >> + > >> +

Re: [dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-30 Thread Bruce Richardson
On Fri, Jun 30, 2017 at 08:29:06PM +0200, Thomas Monjalon wrote: > 30/06/2017 18:46, Jan Blunck: > > On Fri, Jun 30, 2017 at 11:16 AM, Thomas Monjalon > > wrote: > > > 29/06/2017 20:21, Jan Blunck: > > >> +static int > > >> +bus_find_device(const struct rte_bus *bus, const void *_dev) > > >> +{ >

Re: [dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-30 Thread Thomas Monjalon
30/06/2017 18:46, Jan Blunck: > On Fri, Jun 30, 2017 at 11:16 AM, Thomas Monjalon wrote: > > 29/06/2017 20:21, Jan Blunck: > >> +static int > >> +bus_find_device(const struct rte_bus *bus, const void *_dev) > >> +{ > >> + struct rte_device *dev; > >> + > >> + dev = bus->find_device(NULL, c

Re: [dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-30 Thread Jan Blunck
On Fri, Jun 30, 2017 at 11:16 AM, Thomas Monjalon wrote: > 29/06/2017 20:21, Jan Blunck: >> +static int >> +bus_find_device(const struct rte_bus *bus, const void *_dev) >> +{ >> + struct rte_device *dev; >> + >> + dev = bus->find_device(NULL, cmp_rte_device, _dev); >> + return !dev; >>

Re: [dpdk-dev] [PATCH v7 06/15] bus: add helper to find which bus holds a device

2017-06-30 Thread Thomas Monjalon
29/06/2017 20:21, Jan Blunck: > +static int > +bus_find_device(const struct rte_bus *bus, const void *_dev) > +{ > + struct rte_device *dev; > + > + dev = bus->find_device(NULL, cmp_rte_device, _dev); > + return !dev; > +} The preferred code style is to make explicit the NULL compariso