Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Thomas Monjalon
12/06/2020 22:24, Dmitry Kozliuk: > > > > > +#include > > > > > > > > I think we should find a better file name for these wrappers. > > > > "EAL memory" means DPDK memory allocator in my mind. > > > > We need a file name which is about OS-independent wrappers, > > > > or libc wrappers. > > > > Wha

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Dmitry Kozliuk
> > > Not sure if they are in DPDK scope, apart from rte_mem_lock, which > > generalizes rte_mem_lock_page already in rte_memory.h. What may be > typical > > use cases for data-plane apps? I can see testpmd using mmap for > allocating > > external memory (because of possible use of hugepages), doe

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Thomas Monjalon
12/06/2020 15:44, Dmitry Kozliuk: > > [...] > > > +INTERNAL { > > > + global: > > > + > > > + rte_mem_lock; > > > + rte_mem_map; > > > + rte_mem_page_size; > > > + rte_mem_unmap; > > > +}; > > > > Not sure why these functions are internal. > > They may be useful for DPDK applica

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Dmitry Kozliuk
> [...] > > +INTERNAL { > > + global: > > + > > + rte_mem_lock; > > + rte_mem_map; > > + rte_mem_page_size; > > + rte_mem_unmap; > > +}; > > Not sure why these functions are internal. > They may be useful for DPDK applications. > We would need to add the file in doxygen index. >

Re: [dpdk-dev] [PATCH v8 03/11] eal: introduce memory management wrappers

2020-06-12 Thread Thomas Monjalon
10/06/2020 16:27, Dmitry Kozlyuk: > Introduce OS-independent wrappers for memory management operations used > across DPDK and specifically in common code of EAL: > > * rte_mem_map() > * rte_mem_unmap() > * rte_mem_page_size() > * rte_mem_lock() > > Windows uses different APIs for memory mapping a