Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-10 Thread Thomas Monjalon
10/01/2019 09:53, Varghese, Vipin: > Hi Thomas, > > snipped > > > > 10/01/2019 04:08, Varghese, Vipin: > > > snipped > > > > > > > > Hi Vipin, > > > > > > > > The code split in this v8 looks really better, except this patch > > > > which makes no sense alone. > > > Hi Thomas, I need this base pat

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-10 Thread Varghese, Vipin
Hi Thomas, snipped > > 10/01/2019 04:08, Varghese, Vipin: > > snipped > > > > > > Hi Vipin, > > > > > > The code split in this v8 looks really better, except this patch > > > which makes no sense alone. > > Hi Thomas, I need this base patch as first one. These include the helper > MACRO and inclu

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-10 Thread Thomas Monjalon
10/01/2019 04:08, Varghese, Vipin: > snipped > > > > Hi Vipin, > > > > The code split in this v8 looks really better, except this patch which > > makes no > > sense alone. > Hi Thomas, I need this base patch as first one. These include the helper > MACRO and include which pans out for next 7 pa

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-09 Thread Varghese, Vipin
snipped > > Hi Vipin, > > The code split in this v8 looks really better, except this patch which makes > no > sense alone. Hi Thomas, I need this base patch as first one. These include the helper MACRO and include which pans out for next 7 patches. > I feel you can move these changes in next p

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

2019-01-09 Thread Thomas Monjalon
Hi Vipin, The code split in this v8 looks really better, except this patch which makes no sense alone. I feel you can move these changes in next patches, where appropriate, isn't it? 07/01/2019 16:38, Vipin Varghese: > Update code base and meson build file to accomadate changes for the > new func