Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Nélio Laranjeiro
On Thu, Jul 05, 2018 at 04:07:28PM +0100, Mohammad Abdul Awal wrote: >Some nits. > >Auto-completion suggestion for values should be wrapped between '<' and >'>', not '(' and ')'. See all the cases. >[...] Right, I'll send a v9 to fix this. Thanks, -- Nélio Laranjeiro 6WIND

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Mohammad Abdul Awal
Some nits. Auto-completion suggestion for values should be wrapped between '<' and '>', not '(' and ')'. See all the cases. On 05/07/2018 15:33, Nelio Laranjeiro wrote: Due to the complex NVGRE_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new com