Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Ferruh Yigit wrote: >On 4/3/2019 3:22 PM, Ye Xiaolong wrote: >> On 04/03, Ferruh Yigit wrote: >> [snip] >>> >>> It seems, 'tools/include/asm/barrier.h' is required for 'smp_wmb()' & >>> 'smp_rmb()' in 'xsk.h'. >>> We have equivalents of these in DPDK [1], and perhaps it can be possible to

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 3:22 PM, Ye Xiaolong wrote: > On 04/03, Ferruh Yigit wrote: > [snip] >> >> It seems, 'tools/include/asm/barrier.h' is required for 'smp_wmb()' & >> 'smp_rmb()' in 'xsk.h'. >> We have equivalents of these in DPDK [1], and perhaps it can be possible to >> use >> them and not include this

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Bruce Richardson wrote: >On Wed, Apr 03, 2019 at 11:14:58PM +0800, Ye Xiaolong wrote: >> On 04/03, Luca Boccassi wrote: >> >On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote: >> >> On 04/03, Luca Boccassi wrote: >> >> [snip] >> >> > > Got it. >> >> > > >> >> > > In above steps, 'libbp

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Bruce Richardson
On Wed, Apr 03, 2019 at 11:14:58PM +0800, Ye Xiaolong wrote: > On 04/03, Luca Boccassi wrote: > >On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote: > >> On 04/03, Luca Boccassi wrote: > >> [snip] > >> > > Got it. > >> > > > >> > > In above steps, 'libbpf' also build from kernel source tree, wil

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Luca Boccassi wrote: >On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote: >> On 04/03, Luca Boccassi wrote: >> [snip] >> > > Got it. >> > > >> > > In above steps, 'libbpf' also build from kernel source tree, will >> > > it >> > > be problem >> > > in you builds to not have it build fro

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 22:43 +0800, Ye Xiaolong wrote: > On 04/03, Luca Boccassi wrote: > [snip] > > > Got it. > > > > > > In above steps, 'libbpf' also build from kernel source tree, will > > > it > > > be problem > > > in you builds to not have it build from source? > > > > > > If not, taking in

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Luca Boccassi wrote: [snip] >> >> Got it. >> >> In above steps, 'libbpf' also build from kernel source tree, will it >> be problem >> in you builds to not have it build from source? >> >> If not, taking into account that xsk.h also will be fixed, only >> 'tools/include/asm/barrier.h' r

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
On 04/03, Ferruh Yigit wrote: [snip] > >It seems, 'tools/include/asm/barrier.h' is required for 'smp_wmb()' & >'smp_rmb()' in 'xsk.h'. >We have equivalents of these in DPDK [1], and perhaps it can be possible to use >them and not include this header at all. > >in 'rte_eth_af_xdp.c', before includin

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 2:22 PM, Bruce Richardson wrote: > On Tue, Apr 02, 2019 at 08:43:48PM +0100, Ferruh Yigit wrote: >> On 4/2/2019 4:46 PM, Xiaolong Ye wrote: >>> Add a new PMD driver for AF_XDP which is a proposed faster version of >>> AF_PACKET interface in Linux. More info about AF_XDP, please refer to

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 14:09 +0100, Ferruh Yigit wrote: > On 4/3/2019 12:35 PM, Luca Boccassi wrote: > > On Wed, 2019-04-03 at 12:18 +0100, Ferruh Yigit wrote: > > > On 4/3/2019 11:42 AM, Luca Boccassi wrote: > > > > On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: > > > > > On Wed, 2019-04-0

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Bruce Richardson
On Tue, Apr 02, 2019 at 08:43:48PM +0100, Ferruh Yigit wrote: > On 4/2/2019 4:46 PM, Xiaolong Ye wrote: > > Add a new PMD driver for AF_XDP which is a proposed faster version of > > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > > [2]. > > > > This is the vanilla versi

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 12:35 PM, Luca Boccassi wrote: > On Wed, 2019-04-03 at 12:18 +0100, Ferruh Yigit wrote: >> On 4/3/2019 11:42 AM, Luca Boccassi wrote: >>> On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > Hi, Luca > > On 04/0

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 1:16 PM, Luca Boccassi wrote: > On Wed, 2019-04-03 at 12:35 +0100, Luca Boccassi wrote: >> On Wed, 2019-04-03 at 12:18 +0100, Ferruh Yigit wrote: >>> On 4/3/2019 11:42 AM, Luca Boccassi wrote: On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: > On Wed, 2019-04-03 at 17:59

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 12:35 +0100, Luca Boccassi wrote: > On Wed, 2019-04-03 at 12:18 +0100, Ferruh Yigit wrote: > > On 4/3/2019 11:42 AM, Luca Boccassi wrote: > > > On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: > > > > On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > > > > > Hi, L

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 12:18 +0100, Ferruh Yigit wrote: > On 4/3/2019 11:42 AM, Luca Boccassi wrote: > > On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: > > > On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > > > > Hi, Luca > > > > > > > > On 04/02, Luca Boccassi wrote: > > > > > On T

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ferruh Yigit
On 4/3/2019 11:42 AM, Luca Boccassi wrote: > On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: >> On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: >>> Hi, Luca >>> >>> On 04/02, Luca Boccassi wrote: On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > diff --git a/drivers/net

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 11:36 +0100, Luca Boccassi wrote: > On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > > Hi, Luca > > > > On 04/02, Luca Boccassi wrote: > > > On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > > > > diff --git a/drivers/net/af_xdp/Makefile > > > > b/drivers/net/af_

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Luca Boccassi
On Wed, 2019-04-03 at 17:59 +0800, Ye Xiaolong wrote: > Hi, Luca > > On 04/02, Luca Boccassi wrote: > > On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > > > diff --git a/drivers/net/af_xdp/Makefile > > > b/drivers/net/af_xdp/Makefile > > > new file mode 100644 > > > index 0..8343e30

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-03 Thread Ye Xiaolong
Hi, Luca On 04/02, Luca Boccassi wrote: >On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: >> diff --git a/drivers/net/af_xdp/Makefile >> b/drivers/net/af_xdp/Makefile >> new file mode 100644 >> index 0..8343e3016 >> --- /dev/null >> +++ b/drivers/net/af_xdp/Makefile >> @@ -0,0 +1,32 @

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-02 Thread Ye Xiaolong
On 04/02, Stephen Hemminger wrote: >On Tue, 2 Apr 2019 23:46:53 +0800 >Xiaolong Ye wrote: > >> +/* pull from complete qeueu to leave more space */ > >Overall looks good, one last spelling error Sorry for the typo, will fix in in next version. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-02 Thread Ferruh Yigit
On 4/2/2019 4:46 PM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] htt

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-02 Thread Luca Boccassi
On Tue, 2019-04-02 at 23:46 +0800, Xiaolong Ye wrote: > diff --git a/drivers/net/af_xdp/Makefile > b/drivers/net/af_xdp/Makefile > new file mode 100644 > index 0..8343e3016 > --- /dev/null > +++ b/drivers/net/af_xdp/Makefile > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +#

Re: [dpdk-dev] [PATCH v9 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2019 23:46:53 +0800 Xiaolong Ye wrote: > + /* pull from complete qeueu to leave more space */ Overall looks good, one last spelling error