Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-12 Thread Carrillo, Erik G
Hi Stephen, This looks like a useful addition. Some comments in-line: > -Original Message- > From: Stephen Hemminger > Sent: Monday, June 10, 2019 5:45 PM > To: rsanf...@akamai.com; Carrillo, Erik G > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [RFC] rte_timer: add rte_timer_next_t

Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-11 Thread Sanford, Robert
You are correct. I just looked at it in Patchwork. Sorry about that. (I should learn never to trust Outlook for Mac.) On 6/11/19, 10:27 AM, "Stephen Hemminger" wrote: On Tue, 11 Jun 2019 13:37:33 + "Sanford, Robert" wrote: > Hi Stephen, > > The code seems fine. My only comment is that t

Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-11 Thread Stephen Hemminger
On Tue, 11 Jun 2019 13:37:33 + "Sanford, Robert" wrote: > Hi Stephen, > > The code seems fine. My only comment is that there is not a blank line before > the new code, in both the .c and .h. > > -- > Regards Where, I see the blank line between functions and checkpatch is happy.

Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks

2019-06-11 Thread Sanford, Robert
Hi Stephen, The code seems fine. My only comment is that there is not a blank line before the new code, in both the .c and .h. -- Regards, Robert On 6/10/19, 6:45 PM, "Stephen Hemminger" wrote: It is useful to know when the next timer will expire when using rte_epoll_wait (or sleep when idle