Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-12-01 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, November 30, 2017 11:13 PM > To: Carrillo, Erik G > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH v4 2/4] eventtimer: add common code > > On Thu, Nov 30, 2017 at 08:59:19PM

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-11-30 Thread Pavan Nikhilesh Bhagavatula
On Thu, Nov 30, 2017 at 08:59:19PM +, Carrillo, Erik G wrote: > Hi Pavan, > > Thanks for the review; I'm working on addressing the comments and have the > following question (inline): > > <... snipped ...> > > > > + adapter->data->mz = mz; > > > + adapter->data->event_dev_id = conf->event_dev

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-11-30 Thread Carrillo, Erik G
Hi Pavan, Thanks for the review; I'm working on addressing the comments and have the following question (inline): <... snipped ...> > > + adapter->data->mz = mz; > > + adapter->data->event_dev_id = conf->event_dev_id; > > + adapter->data->id = adapter_id; > > + adapter->data->socket_id

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-11-28 Thread Pavan Nikhilesh Bhagavatula
Hi Gabriel, Comments inline On Tue, Nov 28, 2017 at 11:40:06AM -0600, Erik Gabriel Carrillo wrote: > +struct rte_event_timer_adapter * > +rte_event_timer_adapter_create(const struct rte_event_timer_adapter_conf > *conf) > +{ > + /* default port conf values */ > + struct rte_event_port_c