Re: [dpdk-dev] [dpdk-dev,v1] net/tap: add tun support

2018-02-26 Thread Varghese, Vipin
Hi Pascal, Thanks for the comments, Please find my updates inline > -Original Message- > From: Pascal Mazon [mailto:pascal.ma...@6wind.com] > Sent: Thursday, February 22, 2018 12:22 PM > To: Varghese, Vipin ; dev@dpdk.org; Mcnamara, > John ; Yigit, Ferruh > Cc: Kovacevic, Marko > Subjec

Re: [dpdk-dev] [dpdk-dev,v1] net/tap: add tun support

2018-02-22 Thread Pascal Mazon
Personally, I'm mostly ok with this. I added a couple of comments inline. On 21/02/2018 00:12, Vipin Varghese wrote: > The change adds TUN PMD logic to the existing TAP PMD. TUN PMD can > be initialized with 'net_tunX' where 'X' represents unique id. PMD > supports argument interface, while MAC ad