Re: Sign changes through function signatures

2023-02-06 Thread Ben Magistro
I'm a fan of "just rip the bandaid off" (especially when it's convenient for me, however it's very possible I will also be the person to bring up backwards compatibility). Speaking of backwards compatibility, API/ABI breakage was semi-recently discussed at the techboard [1]. From the notes it was

RE: Sign changes through function signatures

2023-02-04 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 3 February 2023 23.13 > > On Fri, Feb 03, 2023 at 12:05:04PM +, Bruce Richardson wrote: > > On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >

Re: Sign changes through function signatures

2023-02-03 Thread Tyler Retzlaff
On Fri, Feb 03, 2023 at 12:05:04PM +, Bruce Richardson wrote: > On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, 2 February 2023 21.45 > > > > > > 02/02/2023 21:26, Tyler Retzlaff: > > > > On Thu, Feb

Re: Sign changes through function signatures

2023-02-03 Thread Bruce Richardson
On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, 2 February 2023 21.45 > > > > 02/02/2023 21:26, Tyler Retzlaff: > > > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > > > > Hello, > > > > > > >

RE: Sign changes through function signatures

2023-02-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 2 February 2023 21.45 > > 02/02/2023 21:26, Tyler Retzlaff: > > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > > > Hello, > > > > > > While making some updates to our code base for 22.11.1 that were > missed in

Re: Sign changes through function signatures

2023-02-02 Thread Thomas Monjalon
02/02/2023 21:26, Tyler Retzlaff: > On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > > Hello, > > > > While making some updates to our code base for 22.11.1 that were missed in > > our first pass through, we hit the numa node change[1]. In the process of > > updating our code, we n

Re: Sign changes through function signatures

2023-02-02 Thread Tyler Retzlaff
On Thu, Feb 02, 2023 at 02:23:39PM -0500, Ben Magistro wrote: > Hello, > > While making some updates to our code base for 22.11.1 that were missed in > our first pass through, we hit the numa node change[1]. In the process of > updating our code, we noticed that a couple functions (rx/tx_queue_se