[dpdk-dev] [PATCH v2 0/3] Enable uio_pci_generic support

v2 changes: - Change variable name of kernel driver with precise comment - Fix a union definition error in v1 patchset - Move redefined macro IORESOURCE_MEM to rte_pci.h with comment Linux kernel provides UIO as well as VFIO mechanism to support writing user space device driver. Comparing to UIO

[dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support

v2 changes: - Change variable name of kernel driver with precise comment. - Fix a union definition error in v1 patchset. - Move redefined macro IORESOURCE_MEM to rte_pci.h with comment. 1) Unify procedure to retrieve BAR resource mapping information. 2) Setup bus master bit in NIC's PCIe

[dpdk-dev] [PATCH v2 2/3] eal: add interrupt enable/disable routines for uio_pci_generic

enable/disable interrupt by manipulating a control bit of command register on NIC's PCIe configuration space. Signed-off-by: Danny Zhou Tested-by: Qun Wan --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 68 +--- 1 file changed, 52 insertions(+), 16 deletions(-) diff

[dpdk-dev] [PATCH v2 3/3] tools: enable binding NIC device to uio_pci_generic

Add uio_pci_generic to the list of supported kernel drivers. Signed-off-by: Danny Zhou Tested-by: Qun Wan --- tools/dpdk_nic_bind.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dpdk_nic_bind.py b/tools/dpdk_nic_bind.py index 812b6a1..2483056 100755 ---

[dpdk-dev] [PATCH v9 07/14] eal, ethdev: Add a function and function pointers to close ether device

On 2015/02/19 23:31, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Thursday, February 19, 2015 2:50 AM >> To: dev at dpdk.org >> Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon at 6wind.com; Tetsuya >> Mukawa >>

[dpdk-dev] [PATCH v9 12/14] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

On 2015/02/19 23:51, Iremonger, Bernard wrote: > >> -Original Message- >> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] >> Sent: Thursday, February 19, 2015 2:50 AM >> To: dev at dpdk.org >> Cc: Qiu, Michael; Iremonger, Bernard; thomas.monjalon at 6wind.com; Tetsuya >> Mukawa >>

[dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type

On 2015/02/19 22:29, Tetsuya Mukawa wrote: > On 2015/02/19 20:17, Thomas Monjalon wrote: >>> @@ -152,6 +159,7 @@ struct rte_pci_device { >>> uint16_t max_vfs; /**< sriov enable if not zero */ >>> int numa_node; /**< NUMA node connection */ >>>

[dpdk-dev] [PATCH v10 00/14] Port Hotplug Framework

This patch series adds a dynamic port hotplug framework to DPDK. With the patches, DPDK apps can attach or detach ports at runtime. The basic concept of the port hotplug is like followings. - DPDK apps must have responsibility to manage ports. DPDK apps only know which ports are attached or

[dpdk-dev] [PATCH v10 01/14] eal: Enable port Hotplug framework in Linux

The patch adds CONFIG_RTE_LIBRTE_EAL_HOTPLUG in Linux and BSD configuration. So far, Hotplug functions only support linux. v9: - Move this patch at the top of this patch series. (Thanks to Thomas Monjalon) Signed-off-by: Tetsuya Mukawa --- config/common_bsdapp | 6 ++

[dpdk-dev] [PATCH v10 02/14] eal_pci: Add flag to hold kernel driver type

From: Michael Qiu Currently, dpdk has no ability to know which type of driver( vfio-pci/igb_uio/uio_pci_generic) the device used. It only can check whether vfio is enabled or not staticly. It really useful to have the flag, becasue different type need to handle

[dpdk-dev] [PATCH v10 03/14] eal_pci: pci memory map work with driver type

From: Michael Qiu With the driver type flag in struct rte_pci_dev, we do not need to always map uio devices with vfio related function when vfio enabled. Signed-off-by: Michael Qiu Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/linuxapp/eal/eal_pci.c | 30

[dpdk-dev] [PATCH v10 04/14] eal/pci, ethdev: Remove assumption that port will not be detached

To remove assumption, do like followings. This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver structure. The flags indicate the driver can detach devices at runtime. Also, remove assumption that port will not be detached. To remove the assumption. - Add 'attached' member to

[dpdk-dev] [PATCH v10 05/14] eal/pci: Consolidate pci address comparison APIs

This patch replaces pci_addr_comparison() and memcmp() of pci addresses by rte_eal_compare_pci_addr(). To compare PCI addresses, rte_eal_compare_pci_addr() doesn't use memcmp(). This is because sizeof(struct rte_pci_addr) returns 6, but actually this structure is like below. struct rte_pci_addr

[dpdk-dev] [PATCH v10 06/14] ethdev: Add rte_eth_dev_release_port to release specified port

This patch adds rte_eth_dev_release_port(). The function is used for changing an attached status of the device that has specified name. v9: - rte_eth_dev_free() is replaced by rte_eth_dev_release_port(). (Thanks to Thomas Monjalon) v6: - Use rte_eth_dev structure as the paramter of

[dpdk-dev] [PATCH v10 07/14] eal, ethdev: Add a function and function pointers to close ether device

The patch adds function pointer to rte_pci_driver and eth_driver structure. These function pointers are used when ports are detached. Also, the patch adds rte_eth_dev_uninit(). So far, it's not called by anywhere, but it will be called when port hotplug function is implemented. v10: - Add size

[dpdk-dev] [PATCH v10 08/14] ethdev: Add functions that will be used by port hotplug functions

The patch adds following functions. - rte_eth_dev_save() The function is used for saving current rte_eth_dev structures. - rte_eth_dev_get_changed_port() The function receives the rte_eth_dev structures, then compare these with current values to know which port is actually attached or

[dpdk-dev] [PATCH v10 09/14] eal/linux/pci: Add functions for unmapping igb_uio resources

The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v9: - Remove "rte_dev_hotplug.h". - Remove needless "#ifdef". (Thanks to Thomas Monjalon and Neil Horman) - Remove pci_unmap_device(). It will be

[dpdk-dev] [PATCH v10 10/14] eal/pci: Add a function to remove the entry of devargs list

The function removes the specified devargs entry from devargs_list. Also, the patch adds sanity checking to rte_eal_devargs_add(). v5: - Change function definition of rte_eal_devargs_remove(). v4: - Fix sanity check code. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH v10 11/14] eal/pci: Add probe and close functions of pci driver

- Add pci_close_all_drivers() The function tries to find a driver for the specified device, and then close the driver. - Add rte_eal_pci_probe_one() and rte_eal_pci_close_one() The functions are used for probe and close a device. First the function tries to find a device that has the

[dpdk-dev] [PATCH v10 12/14] ethdev: Add one dev_type parameter to rte_eth_dev_allocate

This new parameter is needed to keep device type like PCI or virtual. Port detaching processes are different between PCI device and virtual device. RTE_ETH_DEV_PCI indicates device type is PCI. RTE_ETH_DEV_VIRTUAL indicates device is virtual. v10: - Change order of version.map. (Thanks to

[dpdk-dev] [PATCH v10 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

These functions are used for attaching or detaching a port. When rte_eal_dev_attach() is called, the function tries to realize the device name as pci address. If this is done successfully, rte_eal_dev_attach() will attach physical device port. If not, attaches virtual devive port. When

[dpdk-dev] [PATCH v10 14/14] doc: Add port hotplug framework section to programmers guide

This patch adds a new section for describing port hotplug framework. Signed-off-by: Tetsuya Mukawa --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/port_hotplug_framework.rst | 110 +++ 2 files changed, 111 insertions(+) create mode 100644

[dpdk-dev] [PATCH v10] librte_pmd_pcap: Add port hotplug support

This patch adds finalization code to free resources allocated by the PMD. v6: - Fix a paramter of rte_eth_dev_free(). v4: - Change function name. Signed-off-by: Tetsuya Mukawa --- lib/librte_pmd_pcap/rte_eth_pcap.c | 40 ++ 1 file changed, 40 insertions(+)

[dpdk-dev] [PATCH v10] testpmd: Add port hotplug support

The patch introduces following commands. - port attach [ident] - port detach [port_id] - attach: attaching a port - detach: detaching a port - ident: pci address of physical device. Or device name and parameters of virtual device. (ex. :02:00.0, eth_pcap0,iface=eth0) -

[dpdk-dev] [PATCH v10 1/2] librte_pmd_null: Add Null PMD

Null PMD is a driver of the virtual device particularly designed to measure performance of DPDK PMDs. When an application call rx, Null PMD just allocates mbufs and returns those. Also tx, the PMD just frees mbufs. The PMD has following options. - size: specify packe size allocated by RX. Default

[dpdk-dev] [PATCH v10 2/2] librte_pmd_null: Support port hotplug function

This patch adds port hotplug support to Null PMD. v9: - Use rte_eth_dev_release_port() instead of rte_eth_dev_free(). v7: - Add parameter checkings. (Thanks to Iremonger, Bernard) v6: - Fix a parameter of rte_eth_dev_free(). v4: - Fix commit title. Signed-off-by: Tetsuya Mukawa ---

[dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.

Hi Stefan, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stefan Puiu > Sent: Thursday, February 19, 2015 8:59 PM > To: dev at dpdk.org > Cc: Stefan Puiu > Subject: [dpdk-dev] [PATCH] Fix compilation error when compiling with > clang-3.4 in C++11 mode: in

[dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.

Hi Pablo, On Fri, Feb 20, 2015 at 10:19 AM, De Lara Guarch, Pablo wrote: > Hi Stefan, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stefan Puiu >> Sent: Thursday, February 19, 2015 8:59 PM >> To: dev at dpdk.org >> Cc: Stefan Puiu >> Subject:

[dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD

On 19/02/2015 13:48, Zhou Danny wrote: > v4 changes > - Export interrupt enable/disable functions for shared libraries > - Adjust position of new-added structure fields and functions to > avoid breaking ABI > > v3 changes > - Add return value for interrupt enable/disable functions > - Move spinlok

[dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support

Hi Danny, 2015-02-20 01:08, Zhou Danny: > @@ -148,6 +151,7 @@ struct rte_pci_device { > struct rte_pci_id id; /**< PCI ID. */ > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI > Memory Resource */ > struct rte_intr_handle intr_handle;

[dpdk-dev] [PATCH v2] testpmd check return value of rte_eth_dev_vlan_filter()

> -Original Message- > From: Qiu, Michael > Sent: Wednesday, January 28, 2015 2:38 AM > To: Jastrzebski, MichalX K; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] testpmd check return value of > rte_eth_dev_vlan_filter() > > On 1/28/2015 1:20 AM, Michal Jastrzebski wrote: > > This

[dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation

In C++11 concatenated string literals need to have a space in between. Found with clang++-3.4, IIRC g++-4.8 also complains about this. Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier

[dpdk-dev] [PATCH] cmdline: fix ressize in parse_portlist

2015-02-04 10:49, Olivier Matz: > The argument ressize contains the size of the result buffer which > should be large enough to store the parsed result of a token. In > this case, it should be larger or equal to sizeof(cmdline_portlist_t) > (4 bytes), not PORTLIST_TOKEN_SIZE which is the max size

[dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support

On Thu, Feb 19, 2015 at 05:56:41PM +, John McNamara wrote: > From: Richardson, Bruce > > Add optional support for inline processing of packets inside the RX > or TX call. For an RX callback, what happens is that we get a set of > packets from the NIC and then pass them to a callback

[dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map

> > Building shared libraries and using virtio PMD results in undefined > > reference to 'rte_eal_iopl_init'. > > > > Add missing function to eal version map. > > > > Signed-off-by: Sergio Gonzalez Monroy > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH] eal: fix fscanf format mismatch

> > Variables are unsigned int but format scans for signed int. > > > > Signed-off-by: Sergio Gonzalez Monroy > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH v10 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

Hi Tetsuya, On Fri, Feb 20, 2015 at 7:39 AM, Tetsuya Mukawa wrote: > These functions are used for attaching or detaching a port. [..] > + > +static void > +get_vdev_name(char *vdevargs) > +{ > + char *sep; > + > + if (vdevargs == NULL) > + return; > + > + /* set

[dpdk-dev] [PATCH v2 1/3] eal: enable uio_pci_generic support

On Fri, Feb 20, 2015 at 10:01:10AM +0100, Thomas Monjalon wrote: > Hi Danny, > > 2015-02-20 01:08, Zhou Danny: > > @@ -148,6 +151,7 @@ struct rte_pci_device { > > struct rte_pci_id id; /**< PCI ID. */ > > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI

[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

Hi Cunming, You would have more chance to have a review by CC'ing John. I checked your patch and have a comment below. 2015-02-12 17:08, Cunming Liang: > Klocwork report 'req' might be used uninitialized. > In some cases it can 'goto error' when '*internals' not been set. > The result is

[dpdk-dev] [PATCH v3 0/2] testpmd: check return value of rte_eth_dev_vlan_filter()

v3 changes: - add seperate patch with testpmd_funcs.rst changes v2 changes: - fix formatting errors This patchset modifies testpmd behavior when setting: rx_vlan add all vf_port (enabling all vlanids to be passed thru rx filter on VF). Rx_vlan_all_filter_set() function, checks if the next vlanid

[dpdk-dev] [PATCH v3 1/2] doc: add information about limited number of vlan_ids

This patch adds information to testpmd_funcs.rst file, about limited number of vlan_ids possible to be enabled in a filter. This is limited to the maximum number of entries possible in the VFTA table. Signed-off-by: Michal Jastrzebski --- doc/guides/testpmd_app_ug/testpmd_funcs.rst |2 ++ 1

[dpdk-dev] [PATCH v3 2/2] testpmd: check return value of rte_eth_dev_vlan_filter()

This patch modifies testpmd behavior when setting: rx_vlan add all vf_port (enabling all vlanids to be passed thru rx filter on VF). Rx_vlan_all_filter_set() function, checks if the next vlanid can be enabled by the driver. Number of vlanids is limited by the NIC and thus the NIC do not allow to

[dpdk-dev] [PATCH v4 2/3] ethdev: add optional rxtx callback support

2015-02-20 10:06, Bruce Richardson: > On Thu, Feb 19, 2015 at 05:56:41PM +, John McNamara wrote: > > From: Richardson, Bruce > > > > Add optional support for inline processing of packets inside the RX > > or TX call. For an RX callback, what happens is that we get a set of > > packets from

[dpdk-dev] [PATCH v10 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

On 2015/02/20 19:14, Maxime Leroy wrote: > Hi Tetsuya, > > On Fri, Feb 20, 2015 at 7:39 AM, Tetsuya Mukawa wrote: >> These functions are used for attaching or detaching a port. > [..] >> + >> +static void >> +get_vdev_name(char *vdevargs) >> +{ >> + char *sep; >> + >> + if (vdevargs

[dpdk-dev] [PATCH] e1000: fix e1000 PCI access endian issue.

> e1000 is little endian, but cpu maybe not. > add necessary conversions. > > rte_cpu_to_le_32(...) for PCI write > rte_le_to_cpu_32(...) for PCI read. > > Signed-off-by: Xuelin Shi Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] ixgbe: fix ixgbe PCI access endian issue

> ixgbe is little endian, but cpu maybe not. > add necessary conversions. > rte_cpu_to_le_32(...) for PCI write > rte_le_to_cpu_32(...) for PCI read. > > Signed-off-by: Xuelin Shi Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCH] kni/ethtool/ixgbe: enforce access between ixgbe PCI and CPU

Anyone to review this patch? 2015-02-11 14:49, xuelin.shi at freescale.com: > From: Xuelin Shi > > make sure: > CPU read from ixgbe with IXGBE_LE32_TO_CPUS > CPU write to ixgbe with IXGBE_CPU_TO_LE32 > > otherwise, there is endian issue for ixgbe on BIG_ENDIAN CPU. > >

[dpdk-dev] [PATCH] ixgbe: fix vector PMD chained mbuf receive

> When the vector pmd was receiving a mix of packets of various sizes, > some of which were split across multiple mbufs, there was an issue > with reassembly of the jumbo frames. This was due to a skipped increment > when using "continue" in a while loop. Changing the loop to a "for" > loop fixes

[dpdk-dev] [PATCH] ixgbe: forbid building vpmd without Rx bulk alloc

2015-01-30 00:31, Thomas Monjalon: > CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC is a prerequisite > of CONFIG_RTE_IXGBE_INC_VECTOR. > > Reported-by: Alexander Belyakov > Signed-off-by: Thomas Monjalon Applied

[dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero

2015-02-17 15:52, Pablo de Lara: > rx_fc_en and tx_fc_en in cmd_link_flow_ctrl_set_parsed > could be used without being initialized. > > Signed-off-by: Pablo de Lara Applied, thanks

[dpdk-dev] packet processing speed

Hi Team , I am using DPDK-1.7.1 and want to enhance the packet processing speed . But couldn't get how memory get initialize and lcore - port-queue mapping . Suggestions are welcome on this . Regards, Kuldeep The information contained in this electronic message and any attachments to this

[dpdk-dev] [PATCH 2/3] mbuf: fix a couple of doxygen comments

Fix a couple of doxygen comments in mbuf structure: - seqn had no doxygen syntax. - usr was not generating proper link to function. Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_mbuf/rte_mbuf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH 1/3] doc: add librte_reorder to doxygen conf

Add missing reorder lirbary directory to doxygen configuration. Signed-off-by: Sergio Gonzalez Monroy --- doc/api/doxy-api.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf index 27c782c..86298b7 100644 --- a/doc/api/doxy-api.conf +++

[dpdk-dev] [PATCH 0/3] Misc fixes

This series fixes a few small issues in different files: - doxygen syntax of a couple of comments in struct mbuf - add missing reorder library directory to doxygen config - rte_reorder_create was not being checked for possible errors, so add proper error checking and move it before launching

[dpdk-dev] [PATCH 3/3] examples/packet_ordering: move creation of reorder buffer

There was no error checking after calling rte_reorder_create. Move the creation of the reorder buffer before launching threads in case of memory error. Signed-off-by: Sergio Gonzalez Monroy --- examples/packet_ordering/main.c | 37 + 1 file changed, 25

[dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation

Hi, On Fri, Feb 20, 2015 at 1:26 PM, Thomas Monjalon wrote: > Hi Stefan, > > Thanks for improving DPDK for C++ usage. > > I'm a bit lost because that's the fourth time you send the same patch > (without versioning): > http://dpdk.org/dev/patchwork/patch/3140/ > (this one had some

[dpdk-dev] [PATCH 1/2] rte_pci.h: Fix C++11 compilation

In C++11 concatenated string literals need to have a space in between. Found with clang++-3.4, IIRC g++-4.8 also complains about this. Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier

[dpdk-dev] [PATCH 2/2] Headers: more C++11 compilation fixes

Fixed two more places where non-C++11 string concatenation is used. Spotted by John McNamara. Signed-off-by: Stefan Puiu --- lib/librte_mempool/rte_mempool.h |8 lib/librte_vhost/vhost-net-cdev.h |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [PATCH v2] i40e: fix build with gcc 5

> > Eliminate ambiguity in the condition which trips up a "logical not > > is only applied to the left..." warning from gcc 5, causing build > > failure with -Werror. Besides non-ambiguous, the condition is > > far more obvious this way. > > > > Signed-off-by: Panu Matilainen > > Acked-by:

[dpdk-dev] packet processing speed

2015-02-20 11:18, kuldeep.samasi at wipro.com: > I am using DPDK-1.7.1 and want to enhance the packet processing speed . > But couldn't get how memory get initialize and lcore - port-queue mapping . > > Suggestions are welcome on this . The description of your problem is too short and vague. The

[dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types

> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, February 17, 2015 5:02 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified > packet > types > > Hi Helin, > > On 02/17/2015

[dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration

2015-02-19 18:26, Michal Jastrzebski: > From: Maciej Gajdzica > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > address type from uint8_t[4] to uint32_t. Also removed union from > arp_hdr struct. Updated test-pmd to match new arp_hdr version. > > Signed-off-by: Maciej

[dpdk-dev] [PATCH 0/8] Improve build process

On 13/02/2015 12:51, Neil Horman wrote: > On Fri, Feb 13, 2015 at 11:08:02AM +, Gonzalez Monroy, Sergio wrote: >> On 13/02/2015 10:14, Panu Matilainen wrote: >>> On 02/12/2015 05:52 PM, Neil Horman wrote: On Thu, Feb 12, 2015 at 04:07:50PM +0200, Panu Matilainen wrote: > On 02/12/2015

[dpdk-dev] [PATCH v3 4/6] bond: add example application for link bonding mode 6

2015-02-19 18:26, Michal Jastrzebski: > + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. You should check the date. Is there some reviews of the copyright at Intel? It's quite common to see these dates starting and finishing too early. > +#ifdef RTE_EXEC_ENV_BAREMETAL >

[dpdk-dev] [PATCH v2 0/2] support TSO on i40e

2015-02-13 09:48, Jijiang Liu: > This patch set enables i40e TSO feature for both non-tunneling packet and > tunneling packet. > > Change logs: > v2 change: rework based on Olivier's patch set [PATCH v2 00/20] enhance > tx checksum offload API >

[dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration

> 2015-02-19 18:26, Michal Jastrzebski: > > From: Maciej Gajdzica > > > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > > address type from uint8_t[4] to uint32_t. Also removed union from > > arp_hdr struct. Updated test-pmd to match new arp_hdr version. > > > >

[dpdk-dev] [PATCH v10 13/14] eal/pci: Add rte_eal_dev_attach/detach() functions

Hi Tetsuya, Thanks for your comment. On Fri, Feb 20, 2015 at 11:32 AM, Tetsuya Mukawa wrote: > On 2015/02/20 19:14, Maxime Leroy wrote: >> Hi Tetsuya, [...] >> > > Hi Maxime, > > I appreciate for your comment. > > When rte_eal_init() is called, if we have "--vdev" options, these will > be

[dpdk-dev] [PATCH] cmdline: fix type format from unsigned to size_t for buffer size

Function match_inst is used to take buffor using sizeof() which is size_t type. This modification also involved changing '%u' to '%zu' in printf function. Signed-off-by: Daniel Mrzyglod --- lib/librte_cmdline/cmdline_parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration

2015-02-20 14:54, Gajdzica, MaciejX T: > > 2015-02-19 18:26, Michal Jastrzebski: > > > From: Maciej Gajdzica > > > > > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > > > address type from uint8_t[4] to uint32_t. Also removed union from > > > arp_hdr struct. Updated

[dpdk-dev] [PATCH] mk: Rework gcc version detection to permit versions newer than 4.x

On 02/20/2015 04:04 PM, Thomas Monjalon wrote: > Hi Panu, > > 2015-02-18 14:11, Panu Matilainen: >> Separately comparing major and minor versions becomes seriously clumsy >> when with major version changes, convert the entire version string into >> a numeric value (ie 4.6.0 becomes 460 and 5.0.0

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Thursday, February 19, 2015 3:34 PM > To: Wodkowski, PawelX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 0/3] new headroom stats library and > example application > > On Thu,

[dpdk-dev] [PATCH 2/2] i40e:enable TSO support

Hello, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand > Sent: Monday, February 9, 2015 10:11 AM > To: Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] i40e:enable TSO support > > Hello, > > This patch does two

[dpdk-dev] [PATCH v4 0/6] Link Bonding mode 6 support (ALB)

v4 changes: - license year modified - aded license to rte_eth_bond_alb files - removed RTE_EXEC_ENV_BAREMETAL in #define v3 changes: - completed description for mode 5 unit tests patch - fixed errors required by checkpatch.pl - moved patch version changes from patches to cover-letter v2 changes:

[dpdk-dev] [PATCH v4 1/6] net: changed arp_hdr struct declaration

From: Maciej Gajdzica Changed MAC address type from uint8_t[6] to struct ether_addr and IP address type from uint8_t[4] to uint32_t to make it consistent with other DPDK code using MAC and IP addresses. It allows us to use is_same_ether_addr and ether_addr_copy

[dpdk-dev] [PATCH v4 2/6] bond: add link bonding mode 6 implementation

From: Maciej Gajdzica This mode includes adaptive TLB and receive load balancing (RLB). In RLB the bonding driver intercepts ARP replies send by local system and overwrites its source MAC address, so that different peers send data to the server on different slave

[dpdk-dev] [PATCH v4 3/6] bond: add debug info for mode 6 link bonding

This patch add some debug information when using link bonding mode 6. It prints basic information about ARP packets on RX and TX (MAC, ip, packet number, arp packet type). If CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB == y. If CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1 is enabled instead of previous one, use show

[dpdk-dev] [PATCH v4 4/6] bond: add example application for link bonding mode 6

This patch contains an example for link bonding mode 6. It interact with user by a command prompt. Available commands are: Start - starts ARP_thread which respond to ARP_requests and sends ARP_updates (this Is enabled by default after startup), Stop -stops ARP_thread, Send count ip - send count

[dpdk-dev] [PATCH v4 5/6] bond: modify TLB unit tests

From: Daniel Mrzyglod This patch modify mode older name from BONDING_MODE_ADAPTIVE_TRANSMIT_LOAD_BALANCING to BONDING_MODE_TLB This patch also changes order of TEST_ASSERT macro in test_tlb_verify_slave_link_status_change_failover. Signed-off-by: Daniel Mrzyglod

[dpdk-dev] [PATCH v4 6/6] bond: add unit tests for link bonding mode 6.

From: Maciej Gajdzica Added 4 unit tests checking link bonding mode 6 behavior. Also modified virtual_pmd so it is possible to provide packets, that should be received with rx_burst and to inspect packets transmitted by tx_burst. In packet_burst_generator.c

[dpdk-dev] [PATCH] bond: changed port_id type to uint8_t to prevent data loss.

In some places port_id is declared as int, which causes data loss when using functions expecting port_id as uint8_t. Issue found with static code analysis tool. Signed-off-by: Maciej Gajdzica --- lib/librte_pmd_bond/rte_eth_bond_pmd.c |5 +++-- 1 file changed, 3 insertions(+), 2

[dpdk-dev] [PATCH] bond: changed slave_id to uint8_t to prevent data loss

In some places slave_id is declared as uint16_t, which causes data loss when using functions expecting port_id as uint8_t. Issue found with static code analysis tool. Signed-off-by: Maciej Gajdzica --- lib/librte_pmd_bond/rte_eth_bond_8023ad.c |4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH] bond: changed rx and tx queue_id field type to prevent data loss.

Previous type of rx and tx queue_id field was int, which caused possible data loss when calling functions expecting uint16_t as an argument. Issue found with static code analysis tool. Signed-off-by: Maciej Gajdzica --- lib/librte_pmd_bond/rte_eth_bond_pmd.c |3 ++-

[dpdk-dev] [PATCH] virtio: Changed variable types to prevent possible data loss in virtio_ethdev.c, virtio_ethdev.h and virtio_rxtx.c

Changed vtpci_queue_idx type in function virtio_dev_queue_setup from uint8_t to uint16_t to prevent possible data loss. Also changed type of head variable in function virtio_send_command from uint32_t to uint16_t. Issues found with static code analysis tool. Signed-off-by: Maciej Gajdzica ---

[dpdk-dev] [PATCH v3 4/6] bond: add example application for link bonding mode 6

> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, February 20, 2015 3:43 PM > To: Jastrzebski, MichalX K > Cc: dev at dpdk.org; Butler, Siobhan A > Subject: Re: [dpdk-dev] [PATCH v3 4/6] bond: add example application for > link bonding mode

[dpdk-dev] [PATCH] virtio: fixed possible data loss in function virtio_recv_mergeable_pkts

Variable rcv_cnt declared in function virtio_recv_mergeable_pkts was of type uint32_t. It was used by virtqueue_dequeue_burst_rx function, which expects argument of type uint16_t. Changed rcv_cnt variable type to uint16_t to prevent possible data loss. Issue found with static code analysis tool.

[dpdk-dev] [PATCH] enic: changed type of field ig_vlan_strip_en in struct enic to prevent possible data loss

Field ig_vlan_strip_en in struct enic type is int. It is used only by function enic_set_nic_cfg which expects uint_8 as argument. Changed type of the field to prevent possible loss of precision. Issue found with static code analysis tool. Signed-off-by: Maciej Gajdzica ---

[dpdk-dev] [PATCH] enic: Changed ENIC_ALIGN to unisgned long to prevent possible data loss

Define ENIC_ALIGN is used only by function rte_memzone_reserve_aligned, which expects argument of type unsigned. Defined constant is of type unsigned long long. Changed type to unsigned long to prevent possible loss of precision. Issue found with static code analysis tool. Signed-off-by: Maciej

[dpdk-dev] [PATCH] enic: fixed possible data loss in vnic_dev.h

In function writeq is written in two 32-bit long registers with writel function. When trying to write val >> 32, static code analysis tool reports that 64-bit value is passed to function expecting 32-bit value. Added cast to clear this warning. Signed-off-by: Maciej Gajdzica ---

[dpdk-dev] [PATCH] enic: Fixed possible data loss in vnic_dev.c

Macro GET_CONFIG passes result of sizeof operation to the function vnic_dev_spec. This function expects parameter of type unsigned int. Changed that parameter type to size_t in function declaration to prevent possible data loss. Issue found with static code analysis tool. Signed-off-by: Maciej

[dpdk-dev] RTE_PIPELINE_ACTION_PORT_META doesn't work properly

Hi, list! RTE_PIPELINE_ACTION_PORT_META option in rte_pipeline library doesn't work for non-default table entries. Is this bug or correct behaviour? This is my patch, that changes this behaviour: --- a/lib/librte_pipeline/rte_pipeline.c +++ b/lib/librte_pipeline/rte_pipeline.c @@ -999,8

[dpdk-dev] [PATCH v3 0/4] Support NVGRE on i40e

The patch set supports NVGRE on i40e. It includes: - Support RX filters for NVGRE packet. It uses MAC and VLAN to point to a queue. The filter types supported are listed below: 1. Inner MAC and Inner VLAN ID 2. Inner MAC address, inner VLAN ID and tenant ID. 3. Inner MAC and

[dpdk-dev] [PATCH v3 1/4] librte_ether:add an ETHER_TYPE_TEB macro

From: Jijiang Liu Add an Ethernet type definition for Transparent Ethernet Bridging. Signed-off-by: Jijiang Liu Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ether.h

[dpdk-dev] [PATCH v3 2/4] i40e:support RX tunnel filter for NVGRE packet

From: Jijiang Liu The filter types supported are listed below for NVGRE packet: 1. Inner MAC and Inner VLAN ID. 2. Inner MAC address, inner VLAN ID and tenant ID. 3. Inner MAC and tenant ID. 4. Inner MAC address. 5. Outer MAC address, tenant ID and inner

[dpdk-dev] [PATCH v3 3/4] app/testpmd:test RX tunnel filter for NVGRE packet

From: Jijiang Liu Extend the "tunnel_filter" command in testpmd to test the RX tunnel filter API for NVGRE packet. Signed-off-by: Jijiang Liu Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-)

[dpdk-dev] [PATCH v3 4/4] app/testpmd:test NVGRE Tx checksum offload

From: Jijiang Liu Enhance csum fwd engine based on current TX checksum framework in order to test TX Checksum offload for NVGRE packet. It includes: - IPv4 and IPv6 packet - outer L3, inner L3 and L4 checksum offload for Tx side. Signed-off-by: Declan Doherty ---

[dpdk-dev] [PATCH v3 0/3] enable uio_pci_generic support

v3 changes - made processing of uio devices identical, irrespective of igb_uio or uio_pci_generic - removed storage of kernel driver name from dev node as now unneeded. v2 changes: - Change variable name of kernel driver with precise comment - Fix a union definition error in v1 patchset - Move

[dpdk-dev] [PATCH v3 3/3] tools: enable binding NIC device to uio_pci_generic

From: Zhou Danny Add uio_pci_generic to the list of supported kernel drivers. Signed-off-by: Danny Zhou Tested-by: Qun Wan Signed-off-by: Bruce Richardson --- tools/dpdk_nic_bind.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v3 2/3] eal: add interrupt enable/disable routines for uio_pci_generic

From: Zhou Danny enable/disable interrupt by manipulating a control bit of command register on NIC's PCIe configuration space. Signed-off-by: Danny Zhou Tested-by: Qun Wan Signed-off-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 68

[dpdk-dev] [PATCH v5 0/3] DPDK ethdev callback support

This patchset is for a small optional addition to the ethdev library, to add support for callbacks at the RX and TX stages. This allows packet processing to be done on packets before they get returned to applications using rte_eth_rx_burst call. See the RFC cover letter for the use cases:

[dpdk-dev] [PATCH v5 3/3] examples: example showing use of callbacks.

From: Richardson, Bruce Example showing how callbacks can be used to insert a timestamp into each packet on RX. On TX the timestamp is used to calculate the packet latency through the app, in cycles. Signed-off-by: Bruce Richardson Signed-off-by: John McNamara ---

  1   2   >