2015-07-10 00:31, Helin Zhang:
> Currently only 6 bits which are stored in ol_flags are used to indicate the
> packet types. This is not enough, as some NIC hardware can recognize quite
> a lot of packet types, e.g i40e hardware can recognize more than 150 packet
> types. Hiding those packet types
2015-07-15 18:06, Zhang, Helin:
> > The workaround for Tx tunnel offloading can now be replaced with packet type
> > flag checking.
> > The ol_flags for IPv4/IPv6 and tunnel Rx offloading are replaced with
> > packet type
> > flags.
> >
> > Signed-off-by: Thomas Monjalon
> > Acked-by: Adrien Maz
> > The significant ABI changes of all shared libraries are planned to support
> > unified packet type which will be taken effect from release 2.2. Here
> > announces that ABI changes in detail.
> >
> > Signed-off-by: Helin Zhang
> Acked-by: Jingjing Wu
Applied with rewording to take new NEXT_A
A packet is tunnelled if the tunnel type is identified or if it has
an inner part.
Fix also a typo in RTE_PTYPE_INNER_L3_MASK.
Fixes: f295a00a2b44 ("mbuf: add definitions of unified packet types")
Signed-off-by: Thomas Monjalon
---
app/test-pmd/rxonly.c | 2 +-
lib/librte_mbuf/rte_mbuf.h
2015-07-15 23:57, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > A packet is tunnelled if the tunnel type is identified or if it has an
> > inner part.
> >
> > Fix also a typo in RTE_PTYPE_INNER_L3_MASK.
> >
> > Fixes: f295a00a2b44 ("mbuf: add definitions of unif
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, July 15, 2015 5:13 PM
> To: Zhang, Helin
> Cc: olivier.matz at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH] mbuf: fix tunnel flags check
>
> 2015-07-15 23:57, Zhang, Helin:
> > From
Hi All,
It seems that on FreeBSD, nic_uio currently only binds the devices matched in
rte_pci_dev_ids.h. On Linux, it's possible to bind any listed device with
igb_uio or vfio.
The pci device ids supported by cxgbe PMD, maintained in a table, are not part
of rte_pci_dev_ids.h. Hence, Chelsio T5
Update malloc documentation to reflect new implementation details.
Signed-off-by: Sergio Gonzalez Monroy
---
v11:
- Add copyright and licence to SVG file
doc/guides/prog_guide/env_abstraction_layer.rst | 220 -
doc/guides/prog_guide/img/malloc_heap.png | Bin 81329 -> 0 bytes
doc/g
From: Xuelin Shi
1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...)
2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...)
3. checking pci status with converted constant.
Signed-off-by: Xuelin Shi
---
drivers/net/ixgbe/ixgbe_rxtx.c | 77 --
Hi Thomas,
I have worked out the new version based on dpdk v2 codebase to address the
comments.
http://www.dpdk.org/dev/patchwork/patch/6449/
thanks,
Xuelin Shi
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, July 10, 2015 22:52
Hi Maryam,
On 07/15/2015 03:11 PM, Maryam Tahhan wrote:
> This patch set implements xstats_get() and xstats_reset() in dev_ops for
> ixgbe to expose detailed error statistics to DPDK applications. The
> dump_cfg application was extended to demonstrate the usage of
> retrieving statistics for DPDK
Hello Rahul,
(cc Bruce)
How about removing this "whitelist" from the nic_uio driver and just rely
on the hw.nic_uio.bdfs parameter to find out which devices to bind ?
--
David Marchand
On Thu, Jul 16, 2015 at 2:12 PM, Rahul Lakkireddy <
rahul.lakkireddy at chelsio.com> wrote:
> Hi All,
>
> I
On Thu, Jul 16, 2015 at 09:57:03AM +0200, David Marchand wrote:
> Hello Rahul,
>
> (cc Bruce)
>
> How about removing this "whitelist" from the nic_uio driver and just rely
> on the hw.nic_uio.bdfs parameter to find out which devices to bind ?
>
Yes, that would be my thinking too. It probably shou
From: "De Lara Guarch, Pablo"
_mm_test_all_zeros is not available for CPUs with no SSE4.1,
therefore, DPDK would not build.
This patch adds an alternative for this, using _mm_cmpeq_epi32 and
_mm_movemask_epi8.
Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
Signed-off-by:
2015-07-16 00:36, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2015-07-15 23:57, Zhang, Helin:
> > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > > A packet is tunnelled if the tunnel type is identified or if it has an
> > > > inner part.
> >
Helin,
In commit http://dpdk.org/browse/dpdk/commit/?id=c22265f6fd4cdc, some fake flags
were added:
#define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< External IP header checksum
error. */
#define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX pkt
oversize.
>diff --git a/lib/librte_hash/rte_cuckoo_hash.c
b/lib/librte_hash/rte_cuckoo_hash.c
>new file mode 100644
>index 000..50e3acd
>--- /dev/null
>+++ b/lib/librte_hash/rte_cuckoo_hash.c
>@@ -0,0 +1,1027 @@
...
>+
>+/* Functions to compare multiple of 16 byte keys (up to 128 bytes) */
>+static int
>
2015-07-16 08:37, Sergio Gonzalez Monroy:
> new file mode 100755
> index 000..d6bcc84
> --- /dev/null
> +++ b/doc/guides/prog_guide/img/malloc_heap.svg
This file has the exec bit.
Will be fixed before applying.
2015-07-16 08:37, Sergio Gonzalez Monroy:
> Update malloc documentation to reflect new implementation details.
Should you reword the memzone chapter and move it after the malloc one?
On 16/07/2015 11:12, Thomas Monjalon wrote:
> 2015-07-16 08:37, Sergio Gonzalez Monroy:
>> Update malloc documentation to reflect new implementation details.
> Should you reword the memzone chapter and move it after the malloc one?
I didn't think that the memzone doc needed to change its wording fo
Hi Bruce and David,
On Thu, Jul 16, 2015 at 09:57:15 +0100, Bruce Richardson wrote:
> On Thu, Jul 16, 2015 at 09:57:03AM +0200, David Marchand wrote:
> > Hello Rahul,
> >
> > (cc Bruce)
> >
> > How about removing this "whitelist" from the nic_uio driver and just rely
> > on the hw.nic_uio.bdfs p
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/abi.rst |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 126f73e..942f3ea 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/rel_notes
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 1:37 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_cfgfile
>
>
> Signed-off-by: Cristian Dumitrescu
Acked-by: M
2015-07-15 17:32, Sergio Gonzalez Monroy:
> Current implemetation allows reserving/creating memzones but not the opposite
> (unreserve/free). This affects mempools and other memzone based objects.
>
> From my point of view, implementing free functionality for memzones would look
> like malloc over
2015-07-15 12:16, Olivier MATZ:
> On 07/09/2015 03:22 PM, Bruce Richardson wrote:
> > The comment for TX offload flags stated that those flags started at bit
> > 55 and then were added to the right of that, leaving 8 bits reserved for
> > generic mbuf (i.e. non-offload) use. This comment may not ha
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/abi.rst | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..271e08e 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/r
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 2:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
>
>
> Signed-off-by: Cristian Dumitrescu
Acked-by: Ma
2015-07-16 13:19, Cristian Dumitrescu:
> +* librte_port (rte_port.h): Macros to access the packet meta-data stored
> within
> + the packet buffer will be adjusted to cover the packet mbuf structure as
> well,
> + as currently they are able to access any packet buffer location except the
> + pa
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 2:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
>
>
> Signed-off-by: Cristian Dumitrescu
> ---
> doc/
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 1:37 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_cfgfile
>
>
> Signed-off-by: Cristian Dumitrescu
> ---
> d
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 12:37 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_cfgfile
>
>
> Signed-off-by: Cristian Dumitrescu
> ---
Ac
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 1:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
>
>
> Signed-off-by: Cristian Dumitrescu
> ---
Acked-
On 14/07/15 19:21, Polevoy, Igor wrote:
> Hi,
> We are developing an application that uses DPDK PMD functionality .
> We are using a linux shared library which contains the network packets
> processing code and it is statically linked with all the necessary DPDK libs.
> The .so is loaded by the
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, July 13, 2015 17:11
> To: Kulasek, TomaszX
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration
>
> 2015-07-13 14:43, Kulasek, TomaszX:
> > From: Tho
This implementation is designed to provide a familar interface for applications
that rely on kernel-space driver to support ethtool_op and net_device_op for
device management. The initial implementation focuses on ops that can be
implemented through existing netdev APIs. More ops will be support
add new api:
- rte_eth_dev_default_mac_addr_set
the new api, rte_eth_dev_default_mac_addr_set, uses the
existing dev_op, mac_addr_set, to enable setting mac
addr from ethdev level.
Signed-off-by: Liang-Min Larry Wang
---
lib/librte_ether/rte_ethdev.c | 21 +
lib/lib
add new apis:
- rte_eth_dev_get_reg_length
- rte_eth_dev_get_reg_info
- rte_eth_dev_get_eeprom_length
- rte_eth_dev_get_eeprom
- rte_eth_dev_set_eeprom
to enable reading device parameters (register and
eeprom) based upon ethtool alike
data parameter specification.
Signed-off-by: Liang-Min Larry W
add function to support ethtool ops:
- set_mac_addr
- get_reg_length
- get_regs
- get_eeprom_length
- get_eeprom
- set_eeprom
Signed-off-by: Liang-Min Larry Wang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 178 +-
drivers/net/ixgbe/ixgbe_regs.h | 376
add function to support ethtool ops:
- set_mac_addr
- get_reg_length
- get_regs
- get_eeprom_length
- get_eeprom
- set_eeprom
Signed-off-by: Liang-Min Larry Wang
---
drivers/net/e1000/igb_ethdev.c | 175
drivers/net/e1000/igb_regs.h | 223 ++
The example includes an ethtool library and two applications:
one application is a non- DPDK process (nic-control)
and the other is a DPDK l2fwd applicaiton (l2fwd-app).
The nic-control process sends ethtool alike device management
requests to l2fwd-app through a named pipe IPC. This example
is des
2015-07-16 10:00, Pablo de Lara:
> From: "De Lara Guarch, Pablo"
>
> _mm_test_all_zeros is not available for CPUs with no SSE4.1,
> therefore, DPDK would not build.
> This patch adds an alternative for this, using _mm_cmpeq_epi32 and
> _mm_movemask_epi8.
>
> Fixes: 48a399119619 ("hash: replace w
2015-07-15 16:13, Pablo de Lara:
> SLES 12 has kernel 3.12, which original does not have skb_set_hash,
> but SuSE has added that function to the kernel integrated on it.
> Therefore, the function is not declared when compiling on this OS.
>
> Reported-by: Sotiris Salloumis
> Signed-off-by: Pablo
2015-07-15 13:40, Pablo de Lara:
> When encountering a loop while adding a new entry,
> element out of bounds of array was being unnecessarily resetted.
>
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
>
> Signed-off-by: Pablo de Lara
Applied, thanks
2015-07-15 13:40, Pablo de Lara:
> gcc 4.4 and 4.5 throws following error:
> rte_cuckoo_hash.c:145: error: flexible array member in otherwise empty struct.
>
> This is due to empty length in flexible array, which has been changed to use
> size 0 in the declaration of the array.
>
> Fixes: 48a3991
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, July 16, 2015 1:26 PM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port
>
> 2015-07-16 13:19, Cristian Dumitrescu
v2 changes:
-text simplification
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/abi.rst |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..6c064e2 100644
--- a/doc/guides/rel_notes/
Konstantin, what is the status of this patch?
2015-06-26 10:07, Tomasz Kulasek:
> This patch adds management of PKT_RX_FDIR and PKT_RX_RSS_HASH ol_flags in vPMD
> for unified packet type as well as for 16 bit field packet_type when
> RTE_UNIFIED_PKT_TYPE is not defined.
>
> This patch depends of
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, July 16, 2015 2:39 AM
> To: Zhang, Helin
> Cc: dev at dpdk.org; olivier.matz at 6wind.com
> Subject: mbuf offload flags
>
> Helin,
>
> In commit http://dpdk.org/browse/dpdk/commit/?id=c2
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Cristian Dumitrescu
> Sent: Thursday, July 16, 2015 4:27 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: announce ABI change for librte_port
>
> v2 changes:
> -text simplification
>
> Signed-of
2015-07-16 15:50, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Helin,
> >
> > In commit http://dpdk.org/browse/dpdk/commit/?id=c22265f6fd4cdc, some
> > fake flags were added:
> >
> > #define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< External IP header
> > checksum
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/abi.rst |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..aa7c036 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/rel_no
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/abi.rst |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..194e8c6 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/rel_notes
Why doesn't igb driver set the wthresh it wants as default?
I see:
PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance,
consider setting the TX WTHRESH value to 4, 8, or 16.
But the default tx_conf has wthresh of 0.
#define IGB_DEFAULT_TX_WTHRESH 0
Either mess
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.
Signed-off-by: Stephen Hemminger
---
drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm10k/base/fm10
On 07/16/2015 10:26 AM, Stephen Hemminger wrote:
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
> 1 file changed, 1 inser
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhe Tao
> Sent: Friday, July 3, 2015 10:12 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the DD
> bits
> are multiplex with descriptor type field. so cannot u
Hash library uses optimized compare functions that use
x86 intrinsics, therefore non-x86 systems could not build
the library. In that case, the compare function is set
to the generic memcmp.
Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
Reported-by: Tony Lu
Signed-off-by:
Hi Tony,
> -Original Message-
> From: Tony Lu [mailto:zlu at ezchip.com]
> Sent: Thursday, July 16, 2015 10:40 AM
> To: De Lara Guarch, Pablo; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash library
> with cuckoo hash implementation
>
> >diff --git a/l
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.
Signed-off-by: Stephen Hemminger
---
drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm10k/base/fm10
2015-07-16 21:41, Pablo de Lara:
> Hash library uses optimized compare functions that use
> x86 intrinsics, therefore non-x86 systems could not build
> the library. In that case, the compare function is set
> to the generic memcmp.
[...]
> --- /dev/null
> +++ b/lib/librte_hash/rte_cmp_fns.h
Renami
Signed-off-by: Stephen Hemminger
---
doc/guides/rel_notes/abi.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
index 9e98d62..a4d100b 100644
--- a/doc/guides/rel_notes/abi.rst
+++ b/doc/guides/rel_notes/abi.rst
@@ -34,3 +
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, July 16, 2015 10:22 PM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: [PATCH] doc: announce ABI change for librte_sched
>
> Signed-off-by: Stephen Hemmi
2015-07-16 09:25, Liang-Min Larry Wang:
> The example includes an ethtool library and two applications:
> one application is a non- DPDK process (nic-control)
> and the other is a DPDK l2fwd applicaiton (l2fwd-app).
> The nic-control process sends ethtool alike device management
> requests to l2fwd
On Thu, Jul 16, 2015 at 02:21:39PM -0700, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger
> ---
> doc/guides/rel_notes/abi.rst | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst
> index 9e98d62..a4d100b 100644
This is a subset of earlier rte_sched patches.
It does not address the read/clearing API issue since that
was still under discussion.
Stephen Hemminger (4):
rte_sched: make RED optional at runtime
rte_sched: don't put tabs in log messages
rte_sched: use correct log level
rte_sched: hide s
Want to be able to build with RTE_SCHED_RED enabled but
allow disabling RED on a per-queue basis at runtime.
RED is disabled unless min/max thresholds set.
Signed-off-by: Stephen Hemmminger
---
lib/librte_sched/rte_sched.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/librte_
syslog does not like tabs in log messages; tab gets translated to #011
Signed-off-by: Stephen Hemminger
---
lib/librte_sched/rte_sched.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 6928c98..1
The setup messages should be at DEBUG level since they are not
important for normal operation of system. The messages about
problems should be at NOTICE or ERR level.
Signed-off-by: Stephen Hemminger
---
lib/librte_sched/rte_sched.c | 15 +--
1 file changed, 9 insertions(+), 6 deleti
Right now the scheduler hierarchy is encoded as a bitfield
that is visible as part of the ABI. This creates an barrier
limiting future expansion of the hierarchy.
As a transistional step. hide the actual layout of the hierarchy
and mark the exposed structure as deprecated. This will allow for
expa
2015-07-16 09:25, Liang-Min Larry Wang:
> This implementation is designed to provide a familar interface for
> applications that rely on kernel-space driver to support ethtool_op and
> net_device_op for device management. The initial implementation focuses on
> ops that can be implemented throug
2015-07-15 13:22, Liang-Min Larry Wang:
> fix return value, using the macro input instead of -EINVAL.
>
> Signed-off-by: Liang-Min Larry Wang
Applied, thanks
Thomas,
Do you want me to create a separate patch just include the
example/l2fwd-ethtool? Do you also mean besides the identified Makefiles, you
see more rework needs to be done, or I just need to fix Makefile issue? If just
Makefile issue, I could try to make another attempt tomorrow?
The return in fm10k_dev_handle_fault has useless conditional
since it always returns 0 here.
Signed-off-by: Stephen Hemminger
---
drivers/net/fm10k/fm10k_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 902cca
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, July 16, 2015 10:35 PM
> To: Dumitrescu, Cristian
> Cc: dev at dpdk.org; Stephen Hemminger
> Subject: [PATCH v5 0/4] rte_sched: cleanup and deprecation
>
> This is a subset of earlier
Thomas,
Thanks for clarification. Our next step is to create hooks on virtio
and vmxnet3 and other ethtool op.
Thanks again for making prompt reply as I am aware it's very late in your time
zone.
Larry
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6win
> I am running a virtual guest on Ubuntu and trying to use dpdk testpmd as a
> packet forwarder.
>
> After starting the virtual guest, I do
> insmod igb_uio.ko
> insmod rte_kni.ko
> echo ":00:06.0" > /sys/bus/pci/drivers/virtio-pci/unbind
> echo ":00:07.0" > /sys/bus/pci/drivers/virtio-pci/
These were found by running the Linux kernel coccinelle scripts
on the DPDK source.
Stephen Hemminger (2):
rte_ethdev: fix crash if malloc fails in rte_eth_dev_callback_register
kni: fix coccinelle warnings
lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 4 ++--
lib/librte_eal/linuxapp/
Found by coccinelle script. If rte_zmalloc() failed in
rte_eth_dev_callback_register
then NULL pointer would be dereferenced.
Signed-off-by: Stephen Hemminger
---
lib/librte_ether/rte_ethdev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_ether/rte_ethde
This fixes cases in KNI where kernel allocation function return value
is needlessly casted.
lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c:3181:25-28: WARNING: casting
value returned by memory allocation function to (u32 *) is useless.
lib/librte_eal/linuxapp/kni/kni_vhost.c:690:9-28: WARNING
The fm10k driver was reading the interrupt cause register but then
using the interrupt mask register defines to look at the bits.
The result is that if a fault happens, the driver would never clear
the fault and would get into an infinite cycle of interrupts.
Note: I don't work for Intel or have t
On Wed, 15 Jul 2015 14:50:59 +0100
Bernard Iremonger wrote:
> Changes in V6:
> Rebase.
> Use queue_release function in dev_uninit function (patch 5)
> Set vq to NULL in queue release function.
> Move previous patch 5 to patch 6.
>
>
> Changes in V5:
> Rebase.
> Add proper queue release patch (p
On Fri, 17 Jul 2015 00:52:09 +
"Lu, Wenzhuo" wrote:
> Hi Stephen,
> I don't think there's a conflict. The message just reminder us that we can
> adjust the values to achieve better performance.
> I saw ixgbe and i40e also use 0 as the same default value. To my opinion,
> it's good to keep t
82 matches
Mail list logo
