[dpdk-dev] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

2016-01-03 Thread Matthew Hall
Hello, In over a month I didn't get a reply if it would be OK to clean up the inconsistent tabs and spaces indents in the pktgen, to make it easier for the community to read the code and help maintain it and add bug fixes. It would be very helpful if I could get a response and a plan for this

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c

2016-01-03 Thread Yi Lu
Error message: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ?rte_eal_hpet_init?: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ?rte_thread_setname? [-Werror=implicit-function-declaration] ret = rte_thread_setnam

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c

2016-01-03 Thread Yi Lu
Error message: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ?rte_eal_hpet_init?: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ?rte_thread_setname? [-Werror=implicit-function-declaration] ret = rte_thread_setnam

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c

2016-01-03 Thread Yi Lu
Error message: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ?rte_eal_hpet_init?: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ?rte_thread_setname? [-Werror=implicit-function-declaration] ret = rte_thread_setnam

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c

2016-01-03 Thread luy...@live.com
From: Yi Lu Error message: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ?rte_eal_hpet_init?: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ?rte_thread_setname? [-Werror=implicit-function-declaration] ret = rte

[dpdk-dev] [PATCH] eal: fix compile error in eal_timer.c

2016-01-03 Thread Yi Lu
Error message: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c: In function ?rte_eal_hpet_init?: /root/dpdk-2.2.0/lib/librte_eal/linuxapp/eal/eal_timer.c:222:2: error: implicit declaration of function ?rte_thread_setname? [-Werror=implicit-function-declaration] ret = rte_thread_setnam

[dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

2016-01-03 Thread Wiles, Keith
On 1/3/16, 2:06 AM, "Matthew Hall" wrote: >Hello, > >In over a month I didn't get a reply if it would be OK to clean up the >inconsistent tabs and spaces indents in the pktgen, to make it easier >for the community to read the code and help maintain it and add bug fixes. > >It would be very hel

[dpdk-dev] [RFC 1/7] eal/common: define rte_soc_* related common interface

2016-01-03 Thread Jan Viktorin
On Sat, 2 Jan 2016 19:45:40 +0100 Jan Viktorin wrote: > > > > Do you consider this will break binary compatibility since > > sizeof (rte_soc_addr) is PATH_MAX (1024) and the other elements of the > > union inside rte_devargs are much smaller (like 32 bytes). > > > > I had a bad feeling about

[dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

2016-01-03 Thread Matthew Hall
On 1/3/16 9:09 AM, Wiles, Keith wrote: > Pktgen is setup for tabs for 4 (with replace tabs with spaces), using tab > stop of 8 is just wrong IMO :-) > Just started using kdevelop instead of eclipse, so I may have corrupted the > style some :-( The problem I found was a number of files had an inc

[dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

2016-01-03 Thread Stephen Hemminger
On Sun, 3 Jan 2016 14:07:35 -0800 Matthew Hall wrote: > On 1/3/16 9:09 AM, Wiles, Keith wrote: > > Pktgen is setup for tabs for 4 (with replace tabs with spaces), using tab > > stop of 8 is just wrong IMO :-) > > Just started using kdevelop instead of eclipse, so I may have corrupted the > > st

[dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and spaces, etc.)?

2016-01-03 Thread Ferruh Yigit
On Sun, Jan 03, 2016 at 05:09:16PM +, Wiles, Keith wrote: > A bigger question is what is the coding style of DPDK and where is it > documented? I looked in the docs/web site and did not find any coding style > suggestions. Maybe I missed it someplace. There is one in: http://dpdk.org/doc/