[dpdk-dev] [PATCH v1] change log level for check when add port in blacklist

2016-06-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of xu,huilong > Sent: Tuesday, May 31, 2016 10:40 AM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Xu, HuilongX > Subject: [dpdk-dev] [PATCH v1] change log level for check when add port in > blackli

[dpdk-dev] [PATCH] examples/vhost: fix corrupted vdev tailq list

2016-06-07 Thread Yuanhan Liu
There are two tailq lists, one for logging all vhost devices, another one for logging vhost devices distributed on a specific core. However, there is just one tailq entry, named "next", to chain the two list, which is wrong and could result to a corrupted tailq list, that the tailq list might alway

[dpdk-dev] [PATCH v3 00/20] vhost ABI/API refactoring

2016-06-07 Thread Yuanhan Liu
v3: - adapted the new vhost ABI/API changes to tep_term example, to make sure not break build at least. - bumped the ABI version to 3 NOTE: I created a branch at dpdk.org [0] for more conveinient testing: [0]: git://dpdk.org/next/dpdk-next-virtio for-testing Every time we introduc

[dpdk-dev] [PATCH v3 01/20] vhost: declare backend with int type

2016-06-07 Thread Yuanhan Liu
It's an fd; so define it as "int", which could also save the unncessary (int) case. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/rte_virtio_net.h | 2 +- lib/librte_vhost/virtio-net.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) di

[dpdk-dev] [PATCH v3 02/20] vhost: set/reset dev flags internally

2016-06-07 Thread Yuanhan Liu
It does not make sense to ask the application to set/unset the flag VIRTIO_DEV_RUNNING (that used internal only) at new_device()/ destroy_device() callback. Instead, it should be set after new_device() succeeds and reset before destroy_device() is invoked inside vhost lib. This patch fixes it. Si

[dpdk-dev] [PATCH v3 03/20] vhost: declare device fh as int

2016-06-07 Thread Yuanhan Liu
Firstly, "int" would be big enough: we don't need 64 bit to represent a virtio-net device id. Secondly, this could let us avoid the ugly "%" PRIu64 ".." stuff. And since ctx.fh is derived from device_fh, declare it as int, too. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane

[dpdk-dev] [PATCH v3 04/20] examples/vhost: make a copy of virtio device id

2016-06-07 Thread Yuanhan Liu
Make a copy of virtio device id (device_fh) from the virtio_net struct, so that we could have less dependency on the virtio_net struct. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- examples/vhost/main.c | 59 --- exampl

[dpdk-dev] [PATCH v3 05/20] vhost: rename device fh to vid

2016-06-07 Thread Yuanhan Liu
I failed to figure out what does "fh" mean here for a long while. The only guess I could have had is "file handle". So, you get the point that it's not well named. I then figured it out that "fh" is derived from the fuse lib, and my above guess is right. However, device_fh represents a virtio net

[dpdk-dev] [PATCH v3 06/20] vhost: get device by vid only

2016-06-07 Thread Yuanhan Liu
get_device() just needs vid, so pass vid as the parameter only. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/vhost-net.h | 30 ++-- lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 64 - lib/librte_vhos

[dpdk-dev] [PATCH v3 07/20] vhost: move vhost device ctx to cuse

2016-06-07 Thread Yuanhan Liu
vhost cuse is now the last reference of the vhost_device_ctx struct; move it there, and do a rename to "vhost_cuse_device_ctx", to make it clear that it's "cuse only". Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/vhost-net.h | 8 ---

[dpdk-dev] [PATCH v3 08/20] vhost: introduce new API to export numa node

2016-06-07 Thread Yuanhan Liu
Introduce a new API rte_vhost_get_numa_node() to get the numa node from which the virtio_net struct is allocated. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- drivers/net/vhost/rte_eth_vhost.c | 13 - lib/librte_vhost/rte_vhost_version.map | 7 +

[dpdk-dev] [PATCH v3 09/20] vhost: introduce new API to export number of queues

2016-06-07 Thread Yuanhan Liu
Introduce a new API rte_vhost_get_queue_num() to export the number of queues. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- drivers/net/vhost/rte_eth_vhost.c | 2 +- lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h | 11 +

[dpdk-dev] [PATCH v3 10/20] vhost: introduce new API to export ifname

2016-06-07 Thread Yuanhan Liu
Introduce a new API rte_vhost_get_ifname() to export the ifname to application. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- drivers/net/vhost/rte_eth_vhost.c | 12 lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h

[dpdk-dev] [PATCH v3 11/20] vhost: introduce new API to export queue free entries

2016-06-07 Thread Yuanhan Liu
The new API rte_vhost_avail_entries() is actually a rename of rte_vring_available_entries(), with the "vring" to "vhost" name change to keep the consistency of other vhost exported APIs. This change could let us avoid the dependency of "virtio_net" struct, to prepare for the ABI refactoring. Sign

[dpdk-dev] [PATCH v3 12/20] vhost: remove dependency on priv field

2016-06-07 Thread Yuanhan Liu
This change could let us avoid the dependency of "virtio_net" struct, to prepare for the ABI refactoring. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- drivers/net/vhost/rte_eth_vhost.c | 13 +++-- examples/vhost/main.c | 10 +++--- 2 files cha

[dpdk-dev] [PATCH v3 13/20] vhost: export vid as the only interface to applications

2016-06-07 Thread Yuanhan Liu
With all the previous prepare works, we are just one step away from the final ABI refactoring. That is, to change current API to let them stick to vid instead of the old virtio_net dev. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- v2: update release note v3: - bump

[dpdk-dev] [PATCH v3 14/20] vhost: hide internal structs/macros/functions

2016-06-07 Thread Yuanhan Liu
We are now safe to move all those internal structs/macros/functions to vhost-net.h, to hide them from external access. This patch also breaks long lines and removes some redundant comments. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/rte_virtio_net

[dpdk-dev] [PATCH v3 15/20] vhost: remove unnecessary fields

2016-06-07 Thread Yuanhan Liu
The "reserved" field in virtio_net and vhost_virtqueue struct is not necessary any more. We now expose virtio_net device with a number "vid". This patch also removes the "priv" field: all fields are priviate now: application can't access it now. The only way that we could still access it is to exp

[dpdk-dev] [PATCH v3 16/20] vhost: remove virtio-net.h

2016-06-07 Thread Yuanhan Liu
It barely has anything useful there, just 2 functions prototype. Here move them to vhost-net.h, and delete it. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/vhost-net.h | 3 ++ lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 1 - li

[dpdk-dev] [PATCH v3 17/20] vhost: reserve few more space for future extension

2016-06-07 Thread Yuanhan Liu
"virtio_net_device_ops" is the only left open struct that an application can access, therefore, it's the only place that might introduce potential ABI break in future for extension. So, do some reservation for it. 5 should be pretty enough, considering that we have barely touched it for a long whi

[dpdk-dev] [PATCH v3 18/20] examples/tep_term: adapt to new vhost ABI/API changes

2016-06-07 Thread Yuanhan Liu
Adapt to the new vhost ABI/API refactoring changes, to not break the build. It's a straightforward change: replace "struct virtio_net *dev" with "int fd". Simple build test only so far. Signed-off-by: Yuanhan Liu --- tep_term is built on top of vhost switch example; they shared a lot of code (be

[dpdk-dev] [PATCH v3 19/20] vhost: per device virtio net header len

2016-06-07 Thread Yuanhan Liu
Virtio net header length is set per device, but not per queue. So, there is no reason to store it in vhost_virtqueue struct, instead, we should store it in virtio_net struct, to make one copy only. Signed-off-by: Yuanhan Liu Tested-by: Rich Lane Acked-by: Rich Lane --- lib/librte_vhost/vhost-n

[dpdk-dev] [PATCH v3 20/20] vhost: make buf vector for scatter Rx local

2016-06-07 Thread Yuanhan Liu
From: Ilya Maximets Array of buf_vector's is just an array for temporary storing information about available descriptors. It used only locally in virtio_dev_merge_rx() and there is no reason for that array to be shared. Fix that by allocating local buf_vec inside virtio_dev_merge_rx(). Signed-o

[dpdk-dev] [PATCH v3 0/6] vhost: add vhost-user client mode and reconnect ability

2016-06-07 Thread Yuanhan Liu
v3: - make the "reconnect" feature be default for client mode, as it's good to handle guest OS restart with less effort. - fix var not-initilized error pointed out by Rich NOTE: I created a branch at dpdk.org [0] for more convenient testing: [0]: git://dpdk.org/next/dpdk-next-virti

[dpdk-dev] [PATCH v3 1/6] vhost: rename structs for enabling client mode

2016-06-07 Thread Yuanhan Liu
DPDK vhost-user just acts as server so far, so, using a struct named as "vhost_server" is okay. However, if we add client mode, it doesn't make sense any more. Here renames it to "vhost_user_socket". There was no obvious wrong about "connfd_ctx", but I think it's obviously better to rename it to "

[dpdk-dev] [PATCH v3 2/6] vhost: add vhost-user client mode

2016-06-07 Thread Yuanhan Liu
Add a new paramter (flags) to rte_vhost_driver_register(). DPDK vhost-user acts as client mode when RTE_VHOST_USER_CLIENT flag is set. The flags would also allow future extensions without breaking the API (again). The rest is straingfoward then: allocate a unix socket, and bind/listen for server,

[dpdk-dev] [PATCH v3 3/6] vhost: add reconnect ability

2016-06-07 Thread Yuanhan Liu
Allow reconnecting on failure by default when: - DPDK app starts first and QEMU (as the server) is not started yet. Without reconnecting, DPDK app would simply fail on vhost-user registration. - QEMU restarts, say due to OS reboot. Without reconnecting, you can't re-establish the connection

[dpdk-dev] [PATCH v3 4/6] vhost: workaround stale vring base

2016-06-07 Thread Yuanhan Liu
When DPDK app crashes (or quits, or gets killed), a restart of DPDK app would get stale vring base from QEMU. That would break the kernel virtio net completely, making it non-work any more, unless a driver reset is done. So, instead of getting the stale vring base from QEMU, Huawei suggested we co

[dpdk-dev] [PATCH v3 5/6] examples/vhost: add client option

2016-06-07 Thread Yuanhan Liu
Add --client option to let vhost-switch acts as the client. Signed-off-by: Yuanhan Liu --- v3: remove the --reconnect opt, as it's enabled by default. --- examples/vhost/main.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/examples/vhost/main.c b/examples/vho

[dpdk-dev] [PATCH v3 6/6] vhost: add pmd client option

2016-06-07 Thread Yuanhan Liu
Add client option to vhost pmd, to let it act as the vhost-user client. Signed-off-by: Yuanhan Liu --- v3: - remove the reconect option, as it's enabled by default now. - fixed non-initilized var reported by Rich --- drivers/net/vhost/rte_eth_vhost.c | 38 ++-

[dpdk-dev] [PATCH v2 0/8] support reset of VF link

2016-06-07 Thread Zhe Tao
From: "zhe.tao" If the PF link is down and up, VF link will not work accordingly. This patch set addes the support of VF link reset. So, when VF receices the messges of physical link down/up. APP can reset the VF link and let it recover. PS: This patch set is splitted from a previous patch set,

[dpdk-dev] [PATCH v2 1/8] lib/librte_ether: support device reset

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Add an API to reset the device. It's for VF device in this scenario, kernel PF + DPDK VF. When the PF port down/up, APP should call this API to reset VF port. Most likely, APP should call it in its management thread and guarantee the thread safe. Signed-off-by: Wenzhuo Lu Signe

[dpdk-dev] [PATCH v2 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Define lock mode for RX/TX queue. Because when resetting the device we want the resetting thread to get the lock of the RX/TX queue to make sure the RX/TX is stopped. Using next ABI macro for this ABI change as it has too much impact. 7 APIs and 1 global variable are impacted.

[dpdk-dev] [PATCH v2 3/8] ixgbe: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-b

[dpdk-dev] [PATCH v2 4/8] ixgbe: implement device reset on VF

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port,

[dpdk-dev] [PATCH v2 5/8] igb: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-b

[dpdk-dev] [PATCH v2 6/8] igb: implement device reset on VF

2016-06-07 Thread Zhe Tao
From: Wenzhuo Lu Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port,

[dpdk-dev] [PATCH v2 8/8] i40e: implement device reset on VF

2016-06-07 Thread Zhe Tao
From: "zhe.tao" Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, a

[dpdk-dev] [PATCH v2 7/8] i40e: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
From: "zhe.tao" Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by

[dpdk-dev] [PATCH v3 0/8] support reset of VF link

2016-06-07 Thread Zhe Tao
If the PF link is down and up, VF link will not work accordingly. This patch set addes the support of VF link reset. So, when VF receices the messges of physical link down/up. APP can reset the VF link and let it recover. PS: This patch set is splitted from a previous patch set, *automatic link re

[dpdk-dev] [PATCH v3 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-07 Thread Zhe Tao
Define lock mode for RX/TX queue. Because when resetting the device we want the resetting thread to get the lock of the RX/TX queue to make sure the RX/TX is stopped. Using next ABI macro for this ABI change as it has too much impact. 7 APIs and 1 global variable are impacted. Signed-off-by: Wenz

[dpdk-dev] [PATCH v3 1/8] lib/librte_ether: support device reset

2016-06-07 Thread Zhe Tao
Add an API to reset the device. It's for VF device in this scenario, kernel PF + DPDK VF. When the PF port down/up, APP should call this API to reset VF port. Most likely, APP should call it in its management thread and guarantee the thread safe. Signed-off-by: Wenzhuo Lu --- lib/librte_ether/rt

[dpdk-dev] [PATCH v3 3/8] ixgbe: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v3 4/8] ixgbe: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v3 5/8] igb: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v3 6/8] igb: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v3 7/8] i40e: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Zhe Tao --- dr

[dpdk-dev] [PATCH v3 8/8] i40e: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v4 01/39] bnxt: new driver for Broadcom NetXtreme-C devices

2016-06-07 Thread Thomas Monjalon
Hi Stephen, Reminder from http://dpdk.org/dev#send: git send-email -39 -v4 --cover-letter --annotate --in-reply-to Please do not forget --in-reply-to. Thanks

[dpdk-dev] [PATCH v3 0/8] support reset of VF link

2016-06-07 Thread Thomas Monjalon
Hi Zhe, Reminder from http://dpdk.org/dev#send: git send-email -8 -v3 --cover-letter --annotate --in-reply-to Please do not forget --in-reply-to. Thanks

[dpdk-dev] [PATCH v4 0/8] support reset of VF link

2016-06-07 Thread Zhe Tao
If the PF link is down and up, VF link will not work accordingly. This patch set addes the support of VF link reset. So, when VF receices the messges of physical link down/up. APP can reset the VF link and let it recover. PS: This patch set is splitted from a previous patch set, *automatic link re

[dpdk-dev] [PATCH v4 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-07 Thread Zhe Tao
Define lock mode for RX/TX queue. Because when resetting the device we want the resetting thread to get the lock of the RX/TX queue to make sure the RX/TX is stopped. Using next ABI macro for this ABI change as it has too much impact. 7 APIs and 1 global variable are impacted. Signed-off-by: Wenz

[dpdk-dev] [PATCH v4 1/8] lib/librte_ether: support device reset

2016-06-07 Thread Zhe Tao
Add an API to reset the device. It's for VF device in this scenario, kernel PF + DPDK VF. When the PF port down/up, APP should call this API to reset VF port. Most likely, APP should call it in its management thread and guarantee the thread safe. Signed-off-by: Wenzhuo Lu --- lib/librte_ether/rt

[dpdk-dev] [PATCH v4 3/8] ixgbe: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v4 4/8] ixgbe: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v4 5/8] igb: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v4 6/8] igb: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v4 7/8] i40e: RX/TX with lock on VF

2016-06-07 Thread Zhe Tao
Add RX/TX paths with lock for VF. It's used when the function of link reset on VF is needed. When the lock for RX/TX is added, the RX/TX can be stopped. Then we have a chance to reset the VF link. Please be aware there's performence drop if the lock path is chosen. Signed-off-by: Zhe Tao --- dr

[dpdk-dev] [PATCH v4 8/8] i40e: implement device reset on VF

2016-06-07 Thread Zhe Tao
Implement the device reset function. 1, Add the fake RX/TX functions. 2, The reset function tries to stop RX/TX by replacing the RX/TX functions with the fake ones and getting the locks to make sure the regular RX/TX finished. 3, After the RX/TX stopped, reset the VF port, and then release

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

2016-06-07 Thread Tetsuya Mukawa
On 2016/06/06 19:50, Tan, Jianfeng wrote: >> Please let me make sure how we can invoke many DPDK applications in >> hundreds containers. >> (Do we have a way to do? Or, will we have it in the future?) > > Just to add some option here, we cannot say no to that kind of use case. > To have many insta

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

2016-06-07 Thread Yuanhan Liu
On Tue, Jun 07, 2016 at 04:12:28PM +0900, Tetsuya Mukawa wrote: > On 2016/06/06 19:50, Tan, Jianfeng wrote: > >> Please let me make sure how we can invoke many DPDK applications in > >> hundreds containers. > >> (Do we have a way to do? Or, will we have it in the future?) > > > > Just to add some

[dpdk-dev] [PATCH v2] scripts: add script for generating customised build config

2016-06-07 Thread Thomas Monjalon
Hi Bruce 2016-04-29 16:48, Bruce Richardson: > This patch adds in the configure.py script file. It can be used to > generate custom build-time configurations for DPDK either manually on > the commandline or by calling it from other scripts. It takes as parameters > the base config template to use,

[dpdk-dev] [PATCH] scripts: check commits with checkpatch

2016-06-07 Thread Thomas Monjalon
2016-06-02 13:33, Bruce Richardson: > On Thu, Jun 02, 2016 at 11:13:15AM +0200, Thomas Monjalon wrote: > > The new option -n allows to give a number of commits to check > > from the git HEAD. > > If neither -n nor patch files are given, the commits after > > origin/master are checked. > > > > Yep

[dpdk-dev] [PATCH v2] doc: add pep8 as the python code style guidelines

2016-06-07 Thread Thomas Monjalon
2016-06-03 11:51, Bruce Richardson: > On Fri, May 27, 2016 at 03:57:15PM +0100, John McNamara wrote: > > Added PEP8 to the DPDK Coding Style guidelines to cover Python > > contributions to DPDK. > > > > Signed-off-by: John McNamara > Acked-by: Bruce Richardson Applied, thanks

[dpdk-dev] [PATCH v2] doc: fix typo in freebsd doc

2016-06-07 Thread Thomas Monjalon
> > Signed-off-by: Pablo de Lara > Acked-by: Bruce Richardson Applied, thanks

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Slawomir Mrozowicz
lrand48 should not be used for security related applications, as linear congruential algorithms are too easy to break. Used a compliant random number generator /dev/urandom. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Coverity ID 124558 Signed-off-by: Slawomir Mrozo

[dpdk-dev] [PATCH] fix build issues in the cross-compiling mode

2016-06-07 Thread Thomas Monjalon
2016-05-26 13:20, Bruce Richardson: > On Thu, May 26, 2016 at 04:50:14PM +0530, Jerin Jacob wrote: > > Removed comparison against $CC in Makefiles as > > in cross-compiling mode CC can be a different string > > instead of string "gcc" > > > > Suggested-by: Thomas Monjalon > > Signed-off-by: Jerin

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Thomas Monjalon
Hi Slawomir, "Calling risky function" -> it's obviously a NACK :) unless you mean "replace non-secure random".

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Sergio Gonzalez Monroy
On 07/06/2016 09:58, Slawomir Mrozowicz wrote: > lrand48 should not be used for security related applications, > as linear congruential algorithms are too easy to break. > Used a compliant random number generator /dev/urandom. > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample applica

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-06-07 Thread Thomas Monjalon
2016-05-24 12:56, Panu Matilainen: > On 05/20/2016 08:08 PM, Thomas Monjalon wrote: > > 2016-05-20 18:50, Christian Ehrhardt: > >> The individual libraries have various cross dependencies. > >> This is already refelcted in the DEPDIR dependency, but not yet in > >> proper DT_NEEDED flags in the .so

[dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile

2016-06-07 Thread Thomas Monjalon
2016-05-31 14:35, Ferruh Yigit: > On 5/30/2016 5:46 PM, Ferruh Yigit wrote: > > On 5/30/2016 5:21 PM, Olivier Matz wrote: > >> Hi Ferruh, > >> > >> On 05/30/2016 05:49 PM, Ferruh Yigit wrote: > >>> On 5/30/2016 12:56 PM, Olivier Matz wrote: > The $(comma) variable is not defined in this Makefi

[dpdk-dev] [PATCH] doc/tespmd: fix flow director examples

2016-06-07 Thread Mauricio Vasquez B
A previous patch modified the CLIs witout updating the examples. Fixes: 53b2bb9b7ea7 ("app/testpmd: new flow director commands") Signed-off-by: Mauricio Vasquez B --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

2016-06-07 Thread Shreyansh Jain
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Hunt > Sent: Friday, June 03, 2016 8:28 PM > To: dev at dpdk.org > Cc: olivier.matz at 6wind.com; viktorin at rehivetech.com; > jerin.jacob at caviumnetworks.com; David Hunt > Subject: [dpdk-dev] [PATCH v8

[dpdk-dev] [PATCH 1/3] kni: fix compile error for Linux 4.7

2016-06-07 Thread Thomas Monjalon
2016-05-30 12:22, Ferruh Yigit: > Fix compile error becuase of Linux API change, 'trans_start' field > removed from 'struct net_device'. > > Linux: 9b36627acecd ("net: remove dev->trans_start") > > Signed-off-by: Ferruh Yigit Series applied, thanks

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-06-07 Thread Panu Matilainen
On 06/07/2016 11:23 AM, Thomas Monjalon wrote: > 2016-05-24 12:56, Panu Matilainen: >> On 05/20/2016 08:08 PM, Thomas Monjalon wrote: >>> 2016-05-20 18:50, Christian Ehrhardt: The individual libraries have various cross dependencies. This is already refelcted in the DEPDIR dependency, but

[dpdk-dev] [PATCH v8 1/3] mempool: support external mempool operations

2016-06-07 Thread Hunt, David
Hi Shreyansh, On 6/6/2016 3:38 PM, Shreyansh Jain wrote: > Hi, > > (Apologies for overly-eager email sent on this thread earlier. Will be more > careful in future). > > This is more of a question/clarification than a comment. (And I have taken > only some snippets from original mail to keep it c

[dpdk-dev] [PATCH v2] scripts: add script for generating customised build config

2016-06-07 Thread Bruce Richardson
On Tue, Jun 07, 2016 at 09:36:37AM +0200, Thomas Monjalon wrote: > Hi Bruce > > 2016-04-29 16:48, Bruce Richardson: > > This patch adds in the configure.py script file. It can be used to > > generate custom build-time configurations for DPDK either manually on > > the commandline or by calling it

[dpdk-dev] [PATCH v2 1/5] testpmd: add retry option

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 1/5] testpmd: add retry option > > This patch

[dpdk-dev] [PATCH v2] aesni_mb: fix control issues in aesni pmd

2016-06-07 Thread Jain, Deepak K
Fix wrong indentation for return value Coverity ID: 126585 Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto") Signed-off-by: Deepak Kumar Jain --- v2: Corrected PMD in commit message drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[dpdk-dev] [PATCHv6 0/7] Implement pmd hardware support exports

2016-06-07 Thread Thomas Monjalon
Hi Neil, You are creating a new directory buildtools/ which depends on mk/ We also have some scripts used in the build process: scripts/auto-config-h.sh scripts/depdirs-rule.sh scripts/gen-build-mk.sh scripts/gen-config-h.sh scripts/relpath.sh I think we sho

[dpdk-dev] [PATCH v2] aesni_mb: fix null pointer dereferencing

2016-06-07 Thread Jain, Deepak K
Fix null pointer dereferencing by reporing if null and exiting the function. Coverity issue: 126584 Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") Signed-off-by: Deepak Kumar Jain --- v2: Corrected PMD name in commit message drivers/crypto/aesni_mb/rte_aesni_mb_pm

[dpdk-dev] [PATCH v2 2/5] testpmd: configurable tx_first burst number

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 2/5] testpmd: configurable tx_first burst numbe

[dpdk-dev] [PATCH v3 2/2] examples/ethtool: get reg width to allocate memory

2016-06-07 Thread Remy Horton
On 01/06/2016 08:56, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > Not every device uses 32-bit wide register. The app was allocating too > little space for 64-bit registers which resulted in memory corruption. > This commit resolves t

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

2016-06-07 Thread Remy Horton
On 01/06/2016 08:56, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes bef

[dpdk-dev] [PATCHv6 1/7] pmdinfogen: Add buildtools and pmdinfogen utility

2016-06-07 Thread Thomas Monjalon
2016-05-31 09:57, Neil Horman: > +++ b/buildtools/Makefile > @@ -0,0 +1,36 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > +# All rights reserved. I really think it is a strange copyright for a new empty file. > +#if __x86_64__ || __aarch64__

[dpdk-dev] [PATCH v4 2/8] lib/librte_ether: defind RX/TX lock mode

2016-06-07 Thread Ananyev, Konstantin
Hi Zhe & Wenzhuo, Please find my comments below. BTW, for clarification - is that patch for 16.11? I believe it's too late to introduce such significant change in 16.07. Thanks Konstantin > Define lock mode for RX/TX queue. Because when resetting > the device we want the resetting thread to get

[dpdk-dev] [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically

2016-06-07 Thread Panu Matilainen
Up to now dependencies between DPDK internal libraries have been untracked at shared library level, requiring applications to know about library internal dependencies and often consequently overlinking. Since the dependencies are already recorded for build ordering in the makefiles, we can use tha

[dpdk-dev] [PATCH] ivshmem: fix overlap detection code

2016-06-07 Thread Thomas Monjalon
2016-05-24 19:31, Ferruh Yigit: > On 5/24/2016 1:52 PM, Burakov, Anatoly wrote: > >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Anatoly Burakov > >> Sent: Tuesday, May 24, 2016 1:50 PM > >> To: dev at dpdk.org > >> Subject: [dpdk-dev] [PATCH] ivshmem: fix overlap detection code > >> >

[dpdk-dev] [PATCH v2 3/5] testpmd: show throughput in port stats

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 3/5] testpmd: show throughput in port stats >

[dpdk-dev] [PATCH v4 4/8] ixgbe: implement device reset on VF

2016-06-07 Thread Ananyev, Konstantin
> -Original Message- > From: Tao, Zhe > Sent: Tuesday, June 07, 2016 7:53 AM > To: dev at dpdk.org > Cc: Lu, Wenzhuo; Tao, Zhe; Ananyev, Konstantin; Richardson, Bruce; Chen, Jing > D; Liang, Cunming; Wu, Jingjing; Zhang, Helin > Subject: [PATCH v4 4/8] ixgbe: implement device reset on VF

[dpdk-dev] [PATCH] ivshmem: document a potential segmentation fault in rte_ring

2016-06-07 Thread Thomas Monjalon
2016-06-01 15:51, Anatoly Burakov: > Commit 4768c475 added a pointer to the memzone in rte_ring. However, > all memzones are residing in local mem_config, therefore accessing > the memzone pointer inside the guest in an IVSHMEM-shared rte_ring > will cause segmentation fault. This issue is unlikely

[dpdk-dev] [PATCH v2] ivshmem: add all memzones of mempool to metadata

2016-06-07 Thread Thomas Monjalon
2016-06-03 17:38, Ferruh Yigit: > Mempool consist of multiple memzones, at least from two of them. > ivshmem assumes mempool and elements are all in same memzone. > > Updating code to add all memzones when a mempool added. > > Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by >

[dpdk-dev] [PATCH v2 4/5] testpmd: handle all rxqs in rss setup

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 4/5] testpmd: handle all rxqs in rss setup > >

[dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Zhihong > Sent: Wednesday, June 01, 2016 4:28 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > thomas.monjalon at 6wind.com; Wang, Zhihong > Subject: [PATCH v2 5/5] testpmd: show topology at forwarding start

[dpdk-dev] [PATCH v2] aesni_mb: fix null pointer dereferencing

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jain, Deepak K > Sent: Tuesday, June 07, 2016 10:36 AM > To: dev at dpdk.org > Cc: Doherty, Declan; Jain, Deepak K > Subject: [dpdk-dev] [PATCH v2] aesni_mb: fix null pointer dereferencing > > Fix null pointer

[dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2016-06-07 Thread Wang, Zhihong
> -Original Message- > From: Ravi Kerur [mailto:rkerur at gmail.com] > Sent: Tuesday, June 7, 2016 2:32 AM > To: Wang, Zhihong ; Thomas Monjalon > > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions > > Zhilong, Thomas, > > If there is eno

[dpdk-dev] [PATCH v2] aesni_mb: fix control issues in aesni pmd

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jain, Deepak K > Sent: Tuesday, June 07, 2016 10:35 AM > To: dev at dpdk.org > Cc: Doherty, Declan; Jain, Deepak K > Subject: [dpdk-dev] [PATCH v2] aesni_mb: fix control issues in aesni pmd > > Fix wrong inden

[dpdk-dev] [PATCH 7/9] qede: add 100g mode support

2016-06-07 Thread Bruce Richardson
On Fri, May 06, 2016 at 09:30:19PM -0700, Rasesh Mody wrote: > From: Harish Patil > > Change details: > - Add device id to the PCI table > - Add polling for the slowpath events for CMT mode device > - Add prerequites to allow 100g mode typo: prerequisites > o Min number of queues nee

[dpdk-dev] [PATCH v2] app/testpmd: add packet data pointer prefetch in the forwarding loop

2016-06-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Tuesday, May 03, 2016 3:08 PM > To: dev at dpdk.org > Cc: Richardson, Bruce; thomas.monjalon at 6wind.com; De Lara Guarch, > Pablo; Jerin Jacob > Subject: [dpdk-dev] [PATCH v2] app/testpmd: add pac

[dpdk-dev] [PATCH] examples/ipsec-secgw: wrong spi read from packet

2016-06-07 Thread Slawomir Mrozowicz
In ipsec-secgw wrong SPI number is read from incoming ESP packet. The problem exist inside function inbound_sa_lookup(). The SPI is read from mbuf where the information is stored in big-endian. In low-endian environment the value is erroneous. Fixed by add conversion rte_be_to_cpu_32(). Fixes: d29

  1   2   >