[dpdk-dev] [PATCH] net/mlx5: fix memory leak when parsing device params

2017-01-22 Thread Shahaf Shuler
in case of an error argument list is not freed. Fixes: e72dd09b614e ("net/mlx5: add support for configuration through kvargs") CC: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx

[dpdk-dev] [PATCH 0/3] few virtio/vhost fixes

2017-01-22 Thread Yuanhan Liu
--- Yuanhan Liu (3): vhost: fix dead loop in enqueue path vhost: fix long stall of vhost-user negotiation net/virtio: fix crash when number of virtio devices > 1 drivers/net/virtio/virtio_ethdev.c | 2 +- lib/librte_vhost/vhost_user.c | 3 ++- lib/librte_vhost/virtio_net.c | 4 +++

[dpdk-dev] [PATCH 2/3] vhost: fix long stall of vhost-user negotiation

2017-01-22 Thread Yuanhan Liu
Setting up the mapping from GPA (guest physical address) to HPA (guest physical address) could be very time consuming when the guest memory is backened with small pages (4K). The bigger the guest memory, the longer it takes. This could lead a very long vhost-user negotiation. Since the mapping is

[dpdk-dev] [PATCH 1/3] vhost: fix dead loop in enqueue path

2017-01-22 Thread Yuanhan Liu
If a malicious guest forges a dead loop desc chain (let desc->next point to itself) and desc->len is zero, this could lead to a dead loop in copy_mbuf_to_desc(following is a simplified code to show this issue clearly): while (mbuf_is_not_totally_consumed) { if (desc_avail == 0) {

[dpdk-dev] [PATCH 3/3] net/virtio: fix crash when number of virtio devices > 1

2017-01-22 Thread Yuanhan Liu
The vtpci_ops assignment needs the 'hw->port_id' as an input parameter. That said, we should set 'hw->port_id' firstly, then do the vtpci_ops assignment, while the code does reversely. That would result to a crash when more than one virtio devices are used, because we keep assigning proper vtpci_op

Re: [dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe

2017-01-22 Thread Peng, Yuan
Tested-by: Peng Yuan - version: 17.02-rc1 - OS/Kernel: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - NIC: 82599 Test cases: 5 Passed: 5 Test steps: Test Case 1: MACsec packets send and receive 1. connect the two ixgbe po

[dpdk-dev] [PATCH v1] net/ixgbe: add more check in n-tuple filter

2017-01-22 Thread Wei Zhao
Add more check on the mask of src_addr, dst_addr and next_proto_id in n-tuple filter rule pattern parser.If do not add such check, it maybe cause error in pattern parser. Signed-off-by: zhao wei --- drivers/net/ixgbe/ixgbe_flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation

2017-01-22 Thread Rasesh Mody
This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_fw_funcs.c |2 +- drivers/net/qede/base/reg_addr.h|6 +++--- 2 files changed, 4 insertions(+), 4

Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation

2017-01-22 Thread Andrew Rybchenko
On 01/23/2017 08:02 AM, Rasesh Mody wrote: This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_init_fw_funcs.c |2 +- drivers/net/qede/base/reg_addr.h|

[dpdk-dev] [PATCH] examples: fix ip_reassembly not work with some NICs

2017-01-22 Thread Yong Liu
Some network device drivers like Fortville may not fill packet type by default. Changed the method for detecting packet type from mbuf packet type to ethernet header MAC type will make sure this example compatible with all NICs. Fixes: b84fb4cb88ff ("examples/ip_reassembly: overhaul") Signed-off-

[dpdk-dev] [PATCH v2] examples: fix ip_reassembly not work with some NICs

2017-01-22 Thread Yong Liu
Some network device drivers like Fortville may not fill packet type by default. Changed the method for detecting packet type from mbuf packet type to ethernet header MAC type will make sure this example compatible with all NICs. Fixes: b84fb4cb88ff ("examples/ip_reassembly: overhaul") v2: * fix c

Re: [dpdk-dev] [PATCH 1/3] vhost: fix dead loop in enqueue path

2017-01-22 Thread Maxime Coquelin
On 01/22/2017 09:46 AM, Yuanhan Liu wrote: If a malicious guest forges a dead loop desc chain (let desc->next point to itself) and desc->len is zero, this could lead to a dead loop in copy_mbuf_to_desc(following is a simplified code to show this issue clearly): while (mbuf_is_not_totally_c

Re: [dpdk-dev] [PATCH 3/3] net/virtio: fix crash when number of virtio devices > 1

2017-01-22 Thread Maxime Coquelin
On 01/22/2017 09:47 AM, Yuanhan Liu wrote: The vtpci_ops assignment needs the 'hw->port_id' as an input parameter. That said, we should set 'hw->port_id' firstly, then do the vtpci_ops assignment, while the code does reversely. That would result to a crash when more than one virtio devices are