On 20/01/2017 18:37, Thomas Monjalon wrote:
[..]
3 comments here:
- it is in the wrong section (EAL instead of Drivers)
- secondary processes can setup a vdev PMD
- before Yuanhan's patch, even PCI PMD were blanking primary process data
Since the code being changed is in rte_ether rather than
Ignore the error=IXGBE_ERR_SFP_NOT_PRESENT when SFP is not present.
If it is not ignored, testpmd will in the NIC initialization process.
Ixgbe kernel driver ignores this error and works well. So DPDK
does same thing.
Signed-off-by: Wei Dai
Signed-off-by: Helin Zhang
Tested-by: Yuan Peng
---
d
On 23/01/2017 11:56, Yuanhan Liu wrote:
[..]
http://dpdk.org/ml/archives/dev/2017-January/054422.html
Yes, it should fix that issue.
Well, few more thoughts: it may fix the crash issue Remy saw, but it
looks like more a workaround to me. Basically, if primary and secondary
shares a same por
On Monday 23 January 2017 11:02 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
add support for fsl-mc bus based dpaa2 pmd driver.
Signed-off-by: Hemant Agrawal
---
<...>
diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile
new file mode 100644
index 000
The commit aed0b12930b ("net/vhost: fix socket file deleted on stop")
moves rte_vhost_driver_register and rte_vhost_driver_unregister from
dev_start() and dev_stop() into driver's probe() and remove().
Apps, like testpmd, using vhost pmd in server mode, usually calls
dev_stop() and dev_close() as
Hi Keith,
On Mon, 23 Jan 2017 17:50:27 +, "Wiles, Keith"
wrote:
> > On Jan 23, 2017, at 10:18 AM, Olivier Matz
> > wrote:
> >
> > Hi Ferruh,
> >
> > On Sun, 22 Jan 2017 01:50:34 +, Ferruh Yigit
> > wrote:
> >> make config dependency resolving was always running serial,
> >> parallel
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai
> Sent: Tuesday, January 24, 2017 4:14 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Ananyev, Konstantin; Dai, Wei
> Subject: [dpdk-dev] [PATCH] net/ixgbe: correct error when SFP not present
>
> Ignore th
Tested-by: Yong Liu
- Tested Branch: master
- Tested Commit: 61207d014fc906302a184ae2f779b54ccfd0cd4c
- OS: Fedora20 4.9.0
- GCC: gcc version 4.8.3 20140911
- CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
- NIC: Intel Corporation Device Fortville [8086:1584]
- Default x86_64-native-linuxapp-gcc
When MACsec patch was merged. The helper function is_ixgbe_pmd() was
just raised and merged in another git tree. Now, both of them have
been merged in the same git tree. So do the same fix for MACsec.
Tiwei Bie (1):
net/ixgbe: fix API parameter checking
drivers/net/ixgbe/ixgbe_ethdev.c | 30 +
Add checks to rte_pmd_ixgbe_macsec_* APIs to ensure that the
port is an ixgbe port.
Fixes: b35d309710fe ("net/ixgbe: add MACsec offload")
Signed-off-by: Tiwei Bie
---
drivers/net/ixgbe/ixgbe_ethdev.c | 30 ++
drivers/net/ixgbe/rte_pmd_ixgbe.h | 4
2 files chan
On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
Adding NXP DPAA2 architecture specific mempool support
Each mempool instance is represented by a DPBP object
from the FSL-MC bus.
This patch also registers a dpaa2 type MEMPOOL OPS
Signed-off-b
On Tue, Jan 24, 2017 at 09:42:35AM +0100, Olivier MATZ wrote:
> Hi Keith,
>
> On Mon, 23 Jan 2017 17:50:27 +, "Wiles, Keith"
> wrote:
> > > On Jan 23, 2017, at 10:18 AM, Olivier Matz
> > > wrote:
> > >
> > > Hi Ferruh,
> > >
> > > On Sun, 22 Jan 2017 01:50:34 +, Ferruh Yigit
> > > wro
Thank you Steve.
I never did it before and I don't know if I have rights for that, but:
Acked-by: Igor Ryzhov
On Tue, Jan 24, 2017 at 5:21 AM, Steve Shin wrote:
> This patch fixes a bug in replaying MAC address to the hardware
> in rte_eth_dev_config_restore() routine. Added default MAC repla
> -Original Message-
> From: Wiles, Keith
> Sent: Tuesday, January 24, 2017 5:26 AM
> To: Ananyev, Konstantin
> Cc: Stephen Hemminger ; Hu, Jiayu
> ; dev@dpdk.org; Kinsella, Ray
> ; Gilmore, Walter E ;
> Venkatesan, Venky ;
> yuanhan@linux.intel.com
> Subject: Re: [dpdk-dev] [RFC]
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Monday, January 23, 2017 12:25 PM
> To: Doherty, Declan; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; sta...@dpdk.org; Doherty, Declan
> Subject: RE: [dpdk-dev] [PATCH] cryptodev: crypto PMD functions
> incorrectly inlined
>
> > -Origi
Following on from the previous RFC, this generalises the rte_ring
structure using C constructs rather than using macros. The idea
here is to have the size of the data objects passed in to all common
functions and then switching the code paths, where necessary, based on
those size parameters. For t
Provide a separate rte_ring implementation which just calls into the
common ring code. This allows us to generalise the common ring code
without affecting the API/ABI of the rte_ring. The common functions
are now all renamed to have an rte_common_ring prefix.
Signed-off-by: Bruce Richardson
---
Create rte_common_ring.[ch] files which will be modified to contain
generic ring implementation code to be shared across multiple ring
implementations for different sizes and types of data.
For now, these are exact copies of the original rte_ring files.
Signed-off-by: Bruce Richardson
---
lib/li
Change the common ring enqueue/dequeue functions to support enqueuing and
dequeuing 16B values. Add the element size as parameter to all common ring
functions that need it, and pass that as parameter from the rte_ring
functions.
Signed-off-by: Bruce Richardson
---
lib/librte_ring/rte_common_ring
using a placeholder struct type of the correct (16B) size, create an
event ring type and unit test it to verify the generalized ring
implementation works.
Signed-off-by: Bruce Richardson
---
app/test/Makefile| 1 +
app/test/test_event_ring.c | 83 +
lib/librte_ring/M
On 1/23/2017 11:05 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
Signed-off-by: Hemant Agrawal
---
<...>
--- a/drivers/net/dpaa2/Makefile
+++ b/drivers/net/dpaa2/Makefile
@@ -66,6 +66,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += lib/librte_eal
lib/librte_ether
DEPDI
On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
> On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
>> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
>>> Adding NXP DPAA2 architecture specific mempool support
>>> Each mempool instance is represented by a DPBP object
>>> from the FSL-MC bus.
>>>
>>>
2017-01-24 08:16, Remy Horton:
>
> On 20/01/2017 18:37, Thomas Monjalon wrote:
> [..]
> > 3 comments here:
> > - it is in the wrong section (EAL instead of Drivers)
> > - secondary processes can setup a vdev PMD
> > - before Yuanhan's patch, even PCI PMD were blanking primary process data
>
> Sin
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
---
drivers/net/szedata2/rte_eth_szedata2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/szedata2/rte_eth_szedata2.h
b/drivers/net/szedata2/rte_eth_szedata2.h
in
On 1/24/2017 10:45 AM, Hemant Agrawal wrote:
> On 1/23/2017 11:05 PM, Ferruh Yigit wrote:
>> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
>>> Signed-off-by: Hemant Agrawal
>>> ---
>> <...>
>>> --- a/drivers/net/dpaa2/Makefile
>>> +++ b/drivers/net/dpaa2/Makefile
>>> @@ -66,6 +66,6 @@ DEPDIRS-$(CON
On Wed, 18 Jan 2017 13:03:48 +0800, Yuanhan Liu
wrote:
> On Tue, Jan 17, 2017 at 12:18:25PM +0100, Olivier Matz wrote:
> > > I hope I could have time to dig this further, since, honestly, I
> > > don't quite like this patch: it makes things un-maintainable.
> >
> > Well, I'm not that proud of t
On Sun, Jan 22, 2017 at 01:50:34AM +, Ferruh Yigit wrote:
> make config dependency resolving was always running serial,
> parallelize it for better performance.
>
> $ time make T=x86_64-native-linuxapp-gcc config
> real0m12.633s
>
> $ time make -j8 T=x86_64-native-linuxapp-gcc config
> re
On 24/01/2017 10:49, Thomas Monjalon wrote:
[..]
Seems OK to me, assuming Yuanhan's patch is going in as-is.
Yuanhan's patch is already part of RC1.
Ah ok. I'll rebase a v2 then..
Hi Olivier,
2017-01-23, Olivier Matz:
Before this patch, the management of dependencies between directories
had several issues:
- the generation of .depdirs, done at configuration is slow: it can take
more than one minute on some slow targets (usually ~10s on a standard
PC).
Indeed, on a Qu
On 1/23/2017 5:58 PM, Ferruh Yigit wrote:
> On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
> <...>
>
>>
>> Hemant Agrawal (33):
>> mk/dpaa2: add the crc support to the machine type
>> drivers/common/dpaa2: adding qbman driver
>> bus/fslmc: introducing fsl-mc bus driver
>> bus/fslmc: introduc
On Tue, Jan 24, 2017 at 12:19:49PM +0100, Robin Jarry wrote:
> Hi Olivier,
>
> 2017-01-23, Olivier Matz:
> > Before this patch, the management of dependencies between directories
> > had several issues:
> >
> > - the generation of .depdirs, done at configuration is slow: it can take
> > more tha
On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote:
> Before this patch, the management of dependencies between directories
> had several issues:
>
> - the generation of .depdirs, done at configuration is slow: it can take
> more than one minute on some slow targets (usually ~10s on a
Some Tx offload flags are missed in Bitmask of all supported packet
Tx flags by i40e.
This patch fixes it.
Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation")
Signed-off-by: Jingjing Wu
---
drivers/net/i40e/i40e_rxtx.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dr
Some Tx offload flags are missed in Bitmask of all supported packet
Tx offload features flags.
This patch fixes it.
Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Signed-off-by: Jingjing Wu
---
lib/librte_mbuf/rte_mbuf.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_mbuf
Some Tx offload flags are missed in bitmask of all supported packet
Tx offload features flags.
This patch fixes it.
Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Signed-off-by: Jingjing Wu
---
lib/librte_mbuf/rte_mbuf.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_mbuf
Some Tx offload flags are missed in bitmask of all supported packet
Tx flags by i40e.
This patch fixes it.
Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation")
Signed-off-by: Jingjing Wu
---
drivers/net/i40e/i40e_rxtx.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dr
On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>
> Signed-off-by: Matej Vido
Unrelated from this patch, in maintainers file, you have your other mail
address: "Matej Vido ", do you want to update it?
> ---
> drivers/net/szeda
On Tue, Jan 24, 2017 at 05:10:15PM +0530, Jerin Jacob wrote:
> On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote:
> > Before this patch, the management of dependencies between directories
> > had several issues:
> >
> > - the generation of .depdirs, done at configuration is slow: it can
Hi Bruce,
2017-01-24, Bruce Richardson:
what are the differences in the patches like when doing a build rather
than just a config? If the build is minutes long because of slow IO,
is the extra 10 seconds really going to make that much of a difference?
I agree there is no significant difference
Hi,
On Sat, 21 Jan 2017 16:28:29 +, "Ananyev, Konstantin"
wrote:
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya
> > Matveychikov Sent: Saturday, January 21, 2017 3:08 PM
> > To: Yigit, Ferruh
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATC
On Tue, Jan 24, 2017 at 12:15:06PM +, Bruce Richardson wrote:
> On Tue, Jan 24, 2017 at 05:10:15PM +0530, Jerin Jacob wrote:
> > On Mon, Jan 23, 2017 at 06:19:13PM +0100, Olivier Matz wrote:
> > > Before this patch, the management of dependencies between directories
> > > had several issues:
>
On 1/23/2017 5:19 PM, Olivier Matz wrote:
> Before this patch, the management of dependencies between directories
> had several issues:
>
> - the generation of .depdirs, done at configuration is slow: it can take
> more than one minute on some slow targets (usually ~10s on a standard
> PC).
>
On 1/24/2017 10:09 AM, Igor Ryzhov wrote:
> Thank you Steve.
>
> I never did it before and I don't know if I have rights for that, but:
>
> Acked-by: Igor Ryzhov mailto:iryz...@nfware.com>>
Unrelated to the patch itself, but since it has been mentioned, let me
share what I know, I believe Thoma
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Tuesday, January 24, 2017 12:57 PM
> To: Richardson, Bruce
> Cc: Olivier Matz ; dev@dpdk.org; Yigit, Ferruh
> ; thomas.monja...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] mk: optimize directory depe
On 1/24/2017 7:34 AM, Jianfeng Tan wrote:
> We announced ABI changes to remove iomem and ioport mapping in
> igb_uio. But it has potential backward compatibility issue: cannot
> run old version DPDK on modified igb_uio.
>
> The purpose of this changes was to fix a bug: when DPDK app crashes,
> tho
Hello Ferruh,
Thanks for the explanation.
I tried to find something like that in "Contribution Guidelines" and found
that both "Acked-by" and "Reviewed-by" are just mentioned but not explained.
Meaning of these sentences can be different in different projects so it can
be good to explain it in DP
On 24.01.2017 12:58, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
Unrelated from this patch, in maintainers file, you have your other mail
address: "Matej Vido ", do you want to
On 1/24/2017 2:02 PM, Matej Vido wrote:
> On 24.01.2017 12:58, Ferruh Yigit wrote:
>> On 1/24/2017 10:49 AM, Matej Vido wrote:
>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
>>> Signed-off-by: Matej Vido
>> Unrelated from this patch, in maintainers file, you have
While ENA can handle checksum calculations in almost all cases,
it cannot do so when DF bit in IPv4 header is not set,
that is DF=0, and TSO is requested. For that situation pseudo
header must be prepared manually.
Signed-off-by: Jakub Palider
---
drivers/net/ena/ena_ethdev.c | 29 ++
Signed-off-by: Matej Vido
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f071138..21d0ef9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -311,7 +311,7 @@ F: drivers/net/enic/
F: doc/guides/nics/enic.rst
Combo szedata2
-M: Mat
On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce"
wrote:
>
> Ok. Point taken for the lower-core count parts.
>
> Thomas - can at least one of these patches be merged into 17.02,
> since it will definitely help us developers? [If Olivier's is too big
> a change at this point in the cycle, c
On 1/24/2017 4:19 PM, Ferruh Yigit wrote:
On 1/24/2017 9:12 AM, Shreyansh Jain wrote:
On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote:
On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
Adding NXP DPAA2 architecture specific mempool support
Each mempool instance is represented by a DPBP objec
> On Jan 24, 2017, at 3:33 AM, Ananyev, Konstantin
> wrote:
>
>
>
>> -Original Message-
>> From: Wiles, Keith
>> Sent: Tuesday, January 24, 2017 5:26 AM
>> To: Ananyev, Konstantin
>> Cc: Stephen Hemminger ; Hu, Jiayu
>> ; dev@dpdk.org; Kinsella, Ray
>> ; Gilmore, Walter E ;
>> Venk
> On Jan 24, 2017, at 7:50 AM, Olivier MATZ wrote:
>
> On Tue, 24 Jan 2017 13:26:41 +, "Richardson, Bruce"
> wrote:
>>
>> Ok. Point taken for the lower-core count parts.
>>
>> Thomas - can at least one of these patches be merged into 17.02,
>> since it will definitely help us developers?
Hello,
We are facing a peculiar problem with respect to symbol namespace in DPDK. I
think Ferruh and Thomas would have fair idea about it as they have already
reviewed and commented on it. I was hoping to get some input to take it
forward from here.
Brief Intro to DPAA2 Architecture:
This is bri
Secondary processes were blanket zeroing ethernet device memory,
resulting in NULL dereference crashes in multi-process setups.
Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device")
Signed-off-by: Remy Horton
---
doc/guides/rel_notes/release_17_02.rst | 5 +
lib/librte_ether/rte
On 1/24/2017 2:02 PM, Matej Vido wrote:
> On 24.01.2017 12:58, Ferruh Yigit wrote:
>> On 1/24/2017 10:49 AM, Matej Vido wrote:
>>> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
>>> Signed-off-by: Matej Vido
>> Unrelated from this patch, in maintainers file, you have
On Tue, Jan 24, 2017 at 12:04:09PM +0530, Akhil Goyal wrote:
> On 1/21/2017 1:01 AM, Neil Horman wrote:
> > On Fri, Jan 20, 2017 at 06:47:49PM +0530, Akhil Goyal wrote:
> > > On 1/20/2017 6:02 PM, Neil Horman wrote:
> > > > On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.go...@nxp.com wrote:
> > >
On 1/24/2017 2:44 AM, Beilei Xing wrote:
> VNI of VXLAN is parsed wrongly. The root cause is that
> array vni in item VXLAN also uses network byte ordering.
>
> Fixes: d416530e6358 ("net/i40e: parse tunnel filter")
>
> Signed-off-by: Beilei Xing
> ---
> drivers/net/i40e/i40e_flow.c | 22 +++
Document the function and make it public, since it is used at several
places in the drivers. The old one is marked as deprecated.
Signed-off-by: Olivier Matz
---
drivers/net/enic/enic_rxtx.c | 2 +-
drivers/net/fm10k/fm10k_rxtx.c| 6 +++---
drivers/net/fm10k/fm10k_rxtx
Rename __rte_mbuf_raw_free() as rte_mbuf_raw_free() and make
it public. The old function is kept for compat but is marked as
deprecated.
The next commit changes the behavior of rte_mbuf_raw_free() to
make it more consistent with rte_mbuf_raw_alloc().
Signed-off-by: Olivier Matz
---
drivers/net/
Based on discussion done in [1], this patchset reorganizes the mbuf.
The main changes are:
- reorder structure to increase vector performance on some non-ia
platforms.
- add a 64bits timestamp field in the 1st cache line
- m->next, m->nb_segs, and m->refcnt are always initialized for mbufs
in
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next
to NULL when the mbuf is stored inside the mempool (unused).
This is done in rte_pktmbuf_prefree_seg(), before freeing or
recycling a mbuf.
Before this patch, the value of m->refcnt was expected to be 0
while in pool.
The objectives are
It is now possible to reference a port identifier larger than 256
and have a mbuf chain larger than 256 segments.
Signed-off-by: Olivier Matz
---
app/test-pmd/csumonly.c | 4 ++--
lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 4 ++--
lib/li
Move this field in the second cache line, since no driver use it
in Rx path. The freed space will be used by a timestamp in next
commit.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h
The field itself is not fully described yet, but this commit reserves
the room in the mbuf.
Signed-off-by: Olivier Matz
---
lib/librte_mbuf/rte_mbuf.c | 2 ++
lib/librte_mbuf/rte_mbuf.h | 10 ++
2 files changed, 12 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf
Now that the m->next pointer and m->nb_segs is expected to be set (to
NULL and 1 respectively) after a mempool_get(), we can avoid to write them
in the Rx functions of drivers.
Only some drivers are patched, it's not an exhaustive patch. It gives
the idea to do the same in other drivers.
Signed-o
On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>
> Signed-off-by: Matej Vido
Reviewed-by: Ferruh Yigit
Cc: sta...@dpdk.org
Applied to dpdk-next-net/master, thanks.
On Wed, 18 Jan 2017 21:11:28 +0100, Olivier Matz
wrote:
> Hi guys,
>
> On Tue, 17 Jan 2017 21:55:16 +0530, Jerin Jacob
> > Oliver,
> >
> > Could you please suggest how to proceed further?
> >
>
> Sorry for the lack of response. I know people are waiting for
> me, but these days I have too ma
From: Jerin Jacob
To avoid multiple stores on fast path, Ethernet drivers
aggregate the writes to data_off, refcnt, nb_segs and port
to an uint64_t data and write the data in one shot
with uint64_t* at &mbuf->rearm_data address.
Some of the non-IA platforms have store operation overhead
if the s
On Thu, 13 Oct 2016 14:35:06 +, Oleg Kuporosov
wrote:
> The hard requirement of financial services industry is accurate
> timestamping aligned with the packet itself. This patch is to satisfy
> this requirement:
>
> - include uint64_t timestamp field into rte_mbuf with minimal impact
> to thr
Hi,
> -Original Message-
> From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com]
> Sent: Friday, January 20, 2017 2:05 PM
> To: dev@dpdk.org
> Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo;
> Mcnamara, John; nhor...@tuxdriver.com; Akhil Goyal
> Subject: [PATCH v3 0
On Tue, Jan 24, 2017 at 04:19:28PM +0100, Olivier Matz wrote:
> Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next
> to NULL when the mbuf is stored inside the mempool (unused).
> This is done in rte_pktmbuf_prefree_seg(), before freeing or
> recycling a mbuf.
>
> Before this patch, the
On 1/24/2017 5:38 AM, Rasesh Mody wrote:
> Check if promisc mode was set when setting allmulti mode and visa-versa.
> Introduced BNX2X_RX_MODE_ALLMULTI_PROMISC for the same. If check is
> absent the filter configuration gets over written.
>
> Fixes: 540a211084a7 ("bnx2x: driver core")
> Fixes: 5db
On 1/24/2017 8:51 AM, Lu, Wenzhuo wrote:
<...>
>>
>> Ignore the error=IXGBE_ERR_SFP_NOT_PRESENT when SFP is not present.
>> If it is not ignored, testpmd will in the NIC initialization process.
>> Ixgbe kernel driver ignores this error and works well. So DPDK does same
>> thing.
>>
>> Signed-off-b
On 24.01.2017 16:11, Ferruh Yigit wrote:
On 1/24/2017 2:02 PM, Matej Vido wrote:
On 24.01.2017 12:58, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
Unrelated from this patch, in
On 1/24/2017 9:00 AM, Tiwei Bie wrote:
> Add checks to rte_pmd_ixgbe_macsec_* APIs to ensure that the
> port is an ixgbe port.
>
> Fixes: b35d309710fe ("net/ixgbe: add MACsec offload")
>
> Signed-off-by: Tiwei Bie
Applied to dpdk-next-net/master, thanks.
> On Jan 24, 2017, at 4:56 PM, Olivier MATZ wrote:
>
> Hi,
>
> On Sat, 21 Jan 2017 16:28:29 +, "Ananyev, Konstantin"
> wrote:
>>> -Original Message-
>>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya
>>> Matveychikov Sent: Saturday, January 21, 2017 3:08 PM
>>> To: Yigit
On Tue, Jan 24, 2017 at 04:19:25PM +0100, Olivier Matz wrote:
> Based on discussion done in [1], this patchset reorganizes the mbuf.
>
Hi Olivier,
thanks for all the work on this. From a quick scan of the patches, and
the description below, it looks like a good set of changes. Comments
below to
On 24.01.2017 16:24, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
Signed-off-by: Matej Vido
Reviewed-by: Ferruh Yigit
Cc: sta...@dpdk.org
Applied to dpdk-next-net/master, thanks.
I'm not sure about the
This patch provides the initial implementation of the scheduler poll mode
driver using DPDK cryptodev framework.
Scheduler PMD is used to schedule and enqueue the crypto ops to the
hardware and/or software crypto devices attached to it (slaves). The
dequeue operation from the slave(s), and the pos
This patch adds the cryptodev scheduler PMD name and type identifier to
librte_cryptodev.
Signed-off-by: Fan Zhang
---
lib/librte_cryptodev/rte_cryptodev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/rte_cryptodev.h
index f2
Adds APIs and function prototypes for the scheduler PMD to perform extra
operations other than standard cryptodev APIs.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 162 +
.../scheduler/rte_cryptodev_scheduler_operations.h | 71 +
Adds a number of internal structures for the cryptodev scheduler PMD. The
structures include the scheduler context, slave, queue pair context,
and session.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd_private.h | 115 +++
1 file changed, 115 insertions(
Implements round-robin scheduling mode and register into cryptodev
scheduler ops structure. This mode enqueues a burst of operation
to one of its slaves, and iterates the next burst to the other
slave. Same procedure is done on dequeueing operations.
Signed-off-by: Fan Zhang
---
drivers/crypto/s
Adds the implementations of the APIs for scheduler cryptodev PMD.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 464 +
1 file changed, 464 insertions(+)
create mode 100644 drivers/crypto/scheduler/rte_cryptodev_scheduler.c
diff --git a/dr
Adds crypto scheduler's PMD's probe and remove function and the device's
enqueue and dequeue burst functions. A cryptodev scheduler PMD is
then registered in the end.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd.c | 361 +++
1 file changed, 361
Implements all standard operations required for cryptodev,
and register them to cryptodev operation function pointer table.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/scheduler_pmd_ops.c | 490 +++
1 file changed, 490 insertions(+)
create mode 100644 drivers/c
Adds Makefile for scheduler cryptodev PMD, and updates existing
Makefiles. Different than other cryptodev PMDs, scheduler PMD
is required to be built as shared libraries.
Signed-off-by: Fan Zhang
---
drivers/crypto/Makefile | 3 +-
drivers/crypto/scheduler/Makefile | 66 ++
Same as other cryptodev PMDs, it is necessary to carry out the unit
test for scheduler PMD. Currently the test is designed to attach 2
AESNI-MB cryptodev PMDs as slaves, sets the scheduling mode as round-
robin, and runs almost all AESNI-MB test items (except for sessionless
tests). In the end, the
Adds scheduler PMD enable and debug flags to config/common_base.
Signed-off-by: Fan Zhang
---
config/common_base | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/config/common_base b/config/common_base
index b9fb8e2..cd4a0f3 100644
--- a/config/common_base
+++ b/config/
Adds the description of the cryptodev scheduler PMD overview,
limitations, build, instructions, modes, etc.
Signed-off-by: Fan Zhang
---
doc/guides/cryptodevs/img/scheduler-overview.svg | 277 +++
doc/guides/cryptodevs/index.rst | 3 +-
doc/guides/cryptodev
On 1/24/2017 3:55 PM, Matej Vido wrote:
> On 24.01.2017 16:11, Ferruh Yigit wrote:
>> On 1/24/2017 2:02 PM, Matej Vido wrote:
>>> On 24.01.2017 12:58, Ferruh Yigit wrote:
On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
>>>
On Tue, 24 Jan 2017 15:59:08 +, Bruce Richardson
wrote:
> On Tue, Jan 24, 2017 at 04:19:25PM +0100, Olivier Matz wrote:
> > Based on discussion done in [1], this patchset reorganizes the mbuf.
> >
>
> Hi Olivier,
>
> thanks for all the work on this. From a quick scan of the patches, and
>
On Tue, 24 Jan 2017 19:57:13 +0400, Ilya Matveychikov
wrote:
> > On Jan 24, 2017, at 4:56 PM, Olivier MATZ
> > wrote:
> >
> > Hi,
> >
> > On Sat, 21 Jan 2017 16:28:29 +, "Ananyev, Konstantin"
> > wrote:
> >>> -Original Message-
> >>> From: dev [mailto:dev-boun...@dpdk.org] On Beh
The log "Debug logs available - lower performance" should
now only be displayed when dataplane debug logs are enabled.
The issue occurs only if the default log level (CONFIG_RTE_LOG_LEVEL) is
set to DEBUG in the configuration, which is not the case by default.
Fixes: 5d8f0baf69ea ("log: do not dr
This patch provides the initial implementation of the scheduler poll mode
driver using DPDK cryptodev framework.
Scheduler PMD is used to schedule and enqueue the crypto ops to the
hardware and/or software crypto devices attached to it (slaves). The
dequeue operation from the slave(s), and the pos
This patch adds the cryptodev scheduler PMD name and type identifier to
librte_cryptodev.
Signed-off-by: Fan Zhang
---
lib/librte_cryptodev/rte_cryptodev.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/rte_cryptodev.h
index f2
Adds a number of internal structures for the cryptodev scheduler PMD. The
structures include the scheduler context, slave, queue pair context,
and session.
Signed-off-by: Fan Zhang
Signed-off-by: Declan Doherty
---
drivers/crypto/scheduler/scheduler_pmd_private.h | 115 +++
Adds the implementations of the APIs for scheduler cryptodev PMD.
Signed-off-by: Fan Zhang
---
drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 464 +
1 file changed, 464 insertions(+)
create mode 100644 drivers/crypto/scheduler/rte_cryptodev_scheduler.c
diff --git a/dr
1 - 100 of 149 matches
Mail list logo
