Re: [dpdk-dev] [PATCH v2] net/mlx5: fix reusing Rx/Tx queues

2017-03-22 Thread Nélio Laranjeiro
On Tue, Mar 21, 2017 at 10:50:51AM -0700, Yongseok Koh wrote: > When configuring Rx/Tx queue, if queue already exists, it is reused. But if > the queue size is changed, it must be resized to not access/overwrite > invalid memory. > > Fixes: 2e22920b85d9 ("mlx5: support non-scattered Tx and Rx") >

[dpdk-dev] [PATCH v5] devtools: add tags and cscope index file generation support

2017-03-22 Thread Jerin Jacob
This script generates cscope, gtags, and tags index files based on EAL environment(architecture and OS(linux/bsd)). Selection of the architecture and OS environment is based on dpdk configuration target(T=).If EAL environment(T=) is not specified, the script generates tag files based on available

Re: [dpdk-dev] [PATCH v2 2/2] vhost: fix max queues

2017-03-22 Thread Yuanhan Liu
On Wed, Mar 01, 2017 at 06:41:59PM +0800, Yuanhan Liu wrote: > 0x8000 is the max virito-net queue pairs the virtio 1.0 spec claims to > support. While for vhost-user, it's a different story: the max vring > index could be passed by the vhost-user spec is 0xff, masked by the > VHOST_USER_VRING_IDX_M

[dpdk-dev] [PATCH] net/i40e: fix vlan filter issue

2017-03-22 Thread Wenzhuo Lu
VLAN filter is not working on i40e because driver need to disable the VLAN promiscuous mode and set the VLAN filter table. Fixes: 5f2b0e3f7656 (net/i40e: set VF VLAN filter from PF) Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 50 ++ dri

Re: [dpdk-dev] [PATCH v5 02/12] crypto/dpaa2_sec: add dpaa2 sec poll mode driver

2017-03-22 Thread Akhil Goyal
On 3/21/2017 8:37 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, March 03, 2017 7:49 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; Mcnamara, John; nhor...@tuxdriver.c

[dpdk-dev] [PATCH 1/2] net/tap: improve link_update

2017-03-22 Thread Pascal Mazon
Reflect device link status according to the state of the tap netdevice and the remote netdevice (if any). If both are UP and RUNNING, then the device link status is set to ETH_LINK_UP, otherwise ETH_LINK_DOWN. Signed-off-by: Pascal Mazon --- drivers/net/tap/rte_eth_tap.c | 32 +++

[dpdk-dev] [PATCH 2/2] net/tap: add link status notification

2017-03-22 Thread Pascal Mazon
As tap is a virtual device, there's no physical way a link can be cut. However, it has an associated kernel netdevice and possibly a remote netdevice too. These netdevices link status may change outside of the DPDK scope, through an external command such as: ip link set dev tapX down This commi

Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation

2017-03-22 Thread Maxime Coquelin
On 03/02/2017 07:16 AM, Yuanhan Liu wrote: We used to allocate queues based on the index from SET_VRING_CALL request: if corresponding queue hasn't been allocated, allocate it. Though it's pratically right (it's the first per-vring request we will get from QEMU for vhost-user negotiation), but

Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation

2017-03-22 Thread Yuanhan Liu
On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote: > > > On 03/02/2017 07:16 AM, Yuanhan Liu wrote: > >We used to allocate queues based on the index from SET_VRING_CALL > >request: if corresponding queue hasn't been allocated, allocate it. > > > >Though it's pratically right (it's t

Re: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support

2017-03-22 Thread Yuanhan Liu
On Sun, Mar 12, 2017 at 05:33:57PM +0100, Maxime Coquelin wrote: > This series adds support to new Virtio's MTU feature[1]. The MTU > value is set via QEMU parameters. Series applied to dpdk-next-virtio, with following minor changes: - don't use upper case for subject - squashed patch 5 to 4 - sq

Re: [dpdk-dev] [PATCH v3 0/9] virtio/vhost: Add MTU feature support

2017-03-22 Thread Maxime Coquelin
On 03/22/2017 09:58 AM, Yuanhan Liu wrote: On Sun, Mar 12, 2017 at 05:33:57PM +0100, Maxime Coquelin wrote: This series adds support to new Virtio's MTU feature[1]. The MTU value is set via QEMU parameters. Series applied to dpdk-next-virtio, with following minor changes: - don't use upper

Re: [dpdk-dev] [PATCH v3] doc: fix parameter of virtio_user for container

2017-03-22 Thread Yuanhan Liu
On Wed, Mar 08, 2017 at 02:45:53AM -0500, Yong Wang wrote: > Update the "Virtio_user for Container Networking" doc, add the > "--file-prefix" option to testpmd in host and container to avoid > hugepage config file conflict. > > Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container

[dpdk-dev] [PATCH 0/7] net/i40e: base code update

2017-03-22 Thread Jingjing Wu
Base code update with main changes: - new AQ commands for Pipeline Personalization Profile - new AQ commands for cloud filter - reduce wait time for adminq command completion Jingjing Wu (7): net/i40e/base: define bit for HW ATR evict control net/i40e/base: control register read/write on X7

[dpdk-dev] [PATCH 2/7] net/i40e/base: control register read/write on X722

2017-03-22 Thread Jingjing Wu
The X722 doesn't support the AQ command to read/write the control register so enable it to bypass the check and use the direct read/write method. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 1/7] net/i40e/base: define bit for HW ATR evict control

2017-03-22 Thread Jingjing Wu
On X722, we can control whether or not the hardware performs ATR eviction. Define the correct bit so we can twiddle it. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/ne

[dpdk-dev] [PATCH 3/7] net/i40e/base: fix potential out of bound array access

2017-03-22 Thread Jingjing Wu
This is fix for klocwork issue where dcbcfg->numapps could be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]). The fix makes sure the array is not accessed past size of array (i.e. I40E_DCBX_MAX_APPS). Fixes: 166dcafc ("i40e/base: add parsing for CEE DCBX TLVs") Cc: sta...@dpd

[dpdk-dev] [PATCH 5/7] net/i40e/base: reduce wait time for adminq command

2017-03-22 Thread Jingjing Wu
When sending an adminq command, we wait for the command to complete in a loop. This loop waits for an entire millisecond, when in practice the adminq command is processed often much faster. Change the loop to use i40e_usec_delay instead, and wait for 50 usecs each time instead. This appears to be

[dpdk-dev] [PATCH 4/7] net/i40e/base: new AQ commands for ppp

2017-03-22 Thread Jingjing Wu
Add admin queue functions for Pipeline Personalization Profile AQ commands defined in DCR 287: - Write Recipe Command buffer (Opcode: 0x0270) - Get Applied Profiles list (Opcode: 0x0271) Signed-off-by: Beilei Xing Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 34 ++

[dpdk-dev] [PATCH 6/7] net/i40e/base: add VF offload flags

2017-03-22 Thread Jingjing Wu
This patch adds: - ENCAP offload negotiation flag. Use the existing ENCAP_CSUM offload flag to negotiate GSO_UDP_TUNNEL_CSUM capability and create new ENCAP flag for negotiating offloads for encapsulated packets - RX_ENCAP_CSUM offload negotiation flag for VF to negotiate RX checksum cap

[dpdk-dev] [PATCH 7/7] net/i40e/base: new AQ commands for cloud filter

2017-03-22 Thread Jingjing Wu
Add new admin queue function and extended fields for cloud filter: - Add admin queue function for Replace filter command (Opcode: 0x025F) - Define big buffer for extended general fields in Add/Remove Cloud filters command Signed-off-by: Store Laura Signed-off-by: Iremonger Bernard Signed-of

[dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-22 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW offloading technique, which reassemble small packets into large ones, to reduce processing overheads for upper layer applications in receiving side, like networking stack. Therefore, we propose to add GRO support in DPDK. DPDK GRO is implemented as

[dpdk-dev] [PATCH 1/2] lib: add Generic Receive Offload support for TCP IPv4 packets

2017-03-22 Thread Jiayu Hu
Introduce two new functions to support TCP IPv4 GRO: - rte_gro_tcp4_tbl_create: create a lookup table for TCP IPv4 GRO. - rte_gro_tcp4_reassemble_burst: reassemble a bulk of TCP IPv4 packets at a time. rte_gro_tcp4_reassemble_burst works in burst-mode, which processes a bulk of packets at a time.

[dpdk-dev] [PATCH 2/2] app/testpmd: provide TCP IPv4 GRO function in iofwd mode

2017-03-22 Thread Jiayu Hu
This patch demonstrates the usage of the TCP IPv4 GRO library in testpmd. Currently, only the iofwd mode supports this feature. By default, TCP IPv4 GRO is turned off. The command, "gro tcp4 on", turns on this feature; the command, "gro tcp4 off", turns off it. Once the feature is turned on, all r

Re: [dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver

2017-03-22 Thread Jerin Jacob
On Tue, Mar 21, 2017 at 02:53:29PM +, Ferruh Yigit wrote: > On 3/21/2017 2:38 PM, Jerin Jacob wrote: > > On Tue, Mar 21, 2017 at 02:31:41PM +, Ferruh Yigit wrote: > >> On 3/20/2017 2:10 PM, Jerin Jacob wrote: > >>> - bgx_link_status mbox definition was changed in Linux > >>> commit 1cc70259

[dpdk-dev] [PATCH v6 1/4] net/tap: move private elements to external header

2017-03-22 Thread Pascal Mazon
In the next patch, access to struct pmd_internals will be necessary in tap_flow.c to store the flows. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/Makefile | 1 + drivers/net/tap/rte_eth_tap.c | 36 ++--- drivers/net/tap/rte_eth_tap.h | 75 +

[dpdk-dev] [PATCH v6 0/4] net/tap: support flow API

2017-03-22 Thread Pascal Mazon
This series add support for the flow API in tap PMD. It enables filtering specific packets incoming on the tap netdevice, to process only desired ones. Under the hood, it uses kernel TC (traffic control), which takes place very early in the stack, and supports most common pattern items and actions

[dpdk-dev] [PATCH v6 3/4] net/tap: add netlink back-end for flow API

2017-03-22 Thread Pascal Mazon
Each kernel netdevice may have queueing disciplines set for it, which determine how to handle the packet (mostly on egress). That's part of the TC (Traffic Control) mechanism. Through TC, it is possible to set filter rules that match specific packets, and act according to what is in the rule. This

[dpdk-dev] [PATCH v6 2/4] net/tap: add preliminary support for rte_flow

2017-03-22 Thread Pascal Mazon
The flow API provides the ability to classify packets received by a tap netdevice. This patch only implements skeleton functions for flow API support, no patterns are supported yet. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/M

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-03-22 Thread Zhang, Helin
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 20, 2017 5:14 PM > To: Zhang, Helin > Cc: Zhang, Qi Z; techbo...@dpdk.org; dev@dpdk.org; Wu, Jingjing; Yigit, > Ferruh; Liang, Cunming; Fastabend, John R > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH v6 4/4] net/tap: add basic flow API patterns and actions

2017-03-22 Thread Pascal Mazon
Supported flow rules are now mapped to TC rules on the tap netdevice. The netlink message used for creating the TC rule is stored in struct rte_flow. That way, by simply changing a metadata in it, we can require for the rule deletion without further parsing. Supported items: - eth: src and dst (wi

Re: [dpdk-dev] [PATCH v5 09/12] doc: add NXP dpaa2 sec in cryptodev

2017-03-22 Thread Akhil Goyal
On 3/8/2017 11:47 PM, Mcnamara, John wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, March 3, 2017 7:50 PM To: dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan ; De Lara Guarch, Pablo ; Mcnamara, John ; nhor...@tuxdriver.com; hemant.agra..

Re: [dpdk-dev] [PATCH] vfio: fix compile on older kernels

2017-03-22 Thread Burakov, Anatoly
> Super trivial comment inline: Thanks, I'll add those and do a v2. I'll wait a bit in case there are more comments. Thanks, Anatoly

[dpdk-dev] [PATCH] net/sfc: fix always fail Tx queue setup with VLAN offload

2017-03-22 Thread Andrew Rybchenko
Fixes: 1eb4d2e4b360 ("net/sfc: make VLAN insertion a datapath-dependent feature") Signed-off-by: Andrew Rybchenko --- It would be good if the fix is squashed into corresponding patch. drivers/net/sfc/sfc_tx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/sfc/sfc_tx.c b/drivers

[dpdk-dev] [RFC] specifications for asymmetric crypto algorithms

2017-03-22 Thread Umesh Kartha
This RFC contains specifications for asymmetric crypto algorithms. Asymmetric crypto algorithms are essential part of protocols such as SSL/TLS. As the current DPDK crypto library lacks support for asymmetric crypto algorithms, this RFC is an attempt to address it. Cavium offers PCI hardware acc

Re: [dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 9:39 AM, Jerin Jacob wrote: > On Tue, Mar 21, 2017 at 02:53:29PM +, Ferruh Yigit wrote: >> On 3/21/2017 2:38 PM, Jerin Jacob wrote: >>> On Tue, Mar 21, 2017 at 02:31:41PM +, Ferruh Yigit wrote: On 3/20/2017 2:10 PM, Jerin Jacob wrote: > - bgx_link_status mbox definitio

Re: [dpdk-dev] [PATCH] net/sfc: fix always fail Tx queue setup with VLAN offload

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 10:03 AM, Andrew Rybchenko wrote: > Fixes: 1eb4d2e4b360 ("net/sfc: make VLAN insertion a datapath-dependent > feature") > > Signed-off-by: Andrew Rybchenko > --- > It would be good if the fix is squashed into corresponding patch. Done, squashed into 1eb4d2e4b360

Re: [dpdk-dev] [dpdk-dev v2 1/3] examples: enable HW CRC strip by default

2017-03-22 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; sta...@dpdk.org > Subject: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default > > Since VF has no ability to disable/enable HW CRC strip

Re: [dpdk-dev] Is contiguous hugepages memory still required in latest DPDKs?

2017-03-22 Thread Ruslan Bilovol
On 03/21/2017 04:41 PM, Sergio Gonzalez Monroy wrote: The DPDK will still try to allocate contiguous hugepages. Since DPDK v16.07 the mempool library is able to create a mempool with multiple chunks of memory. You would still have the contig memory restriction for any other DPDK library or app.

Re: [dpdk-dev] [dpdk-dev v2 2/3] app: enable HW CRC strip by default

2017-03-22 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; sta...@dpdk.org > Subject: [dpdk-dev v2 2/3] app: enable HW CRC strip by default > > Since VF has no ability to disable/enable HW CRC strip for n

Re: [dpdk-dev] [dpdk-dev v2 2/3] app: enable HW CRC strip by default

2017-03-22 Thread Wu, Jingjing
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, March 22, 2017 8:22 PM > To: Guo, Jia ; Zhang, Helin > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev v2 2/3] app: enable HW CRC strip by default > > > > > -Original Message- > > From: Guo, Jia > > Sent:

Re: [dpdk-dev] [dpdk-dev v2 3/3] test: enable HW CRC strip by default

2017-03-22 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; sta...@dpdk.org > Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default > > Since VF has no ability to disable/enable HW CRC strip for

Re: [dpdk-dev] [dpdk-dev v2 1/3] examples: enable HW CRC strip by default

2017-03-22 Thread Wu, Jingjing
> -Original Message- > From: Wu, Jingjing > Sent: Wednesday, March 22, 2017 7:53 PM > To: Guo, Jia ; Zhang, Helin > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default > > > > > -Original Message- > > From: Guo, Jia > > S

Re: [dpdk-dev] [PATCH v2 2/3] doc: restructure QAT PMD guide

2017-03-22 Thread Mcnamara, John
Hi Fiona, Thanks for the improvements to the doc. Some minor comments below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, March 9, 2017 7:21 PM > To: dev@dpdk.org; De Lara Guarch, Pablo ; > Kusztal, ArkadiuszX > Cc: Jain, Deepa

Re: [dpdk-dev] [PATCH v2 3/3] doc: add support for Intel QAT device D15xx

2017-03-22 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, March 9, 2017 7:21 PM > To: dev@dpdk.org; De Lara Guarch, Pablo ; > Kusztal, ArkadiuszX > Cc: Jain, Deepak K ; Trahe, Fiona > ; Griffin, John > Subject: [dpdk-dev] [PATCH v2 3/3] do

Re: [dpdk-dev] [PATCH] vfio: add hotplug support

2017-03-22 Thread Burakov, Anatoly
Hi Alejandro, Just a general comment, I think there's now a rule to not split error messages onto multiple lines even if going above the 80 char limit, to make grepping easier. > Current device hotplug is just when using UIO. This patch adds > same functionality with VFIO. > > It has been valid

Re: [dpdk-dev] [PATCH v6 4/4] net/tap: add basic flow API patterns and actions

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 9:48 AM, Pascal Mazon wrote: > Supported flow rules are now mapped to TC rules on the tap netdevice. > The netlink message used for creating the TC rule is stored in struct > rte_flow. That way, by simply changing a metadata in it, we can require > for the rule deletion without further

Re: [dpdk-dev] [PATCH 2/2] net/tap: add link status notification

2017-03-22 Thread Wiles, Keith
> On Mar 22, 2017, at 3:40 AM, Pascal Mazon wrote: > > As tap is a virtual device, there's no physical way a link can be cut. > However, it has an associated kernel netdevice and possibly a remote > netdevice too. These netdevices link status may change outside of the > DPDK scope, through an ex

Re: [dpdk-dev] [PATCH 1/2] net/tap: improve link_update

2017-03-22 Thread Wiles, Keith
> On Mar 22, 2017, at 3:40 AM, Pascal Mazon wrote: > > Reflect device link status according to the state of the tap netdevice > and the remote netdevice (if any). If both are UP and RUNNING, then the > device link status is set to ETH_LINK_UP, otherwise ETH_LINK_DOWN. > > Signed-off-by: Pascal

[dpdk-dev] [PATCH 2/7] usertools: refactor the show status function

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha Identified and parameterized the common code in show_status() function as show_device_status().This will enable to avoid code duplication when additional devices added to the script. Signed-off-by: Guduri Prathyusha Signed-off-by: Jerin Jacob --- usertools/dpdk-devbind

[dpdk-dev] [PATCH 4/7] usertools: use optimized driver override scheme to bind

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha The current device bind model uses /sys/bus/pci/driver/new_id scheme to bind devices to the driver. This scheme has following operations to bind a device to the driver. 1) Write device ID and vendor ID to /sys/bus/pci/driver/new_id 2) Write PCI BDF number to /sys/bus/pci/d

[dpdk-dev] [PATCH 3/7] usertools: optimize lspci invocation

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha lspci invoked twice over all the pci devices in the system. The first pass is to extract Numeric IDs and second pass to get extended device details. As an optimization, Used lspci with -nn option in get_device_details() to obtain Numeric ID and extended device details in

[dpdk-dev] [PATCH 5/7] usertools: define DPDK PCI functional device

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha This patch creates the framework to define the DPDK PCI functional device by specifying the pci attributes like Vendor ID, Device ID, Sub Vendor ID, Sub Device ID and Class.This enables a flexible way to add DPDK function devices based on PCI attributes. Crypto devices ca

[dpdk-dev] [PATCH 7/7] usertools: add mempool PCI functional device

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha Signed-off-by: Guduri Prathyusha Signed-off-by: Jerin Jacob --- usertools/dpdk-devbind.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 87e1d30..bb4d536 100755 --- a/usertools/dpdk-devbind.py +++ b/

[dpdk-dev] [PATCH 6/7] usertools: add eventdev PCI functional device

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha Signed-off-by: Guduri Prathyusha Signed-off-by: Jerin Jacob --- usertools/dpdk-devbind.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 4ea0adf..87e1d30 100755 --- a/usertools/dpdk-devbind.py +++ b/

[dpdk-dev] [PATCH 1/7] usertools: refactor the get NIC and crypto details

2017-03-22 Thread Jerin Jacob
From: Guduri Prathyusha get_nic_details() and get_crypto_details() shares a lot of common code. Created a new unified get_device_details() function get the device details. Signed-off-by: Guduri Prathyusha Signed-off-by: Jerin Jacob --- usertools/dpdk-devbind.py | 115 +++--

Re: [dpdk-dev] [PATCH v6 0/4] net/tap: support flow API

2017-03-22 Thread Wiles, Keith
> On Mar 22, 2017, at 4:48 AM, Pascal Mazon wrote: > > This series add support for the flow API in tap PMD. > > It enables filtering specific packets incoming on the tap netdevice, to > process only desired ones. Under the hood, it uses kernel TC (traffic > control), which takes place very earl

Re: [dpdk-dev] [PATCH] notify VF when PF link status changes

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 12:23 AM, al...@att.com wrote: > From: Alex Zelezniak > Hi Alex, Thank you for the patch. Can you please send a new version of the patch with a sign-off? More details related sign-off: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body Overall DPDK contri

Re: [dpdk-dev] [PATCH 0/7] net/i40e: base code update

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 9:24 AM, Jingjing Wu wrote: > Base code update with main changes: > - new AQ commands for Pipeline Personalization Profile > - new AQ commands for cloud filter > - reduce wait time for adminq command completion > > Jingjing Wu (7): > net/i40e/base: define bit for HW ATR evict con

Re: [dpdk-dev] [PATCH v3 2/7] net/ark: HW API part 1 of 3

2017-03-22 Thread Ed Czeck
Hi Stephen, The issue is not ordering or synchronizing IO read and write operations, so memory barriers are not the solution and will not address the compile optimizations which the volatile qualifier avoids. The linux kernel guide states: "The volatile storage class was originally meant for memo

[dpdk-dev] [PATCH 0/7] dpdk-devbind.py refactor

2017-03-22 Thread Jerin Jacob
This patchset refactor the dpdk-devbind.py script to 1) Optimize the bind and status operation delay(It is noticeable when the system has fairly large number of PCIe device. For instance, OCTEONTX system has around 170 PCIe devices and it takes around 19 seconds to bind devices. With this patch it

Re: [dpdk-dev] [PATCH] net/i40e: fix vlan filter issue

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 8:39 AM, Wenzhuo Lu wrote: > VLAN filter is not working on i40e because driver need to > disable the VLAN promiscuous mode and set the VLAN filter > table. > > Fixes: 5f2b0e3f7656 (net/i40e: set VF VLAN filter from PF) > > Signed-off-by: Wenzhuo Lu Applied to dpdk-next-net/master,

[dpdk-dev] Why secondary process can't receive the interrupt from NIC

2017-03-22 Thread topperxin
HI list I'm using two processes in our program. The primary process to load config, init data The secondary process to receive and forward the package from NIC In order to reduce the cpu usage, we decide to use interrupt + poll mode. But I fi

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix reusing Rx/Tx queues

2017-03-22 Thread Ferruh Yigit
On 3/22/2017 7:50 AM, Nélio Laranjeiro wrote: > On Tue, Mar 21, 2017 at 10:50:51AM -0700, Yongseok Koh wrote: >> When configuring Rx/Tx queue, if queue already exists, it is reused. But if >> the queue size is changed, it must be resized to not access/overwrite >> invalid memory. >> >> Fixes: 2e229

[dpdk-dev] [PATCH v5] eventdev: add errno-style return values

2017-03-22 Thread Gage Eads
From: "Eads, Gage" This commit adds rte_errno return values to rte_event_enqueue_burst() and rte_event_dequeue_burst(). These return values allows user software to differentiate between an invalid argument (such as an invalid queue_id or sched_type in an enqueued event) and backpressure from the

Re: [dpdk-dev] [PATCH 17/39] event/octeontx: add SSO HW device operations

2017-03-22 Thread Eads, Gage
Hi Jerin, Please note the checkpatch issues for this patch: http://dpdk.org/ml/archives/test-report/2017-March/012577.html Thanks, Gage

[dpdk-dev] [PATCH] doc: reformat crypto drivers overview

2017-03-22 Thread Pablo de Lara
Follow the approach in the network devices overview, for the feature matrix, so it improves readibility and maintainability. Signed-off-by: Pablo de Lara --- .gitignore | 4 + doc/guides/conf.py | 47 +++-- doc/guides/cryptodevs/feat

[dpdk-dev] [PATCH] doc: add missing supported algos

2017-03-22 Thread Pablo de Lara
AESNI MB supports MD5 and AES XCBC, but it wasn't reflected in the driver documentation. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_mb.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb

Re: [dpdk-dev] [PATCH] doc: fix crypto overview matrix for missing QAT items

2017-03-22 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Thursday, March 09, 2017 8:20 PM > To: Trahe, Fiona; De Lara Guarch, Pablo; Jain, Deepak K > Cc: dev@dpdk.org; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH] doc: fix crypto overview matrix for missi

Re: [dpdk-dev] [PATCH v5 09/12] doc: add NXP dpaa2 sec in cryptodev

2017-03-22 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, March 22, 2017 9:50 AM > To: Mcnamara, John; dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > nhor...@tuxdriver.com; hemant.agra...@nxp.com > Subject:

Re: [dpdk-dev] [PATCH v5 09/12] doc: add NXP dpaa2 sec in cryptodev

2017-03-22 Thread Akhil Goyal
On 3/22/2017 10:00 PM, De Lara Guarch, Pablo wrote: Hi Akhil, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Wednesday, March 22, 2017 9:50 AM To: Mcnamara, John; dev@dpdk.org Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; nhor...@tuxdri

Re: [dpdk-dev] [PATCH v2 02/14] ring: create common structure for prod and cons metadata

2017-03-22 Thread Bruce Richardson
On Wed, Mar 15, 2017 at 03:01:49PM +0100, Thomas Monjalon wrote: > clang error below: > > 2017-03-07 11:32, Bruce Richardson: > > + union { > > + uint32_t sp_enqueue; /**< True, if single producer. */ > > + uint32_t sc_dequeue; /**< True, if single consumer. */ >

Re: [dpdk-dev] [PATCH] examples/dpdk-qat: remove app

2017-03-22 Thread Bruce Richardson
On Fri, Mar 03, 2017 at 04:10:49PM +, Pablo de Lara wrote: > Remove DPDK QAT sample app, in favour of the newer applications > that use the cryptodev library: ipsec-gw and l2fwd-crypto, > which has support for Intel QuickAssist devices. > > Signed-off-by: Pablo de Lara Acked-by: Bruce Richard

[dpdk-dev] [PATCH v2] mempool: remove non-EAL thread note from header

2017-03-22 Thread Gage Eads
Commit 30e6399892276 ("mempool: support non-EAL thread") added the capability for non-EAL threads to use the mempool library. This commit removes the note indicating that the mempool library cannot be used safely by non-EAL threads. Also, fix a typo. Signed-off-by: Gage Eads --- v2: Changed comm

Re: [dpdk-dev] [PATCH v5] eventdev: add errno-style return values

2017-03-22 Thread Jerin Jacob
On Wed, Mar 22, 2017 at 09:58:00AM -0500, Gage Eads wrote: > From: "Eads, Gage" > > This commit adds rte_errno return values to rte_event_enqueue_burst() and > rte_event_dequeue_burst(). > > These return values allows user software to differentiate between an > invalid argument (such as an inval

[dpdk-dev] [PATCH] net/ixgbe: notify VF when PF link status changes

2017-03-22 Thread alexz
From: Alex Zelezniak Signed-off-by: Alex Zelezniak --- drivers/net/ixgbe/ixgbe_ethdev.c | 33 + drivers/net/ixgbe/rte_pmd_ixgbe.h | 14 ++ 2 files changed, 47 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethd

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-03-22 Thread Ananyev, Konstantin
Hi Olivier, > > > > > > Another thing that doesn't look very convenient to me here - > > > > > > We can have 2 different values of timestamp (both normalized and > > > > > > not) > > > > > > and there is no clear way for the application to know which one is > > > > > > in > > > > > > use right

Re: [dpdk-dev] [PATCH v3 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-22 Thread Ferruh Yigit
On 3/21/2017 9:43 PM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > > > Signed-off-by: Ed Czeck > --- > MAINTAINERS | 8 + > config/common_base |

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2017-03-22 Thread Luca Boccassi
On Thu, 2017-03-16 at 19:13 +0100, Thomas Monjalon wrote: > 2017-01-12 15:43, Christian Ehrhardt: > > On Mon, Dec 19, 2016 at 4:15 PM, Thomas Monjalon > wind.com> > > wrote: > > > > > Thanks for sending your Debian/Ubuntu work. > > > > > > 2016-12-13 16:47, Luca Boccassi: > > > > From: Christian

[dpdk-dev] [PATCH v7 02/14] eal: do not panic when CPU isn't supported

2017-03-22 Thread Aaron Conole
This adds a new API to check for the eal cpu versions. It's now possible to gracefully exit the application, or for applications which support non-dpdk datapaths working in concert with DPDK datapaths, there no longer is the possibility of exiting for unsupported CPUs. Signed-off-by: Aaron Conole

[dpdk-dev] [PATCH v7 01/14] eal: do not panic on cpu detection

2017-03-22 Thread Aaron Conole
There may be no way to gracefully recover, but the application should be notified that a failure happened, rather than completely aborting. This allows the user to proceed with a "slow-path" type solution. After this change, the EAL CPU NUMA node resolution step can no longer emit an rte_panic.

[dpdk-dev] [PATCH v7 00/14] eal: Remove most causes of panic on init

2017-03-22 Thread Aaron Conole
In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application).

[dpdk-dev] [PATCH v7 03/14] eal: do not panic on hugepage info init

2017-03-22 Thread Aaron Conole
When attempting to scan hugepages, signal to the eal that an error has occurred, rather than performing a panic. If we fail to acquire hugepage information, simply signal an error to the application. This clears the run_once counter, allowing the user or application to take a corrective action an

[dpdk-dev] [PATCH v7 05/14] eal: do not panic on memzone initialization fails

2017-03-22 Thread Aaron Conole
When memzone initialization fails, report the error to the calling application rather than panic(). Without a good way of detaching / releasing hugepages, at this point the application will have to restart. Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/eal.c | 7 +-- lib/librt

[dpdk-dev] [PATCH v7 06/14] eal: set errno when exiting for already called

2017-03-22 Thread Aaron Conole
Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/eal.c | 7 +-- lib/librte_eal/linuxapp/eal/eal.c | 5 - 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index a71566c..ea76d40 100644 --- a/lib/libr

[dpdk-dev] [PATCH v7 04/14] eal: do not panic if parsing args returns error

2017-03-22 Thread Aaron Conole
It's possible that the application could take a corrective action here, and either prompt the user for different arguments, or at least perform a better logging. Exiting this early prevents any useful information gathering from the application layer. Signed-off-by: Aaron Conole --- lib/librte_e

[dpdk-dev] [PATCH v7 07/14] eal: do not panic on a number of conditions

2017-03-22 Thread Aaron Conole
When log initialization fails, it's generally because the fopencookie failed. While this is rare in practice, it could happen, and it is likely because of memory pressure. So, flag the error, and allow the user to retry. Memory init can only fail when access to hugepages (either as primary or se

[dpdk-dev] [PATCH v7 08/14] eal: do not panic on timer init failure

2017-03-22 Thread Aaron Conole
After code inspection, there is no way for eal_timer_init() to fail. It simply returns 0 in all cases. As such, this test could either go-away or stay here as 'future-proofing'. Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/eal.c | 7 +-- lib/librte_eal/linuxapp/eal/eal.c | 7

[dpdk-dev] [PATCH v7 11/14] eal: do not panic on PCI failures

2017-03-22 Thread Aaron Conole
Some devices may be inaccessible for a variety of reasons, or the PCI-bus may be unavailable causing the whole thing to fail. Still, better to continue attempts at probes. Since PCI isn't neccessarily required, it may be possible to simply log the error and continue on letting the user check the

[dpdk-dev] [PATCH v7 12/14] eal: do not panic if vdev init fails

2017-03-22 Thread Aaron Conole
Even if one vdev should fail, there's no need to prevent further processing. Log the error, and reflect it to the higher levels to decide. Seems like it's possible to continue. At least, the error is reflected properly in the logs. A user could then go and correct or investigate the situation.

[dpdk-dev] [PATCH v7 10/14] eal: do not error if plugins fail to init

2017-03-22 Thread Aaron Conole
Plugins are useful and important. However, it seems crazy to abort everything just because they don't initialize properly. Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/linuxapp/eal/eal.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v7 09/14] eal: do not panic on interrupt thread init

2017-03-22 Thread Aaron Conole
There could be some confusion as to why the call failed - this change will always reflect the value of the error in rte_error. When initializing the interrupt thread, there are a number of possible reasons for failure - some of which are correctable by the application. Do not panic() needlessly, a

[dpdk-dev] [PATCH v7 14/14] rte_eal_init: add info about various error codes

2017-03-22 Thread Aaron Conole
The rte_eal_init function will now pass failure reason hints to the application. To help app developers deciper this, add some brief information about what the codes are indicating. Signed-off-by: Aaron Conole Acked-by: Bruce Richardson --- lib/librte_eal/common/include/rte_eal.h | 27

[dpdk-dev] [PATCH v7 13/14] eal: do not panic when bus probe/scan fails

2017-03-22 Thread Aaron Conole
For now, exit the init. It's likely that even aborting the initialization is premature in this case, as it may be possible to proceed even if one bus or another is not available. Signed-off-by: Aaron Conole --- lib/librte_eal/bsdapp/eal/eal.c | 14 ++ lib/librte_eal/linuxapp/eal/e

Re: [dpdk-dev] [PATCH] doc: add maintainer role about replying questions

2017-03-22 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, March 14, 2017 10:00 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: add maintainer role about replying > questions > > The first line of the MAINTAINERS file are: > " >

[dpdk-dev] [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub

2017-03-22 Thread Ed Czeck
Enable Arkville on supported configurations Add overview documentation Minimum driver support for valid compile Arkville PMD is not supported on ARM or PowerPC at this time v4: * Address issues report from review * Add internal comments on driver arg * provide a bare-biones dev init to avoid compi

[dpdk-dev] [PATCH v4 3/7] net/ark: HW API part 2 of 3

2017-03-22 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources ddm and udm modules Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 3 +- drivers/net/ark/ark_ddm.c | 151 +++ drivers/net/ark/ark_ddm.h | 154 +++ drivers/net/ark/ark

[dpdk-dev] [PATCH v4 2/7] net/ark: HW API part 1 of 3

2017-03-22 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources mpu, pktdir, and rqp modules Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 4 + drivers/net/ark/ark_mpu.c| 181 +++ drivers/net/ark/ark_mpu.h| 143 +++

[dpdk-dev] [PATCH v4 4/7] net/ark: HW API part 3 of 3

2017-03-22 Thread Ed Czeck
Provide C-level interface for Arkville's internal HW resources pktgen and pktchk modules Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile | 3 +- drivers/net/ark/ark_pktchkr.c | 472 drivers/net/ark/ark_pktchkr.h | 114 ++ drivers/net/a

[dpdk-dev] [PATCH v4 5/7] net/ark: Packet TX support initial version

2017-03-22 Thread Ed Czeck
* Core TX packet moving functions * Flesh out ark_adapter struct to support TX code (not all fields used at this patch Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 1 + drivers/net/ark/ark_ethdev.c| 15 ++ drivers/net/ark/ark_ethdev.h| 2 +- drivers/net/ark/ark_ethd

[dpdk-dev] [PATCH v4 7/7] net/ark: Arkville PMD component integration

2017-03-22 Thread Ed Czeck
* Flesh out device configuration * Add links dev_ops * allow dynamic extension loading Signed-off-by: Shepard Siegel Signed-off-by: John Miller Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 712 ++- drivers/net/ark/ark_ext.h| 79 +

  1   2   >