[dpdk-dev] [PATCH v2 1/2] net/i40e: optimize vxlan parsing function

2017-06-01 Thread Beilei Xing
This commit optimizes vxlan parsing function. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 176 ++- 1 file changed, 55 insertions(+), 121 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index 8d1fcde.

[dpdk-dev] [PATCH v2 0/2] net/i40e: extend tunnel filter support

2017-06-01 Thread Beilei Xing
This patchset extends tunnel filter support with vxlan parsing function optimization and NVGRE parsing function. v2 changes: - Add vxlan parsing function optimization. - Optmize NVGRE parsing function. Beilei Xing (2): net/i40e: optimize vxlan parsing function net/i40e: add NVGRE parsing fu

[dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing function

2017-06-01 Thread Beilei Xing
This patch adds NVGRE parsing function to support NVGRE classification. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 271 ++- 1 file changed, 269 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i

Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code

2017-06-01 Thread Lu, Wenzhuo
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 1, 2017 3:46 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 1/3] net/ixgbe: remove reduandent code > > Remove reduandent code. > item->type != RTE_FLOW_ITEM_TYPE_END already cov

Re: [dpdk-dev] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset

2017-06-01 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, June 1, 2017 3:46 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z; sta...@dpdk.org > Subject: [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset > > When the last fdir flow be destroyed, the flag "mask_add

[dpdk-dev] [PATCH 0/2] Allow application set mempool handle

2017-06-01 Thread Santosh Shukla
Some platform can have two different NICs for example external PCI Intel 40G card and Integrated NIC like vNIC/octeontx/dpaa2. Both NICs like to use their preferred pool e.g. external PCI card/ vNIC's preferred pool would be the ring based pool and octeontx/dpaa2 preferred would be ext-mempools. R

[dpdk-dev] [PATCH 2/2] ether/ethdev: Allow pmd to advertise preferred pool capability

2017-06-01 Thread Santosh Shukla
Platform with two different NICs like external PCI NIC and Integrated NIC, May want to use their preferred pool handle. Right now there is no way that two different NICs on same board, Could use their choice of a pool. Both NICs forced to use same pool, Which is statically configured by setting CON

[dpdk-dev] [PATCH 1/2] eal: Introducing option to set mempool handle

2017-06-01 Thread Santosh Shukla
Platform can have external PCI cards like Intel 40G card and Integrated NIC like OcteoTX. Where both NIC has their preferred pool handle. Example: Intel 40G NIC preferred pool is ring_mp_mc and OcteonTX preferred pool handle would be ext-mempool's handle named 'octeontx-fpavf'. There is no way tha

Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer

2017-06-01 Thread Nélio Laranjeiro
On Wed, May 31, 2017 at 10:48:45AM -0700, Yongseok Koh wrote: > SW completion ring of Tx (txq->elts) stores individual mbufs even if a > multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when > cleaning up the completion ring. Otherwise, chained mbufs are redundantly > freed and f

Re: [dpdk-dev] [PATCH] lpm: fix build error on g++ with -O0 option

2017-06-01 Thread Bruce Richardson
On Thu, Jun 01, 2017 at 06:01:35AM +, Sangjin Han wrote: > When rte_lpm.h is used on x86, -O0 option (no optimization at all) > given to g++ (not gcc) causes a compile error like this: > > error: the last argument must be an 8-bit immediate >i24 = _mm_srli_si128(i24, sizeof(uint64_t)); >

Re: [dpdk-dev] Proposed schedule dates for DPDK 17.08, 17.11 and 18.02

2017-06-01 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 30, 2017 9:30 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: Re: [dpdk-dev] Proposed schedule dates for DPDK 17.08, 17.11 and > 18.02 > > No comment? > > So the next dates will be >

Re: [dpdk-dev] [PATCH] net/i40e: exclude internal packet's byte count

2017-06-01 Thread Xing, Beilei
Hi Qi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Thursday, June 1, 2017 6:53 AM > To: Wu, Jingjing ; Zhang, Helin > > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: exclude internal packet's byte c

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-06-01 Thread Ferruh Yigit
On 6/1/2017 6:56 AM, gowrishankar muthukrishnan wrote: > Hi Ferruh, > > On Wednesday 31 May 2017 09:51 PM, Ferruh Yigit wrote: > >> I have sampled below data in x86_64 for KNI on ixgbe pmd. iperf server >>> runs on >>> remote interface connecting PMD and iperf client runs on KNI interface, >>> so

Re: [dpdk-dev] [RFC] proposal of allowing personal/project repos on DPDK.org

2017-06-01 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Thursday, June 1, 2017 6:08 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; > yuanhan@linux.intel.com; Ananyev, Konstantin > ; tho...@monjalon.net > Subject: [dpdk-dev] [RFC] proposal of allo

[dpdk-dev] [PATCH v2] pci: implement find_device bus operation

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- v1 --> v2 * Use the newly defined rte_dev_match_t type lib/librte_eal/common/eal_common_pci.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index b749991..2ab1d

[dpdk-dev] [PATCH v3 1/9] bus: fix bus name registration

2017-06-01 Thread Gaetan Rivet
The default bus registration function should not result in buses registering with double quotes within their names. Fixes: a97725791eec ("bus: introduce bus abstraction") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 2 +- 1 file changed, 1 insert

[dpdk-dev] [PATCH v3 4/9] vdev: implement parse bus operation

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 62 ++--- 1 file changed, 33 insertions(+), 29 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 67c6fff..131e0c2 100644 --- a/li

[dpdk-dev] [PATCH v3 0/9] rte_bus parse API

2017-06-01 Thread Gaetan Rivet
Following the evolutions announced in [1], here is the first part of the rte_devargs rework planned for 17.08. The rationale has been partially explained in [2]. This first part covers the introduction of the necessary facilities in rte_bus to allow for generic device parsing. This API is implemen

[dpdk-dev] [PATCH v3 3/9] bus: introduce parsing functionality

2017-06-01 Thread Gaetan Rivet
This operation can be used either to validate that a device representation can be understood by a bus, as well as store the resulting specialized device representation in any format determined by the bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 21 ++

[dpdk-dev] [PATCH v3 2/9] bus: verify bus name on registration

2017-06-01 Thread Gaetan Rivet
Verify that a bus name is legal. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 13 + lib/librte_eal/common/eal_private.h| 16 2 files changed, 29 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/commo

[dpdk-dev] [PATCH v3 7/9] bus: add helper to find a bus from a device name

2017-06-01 Thread Gaetan Rivet
Find which bus should be able to parse this device name into an internal device representation. Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 15 +++ lib/librte_eal/common/include/rte_bus.h

[dpdk-dev] [PATCH v3 8/9] vdev: expose bus name

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 2 +- lib/librte_eal/common/include/rte_vdev.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 131e0c2..452f60f

[dpdk-dev] [PATCH v3 6/9] bus: add helper to find bus from a name

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal/common/eal_common_bus.c | 19 +++ lib/librte_eal/common/include/rte_bus.h | 14 ++ lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++

[dpdk-dev] [PATCH v3 9/9] devargs: parse bus info

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 17 - lib/librte_eal/common/eal_common_vdev.c | 6 -- lib/librte_eal/common/include/rte_devargs.h | 3 +++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/

[dpdk-dev] [PATCH v3 5/9] pci: implement parse bus operation

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 2ab1d65..c698cf8 100644 --- a/lib/librte_eal/common/eal_common_pci

[dpdk-dev] [PATCH v3 01/14] net/bonding: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/bonding/rte_eth_bond_args.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index e3bdad9..b6a924e 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/

[dpdk-dev] [PATCH v3 00/14] Generic devargs parsing

2017-06-01 Thread Gaetan Rivet
The second part of the work outlined in [1] and [2]. The first part is at [3]. In this patchset, the representation of devices in rte_devargs is made generic to remove some dependencies of the EAL on specific buses implementations. Following the device types being characterized by their bus, the D

[dpdk-dev] [PATCH v3 02/14] net/bnxt: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- drivers/net/bnxt/bnxt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 4418c7f..678a844 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -37,6 +37,7 @@ #include

[dpdk-dev] [PATCH v3 03/14] net/mlx5: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 67fd742..50c4fdd 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -54,6 +54,7 @@ #ifdef PEDANTIC #pragma GCC d

[dpdk-dev] [PATCH v3 04/14] net/e1000: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- drivers/net/e1000/e1000_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h index 8352d0a..6f25428 100644 --- a/drivers/net/e1000/e1000_ethdev.h +++ b/drivers/net/e100

[dpdk-dev] [PATCH v3 07/14] app/testpmd: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index a15598b..d61a4ad 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -34,6 +34,8 @@ #ifndef _TESTPMD_H_ #define _TES

[dpdk-dev] [PATCH v3 05/14] net/ixgbe: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- drivers/net/ixgbe/ixgbe_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h index b576a6f..fc39a3e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgb

[dpdk-dev] [PATCH v3 06/14] net/sfc: properly reference PCI header

2017-06-01 Thread Gaetan Rivet
From: Gaetan Rivet Signed-off-by: Gaetan Rivet --- drivers/net/sfc/sfc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h index fad0ce0..ec82e87 100644 --- a/drivers/net/sfc/sfc.h +++ b/drivers/net/sfc/sfc.h @@ -34,6 +34,7 @@ #include +#inc

[dpdk-dev] [PATCH v3 08/14] dev: device kernel module is a device attribute

2017-06-01 Thread Gaetan Rivet
It is used in generic device structures and must not be tied to a bus. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_dev.h | 12 lib/librte_eal/common/include/rte_pci.h | 9 - 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v3 10/14] devargs: parse bus policies

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 8bb72a2..a5014bf 100644 --- a/lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH v3 11/14] devargs: generic device representation

2017-06-01 Thread Gaetan Rivet
Remove the dependency of this subsystem upon bus specific device representation. Devargs only validates that a device declaration is correct and handled by a bus. The device interpretation is done afterward within the bus. Signed-off-by: Gaetan Rivet --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v3 09/14] bus: introduce bus scan policies

2017-06-01 Thread Gaetan Rivet
Scan policies describe the way a bus should scan the system to search for possible devices. Three flags are introduced: RTE_BUS_SCAN_UNDEFINED: Configuration is irrelevant for this bus RTE_BUS_SCAN_WHITELIST: Scanning should be limited to declared devices RTE_BUS_SCAN_BLACKLIST: Scanning sho

[dpdk-dev] [PATCH v2 0/3] eal: complete attach / detach support

2017-06-01 Thread Gaetan Rivet
Implements attach / detach for the PCI bus, and a streamlined attach for the virtual bus. This is necessary to remove the final dependencies of the EAL on the virtual and PCI buses, due to the rte_eal_dev_attach and rte_eal_dev_detach functions. This patchset depends on: pci: implement find_devi

[dpdk-dev] [PATCH v3 13/14] devargs: generic device types

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_options.c | 13 +++-- lib/librte_eal/common/eal_common_pci.c | 6 +++--- lib/librte_eal/common/eal_common_vdev.c | 1 - lib/librte_eal/common/include/rte_dev

[dpdk-dev] [PATCH v3 12/14] net/virtio: do not reference device type

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/virtio/virtio_pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c index b7b3d61..cd48fb5 100644 --- a/drivers/net/virtio/virtio_pci.c +++ b/drivers/net/virtio/v

[dpdk-dev] [PATCH v3 14/14] devargs: introduce cleaner parsing helper

2017-06-01 Thread Gaetan Rivet
Introduce a more versatile helper to parse device strings. This helper expects a generic rte_devargs structure as storage in order not to require any API changes in the future, should this structure be updated. The old equivalent function is thus being deprecated, as its API does not allow to acco

[dpdk-dev] [PATCH v2 1/3] pci: implement plug/unplug bus operation

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 2a52b9e..580ce86 100644 --- a/lib/librte_eal/common

[dpdk-dev] [PATCH v2 3/3] vdev: use standard bus registration function

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 082bbae..9ef064f 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v2 2/3] dev: remove vdev function dependency

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 49 +++--- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 968c66e..c286628 100644 --- a/lib/

[dpdk-dev] [PATCH 0/8] bus/pci: remove PCI bus from EAL

2017-06-01 Thread Gaetan Rivet
This patchset moves the PCI bus out of the EAL to the drivers/bus subdirectory. The last remaining dependencies have been worked out and the PCI bus is not ready to be moved. Several issues remain: * librte_cryptodev * librte_eventdev * librte_pdump * librte_kni All depend on the PCI bus bei

[dpdk-dev] [PATCH 3/8] pmdinfogen: move to drivers subdirectory

2017-06-01 Thread Gaetan Rivet
pmdinfogen has a dependency on the PCI bus. The latter must be built first. Signed-off-by: Gaetan Rivet --- GNUmakefile| 2 +- MAINTAINERS| 2 +- buildtools/Makefile| 36 buildtools/pmdinfogen/Makefile | 47 - bui

[dpdk-dev] [PATCH 2/8] ethdev: remove useless PCI dependency

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index b572143..a979001 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -47,7 +47,6 @@ #

[dpdk-dev] [PATCH 1/8] eal: expose rte_eal_using_phys_addrs

2017-06-01 Thread Gaetan Rivet
This function was previously private to the EAL layer. Other subsystems requires it, such as the PCI bus. This function is only exposed for linuxapps. In order not to force other components to include stdbool, which is incompatible with several NIC drivers, the return type has been changed from b

[dpdk-dev] [PATCH 4/8] cryptodev: disabled by default

2017-06-01 Thread Gaetan Rivet
The cryptodev library has a dependency on the PCI bus. Moving the PCI bus out of the EAL breaks its compilation. Signed-off-by: Gaetan Rivet --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 8907bea..3893622 1

[dpdk-dev] [PATCH 7/8] kni: disabled by default

2017-06-01 Thread Gaetan Rivet
The kni library has a dependency on the PCI bus. Moving the PCI bus out of the EAL breaks its compilation. Signed-off-by: Gaetan Rivet --- config/common_linuxapp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_linuxapp b/config/common_linuxapp index b3cf41b..cc8

[dpdk-dev] [PATCH 6/8] pdump: disabled by default

2017-06-01 Thread Gaetan Rivet
The pdump library has a dependency on the PCI bus. Moving the PCI bus out of the EAL breaks its compilation. Signed-off-by: Gaetan Rivet --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 9f94956..f035ea6 10064

[dpdk-dev] [PATCH 5/8] eventdev: disabled by default

2017-06-01 Thread Gaetan Rivet
The eventdev library has a dependency on the PCI bus. Moving the PCI bus out of the EAL breaks its compilation. Signed-off-by: Gaetan Rivet --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 3893622..9f94956 10

Re: [dpdk-dev] [PATCH] net/i40e: get information about ddp profile

2017-06-01 Thread Chilikin, Andrey
Hi Beilei > -Original Message- > From: Xing, Beilei > Sent: Thursday, June 1, 2017 3:21 AM > To: Chilikin, Andrey ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: RE: [PATCH] net/i40e: get information about ddp profile > > Hi Andrey, > > > -Original Message- > > From: Chilikin, Andr

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling

2017-06-01 Thread Ferruh Yigit
On 5/30/2017 8:48 AM, Adrien Mazarguil wrote: > On Mon, May 29, 2017 at 06:02:59PM -0700, Yongseok Koh wrote: >> A sanity check is required in priv_fdir_disable(). If resizing Rx queue >> fails, this can cause a crash by referencing a NULL pointer. >> >> Cc: sta...@dpdk.org >> Fixes: 76f5c99e6840 (

Re: [dpdk-dev] [PATCH 10/20] event/dpaa2: add initialization of event device

2017-06-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 31, 2017 20:40 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haa...@intel.com; bruce.richard...@intel.com; > gage.e...@intel.com; Shreyansh Jain > Subject: Re: [P

Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer

2017-06-01 Thread Ferruh Yigit
On 6/1/2017 9:08 AM, Nélio Laranjeiro wrote: > On Wed, May 31, 2017 at 10:48:45AM -0700, Yongseok Koh wrote: >> SW completion ring of Tx (txq->elts) stores individual mbufs even if a >> multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when >> cleaning up the completion ring. Othe

Re: [dpdk-dev] [PATCH 10/20] event/dpaa2: add initialization of event device

2017-06-01 Thread Jerin Jacob
-Original Message- > Date: Thu, 1 Jun 2017 10:25:02 + > From: Nipun Gupta > To: Jerin Jacob > CC: "dev@dpdk.org" , Hemant Agrawal , > "harry.van.haa...@intel.com" , > "bruce.richard...@intel.com" , > "gage.e...@intel.com" , Shreyansh Jain > > Subject: RE: [PATCH 10/20] event/dpaa

[dpdk-dev] [PATCH 0/3] Introduce net bus

2017-06-01 Thread Gaetan Rivet
This new bus takes as devices kernel netdevices. It offers an API for drivers to register a translation layer that would transform the netdev name to one their regular PMD would be able to probe. This is PoC. It currently only works for MLX4 and MLX5 PMDs as they were bifurcated and had very littl

[dpdk-dev] [PATCH 1/3] bus/net: introduce net bus

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- MAINTAINERS | 6 + config/common_linuxapp| 2 + drivers/bus/Makefile | 2 + drivers/bus/net/Makefile | 66 +++ drivers/bus/net/bsd/Makefile

[dpdk-dev] [PATCH 3/3] net/mlx5: net bus support

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx5/mlx5.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index fc99c0d..4e33703 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -58,6 +58,7 @@ #include #includ

[dpdk-dev] [PATCH 2/3] net/mlx4: net bus support

2017-06-01 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/net/mlx4/mlx4.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index ec4419a..705620a 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -62,6 +62,7 @@ #include #includ

Re: [dpdk-dev] [PATCH v3] net/e1000: fix checksum valid flags error

2017-06-01 Thread Ferruh Yigit
On 5/31/2017 4:35 AM, Lu, Wenzhuo wrote: > Hi, > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Wednesday, May 31, 2017 11:03 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo; Zhao1, Wei >> Subject: [PATCH v3] net/e1000: fix checksum valid flags error >> >> This problem is caused by a miss

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-01 Thread Gregory Etelson
On Wednesday, 31 May 2017 15:20:08 IDT Ferruh Yigit wrote: > On 5/31/2017 12:09 PM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and > > end. Copied this behaviour from vfio_pci k

Re: [dpdk-dev] [PATCH v3] ethdev: moved bypass functions to ixgbe pmd

2017-06-01 Thread Ferruh Yigit
On 6/1/2017 1:49 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Nicolau, Radu >> Sent: Wednesday, May 31, 2017 7:10 PM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh; Iremonger, Bernard; Dai, Wei; Lu, Wenzhuo; Nicolau, Radu >> Subject: [PATCH v3] ethdev: moved bypass functions to

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-01 Thread Shijith Thotton
On Wed, May 31, 2017 at 06:11:40PM +0100, Ferruh Yigit wrote: > On 5/31/2017 4:30 PM, Stephen Hemminger wrote: > > On Wed, 31 May 2017 13:20:08 +0100 > > Ferruh Yigit wrote: > > > >> On 5/31/2017 12:09 PM, Shijith Thotton wrote: > >>> Set UIO info device file operations open and release. Call pci

Re: [dpdk-dev] [PATCH 12/20] event/dpaa2: add configuration functions

2017-06-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 31, 2017 20:59 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haa...@intel.com; bruce.richard...@intel.com; > gage.e...@intel.com; Shreyansh Jain > Subject: Re: [P

Re: [dpdk-dev] [PATCH 19/20] event/dpaa2: handle timeout using interrupts in dequeue

2017-06-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 31, 2017 21:19 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haa...@intel.com; bruce.richard...@intel.com; > gage.e...@intel.com; Shreyansh Jain > Subject: Re: [P

Re: [dpdk-dev] [PATCH 1/4] eal: introduce the rte macro for always inline

2017-06-01 Thread Bruce Richardson
On Sat, May 13, 2017 at 02:57:25PM +0530, Jerin Jacob wrote: > Different drivers use internal macros like force_inline for compiler > always inline feature. > Standardizing it through __rte_always_inline macro. > > Signed-off-by: Jerin Jacob > --- > This patch has the following false positive che

Re: [dpdk-dev] [PATCH 1/4] eal: introduce the rte macro for always inline

2017-06-01 Thread Bruce Richardson
On Thu, Jun 01, 2017 at 12:57:30PM +0100, Bruce Richardson wrote: > On Sat, May 13, 2017 at 02:57:25PM +0530, Jerin Jacob wrote: > > Different drivers use internal macros like force_inline for compiler > > always inline feature. > > Standardizing it through __rte_always_inline macro. > > > > Signe

Re: [dpdk-dev] [PATCH 20/20] doc: add NXP DPAA2 EVENTDEV details

2017-06-01 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 31, 2017 21:28 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > harry.van.haa...@intel.com; bruce.richard...@intel.com; > gage.e...@intel.com; Shreyansh Jain > Subject: Re: [P

Re: [dpdk-dev] [PATCH 5/6] net/vmxnet3: receive queue lockup and memleak

2017-06-01 Thread Charles (Chas) Williams
While looking at another issue, I think one of the issues fixed in this commit has already been fixed in the last DPDK release by: commit 8fce14b789aecdb4345a62f6980e7b6e7f4ba245 Author: Stefan Puiu Date: Mon Dec 19 11:40:53 2016 +0200 net/vmxnet3: fix Rx d

Re: [dpdk-dev] [PATCH v3 22/26] net/bnxt: add code to determine the Rx status of VF

2017-06-01 Thread Ferruh Yigit
Hi Ajit, On 6/1/2017 4:02 AM, Ajit Khaparde wrote: > This patch adds code to determine the Rx status of a VF. > It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates > the VNIC count of the function to get the Rx status. > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde

Re: [dpdk-dev] Getting meta data from different pipelines in ip_pipeline application

2017-06-01 Thread Nidhia Varghese
Hi, Any comments on the below thread? Thanks, Nidhia On Tue, May 30, 2017 at 12:33 PM, Nidhia Varghese < nidhiavarghes...@gmail.com> wrote: > Hi, > > This is how I want my pipelines to work:- > Pipeline 4: > Has to get the source mac address and save it in 160th(160-167) meta data > filed in th

[dpdk-dev] [PATCH] net/thunderx: manage PCI device mapping for SQS VFs

2017-06-01 Thread Jerin Jacob
Since the commit e84ad157b7bc ("pci: unmap resources if probe fails"), EAL unmaps the PCI device if ethdev probe returns positive or negative value. nicvf thunderx PMD needs special treatment for Secondary queue set(SQS) PCIe VF devices, where, it expects to not unmap or free the memory without re

Re: [dpdk-dev] [PATCH v4 04/12] net/failsafe: add fail-safe PMD

2017-06-01 Thread Gaëtan Rivet
On Wed, May 31, 2017 at 08:13:53AM -0700, Stephen Hemminger wrote: > On Mon, 29 May 2017 15:42:16 +0200 > Gaetan Rivet wrote: > > +Fail-safe poll mode driver library > > +== > > + > > +The Fail-safe poll mode driver library (**librte_pmd_failsafe**) is a > > virtua

Re: [dpdk-dev] [PATCH v4 05/12] net/failsafe: add plug-in support

2017-06-01 Thread Gaëtan Rivet
On Wed, May 31, 2017 at 08:15:26AM -0700, Stephen Hemminger wrote: > On Mon, 29 May 2017 15:42:17 +0200 > Gaetan Rivet wrote: > > > Periodically check for the existence of a device. > > If a device has not been initialized and exists on the system, then it > > is probed and configured. > > > > T

Re: [dpdk-dev] [PATCH v4 06/12] net/failsafe: add flexible device definition

2017-06-01 Thread Gaëtan Rivet
On Wed, May 31, 2017 at 08:19:36AM -0700, Stephen Hemminger wrote: > On Mon, 29 May 2017 15:42:18 +0200 > Gaetan Rivet wrote: > > > > > +- **exec()** parameter > > + > > + This parameter allows the user to provide a command to the fail-safe PMD > > to > > + execute and define a sub-device. >

Re: [dpdk-dev] [PATCH v4 07/12] net/failsafe: support flow API

2017-06-01 Thread Gaëtan Rivet
On Wed, May 31, 2017 at 08:21:39AM -0700, Stephen Hemminger wrote: > On Mon, 29 May 2017 15:42:19 +0200 > Gaetan Rivet wrote: > > > Signed-off-by: Gaetan Rivet > > Acked-by: Olga Shern > > --- > > doc/guides/nics/features/failsafe.ini | 1 + > > drivers/net/failsafe/Makefile |

Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload capabilities

2017-06-01 Thread Gaëtan Rivet
On Wed, May 31, 2017 at 08:23:09AM -0700, Stephen Hemminger wrote: > On Mon, 29 May 2017 15:42:20 +0200 > Gaetan Rivet wrote: > > > Signed-off-by: Gaetan Rivet > > Acked-by: Olga Shern > > --- > > doc/guides/nics/features/failsafe.ini | 6 ++ > > drivers/net/failsafe/failsafe_ops.c | 131

Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern

2017-06-01 Thread Adrien Mazarguil
On Thu, Jun 01, 2017 at 01:44:56AM +, Zhang, Qi Z wrote: > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, May 31, 2017 3:52 PM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: Adrien Mazarguil ; Mcnamara, John > > > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload capabilities

2017-06-01 Thread Olga Shern
L;w > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaëtan Rivet > Sent: Thursday, June 01, 2017 5:38 PM > To: Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload > capabilities > > On Wed, May 31, 2017

Re: [dpdk-dev] [RFC 3/3] rte_flow: add new action for traffic metering and policing

2017-06-01 Thread Adrien Mazarguil
Hi Cristian, On Tue, May 30, 2017 at 05:44:13PM +0100, Cristian Dumitrescu wrote: > Signed-off-by: Cristian Dumitrescu > --- > lib/librte_ether/rte_flow.h | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h >

[dpdk-dev] [PATCH v2] event/sw: fix credit tracking in port dequeue

2017-06-01 Thread Harry van Haaren
Single-link optimized ports previously did not correctly track credits when dequeued, and re-enqueued as a FORWARD type. This could "inflate" the number of credits in the system. A unit test is added to reproduce and verify the issue, and the fixed implementation counts FORWARD packets, and reduce

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add support for Chelsio T6 family of adapters

2017-06-01 Thread Rahul Lakkireddy
On Tuesday, May 05/30/17, 2017 at 15:58:56 +0530, Thomas Monjalon wrote: >27/05/2017 05:46, Rahul Lakkireddy: >> This series of patches add support for Chelsio T6 family of adapters. > >It is almost one year since your last contribution, >welcome back Rahul :) > Can't believe it'

[dpdk-dev] [PATCH] doc: add generic compilation doc for all sample apps

2017-06-01 Thread Herakliusz Lipiec
Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Fixes: d0dff9ba445e ("doc: sample application us

Re: [dpdk-dev] [PATCH v3 22/26] net/bnxt: add code to determine the Rx status of VF

2017-06-01 Thread Ajit Khaparde
On Thu, Jun 1, 2017 at 7:28 AM, Ferruh Yigit wrote: > Hi Ajit, > > On 6/1/2017 4:02 AM, Ajit Khaparde wrote: > > This patch adds code to determine the Rx status of a VF. > > It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates > > the VNIC count of the function to get the Rx status. >

[dpdk-dev] [PATCH] eventdev: remove PCI dependency

2017-06-01 Thread Jerin Jacob
Remove the PCI dependency from generic data structures and moved the PCI specific code to rte_event_pmd_pci* CC: Gaetan Rivet Signed-off-by: Jerin Jacob --- drivers/event/skeleton/skeleton_eventdev.c | 30 +- lib/librte_eventdev/rte_eventdev.c | 37 +++--- lib/li

[dpdk-dev] [PATCH v4 00/26] bnxt patchset

2017-06-01 Thread Ajit Khaparde
This patchset amongst other changes adds support few more dev_ops, updates HWRM to version 1.7.7, switches to polling stats from the hardware, support for Jumbo MTU, LRO etc.. v1->v2: - Grouped in the end, it also has PMD specific APIs to control VF from PF. - I have updated the release notes

[dpdk-dev] [PATCH v4 03/26] net/bnxt: handle VF/PF initialization appropriately

2017-06-01 Thread Ajit Khaparde
1) For a VF, query the firmware to determine if a MAC address is already configured. If not configure a random default MAC address. 2) Do not initialize the default completion ring in bnxt_alloc_hwrm_rings(). 3) While registering for async events with the firmware, use func_vf_cfg for a VF and use

[dpdk-dev] [PATCH v4 04/26] net/bnxt: support lack of huge pages

2017-06-01 Thread Ajit Khaparde
rte_malloc_virt2phy() does not return a physical address if huge pages aren't in use. Further, rte_memzone->phys_addr is not a physical address. Use rte_mem_virt2phy() and manually lock pages to support lack of huge pages. Also check the return value of rte_mem_virt2phy() Verify the function re

[dpdk-dev] [PATCH v4 05/26] net/bnxt: add additonal HWRM debug info to error messages

2017-06-01 Thread Ajit Khaparde
Add the cmd_err and opaque_0 and opaque_1 fields to HWRM error messages. These allow better debugging of some classes of HWRM errors. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-

[dpdk-dev] [PATCH v4 02/26] net/bnxt: code reorg to properly allocate resources for PF/VF

2017-06-01 Thread Ajit Khaparde
1) Move the function reset to bnxt_dev_init. On the same lines, setup, enable and request interrupt to init path. Memory allocation is also being done in the init path. 2) After a function reset, configure the VFs. Distribute resources evenly between all functions (PF and VF) for now. In the futur

[dpdk-dev] [PATCH v4 06/26] net/bnxt: add tunneling support

2017-06-01 Thread Ajit Khaparde
Add support for udp_tunnel_port_add/del dev_ops to configure a UDP port for VXLAN and Geneve Tunnel protocols. The HWRM supports only one global destination port for a tunnel type, use a referene counter to keep track of its usage. Cache the configured VXLAN/Geneve ports and use that value to check

[dpdk-dev] [PATCH v4 07/26] net/bnxt: add support for xstats get/reset

2017-06-01 Thread Ajit Khaparde
This patch adds support to get and reset xstats dev_ops dev_ops added: xstats_get, xstats_get_name, xstats_reset HWRM commands added: hwrm_port_qstats, hwrm_port_clr_stats Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing

[dpdk-dev] [PATCH v4 08/26] net/bnxt: add support for VLAN filter and strip

2017-06-01 Thread Ajit Khaparde
This patch adds VLAN strip and offload callbacks. To add a VLAN filter: For each VNIC and each associated filter(s) if VLAN exists: if VLAN matches vlan_id VLAN filter already exists, just skip and continue else add a new MAC+VLAN

[dpdk-dev] [PATCH v4 09/26] net/bnxt: add support for set multicast addr list and MAC addr set

2017-06-01 Thread Ajit Khaparde
This patch adds support for set_mc_addr_list and mac_addr_set dev_ops Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Split the patch to document

[dpdk-dev] [PATCH v4 10/26] doc: update bnxt.ini to document Allmulticast mode

2017-06-01 Thread Ajit Khaparde
This patch update bnxt.int to document Allmulticast mode which is already supported by the PMD. Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini index 78a7

[dpdk-dev] [PATCH v4 13/26] net/bnxt: add support for LRO

2017-06-01 Thread Ajit Khaparde
This patch adds support to enable and disable LRO To support this feature, the driver creates an aggregrator ring. When the hardware starts doing LRO, it sends a tpa_start completion. When the driver receives a tpa_end completion, it indicates that the LRO chaining is complete. Signed-off-by: Stee

[dpdk-dev] [PATCH v4 11/26] net/bnxt: add support to get fw version

2017-06-01 Thread Ajit Khaparde
This patch adds support for fw_version_get dev_op Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Avoid using dev_ops in the patch subject line

[dpdk-dev] [PATCH v4 12/26] net/bnxt: add support to set MTU

2017-06-01 Thread Ajit Khaparde
This patch adds support to modify MTU using the set_mtu dev_op. To support frames > 2k, the PMD creates an aggregator ring. When a frame greater than 2k is received, it is fragmented and the resulting fragments are DMA'ed to the aggregator ring. Now the driver can support jumbo frames upto 9500 byt

  1   2   >