Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-07 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Sunday, May 28, 2017 11:45 PM > To: Zhang, Helin ; Wu, Jingjing > ; Richardson, > Bruce ; Ananyev, Konstantin > ; > Liu, Yuanhan ; gaetan.ri...@6wind.com > Cc: dev@dpdk.org; Guo, Jia > Subject: [dpdk-dev] [RFC] Add hot plug event in rte eal

Re: [dpdk-dev] [RFC] Add hot plug event in rte eal interrupt and inplement it in i40e driver.

2017-06-07 Thread Wu, Jingjing
> > > >Secondly, in order to read out the uevent that monitoring, we need to add > >uevent API in rte > layer. We plan add 2 , rte_uevent_connect and rte_get_uevent. All driver > interrupt handler > could use these API to enable the uevent monitoring, and read out the uevent > type , then > cor

[dpdk-dev] [PATCH v2 0/5] net/qede/base: update PMD to 2.5.0.1

2017-06-07 Thread Rasesh Mody
Hi, This patch set adds support for new firmware 8.20.0.0, includes code refactoring, adds an offload type and a bug fix. This patch set updates PMD version to 2.5.0.1. Please apply to dpdk-net-next for 17.08 release. v2 - split the previous series Thanks! Rasesh Harish Patil (4): net/qede:

[dpdk-dev] [PATCH v2 2/5] net/qede: refactoring multi-queue implementation

2017-06-07 Thread Rasesh Mody
From: Harish Patil This patch does the following refactoring and cleanup: - As part of multi-queue support a struct member called 'type' was added in struct qede_fastpath in order to identify whether a queue is RX or TX and take actions based on that. This was unnecessary in the first place since

[dpdk-dev] [PATCH v2 1/5] net/qede: refactoring vport handling code

2017-06-07 Thread Rasesh Mody
From: Harish Patil The refactoring is mainly for two reasons: - To remove an additional layer of internal callbacks for all vport related operations from the struct qed_eth_ops_pass. Instead, we can invoke base APIs directly. - Splitting a single large vport-update configuration into multiple and

[dpdk-dev] [PATCH v2 4/5] net/qede: fix VXLAN tunnel Tx offload flag setting

2017-06-07 Thread Rasesh Mody
From: Harish Patil This patch fixes missing PKT_TX_TUNNEL_VXLAN Tx offload flag from the supported Tx offloads and an incorrect tunnel TX BD bit setting. Fixes: 3d4bb4411683 ("net/qede: add fastpath support for VXLAN tunneling") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/

[dpdk-dev] [PATCH v2 3/5] net/qede/base: upgrade the FW to 8.20.0.0

2017-06-07 Thread Rasesh Mody
This patch adds changes to upgrade to 8.20.0.0 FW. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |3 + drivers/net/qede/base/common_hsi.h| 68 +-- drivers/net/qede/base/ecore.h |2 +- drivers/net/qede/base/ecore_dev.c

[dpdk-dev] [PATCH v2 1/2] mbuf: introduce new Tx offload flag for MPLS-in-UDP

2017-06-07 Thread Rasesh Mody
From: Harish Patil Some PMDs need to know the tunnel type in order to handle advance TX features. This patch adds a new TX offload flag for MPLS-in-UDP packets. Signed-off-by: Harish Patil --- lib/librte_mbuf/rte_mbuf.c |2 ++ lib/librte_mbuf/rte_mbuf.h | 17 ++--- 2 files ch

[dpdk-dev] [PATCH v2 2/2] net/qede: add Tx offloads for MPLS-in-UDP packets

2017-06-07 Thread Rasesh Mody
From: Harish Patil Add support for inner/outer L3/L4 TX csum offload for MPLS-in-UDP packets. The driver checks for PKT_TX_TUNNEL_MPLSINUDP in Tx ol_flags and updates TX BD elements with appropriate offsets/length of tunnel headers. The pseudo csum calculation is removed from qede_xmit_prep_pkts(

[dpdk-dev] [PATCH v2 5/5] net/qede: refactor Tx routine

2017-06-07 Thread Rasesh Mody
From: Harish Patil Refactor TX routine such that TX BD updates can all be grouped together. Based on the TX offloads requested the TX bitfields are calculated in a temporary variable and TX BDs are updated at the end. This will minimize the if checks also. This change is done to easily accommodat

Re: [dpdk-dev] [PATCH 6/7] mbuf: introduce new Tx offload flag for MPLS-in-UDP

2017-06-07 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, June 01, 2017 12:44 PM > > On 6/1/2017 7:59 PM, Patil, Harish wrote: > >> > > > >> On 5/28/2017 9:37 AM, Rasesh Mody wrote: > >>> From: Harish Patil > >>> > >>> Some PMDs need to know the tunnel type in order to handle advance

Re: [dpdk-dev] [PATCH 7/7] net/i40e: add support of restoration

2017-06-07 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Saturday, May 27, 2017 4:22 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Helin ; Wu, > Jingjing > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH 7/7] net/i40e: add support of restoration > > export dev_uninit and dev_init for rest

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add NVGRE parsing function

2017-06-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Wednesday, June 7, 2017 2:54 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 2/2] net/i40e: add NVGRE parsing function > > This patch adds NVGRE parsing function t

[dpdk-dev] [PATCH v2 2/4] net/i40e: support input set selection for FDIR

2017-06-07 Thread Beilei Xing
This patch supports input set selection for flow director filter. Signed-off-by: Beilei Xing Acked-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 8 +- drivers/net/i40e/i40e_ethdev.h | 8 + drivers/net/i40e/i40e_flow.c | 550 +++-- 3 files changed,

[dpdk-dev] [PATCH v2 1/4] net/i40e: support flexible payload parsing for FDIR

2017-06-07 Thread Beilei Xing
This patch adds flexible payload parsing support for flow director filter. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 23 +++ drivers/net/i40e/i40e_fdir.c | 19 --- drivers/net/i40e/i40e_flow.c | 311 - 3 files changed, 330 inser

[dpdk-dev] [PATCH v2 0/4] net/i40e: add advanced features for FDIR

2017-06-07 Thread Beilei Xing
1. Support flexible payload 2. Support reconfiguration of input set 3. Add new supported patterns 4. Add ether pattern support v2 changes: - Add ether pattern support for FDIR. - Split function of configuring flex pit and flex mask. Beilei Xing (4): net/i40e: support flexible payload parsing

[dpdk-dev] [PATCH v2 3/4] net/i40e: update supported patterns for FDIR

2017-06-07 Thread Beilei Xing
This patch updates supported patterns for flow director filters. Signed-off-by: Beilei Xing Acked-by: Wenzhuo Lu --- drivers/net/i40e/i40e_flow.c | 1370 +- 1 file changed, 1346 insertions(+), 24 deletions(-) diff --git a/drivers/net/i40e/i40e_flow.c b/d

[dpdk-dev] [PATCH v2 4/4] net/i40e: support ether pattern for FDIR

2017-06-07 Thread Beilei Xing
Previously, i40e PMD will select ethertype filter parser when adding ether pattern rules. In fact, FDIR also supports ether pattern. This patch adds ether pattern support for FDIR. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c | 35 ++- 1 file change

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Hunt, David
Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used for making examples, specifying the target directory of where the SDK was built. It's not good to re-purpose this for something el

[dpdk-dev] [PATCH v2 2/4] eventdev: restructure event PMD release function

2017-06-07 Thread Jerin Jacob
Remove rte_event_dev_close() from rte_event_pmd_release() function so that rte_event_pmd_release() can be used in stateless way. This will enable rte_event_pmd_vdev_uninit() function to avoid using eventdev_globals global variable and the need for exposing the a global variable to PMD. Signed-of

[dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library

2017-06-07 Thread Jerin Jacob
v3: Removed the bus dependency by spliting lib/librte_eventdev/rte_eventdev_pmd_pci.h and lib/librte_eventdev/rte_eventdev_pmd_vdev.h Jerin Jacob (4): eventdev: remove PCI dependency from generic data structures eventdev: restructure event PMD release function eventdev: make PCI probe and r

[dpdk-dev] [PATCH v2 3/4] eventdev: make PCI probe and remove functions optional

2017-06-07 Thread Jerin Jacob
Made libeventdev library independent of PCI bus by moving pci pmd specific function to rte_eventdev_pmd_pci.h header file. Eventdev PCI PMD can include that for generic eventdev PCI probe and remove function enablement. Signed-off-by: Jerin Jacob --- drivers/event/octeontx/ssovf_worker.h |

[dpdk-dev] [PATCH v2 1/4] eventdev: remove PCI dependency from generic data structures

2017-06-07 Thread Jerin Jacob
Remove the PCI dependency from generic data structures and moved the PCI specific code to rte_event_pmd_pci* CC: Gaetan Rivet Signed-off-by: Jerin Jacob --- drivers/event/skeleton/skeleton_eventdev.c | 30 +- lib/librte_eventdev/rte_eventdev.c | 38 +++--- lib/li

[dpdk-dev] [PATCH v2 4/4] eventdev: make vdev init and uninit functions optional

2017-06-07 Thread Jerin Jacob
Made libeventdev library independent of VDEV bus by moving vdev pmd specific function to rte_eventdev_pmd_vdev.h header file. Eventdev VDEV PMD can include that for generic eventdev VDEV init and uninit function enablement. Signed-off-by: Jerin Jacob --- drivers/event/octeontx/ssovf_evdev.h

[dpdk-dev] Fwd: [dpdk-techboard] Meeting Minutes for May 18th, 2017 (2nd draft)

2017-06-07 Thread Jan Blunck
Here are the meeting notes for the DPDK technical board meeting held on May 18th, 2017. Member attendees: - Bruce Richardson - Hemant Agrawal - Jan Blunck - Jerin Jacob - Konstantin Ananyev - Olivier Matz - Stephen Hemminger - Thomas Monjalon - Yuanhan Liu 1. Service Core Library RFC ---

Re: [dpdk-dev] [PATCH] app/testpmd: print statistics periodically

2017-06-07 Thread Wu, Jingjing
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, May 29, 2017 5:39 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: print statistics periodically > > Add parameter to print port statistics periodically > (disabled by defa

Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending

2017-06-07 Thread Wu, Jingjing
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, May 29, 2017 5:37 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: add parameter to start forwarding sending > > Add parameter to start forwarding sending first > a burst o

Re: [dpdk-dev] [PATCH] dpdk: remove typos using codespell utility

2017-06-07 Thread Mcnamara, John
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, June 7, 2017 6:05 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Mcnamara, John ; Jerin > Jacob > Subject: [dpdk-dev] [PATCH] dpdk: remove typos using codespell utility > > Fixing typos

Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd: enable GRO feature

2017-06-07 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > Sent: Monday, April 24, 2017 4:10 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Wiles, Keith > ; yuanhan@linux.intel.com; Hu, Jiayu > > Subject: [dpdk-dev] [PATCH v3 3/3] app/testpmd: enable G

Re: [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library

2017-06-07 Thread Gaëtan Rivet
Hi Jerin, On Wed, Jun 07, 2017 at 02:13:29PM +0530, Jerin Jacob wrote: > v3: > Removed the bus dependency by spliting > lib/librte_eventdev/rte_eventdev_pmd_pci.h > and lib/librte_eventdev/rte_eventdev_pmd_vdev.h > It works with the PCI bus now, good job. Small problem however: to compile drive

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Shreyansh Jain
Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used for making examples, specifying the target directory of wher

Re: [dpdk-dev] [PATCH v2 0/5] net/qede/base: update PMD to 2.5.0.1

2017-06-07 Thread Ferruh Yigit
On 6/7/2017 8:42 AM, Rasesh Mody wrote: > Hi, > > This patch set adds support for new firmware 8.20.0.0, includes code > refactoring, adds an offload type and a bug fix. This patch set updates > PMD version to 2.5.0.1. > > Please apply to dpdk-net-next for 17.08 release. > > v2 - split the previ

Re: [dpdk-dev] technical board meeting, 2017-06-07

2017-06-07 Thread Ilya Maximets
Hello everyone, I wanted to remind the question about 'external dependencies' and off-by-default policy for the new features. Currently, I'm interested in adding libnuma as a general dependency for LIBRTE_EAL as suggested by Sergio Gonzalez Monroy in discussion of balanced allocation of hugepages

Re: [dpdk-dev] [RFCv2] service core concept

2017-06-07 Thread Ananyev, Konstantin
> -Original Message- > From: Van Haaren, Harry > Sent: Tuesday, June 6, 2017 4:41 PM > To: Ananyev, Konstantin ; Richardson, Bruce > > Cc: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Wiles, Keith > > Subject: RE: [dpdk-dev] [RFCv2] service core concept > > > From: Ananyev, Konsta

Re: [dpdk-dev] [PATCH v3] net/mlx4: support user space rxq interrupt event

2017-06-07 Thread Ferruh Yigit
On 6/6/2017 3:48 PM, Moti Haimovsky wrote: > Implement rxq interrupt callbacks > > Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] event/sw: fix mapped qid count with parallel queue

2017-06-07 Thread Harry van Haaren
This commit fixes the counting of mapped queues to a port, when the type of queue type is PARALLEL. Not incrementing the count here could lead to an underflow of the count when unlinking at a later date. Fixes: 371a688fc159 ("event/sw: support linking queues to ports") Reported-by: Jesse Bruni S

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Hunt, David
Hi Shreyansh, On 7/6/2017 10:36 AM, Shreyansh Jain wrote: Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE_TARGET originally had a different meaning. It was used

Re: [dpdk-dev] [RFCv2] service core concept

2017-06-07 Thread Van Haaren, Harry
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, June 7, 2017 10:51 AM > To: Van Haaren, Harry ; Richardson, Bruce > > Cc: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Wiles, Keith > Subject: RE: [dpdk-dev] [RFCv2] service core concept > > > > > -Original Me

[dpdk-dev] [PATCH] ethdev: fix ethdev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If ethdev has already started it should return -EBUSY instead of 0 when rte_eth_dev_start is called. Fixes: af75078fece3 ("first public release") Signed-off-by: Pavan Nikhilesh --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[dpdk-dev] [PATCH] eventdev: fix eventdev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If eventdev has already started it should return -EBUSY instead of 0 when rte_event_dev_start is called. Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/rte_eventdev.c | 2 +- lib/librte_e

[dpdk-dev] [PATCH] cryptodev: fix cryptodev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If cryptodev has already started it should return -EBUSY instead of 0 when rte_cryptodev_start is called. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Signed-off-by: Pavan Nikhilesh --- lib/librte_cryptodev/rte_cryptodev.

[dpdk-dev] [PATCH v4 0/3] Support TCP/IPv4 GRO in DPDK

2017-06-07 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. Therefore, we propose to support GRO in DPDK. To enable more flexibility to applications, DPDK GRO is implement

[dpdk-dev] [PATCH v4 1/3] lib: add Generic Receive Offload API framework

2017-06-07 Thread Jiayu Hu
Generic Receive Offload (GRO) is a widely used SW-based offloading technique to reduce per-packet processing overhead. It gains performance by reassembling small packets into large ones. This patchset is to support GRO in DPDK. To support GRO, this patch implements a GRO API framework. To enable m

[dpdk-dev] [PATCH v4 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-07 Thread Jiayu Hu
In this patch, we introduce six APIs to support TCP/IPv4 GRO. - gro_tcp_tbl_create: create a TCP reassembly table, which is used to merge packets. - gro_tcp_tbl_destroy: free memory space of a TCP reassembly table. - gro_tcp_tbl_flush: flush packets in the TCP reassembly table. - gro_tcp_tbl_ti

[dpdk-dev] [PATCH v4 3/3] app/testpmd: enable TCP/IPv4 GRO

2017-06-07 Thread Jiayu Hu
This patch demonstrates the usage of GRO library in testpmd. By default, GRO is turned off. Command, "gro on (port_id)", turns on GRO for the given port; command, "gro off (port_id)", turns off GRO for the given port. Currently, GRO only supports to process TCP/IPv4 packets and works in IO forward

[dpdk-dev] [RFC PATCH] replace DPDK config and build system

2017-06-07 Thread Bruce Richardson
Hi all, following on from the pressing need to add support in DPDK for detecting and managing external dependencies, I undertook to see what options we had. However, unrelated to this, over time, I have become increasingly frustrated by the complexity of the DPDK configuration and build system. As

[dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja

2017-06-07 Thread Bruce Richardson
to use, need to have meson >= 0.4 and ninja-build packages installed. Then do the following in main DPDK directory: meson build cd build ninja sudo ninja install This will compile up some DPDK libs, the FVL PMD and testpmd and install them in /usr/local/. [On Fedora you will need to add /usr/loc

Re: [dpdk-dev] technical board meeting, 2017-06-07

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 12:45:43PM +0300, Ilya Maximets wrote: > Hello everyone, > > I wanted to remind the question about 'external dependencies' > and off-by-default policy for the new features. > > Currently, I'm interested in adding libnuma as a general dependency > for LIBRTE_EAL as suggeste

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Shreyansh Jain
On Wednesday 07 June 2017 03:58 PM, Hunt, David wrote: Hi Shreyansh, On 7/6/2017 10:36 AM, Shreyansh Jain wrote: Hello David, On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: Shreyansh, I found an issue (or two) with this part of the patch, and have a proposed solution. 1. RTE

Re: [dpdk-dev] [PATCH v2 1/2] mk: allow use of environment var for make config

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 05:16:18PM +0530, Shreyansh Jain wrote: > On Wednesday 07 June 2017 03:58 PM, Hunt, David wrote: > > Hi Shreyansh, > > > > > > On 7/6/2017 10:36 AM, Shreyansh Jain wrote: > > > Hello David, > > > > > > On Wednesday 07 June 2017 02:09 PM, Hunt, David wrote: > > > > Shreyan

Re: [dpdk-dev] [RFC PATCH] replace DPDK config and build system

2017-06-07 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, June 7, 2017 11:48 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [RFC PATCH] replace DPDK config and build system > > Hi all, > > following on from the pressing need to add support in

Re: [dpdk-dev] [RFCv2] service core concept

2017-06-07 Thread Ananyev, Konstantin
> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, June 7, 2017 11:30 AM > To: Ananyev, Konstantin ; Richardson, Bruce > > Cc: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Wiles, Keith > > Subject: RE: [dpdk-dev] [RFCv2] service core concept > > > > > -Origina

Re: [dpdk-dev] [PATCH] app/testpmd: print statistics periodically

2017-06-07 Thread De Lara Guarch, Pablo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 07, 2017 10:12 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [PATCH] app/testpmd: print statistics periodically > > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent

Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending

2017-06-07 Thread De Lara Guarch, Pablo
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 07, 2017 10:18 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [PATCH] app/testpmd: add parameter to start forwarding > sending > > > > > -Original Message- > > From: De Lara Guarch,

Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 01:20:45PM +, De Lara Guarch, Pablo wrote: > Hi Jingjing, > > > -Original Message- > > From: Wu, Jingjing > > Sent: Wednesday, June 07, 2017 10:18 AM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] app/testpmd: add parameter to start

Re: [dpdk-dev] [RFC PATCH] replace DPDK config and build system

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 02:23:04PM +0100, Luca Boccassi wrote: > On Wed, 2017-06-07 at 13:08 +, Van Haaren, Harry wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > > Richardson > > > Sent: Wednesday, June 7, 2017 11:48 AM > > > To: dev@dpdk.org > > > Cc: Richardson, Br

Re: [dpdk-dev] [PATCH v2 01/11] bus: add bus iterator to find a particular bus

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 12:36:53PM +0530, Shreyansh Jain wrote: > Hello Gaetan, > > On Wednesday 31 May 2017 06:47 PM, Gaetan Rivet wrote: > >From: Jan Blunck > > > >Signed-off-by: Jan Blunck > >Signed-off-by: Gaetan Rivet > >--- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > >

[dpdk-dev] [PATCH 0/5] create event rings type

2017-06-07 Thread Bruce Richardson
Following on from the refactoring of the rte_rings code done in the 17.05 release, it becomes relatively easy to create new ring implementations for data types other than "void *". The first candidate for this is the rte_event type, which being 16B in size, is small enough to be passed around direc

[dpdk-dev] [PATCH 2/5] test/test: add unit tests for exact size rings

2017-06-07 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- test/test/test_ring.c | 71 +++ 1 file changed, 71 insertions(+) diff --git a/test/test/test_ring.c b/test/test/test_ring.c index 858ebc1..7f3b00d 100644 --- a/test/test/test_ring.c +++ b/test/test/test_ring.c @@

[dpdk-dev] [PATCH 1/5] ring: allow rings with non power-of-2 sizes

2017-06-07 Thread Bruce Richardson
The rte_rings traditionally have only supported having ring sizes as powers of 2, with the actual usable space being the size - 1. In some cases, for example, with an eventdev where we want to precisely control queue depths for latency, we need to allow ring sizes which are not powers of two so we

[dpdk-dev] [PATCH 3/5] eventdev: add ring structure for events

2017-06-07 Thread Bruce Richardson
Add in a new rte_event_ring structure type and functions to allow events to be passed core to core. This is needed because the standard rte_ring type only works on pointers, while for events, we want to copy the entire, 16B events themselves - not just pointers to them. The code makes extensive use

[dpdk-dev] [PATCH 4/5] test/test: add auto-tests for event ring functions

2017-06-07 Thread Bruce Richardson
Add some basic tests for the event ring functions. Not everything needs testing as there is so much code re-use from the rte_ring code. Signed-off-by: Bruce Richardson --- test/test/Makefile | 1 + test/test/test_event_ring.c | 275 2 files

[dpdk-dev] [PATCH 5/5] event/sw: change worker rings to standard event rings

2017-06-07 Thread Bruce Richardson
Now that we have a standard event ring implementation for passing events core-to-core, use that in place of the custom event rings in the software eventdev. Signed-off-by: Bruce Richardson --- drivers/event/sw/event_ring.h | 185 -- drivers/event/sw/sw_evd

Re: [dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros

2017-06-07 Thread Thomas Monjalon
Hi, some comments below: 18/05/2017 12:14, Adrien Mazarguil: > These macros resolve to constant expressions that allow developers to > perform endianness conversion on static/const objects, even outside of > function scope as they do not translate to function calls. > > This is most useful for st

Re: [dpdk-dev] PCI domain size

2017-06-07 Thread Thomas Monjalon
25/05/2017 01:40, Stephen Hemminger: > While working on SR-IOV support on Azure, it was discovered that some > applications > and drivers do not support full size PCI domains. On Azure environment the > PCI pass > through device has a synthetic domain value (ie generated by host) which is > > 16

Re: [dpdk-dev] [PATCH 0/2] net/softnic: sw fall-back for traffic management

2017-06-07 Thread Thomas Monjalon
Hi Jasvinder, 26/05/2017 20:11, Jasvinder Singh: > The SoftNIC PMD provides SW fall-back option for the NICs not supporting > the Traffic Management (TM) features. Do you mean that you want to stack PMDs in order to offer some fallbacks? It means the user needs to instantiate this PMD for each H

Re: [dpdk-dev] [dpdk-dev,RFC] build for DPDK with meson and ninja

2017-06-07 Thread Ilya Maximets
Hi, Bruce. That's interesting approach. I tried this on my system and it works. I also tried to do some modifications to add conditional support for libnuma in rte_eal to build with my patches applied. It looks promising. That is what I've got:

[dpdk-dev] [PATCH v3 0/3] mk: make config enhancements

2017-06-07 Thread David Hunt
This patch series is a couple of small patches to make the 'make config' of the build a bit easier for users. Users can now 'make defconfig' which will pick a sensible default based on some 'uname' queries of the system. Users can also set RTE_TEMPLATE in their environment which will get picked u

[dpdk-dev] [PATCH v3 2/3] mk: allow use of environment var for template

2017-06-07 Thread David Hunt
Added new environment variable RTE_TEMPLATE which is an additional variable that can be set in the users environment. This maps on to the existing 'T' command line variable typically used when 'make config' or 'make install' is invoked. So, instead of typing 'make config T=x86_64-native-linuxapp-g

[dpdk-dev] [PATCH v3 1/3] mk: add sensible default target with defconfig

2017-06-07 Thread David Hunt
Users can now use 'make defconfig' to generate a configuration using the most appropriate defaults for the current machine. arch taken from uname -m machine defaults to native execenv is taken from uname, Linux=linuxapp, otherwise bsdapp toolchain is taken from $CC -v to see which compile

[dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file

2017-06-07 Thread David Hunt
* Add in information about 'make defconfig' * Add in information about RTE_TEMPLATE environment variable * Explain the default directory for 'O=' a bit better * Clean up text alignment Signed-off-by: David Hunt --- doc/build-sdk-quick.txt | 28 +++- 1 file changed

Re: [dpdk-dev] [dpdk-users] Invalid TCP/UDP checksum for IPV4 packets

2017-06-07 Thread Thomas Monjalon
Hi, 31/05/2017 10:16, Julien Castets: > I had a running application on DPDK 2.2.0 which offloads IP/TCP/UDP > checksums to the NIC. A few days ago, I started the migration to 17.02 > and started to see invalid TCP/UDP checksum. > > I called the new API rte_eth_tx_prepare() but checksums were stil

Re: [dpdk-dev] [dpdk-dev,RFC] build for DPDK with meson and ninja

2017-06-07 Thread Bruce Richardson
On Wed, Jun 07, 2017 at 05:36:41PM +0300, Ilya Maximets wrote: > Hi, Bruce. > > That's interesting approach. I tried this on my system and it works. > I also tried to do some modifications to add conditional support for > libnuma in rte_eal to build with my patches applied. It looks promising. > T

Re: [dpdk-dev] [PATCH] cryptodev: fix cryptodev start return value

2017-06-07 Thread Trahe, Fiona
Hi Pavan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Wednesday, June 7, 2017 11:37 AM > To: dev@dpdk.org > Cc: Doherty, Declan ; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH] cryptodev: fix cryptodev start return value

Re: [dpdk-dev] [PATCH v2] ethdev: remove driver name from device private data

2017-06-07 Thread Jan Blunck
On Tue, Jun 6, 2017 at 5:10 PM, Ferruh Yigit wrote: > rte_driver->name has the driver name and all physical and virtual > devices has access to it. > > Previously it was not possible for virtual ethernet devices to access > rte_driver->name field (because eth_dev used to keep only pci_dev), > and

Re: [dpdk-dev] [PATCH v2 04/11] bus: add bus helper iterator to find a particular device

2017-06-07 Thread Jan Blunck
On Wed, May 31, 2017 at 3:17 PM, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c | 25 > + > lib/librte_

Re: [dpdk-dev] [PATCH v2 01/11] bus: add bus iterator to find a particular bus

2017-06-07 Thread Jan Blunck
On Wed, Jun 7, 2017 at 3:27 PM, Gaëtan Rivet wrote: > On Wed, Jun 07, 2017 at 12:36:53PM +0530, Shreyansh Jain wrote: >> >diff --git a/lib/librte_eal/common/include/rte_bus.h >> >b/lib/librte_eal/common/include/rte_bus.h >> >index 7c36969..006feca 100644 >> >--- a/lib/librte_eal/common/include/rt

Re: [dpdk-dev] Getting meta data from different pipelines in ip_pipeline application

2017-06-07 Thread Dumitrescu, Cristian
If you print the bytes of the key read by the flow classification pipeline, is it as expected? Make sure you don’t have bytes of random data (incorrect masks) or endianess issues. From: Nidhia Varghese [mailto:nidhiavarghes...@gmail.com] Sent: Sunday, June 4, 2017 8:20 AM To: Dumitrescu, Cristia

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-06-07 Thread Ferruh Yigit
On 6/6/2017 3:43 PM, gowrishankar muthukrishnan wrote: > Hi Ferruh, > Just wanted to check with you on the verdict of this patch, whether we > are waiting for > any objection/ack ?. I was waiting for more comment, I will ack explicitly. > > Thanks, > Gowrishankar > > On Thursday 01 June 2017 0

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

2017-06-07 Thread Ferruh Yigit
On 5/11/2017 12:51 PM, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > In kni_allocate_mbufs(), we attempt to add max_burst (32) count of mbuf > always into alloc_q, which is excessively leading too many rte_pktmbuf_ > free() when alloc_q is contending at high packet rate (for eg 10Gig

Re: [dpdk-dev] [PATCH 0/9] rte_bus parse API

2017-06-07 Thread Jan Blunck
On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > Following the evolutions announced in [1], here is the first part of > the rte_devargs rework planned for 17.08. The rationale has been partially > explained in [2]. > > This first part covers the introduction of the necessary facilities in >

Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name

2017-06-07 Thread Jan Blunck
On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > Find which bus should be able to parse this device name into an internal > device representation. > No, please don't add this. One should know to what bus a device belongs to before plugging it. Artificially encoding the parent bus into the d

Re: [dpdk-dev] [PATCH v4 00/12] introduce fail-safe PMD

2017-06-07 Thread Stephen Hemminger
On Mon, 29 May 2017 15:42:12 +0200 Gaetan Rivet wrote: > This PMD intercepts and manages Ethernet device removal events issued by > slave PMDs and re-initializes them transparently when brought back so that > existing applications do not need to be modified to benefit from true > hot-plugging sup

Re: [dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja

2017-06-07 Thread Jerin Jacob
-Original Message- > Date: Wed, 7 Jun 2017 11:47:43 +0100 > From: Bruce Richardson > To: dev@dpdk.org > CC: Bruce Richardson > Subject: [dpdk-dev] [RFC PATCH] build for DPDK with meson and ninja > X-Mailer: git-send-email 2.9.4 > > to use, need to have meson >= 0.4 and ninja-build packag

Re: [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set

2017-06-07 Thread Maxime Coquelin
On 06/07/2017 08:41 AM, Jianfeng Tan wrote: As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM, applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO is set. This leads to that packets get dropped in VM tcp stack layer because of bad TCP csum. To fix this, we make su

Re: [dpdk-dev] [PATCH 2/2] vhost: fix IP csum not calculated

2017-06-07 Thread Maxime Coquelin
On 06/07/2017 08:41 AM, Jianfeng Tan wrote: There is no way to bypass IP checksum verification in Linux kernel, no matter skb->ip_summed is assigned as CHECKSUM_UNNECESSARY or CHECKSUM_PARTIAL. So any packets with bad IP checksum will be dropped at VM IP layer. To correct, we check this flag

Re: [dpdk-dev] [PATCH 0/9] rte_bus parse API

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 07:22:05PM +0200, Jan Blunck wrote: > On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > > Following the evolutions announced in [1], here is the first part of > > the rte_devargs rework planned for 17.08. The rationale has been partially > > explained in [2]. > > > > T

Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 07:28:07PM +0200, Jan Blunck wrote: > On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > > Find which bus should be able to parse this device name into an internal > > device representation. > > > > No, please don't add this. One should know to what bus a device > belo

Re: [dpdk-dev] [PATCH v2 04/11] bus: add bus helper iterator to find a particular device

2017-06-07 Thread Gaëtan Rivet
On Wed, Jun 07, 2017 at 06:41:58PM +0200, Jan Blunck wrote: > On Wed, May 31, 2017 at 3:17 PM, Gaetan Rivet wrote: > > From: Jan Blunck > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/commo

Re: [dpdk-dev] [PATCH 00/12] Remove cryptodev driver

2017-06-07 Thread Gaëtan Rivet
Hi Pablo, On Wed, May 24, 2017 at 04:27:02PM +0100, Pablo de Lara wrote: > Following the same aproach taken for ethdev, this patch series > removes the PCI specific structure cryptodev driver from rte_cryptodev. > > The patchset makes the following changes: > > - Moves the virtual and PCI device

Re: [dpdk-dev] [RFC PATCH] replace DPDK config and build system

2017-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2017 11:47:42 +0100 Bruce Richardson wrote: > The prototype is incomplete, but it does build a reasonable number of our > libraries, some unit tests, the i40e PMD and the testpmd binary, and I have > successfully passed traffic using testpmd from the build. Some things are > not fu

[dpdk-dev] [PATCH v3 00/10] bus: attach / detach API

2017-06-07 Thread Gaetan Rivet
Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interfa

[dpdk-dev] [PATCH v3 01/10] bus: add bus iterator to find a particular bus

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 11 lib/librte_eal/common/include/rte_bus.h | 34 + lib/librte_eal/linux

[dpdk-dev] [PATCH v3 02/10] bus: add device iterator

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 7 +++ lib/librte_eal/common/include/rte_dev.h | 17 + 2 files changed, 24 insertions(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte

[dpdk-dev] [PATCH v3 04/10] bus: add bus helper iterator to find a particular device

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 25 + lib/librte_eal/common/include/rte_bus.h | 23 +++ lib/l

[dpdk-dev] [PATCH v3 03/10] bus: add helper to find bus for a particular device

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 24 lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/

[dpdk-dev] [PATCH v3 05/10] bus: introduce hotplug functionality

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 2 ++ lib/librte_eal/common/include/rte_bus.h | 31 +++ 2 files changed, 33 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/li

[dpdk-dev] [PATCH v3 07/10] vdev: implement hotplug functionality

2017-06-07 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 36 + 1 file changed, 36 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 52528ef..22e4640 100644 --- a/lib/librte_eal/comm

[dpdk-dev] [PATCH v3 06/10] vdev: implement find_device bus operation

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0037a64..52528ef 100644

[dpdk-dev] [PATCH v3 09/10] ethdev: use embedded rte_device to detach driver

2017-06-07 Thread Gaetan Rivet
From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_dev.c| 43 --- lib/librte_eal/common/include/rte_dev.h | 11 +++ lib/librte_ether/rte_ethd

  1   2   >