Thank you~
1. We have a compare test on qemu-kvm enviroment with huge page and without
huge page. Qemu start process is much longer in huge page enviromwnt. And I
write an email titled with '[DPDK-memory] how qemu waste such long time
under dpdk huge page envriment?'. I could resend it later.
2.
Several drivers, libraries and apps check if a socket
has reserved memory, by implementing their own function,
which returns the total number of sockets that have memory.
First of all, this function is not completely correct,
as it really returns the highest socket id that has memory.
So, if all
Use new function to check if socket id has reserved memory,
instead of implementing a local function that checks
total number of sockets, to verify if selected socket id
is beyond the range of sockets.
Signed-off-by: Pablo de Lara
---
lib/librte_cryptodev/rte_cryptodev.c | 23 ---
Use new function to check if socket id has reserved memory,
instead of implementing a local function that checks
total number of sockets, to verify if selected socket id
is beyond the range of sockets.
Signed-off-by: Pablo de Lara
---
drivers/crypto/scheduler/scheduler_pmd.c | 23 ---
Several drivers and apps check if a socket has reserved memory,
by implementing their own function, which returns the
total number of sockets that have memory.
This function is not really useful, as the main goal is
to check if memory on a specific socket is available,
rather than checking if a soc
Use new function to check if socket id has reserved memory,
instead of implementing a local function that checks
total number of sockets, to verify if selected socket id
is beyond the range of sockets.
Signed-off-by: Pablo de Lara
---
drivers/net/bonding/rte_eth_bond_api.c | 16 -
Use new function to check if socket id has reserved memory,
instead of implementing a local function that checks
total number of sockets, to verify if selected socket id
is beyond the range of sockets.
Signed-off-by: Pablo de Lara
---
test/test/virtual_pmd.c | 16 +---
1 file changed
21/06/2017 01:36, Gaetan Rivet:
> This function was previously private to the EAL layer.
> Other subsystems requires it, such as the PCI bus.
>
> This function is only exposed for linuxapps.
Why exposing it only for Linux?
Every API should be common, even if it is not implemented for FreeBSD.
21/06/2017 01:36, Gaetan Rivet:
> Signed-off-by: Gaetan Rivet
Please add a comment to explain why this include is required now.
21/06/2017 01:36, Gaetan Rivet:
> pmdinfogen has a dependency on the PCI bus. The latter must be built
> first.
I think it should not be moved outside of buildtools.
The build order can be fixed by installing headers before any compilation
like proposed in this RFC: http://dpdk.org/patch/25463
A
Currently EAL allocates hugepages one by one not paying attention
from which NUMA node allocation was done.
Such behaviour leads to allocation failure if number of available
hugepages for application limited by cgroups or hugetlbfs and
memory requested not only from the first socket.
Example:
It is safe to enable LIBRTE_VHOST_NUMA by default for all
configurations where libnuma is already a default dependency.
Signed-off-by: Ilya Maximets
---
config/common_linuxapp | 1 +
config/defconfig_arm-armv7a-linuxapp-gcc | 1 +
config/defconfig_arm64-armv8a-linuxapp-
Version 6:
* Configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES
returned. Enabled by default for x86, ppc and thunderx.
Version 5:
* Fixed shared build. (Automated build test will fail
anyway because libnuma-devel not installed on build servers)
Version 4
On 6/20/2017 9:11 PM, Jerin Jacob wrote:
-Original Message-
Date: Tue, 20 Jun 2017 15:58:50 +0100
From: Sergio Gonzalez Monroy
To: Thomas Monjalon , Ilya Maximets
CC: dev@dpdk.org, Hemant Agrawal , Bruce Richardson
, David Marchand ,
Heetae Ahn , Yuanhan Liu ,
Jianfeng Tan , Neil H
On 6/20/2017 8:04 PM, Wiles, Keith wrote:
On Jun 20, 2017, at 5:43 AM, Hemant Agrawal wrote:
On 6/19/2017 7:22 PM, Wiles, Keith wrote:
On Jun 19, 2017, at 6:00 AM, Shreyansh Jain wrote:
Hello Adrien,
On Friday 16 June 2017 04:04 PM, Adrien Mazarguil wrote:
Hi Shreyansh,
On Fri, Jun 16,
On 21/06/2017 09:14, Hemant Agrawal wrote:
On 6/20/2017 9:11 PM, Jerin Jacob wrote:
-Original Message-
Date: Tue, 20 Jun 2017 15:58:50 +0100
From: Sergio Gonzalez Monroy
To: Thomas Monjalon , Ilya Maximets
CC: dev@dpdk.org, Hemant Agrawal , Bruce
Richardson
, David Marchand
,
Hee
On Wed, Jun 21, 2017 at 01:47:52PM +0530, Hemant Agrawal wrote:
> On 6/20/2017 8:04 PM, Wiles, Keith wrote:
> >
> > > On Jun 20, 2017, at 5:43 AM, Hemant Agrawal
> > > wrote:
> > >
> > > On 6/19/2017 7:22 PM, Wiles, Keith wrote:
> > > >
> > > > > On Jun 19, 2017, at 6:00 AM, Shreyansh Jain
> >
On 21.06.2017 11:25, Sergio Gonzalez Monroy wrote:
> On 21/06/2017 09:14, Hemant Agrawal wrote:
>> On 6/20/2017 9:11 PM, Jerin Jacob wrote:
>>> -Original Message-
Date: Tue, 20 Jun 2017 15:58:50 +0100
From: Sergio Gonzalez Monroy
To: Thomas Monjalon , Ilya Maximets
>>
-Original Message-
> Date: Wed, 21 Jun 2017 09:25:25 +0100
> From: Sergio Gonzalez Monroy
> To: Hemant Agrawal , Jerin Jacob
>
> CC: Thomas Monjalon , Ilya Maximets
> , dev@dpdk.org, Bruce Richardson
> , David Marchand ,
> Heetae Ahn , Yuanhan Liu ,
> Jianfeng Tan , Neil Horman
> ,
21/06/2017 10:41, Jerin Jacob:
> > > 1. There are many machines (arm/ppc), which do not support NUMA.
> > >
> > > https://wiki.linaro.org/LEG/Engineering/Kernel/NUMA
> > >
> >
> > I did find that link too, last modified 4 years ago.
> > Despite that, I could not find any ARM references in libnum
21/06/2017 10:04, Ilya Maximets:
> +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n
We can stop inserting LIBRTE in our config options.
CONFIG_RTE_EAL_ is long enough :)
On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote:
> 21/06/2017 10:04, Ilya Maximets:
> > +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n
>
> We can stop inserting LIBRTE in our config options.
> CONFIG_RTE_EAL_ is long enough :)
>
Consistency. While I agree it's unneeded should have
On Wed, Jun 21, 2017 at 01:47:52PM +0530, Hemant Agrawal wrote:
> On 6/20/2017 8:04 PM, Wiles, Keith wrote:
> >
> >>On Jun 20, 2017, at 5:43 AM, Hemant Agrawal wrote:
> >>
> >>On 6/19/2017 7:22 PM, Wiles, Keith wrote:
> >>>
> On Jun 19, 2017, at 6:00 AM, Shreyansh Jain
> wrote:
>
>
Hi Sam,
On Wed, Jun 21, 2017 at 03:22:45PM +0800, Sam wrote:
> Thank you~
>
> 1. We have a compare test on qemu-kvm enviroment with huge page and without
> huge page. Qemu start process is much longer in huge page enviromwnt. And I
> write an email titled with '[DPDK-memory] how qemu waste such l
On Wed, Jun 21, 2017 at 09:44:06AM +0200, Thomas Monjalon wrote:
> 21/06/2017 01:36, Gaetan Rivet:
> > This function was previously private to the EAL layer.
> > Other subsystems requires it, such as the PCI bus.
> >
> > This function is only exposed for linuxapps.
>
> Why exposing it only for Li
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, June 15, 2017 4:43 PM
> To: Iremonger, Bernard
> Cc: dev@dpdk.org; tho...@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API
>
> On Mon,
On 21.06.2017 11:58, Bruce Richardson wrote:
> On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote:
>> 21/06/2017 10:04, Ilya Maximets:
>>> +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n
>>
>> We can stop inserting LIBRTE in our config options.
>> CONFIG_RTE_EAL_ is long enough :)
>>
> C
On Wed, Jun 21, 2017 at 09:45:12AM +0200, Thomas Monjalon wrote:
> 21/06/2017 01:36, Gaetan Rivet:
> > Signed-off-by: Gaetan Rivet
>
> Please add a comment to explain why this include is required now.
This commit will have this comment in the next version:
This include is necessary for rte_
21/06/2017 10:58, Bruce Richardson:
> On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote:
> > 21/06/2017 10:04, Ilya Maximets:
> > > +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n
> >
> > We can stop inserting LIBRTE in our config options.
> > CONFIG_RTE_EAL_ is long enough :)
> >
> C
-Original Message-
> Date: Wed, 21 Jun 2017 10:49:14 +0200
> From: Thomas Monjalon
> To: Jerin Jacob
> Cc: Sergio Gonzalez Monroy , Hemant
> Agrawal , Ilya Maximets ,
> dev@dpdk.org, Bruce Richardson , David
> Marchand , Heetae Ahn
> , Yuanhan Liu , Jianfeng
> Tan , Neil Horman , Yul
On Wed, Jun 21, 2017 at 12:25:51PM +0300, Ilya Maximets wrote:
> On 21.06.2017 11:58, Bruce Richardson wrote:
> > On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote:
> >> 21/06/2017 10:04, Ilya Maximets:
> >>> +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n
> >>
> >> We can stop insertin
On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote:
> 21/06/2017 01:36, Gaetan Rivet:
> > pmdinfogen has a dependency on the PCI bus. The latter must be built
> > first.
>
> I think it should not be moved outside of buildtools.
>
Right, I agree. I took the simplest path here, but if
> -Original Message-
> From: Wu, Jingjing [mailto:jingjing...@intel.com]
> Sent: Tuesday, June 20, 2017 04:27
> To: Vasily Philipov ; dev@dpdk.org
> Cc: Adrien Mazarguil ; Nélio Laranjeiro
>
> Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
> parameter
>
>
> > +/*
On 6/20/2017 8:13 AM, Nélio Laranjeiro wrote:
> On Tue, Jun 20, 2017 at 08:24:47AM +0300, Shahaf Shuler wrote:
>> In case on multi segment packet, the TSO segment size
>> was taken from the last segment. This may lead to incorrect
>> values in case not all segments are initialized with the field.
>
21/06/2017 11:27, Jerin Jacob:
> -Original Message-
> > Date: Wed, 21 Jun 2017 10:49:14 +0200
> > From: Thomas Monjalon
> > To: Jerin Jacob
> > Cc: Sergio Gonzalez Monroy , Hemant
> > Agrawal , Ilya Maximets ,
> > dev@dpdk.org, Bruce Richardson , David
> > Marchand , Heetae Ahn
> > ,
21/06/2017 11:40, Gaëtan Rivet:
> On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote:
> > Another (probably better) solution is to keep basic definitions
> > and helpers in EAL:
> > - rte_pci.h keeps only some PCI definitions and helpers
> > like rte_pci_addr and eal_parse_pci_BDF(
On 6/20/2017 5:37 PM, Andrew Rybchenko wrote:
> From: Ivan Malov
>
> Signed-off-by: Ivan Malov
> Signed-off-by: Andrew Rybchenko
Applied to dpdk-next-net/master, thanks.
Currently EAL allocates hugepages one by one not paying attention
from which NUMA node allocation was done.
Such behaviour leads to allocation failure if number of available
hugepages for application limited by cgroups or hugetlbfs and
memory requested not only from the first socket.
Example:
Version 7:
* RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES --> RTE_EAL_NUMA_AWARE_HUGEPAGES
Version 6:
* Configuration option RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES
returned. Enabled by default for x86, ppc and thunderx.
Version 5:
* Fixed shared build. (Automated build test
It is safe to enable LIBRTE_VHOST_NUMA by default for all
configurations where libnuma is already a default dependency.
Signed-off-by: Ilya Maximets
---
config/common_linuxapp | 1 +
config/defconfig_arm-armv7a-linuxapp-gcc | 1 +
config/defconfig_arm64-armv8a-linuxapp-
On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote:
> If a library or a build tool uses a definition from a driver,
> there is a build ordering issue, like seen when moving PCI code
> into a bus driver.
>
> One option is to keep PCI helpers and some common definitions in EAL.
> The ot
-Original Message-
> Date: Wed, 21 Jun 2017 11:58:12 +0200
> From: Thomas Monjalon
> To: Jerin Jacob
> Cc: Sergio Gonzalez Monroy , Hemant
> Agrawal , Ilya Maximets ,
> dev@dpdk.org, Bruce Richardson , David
> Marchand , Heetae Ahn
> , Yuanhan Liu , Jianfeng
> Tan , Neil Horman , Yul
On 21.06.2017 13:29, Jerin Jacob wrote:
> -Original Message-
>> Date: Wed, 21 Jun 2017 11:58:12 +0200
>> From: Thomas Monjalon
>> To: Jerin Jacob
>> Cc: Sergio Gonzalez Monroy , Hemant
>> Agrawal , Ilya Maximets ,
>> dev@dpdk.org, Bruce Richardson , David
>> Marchand , Heetae Ahn
>> ,
21/06/2017 12:27, Bruce Richardson:
> On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote:
> > If a library or a build tool uses a definition from a driver,
> > there is a build ordering issue, like seen when moving PCI code
> > into a bus driver.
> >
> > One option is to keep PCI help
Userspace Network Control Interface (UNCI), (formerly KCP).
When a NIC bound to the DPDK, it can't be controlled by Linux tools.
This patch creates a virtual network interface for each DPDK port,
initial target is to get some data from those interfaces, in next
step target is to control DPDK port
This kernel module is based on KNI module, but this one is stripped
version of it and only for control messages, no data transfer
functionality provided.
This Linux kernel module helps userspace application create virtual
interfaces and when a control command issued into that virtual
interface, mo
This library gets control messages form kernelspace and forwards them to
librte_ether and returns response back to the kernelspace.
Library does:
1) Trigger Linux virtual interface creation
2) Initialize the netlink socket communication
3) Provides process() API to the application that does proces
Signed-off-by: Ferruh Yigit
---
v7:
* rebase v17.08
---
config/common_base | 5 ++
config/common_linuxapp | 1 +
doc/api/doxy-api-index.md | 3 +-
doc/api/doxy-api.conf | 1 +
doc
To have the support corresponding kernel module (UNCI) needs to be
inserted. If kernel module is not there, application will run as
it is without kernel control path support.
When UNCI module inserted, running application creates a virtual Linux
network interface (dpdk$) per DPDK port. This inter
-Original Message-
> Date: Wed, 21 Jun 2017 13:36:58 +0300
> From: Ilya Maximets
> To: Jerin Jacob , Thomas Monjalon
>
> CC: Sergio Gonzalez Monroy , Hemant
> Agrawal , dev@dpdk.org, Bruce Richardson
> , David Marchand ,
> Heetae Ahn , Yuanhan Liu ,
> Jianfeng Tan , Neil Horman
> ,
21/06/2017 13:22, Jerin Jacob:
> From: Ilya Maximets
> > On 21.06.2017 13:29, Jerin Jacob wrote:
> > > From: Thomas Monjalon
> > >> 21/06/2017 11:27, Jerin Jacob:
> > >>> From: Thomas Monjalon
> > 21/06/2017 10:41, Jerin Jacob:
> > >>> 1. There are many machines (arm/ppc), which do not
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Wednesday, June 21, 2017 12:26 AM
> To: tho...@monjalon.net; Doherty, Declan
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH 0/5] eal: check socket memory
>
> Several drivers, libraries and apps check if a socket ha
-Original Message-
> Date: Tue, 20 Jun 2017 21:18:01 +0530
> From: Jerin Jacob
> To: Hemant Agrawal
> Cc: dev@dpdk.org, bruce.richard...@intel.com, harry.van.haa...@intel.com,
> gage.e...@intel.com, nipun.gu...@nxp.com, narender.vang...@intel.com
> Subject: Re: [PATCH] eventdev: define t
On Wed, Jun 21, 2017 at 12:00:24PM +0200, Thomas Monjalon wrote:
> 21/06/2017 11:40, Gaëtan Rivet:
> > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote:
> > > Another (probably better) solution is to keep basic definitions
> > > and helpers in EAL:
> > > - rte_pci.h keeps only some
21/06/2017 01:29, Gaetan Rivet:
> +/**
> + * Device comparison function.
> + *
> + * @param dev
> + * Device handle.
> + *
> + * @param data
> + * Data to compare against.
> + *
> + * @return
> + * 0 if the device matches the data.
> + * !0 if the device does not match.
> + * <0 if orderi
Missing room in flow allocation to store the drop specification.
Changing flow without storing the change in rte_flow.
Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
Signed-off-by: Shachar Beiser
---
drivers/net/mlx5/mlx5_flow.c | 8 +---
1 file changed, 5 ins
21/06/2017 01:29, Gaetan Rivet:
> +static int
> +cmp_rte_device(const struct rte_device *dev, const void *_dev2)
Better to rename dev into dev1.
> +{
> + const struct rte_device *dev2 = _dev2;
> +
> + return !(dev == dev2);
simpler: return dev1 != dev2
[...]
> +static int
> +bus_find_de
21/06/2017 01:29, Gaetan Rivet:
> +/**
> + * Bus iterator to find a particular bus.
> + *
> + * If the callback returns zero this function will stop iterating over
> + * any more buses.
> + * If the start parameter is non-NULL, the comparison will only be determined
> + * past this element.
> + *
>
21/06/2017 13:39, Gaëtan Rivet:
> On Wed, Jun 21, 2017 at 12:00:24PM +0200, Thomas Monjalon wrote:
> > 21/06/2017 11:40, Gaëtan Rivet:
> > > On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote:
> > > > Another (probably better) solution is to keep basic definitions
> > > > and helpers i
On Wed, Jun 21, 2017 at 01:55:39PM +0200, Thomas Monjalon wrote:
> 21/06/2017 01:29, Gaetan Rivet:
> > +/**
> > + * Device comparison function.
> > + *
> > + * @param dev
> > + * Device handle.
> > + *
> > + * @param data
> > + * Data to compare against.
> > + *
> > + * @return
> > + * 0 if t
21/06/2017 01:29, Gaetan Rivet:
> /**
> + * Bus iterator to find a particular device.
It should be said that it is iterating over every registered buses.
> + *
> + * If the callback returns non-zero this function will stop iterating over
> any
> + * more buses and devices. To continue a search
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, June 21, 2017 11:42 AM
> To: Richardson, Bruce
> Cc: gaetan.ri...@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first
>
> 21/06/2017 12:27, Bruce Richar
On Wed, Jun 21, 2017 at 11:55:58AM +, Shachar Beiser wrote:
> Missing room in flow allocation to store the drop specification.
> Changing flow without storing the change in rte_flow.
> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
>
> Signed-off-by: Shachar Bei
Socket id parsed from the user was checked
if it was in the range of available sockets.
This check is unnecessary, as the socket specified
might not have memory anyway, so it will fail
at memory allocation.
Therefore, the best solution is to remove this check.
Signed-off-by: Pablo de Lara
---
l
Several libraries, drivers and tests check if a socket
is within the range of available sockets, by
implementig their own function, which returns the total
number of sockets that have memory.
First of all, this function is not completely correct,
as it really returns the highest socket id that ha
Socket id parsed from the user was checked
if it was in the range of available sockets.
This check is unnecessary, as the socket specified
might not have memory anyway, so it will fail
at memory allocation.
Therefore, the best solution is to remove this check.
Signed-off-by: Pablo de Lara
---
d
Socket id parsed from the user was checked
if it was in the range of available sockets.
This check is unnecessary, as the socket specified
might not have memory anyway, so it will fail
at memory allocation.
Therefore, the best solution is to remove this check.
Signed-off-by: Pablo de Lara
---
d
When creating a virtual pmd to test link bonding,
the socket id was checked, if it was in the range
of available sockets.
This check is unnecessary, as the socket specified
might not have memory anyway, so it will fail
at memory allocation.
Therefore, the best solution is to remove this check.
Si
Document NIC features, add more information about them and add more
implementation related support.
Signed-off-by: Ferruh Yigit
---
TODO:
- Not all features all fully documented, need help from community
- Instead of having a new file, it would be nice to auto generate this
file from defaults.i
The following changes since commit 3566af6be7f968c678a867399ddc644fb762873b:
app/testpmd: always build VF and MACsec functions (2017-06-20 09:28:34 +0200)
are available in the git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to c687cebe095b2ea325aa
Hello,
Ethernet frames sent to multicast destination address 01:ff:ff:ff:ff:01
not visible on ixgbe & i40e VF PMDs.
PF PMDs receive multicast frames normally.
Tested with DPDK v17.05.0 and
3566af6be7f968c678a867399ddc644fb762873b (current master)
Regards,
Gregory
Hi Stephen,
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, May 31, 2017 11:52 PM
> To: De Lara Guarch, Pablo
> Cc: Doherty, Declan ; dev@dpdk.org;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix assert check
>
> On Jun 21, 2017, at 5:27 AM, Bruce Richardson
> wrote:
>
> On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote:
>> If a library or a build tool uses a definition from a driver,
>> there is a build ordering issue, like seen when moving PCI code
>> into a bus driver.
>>
>> One opti
Following the same approach taken for ethdev, this patch series
removes the PCI specific structure cryptodev driver from rte_cryptodev.
The patchset makes the following changes:
- Moves the virtual and PCI device specific functions to separate files,
so other cryptodev header files contain only
When retrieving device information for a crypto driver,
driver name was only set when it was a PCI driver.
Getting the driver name from rte_device structure
allows rte_cryptodev_get_info() function to return it
regardless they are virtual or physical devices.
Signed-off-by: Pablo de Lara
Acked-by
rte_cryptodev_devices_get() function was parsing a crypto
device name as an argument, but the function actually
returns device identifiers of devices that share the
same crypto driver, so the argument should be driver name, instead.
Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
CC: sta..
Do not set PCI information in the device information structure
for any crypto device, just for the ones that are PCI, so
this is set internally in the PCI crypto PMDs (only QAT now).
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
drivers/crypto/qat/qat_crypto.c | 5 +++--
lib/li
rte_cryptodev_devices_get() function returns an array of devices
sharing the same driver.
Instead of having two different paths depending on the device being
virtual or physical, retrieve the driver name from rte_device structure.
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
lib/l
Only non virtual devices were storing the pointer to
rte_device structure in rte_cryptodev, which will be needed
to retrieve the driver name for any device.
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 3 ++-
drivers/crypto/aesni_mb/rte_
Move all functions handling virtual devices to a separate
header file "rte_cryptodev_vdev.h", in order to leave only
generic functions for any device in the rest of the files.
Signed-off-by: Pablo de Lara
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 1 +
drivers/crypto/aesni_mb/rte_aes
Call rte_cryptodev_pmd_release_device() if probing a
PCI crypto device, instead of accessing the variables
directly. This will be useful when rte_cryptodev_pci_probe()
gets moved to a separate file.
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
lib/librte_cryptodev/rte_cryptodev.c |
Add PCI probe/remove/init/uninit functions in a separate
file rte_cryptodev_pci.h, which do not use cryptodev driver,
in order to be removed in next commits.
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
lib/librte_cryptodev/Makefile| 1 +
lib/librte_cryptodev/rte_cryp
Signed-off-by: Pablo de Lara
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 4e01fe8..e32b27e 100644
--- a/drivers/crypto/d
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
drivers/crypto/qat/qat_crypto.c| 1 +
drivers/crypto/qat/qat_qp.c| 8 +---
drivers/crypto/qat/rte_qat_cryptodev.c | 32
3 files changed, 26 insertions(+), 15 deletions(-)
diff --
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
lib/librte_cryptodev/rte_cryptodev.c | 103 -
lib/librte_cryptodev/rte_cryptodev_pmd.h | 13
lib/librte_cryptodev/rte_cryptodev_version.map | 10 +--
3 files changed, 1 insertion(+), 125 dele
Signed-off-by: Pablo de Lara
Acked-by: Declan Doherty
---
lib/librte_cryptodev/rte_cryptodev.h | 2 -
lib/librte_cryptodev/rte_cryptodev_pmd.h | 64
2 files changed, 66 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h
b/lib/librte_cryptodev/r
21/06/2017 01:29, Gaetan Rivet:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -354,26 +354,14 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t
> *port_id)
> static int
> rte_eth_dev_is_detachable(uint8_t port_id)
> {
> - uint32_t dev_flags;
> +
21/06/2017 01:29, Gaetan Rivet:
> + return !!dev->device->devargs->bus->unplug;
lib/librte_ether/rte_ethdev.c:364:33: fatal error:
no member named 'bus' in 'struct rte_devargs'
Please move this patch alone, specifying the right dependency.
08/06/2017 01:54, Gaetan Rivet:
> Signed-off-by: Gaetan Rivet
> ---
> This patch depends on:
>
> bus: attach / detach API
> http://dpdk.org/ml/archives/dev/2017-May/066330.html
> http://dpdk.org/dev/patchwork/patch/24489/
Please insert this patch the related series above.
Prior to new crypto patches for this release,
there were some fixes and some cleanup to do in
some crypto drivers, tests, sample apps and documents.
Pablo de Lara (9):
crypto/aesni_mb: remove assert check
test/crypto: fix wrong AAD setting
test/crypto: remove unnecessary offset
test/crypto
Some assert checks in the driver were
incorrect, but they are not necessary anyway,
as application will panic in any case.
Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 --
08/06/2017 01:58, Gaetan Rivet:
> +RTE_REGISTER_BUS(VIRTUAL_BUS_NAME, rte_vdev_bus);
nice :)
AAD should not point at IV for AES algorithms.
For AES-GCM, AAD will point at additional data in the mbuf.
For the other algorithms (such as AES CBC), AAD is not used.
Fixes: ffbe3be0d4b5 ("app/test: add libcrypto")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
test/test/test_cryptodev_p
For AES/DES tests, there is no need to leave out
the first block from the crypto operation.
Signed-off-by: Pablo de Lara
---
test/test/test_cryptodev_perf.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/test/test/test_cryptodev_perf.c b/test/test/test_cryptod
Instead of using duplicated functions to get the algorithm
strings, use the functions from the cryptodev library.
Signed-off-by: Pablo de Lara
---
test/test/test_cryptodev_perf.c | 83 -
1 file changed, 16 insertions(+), 67 deletions(-)
diff --git a/test/
Chain parameter can be CIPHER_HASH, HASH_CIPHER,
CIPHER_ONLY or HASH_ONLY, but only the first two
were shown in the application help.
Fixes: 1a75e9f3fadb ("examples/l2fwd-crypto: add cipher/hash only cases")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
examples/l2fwd-crypto/main.c | 3 +
Fixes: 4790f99d2d31 ("examples/l2fwd-crypto: use cryptodev algorithm parser")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
examples/l2fwd-crypto/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 84
Instead of passing the authentication and cipher offset
from the test vectors, just get them from the IV and AAD lengths.
Signed-off-by: Pablo de Lara
---
test/test/test_cryptodev.c | 59 ++---
.../test/test_cryptodev_kasumi_hash_test_vectors.h | 25 --
Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
app/test-crypto-perf/cperf_options_parsing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-crypto-perf/cperf_options_parsing.c
b/app/test-crypto-p
Fixes: ba7b86b1419b ("doc: add l2fwd-crypto sample app guide")
CC: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
doc/guides/sample_app_ug/l2_forward_crypto.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst
b/doc/guides/samp
1 - 100 of 165 matches
Mail list logo
