Re: [dpdk-dev] [PATCH] eal: don't advertise a physical address when no hugepages

2017-06-26 Thread santosh
Hi Olivier, On Friday 23 June 2017 10:38 PM, Jan Blunck wrote: > On Fri, Jun 23, 2017 at 10:11 AM, Olivier Matz wrote: >> Hi Jan, >> >> On Sat, 10 Jun 2017 10:31:22 +0200, Jan Blunck wrote: >>> On Fri, Jun 9, 2017 at 10:29 AM, Olivier Matz >>> wrote: When populating a mempool with a virt

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-26 Thread Frederico Cadete
On Fri, 2017-06-23 at 23:36 +0800, Tan, Jianfeng wrote: > Hi Cadete, > > > On 6/22/2017 10:58 PM, Frederico Cadete wrote: > > > > Hello, > > > > I believe commit 260aae9a [1] has introduced a regression for the > > case > > of 32-bit process running on a 64-bit kernel. > > > > The commit is ef

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Sergio Gonzalez Monroy
On 23/06/2017 14:02, Thomas Monjalon wrote: 22/06/2017 17:15, Sergio Gonzalez Monroy: Just fyi, the summary line should be lowercase apart from acronyms (DPDK guidelines). On 11/05/2017 02:56, Tonghao Zhang wrote: The NUMA node information for PCI devices provided through sysfs is invalid for

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Thomas Monjalon
26/06/2017 11:14, Sergio Gonzalez Monroy: > On 23/06/2017 14:02, Thomas Monjalon wrote: > > 22/06/2017 17:15, Sergio Gonzalez Monroy: > >> Just fyi, the summary line should be lowercase apart from acronyms (DPDK > >> guidelines). > >> > >> On 11/05/2017 02:56, Tonghao Zhang wrote: > >>> The NUMA no

[dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe

2017-06-26 Thread Radu Nicolau
From: Michal Jastrzebski If-MIB xstats: ifNumber ifIndex ifType ifMtu ifSpeed ifPhysAddress ifOperStatus ifLastChange ifHighSpeed ifConnectorPresent ifCounterDiscontinuityTime EtherLike-MIB xstats: dot3PauseOperMode dot3StatsDuplexStatus dot3StatsRateControlAbility dot3StatsRateControlStatus dot

[dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for i40e

2017-06-26 Thread Radu Nicolau
From: Michal Jastrzebski If-MIB xstats: ifNumber ifIndex ifType ifMtu ifSpeed ifPhysAddress ifOperStatus ifLastChange ifHighSpeed ifConnectorPresent ifCounterDiscontinuityTime EtherLike-MIB xstats: dot3PauseOperMode dot3StatsDuplexStatus dot3StatsRateControlAbility dot3StatsRateControlStatus dot

[dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000

2017-06-26 Thread Radu Nicolau
From: Michal Jastrzebski If-MIB xstats: ifNumber ifIndex ifType ifMtu ifSpeed ifPhysAddress ifOperStatus ifLastChange ifHighSpeed ifConnectorPresent ifCounterDiscontinuityTime EtherLike-MIB xstats: dot3PauseOperMode dot3StatsDuplexStatus dot3StatsRateControlAbility dot3StatsRateControlStatus dot

[dpdk-dev] [PATCH v2 01/16] net/i40e/base: use new virtchnl header file

2017-06-26 Thread Jingjing Wu
Modify the necessary files to be compatible with the new virtchnl.h file instead of relying on i40e_virtchnl.h variant. This mostly changes references to VIRTCHNL_ variables by removing prefix of I40E_. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 24 +- drivers/net/i

[dpdk-dev] [PATCH v2 02/16] net/i40e/base: sync nvmupdate command and adminq subtask

2017-06-26 Thread Jingjing Wu
During NVMupdate, state machine gets into unrecoverable state because i40e_clean_adminq_subtask can get scheduled after the admin queue command but before other state variables are updated. This patch adds locking around admin queue command and update of state variables so that adminq_subtask will

[dpdk-dev] [PATCH v2 00/16] net/i40e: base code update

2017-06-26 Thread Jingjing Wu
v2 changes: - Fix compile issue - update from package from 2017.05.24 to 2017.06.23 i40e base code upate. The main changes are: - use virtchnl.h instead of i40e_virtchnl.h - add support for Adaptive Virtual Function - add new AQ commands for read/write PHY registers - add new phy types for 2

[dpdk-dev] [PATCH v2 04/16] net/i40e/base: add support for Adaptive Virtual Function

2017-06-26 Thread Jingjing Wu
Add device id define and mac_type assignment needed for Adaptive Virtual Function. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 1 + drivers/net/i40e/base/i40e_devids.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/ne

[dpdk-dev] [PATCH v2 03/16] net/i40e/base: add AQ command for read/write PHY registers

2017-06-26 Thread Jingjing Wu
This patch adds new additional command for accessing to PHY registers. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 18 + drivers/net/i40e/base/i40e_common.c | 70 + drivers/net/i40e/base/i40e_prototype.h | 9 + 3 file

[dpdk-dev] [PATCH v2 05/16] net/i40e/base: store the requested FEC information

2017-06-26 Thread Jingjing Wu
Store information about FEC modes, that were requested. It will be used in printing link status information function and this way there is no need to call admin queue there. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 4 drivers/net/i40e/base/i40e_type.h | 1 + 2

[dpdk-dev] [PATCH v2 07/16] net/i40e/base: report supported link modes

2017-06-26 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 22 +++--- drivers/net/i40e/base/i40e_common.c | 18 +++--- 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40

[dpdk-dev] [PATCH v2 06/16] net/i40e/base: add new phy types for 25G AOC and ACC

2017-06-26 Thread Jingjing Wu
This patch adds new phy types for 25G Active Optical Cables (AOC) and Active Copper Cables (ACC) support. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 drivers/net/i40e/base/i40e_common.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/i4

[dpdk-dev] [PATCH v2 09/16] net/i40e/base: update FW AQ API version to 1.7

2017-06-26 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq_cmd.h | 10 +- drivers/net/i40e/base/i40e_common.c | 5 +++-- drivers/net/i40e/base/i40e_type.h | 4 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b

[dpdk-dev] [PATCH v2 08/16] net/i40e/base: track id can be 0

2017-06-26 Thread Jingjing Wu
track_id == 0 is valid for “read only” profiles when profile does not have any “write” commands. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c| 7 +-- drivers/net/i40e/base/i40e_prototype.h | 12 +++- 2 files changed, 8 insertions(+), 11 deletions(-) diff -

[dpdk-dev] [PATCH v2 10/16] net/i40e/base: add support for switch parameters

2017-06-26 Thread Jingjing Wu
Adds double VLAN tagging ethertype fields to Set Switch Parameters AQ command. These were added in firmware API 1.7. Callers of i40e_aq_set_switch_config() can specify the ethertypes to use by filling out the corresponding fields in struct i40e_hw. Signed-off-by: Jingjing Wu --- drivers/net/i4

[dpdk-dev] [PATCH v2 11/16] net/i40e/base: use admin queue for setting LEDs behavior

2017-06-26 Thread Jingjing Wu
Instead of accessing register directly, use newly added AQC in order to blink LEDs. Introduce and utilize a new flag to prevent excessive API version checking. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_adminq.c | 6 ++ drivers/net/i40e/base/i40e_common.c | 148 +

[dpdk-dev] [PATCH v2 12/16] net/i40e/base: avoid potential null pointer dereference

2017-06-26 Thread Jingjing Wu
Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3f3b275..78ed2a8 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/driver

[dpdk-dev] [PATCH v2 13/16] net/i40e/base: avoid reset timeout issue

2017-06-26 Thread Jingjing Wu
This patch allows detection of upcoming core reset in case NIC gets stuck while performing FLR reset. The i40e_pf_reset() function returns I40E_ERR_NOT_READY when global reset was detected. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_common.c | 8 1 file changed, 8 inserti

[dpdk-dev] [PATCH v2 14/16] net/i40e/base: add EEPROM checksum verification

2017-06-26 Thread Jingjing Wu
This patch ensures PFs mutually exclusive access to NVM. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/i40e_nvm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index 90521fa..a1e7830

[dpdk-dev] [PATCH v2 15/16] net/i40e/base: extend processing of DDP

2017-06-26 Thread Jingjing Wu
This patch adds extended processing of DDP packages: - Execution of adminq command sections to support AQ-depended profiles, for example, for programming cloud filters types. - Ability to write a profile without registering it in the list of applied profiles, to be used for AQ-depended prof

[dpdk-dev] [PATCH v2 16/16] net/i40e: use set switch aq instead of register setting

2017-06-26 Thread Jingjing Wu
TPID can be set by set_switch_config aq, change the TPID setting by set_switch_config on new FW release. Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 104 ++--- 1 file changed, 66 insertions(+), 38 deletions(-) diff --git a/drivers/net/i40e

[dpdk-dev] [PATCH v3] test/test_mbuf: remove mempool global var

2017-06-26 Thread Santosh Shukla
Currently, pool resources are allocated statically and are not freed. Results of that test can not run more than once. Fix removes static dependency from test application and now allocating and freeing resources dynamically. Test runs for more than once. Fixes: af75078fece3 ("first public release

[dpdk-dev] [PATCH] lib/librte_sched: fix update tc_credits

2017-06-26 Thread Olivier Chirossel
*** BLURB HERE *** Olivier Chirossel (1): lib/librte_sched: fix update tc_credits Actualy ( for small rate ) if tc_credits_per_period < packets length all packets are drop. also the credits presents before the updade are loose, because tc_credits is set to tc_credits_per_peri

[dpdk-dev] [PATCH] [PATCH] lib/librte_sched: fix update tc_credits Actualy ( for small rate ) if tc_credits_per_period < packets length all packets are drop. also the credits presents before the updad

2017-06-26 Thread Olivier Chirossel
--- doc/guides/prog_guide/qos_framework.rst | 10 -- lib/librte_sched/rte_sched.c| 62 ++--- 2 files changed, 50 insertions(+), 22 deletions(-) diff --git a/doc/guides/prog_guide/qos_framework.rst b/doc/guides/prog_guide/qos_framework.rst index f3f60b8

Re: [dpdk-dev] bug: virtio PMD sends malformed packets for 32-bit processes on 64-bit kernel

2017-06-26 Thread Tan, Jianfeng
On 6/26/2017 4:14 PM, Frederico Cadete wrote: On Fri, 2017-06-23 at 23:36 +0800, Tan, Jianfeng wrote: Hi Cadete, On 6/22/2017 10:58 PM, Frederico Cadete wrote: Hello, I believe commit 260aae9a [1] has introduced a regression for the case of 32-bit process running on a 64-bit kernel. The co

Re: [dpdk-dev] [PATCH] [PATCH] lib/librte_sched: fix update tc_credits Actualy ( for small rate ) if tc_credits_per_period < packets length all packets are drop. also the credits presents before the u

2017-06-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Chirossel > Sent: Monday, June 26, 2017 11:14 AM > To: dev@dpdk.org > Cc: Olivier Chirossel > Subject: [dpdk-dev] [PATCH] [PATCH] lib/librte_sched: fix update tc_credits > Actualy ( for small rate ) if tc

Re: [dpdk-dev] [PATCH v7 0/2] Balanced allocation of hugepages

2017-06-26 Thread Ilya Maximets
So, what do you think about this version? Is it ready for merge or some additional changes needed? Best regards, Ilya Maximets. On 21.06.2017 13:08, Ilya Maximets wrote: > Version 7: > * RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES --> RTE_EAL_NUMA_AWARE_HUGEPAGES > > Version 6: > * Configura

Re: [dpdk-dev] [PATCH v8 1/4] ethtool: move from sample folder to lib folder

2017-06-26 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 12:06:48PM +0100, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit This patch fails to compile with gcc 7.1 Comment at error site below. /Bruce > --- > v7: > * rebase v17.08 > --- > config/common_base | 5 ++ > config/common_linuxapp

[dpdk-dev] [PATCH v2 0/7] Add support for using a config file for DPDK

2017-06-26 Thread Jacek Piasecki
This patchset introduce a mechanism for running dpdk application with parameters provided by configuration file. New API for cfgfile library allows to create a cfgfile at runtime, add new section and add entry in a section - opens up the possibility to have applications dynamically build up a prope

Re: [dpdk-dev] [PATCH v8 3/4] rte_ctrl_if: add control interface library

2017-06-26 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 12:06:50PM +0100, Ferruh Yigit wrote: > This library gets control messages form kernelspace and forwards them to > librte_ether and returns response back to the kernelspace. > > Library does: > 1) Trigger Linux virtual interface creation > 2) Initialize the netlink socket c

[dpdk-dev] [PATCH v2 1/7] cfgfile: remove EAL dependency

2017-06-26 Thread Jacek Piasecki
This patch removes the dependency to EAL in cfgfile library. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/Makefile | 1 + lib/librte_cfgfile/rte_cfgfile.c | 29 + 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/lib/librte_cfgfile/Makefil

[dpdk-dev] [PATCH v2 2/7] cfgfile: add new functions to API

2017-06-26 Thread Jacek Piasecki
Extend existing cfgfile library with providing new API functions: rte_cfgfile_create() - create new cfgfile object rte_cfgfile_add_section() - add new section to existing cfgfile object rte_cfgfile_add_entry() - add new entry to existing cfgfile object in specified section rte_cfgfile_set_entry()

[dpdk-dev] [PATCH v2 3/7] cfgfile: rework of load function

2017-06-26 Thread Jacek Piasecki
From: Kuba Kozak New functions added to cfgfile library make it possible to significantly simplify the code of rte_cfgfile_load_with_params() This patch shows the new body of this function. Signed-off-by: Jacek Piasecki --- lib/librte_cfgfile/rte_cfgfile.c | 143 +-

[dpdk-dev] [PATCH v2 4/7] test/cfgfile: add new unit test

2017-06-26 Thread Jacek Piasecki
Load huge realloc_sections.ini file to check malloc/realloc ability of cfgfile library. Signed-off-by: Jacek Piasecki --- test/test/test_cfgfile.c | 40 +++ test/test/test_cfgfiles/etc/realloc_sections.ini | 128 +++ 2 files changed, 168 insertion

[dpdk-dev] [PATCH v2 5/7] eal: add functions parsing EAL arguments

2017-06-26 Thread Jacek Piasecki
From: Kuba Kozak added function rte_eal_configure which configure Environment Abstraction Layer (EAL) using configuration structure. Signed-off-by: Kuba Kozak Suggested-by: Bruce Richardson --- config/common_base | 1 + lib/Makefile

Re: [dpdk-dev] [PATCH v8 3/4] rte_ctrl_if: add control interface library

2017-06-26 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 12:06:50PM +0100, Ferruh Yigit wrote: > This library gets control messages form kernelspace and forwards them to > librte_ether and returns response back to the kernelspace. > > Library does: > 1) Trigger Linux virtual interface creation > 2) Initialize the netlink socket c

[dpdk-dev] [PATCH v2 6/7] app/testpmd: changed example to parse options from cfg file

2017-06-26 Thread Jacek Piasecki
From: Kuba Kozak This patch shows how to pass arguments to application using config.ini file. If a --cfgfile-path option is passed into commandline non EAL section, then the file is loaded and used by app. If a config.ini file is present in current working directory, and no --cfgfile-path opti

[dpdk-dev] [PATCH v2 7/7] app/testpmd: add parse arguments from JSON config file

2017-06-26 Thread Jacek Piasecki
From: Kuba Kozak This patch shows usage of Jansson library to parse application arguments from JSON config file. https://github.com/akheron/jansson If a --cfgfile-path option is passed into commandline non EAL section, then the disired JSON file is loaded and used by app. In case when JSON doe

Re: [dpdk-dev] [PATCH v8 0/4] Userspace Network Control Interface (UNCI)

2017-06-26 Thread Bruce Richardson
On Wed, Jun 21, 2017 at 12:06:47PM +0100, Ferruh Yigit wrote: > Userspace Network Control Interface (UNCI), (formerly KCP). > > When a NIC bound to the DPDK, it can't be controlled by Linux tools. > > This patch creates a virtual network interface for each DPDK port, > initial target is to get so

Re: [dpdk-dev] [PATCH 1/6] service cores: header and implementation

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 10:06:14 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH 1/6] service cores: header and impl

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault

2017-06-26 Thread Nélio Laranjeiro
On Sun, Jun 25, 2017 at 07:55:01AM +, Shachar Beiser wrote: > Missing room in flow allocation to store the drop specification. > Changing flow without storing the change in rte_flow. > Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier") > > Signed-off-by: Shachar Bei

Re: [dpdk-dev] [PATCH 2/6] service cores: coremask parsing

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 10:06:15 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH 2/6] service cores: coremask parsin

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Sergio Gonzalez Monroy
On 26/06/2017 10:39, Thomas Monjalon wrote: 26/06/2017 11:14, Sergio Gonzalez Monroy: On 23/06/2017 14:02, Thomas Monjalon wrote: 22/06/2017 17:15, Sergio Gonzalez Monroy: Just fyi, the summary line should be lowercase apart from acronyms (DPDK guidelines). On 11/05/2017 02:56, Tonghao Zhang

Re: [dpdk-dev] [PATCH 3/6] service cores: EAL init changes

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 10:06:16 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH 3/6] service cores: EAL init change

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault

2017-06-26 Thread Ferruh Yigit
On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: > On Sun, Jun 25, 2017 at 07:55:01AM +, Shachar Beiser wrote: >> Missing room in flow allocation to store the drop specification. >> Changing flow without storing the change in rte_flow. >> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in ha

Re: [dpdk-dev] [PATCH 5/6] service core: add unit tests

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 10:06:18 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH 5/6] service core: add unit tests >

Re: [dpdk-dev] [PATCH v2 1/7] cfgfile: remove EAL dependency

2017-06-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jacek Piasecki > Sent: Monday, June 26, 2017 11:59 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Jain, Deepak K > ; Piasecki, JacekX > Subject: [dpdk-dev] [PATCH v2 1/7] cfgfile: remove EAL dependency > > This

Re: [dpdk-dev] [PATCH v2 15/16] net/i40e/base: extend processing of DDP

2017-06-26 Thread Ferruh Yigit
On 6/26/2017 10:48 AM, Jingjing Wu wrote: > This patch adds extended processing of DDP packages: > - Execution of adminq command sections to support AQ-depended profiles, >for example, for programming cloud filters types. > - Ability to write a profile without registering it in the list of >

Re: [dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Mon, 19 Jun 2017 15:35:22 +0530 > From: Jerin Jacob > To: "Rao, Nikhil" > CC: Gage Eads , dev@dpdk.org, tho...@monjalon.net, > bruce.richard...@intel.com, harry.van.haa...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, narender.vang...@intel.com > S

Re: [dpdk-dev] [PATCH v2 16/16] net/i40e: use set switch aq instead of register setting

2017-06-26 Thread Ferruh Yigit
On 6/26/2017 10:48 AM, Jingjing Wu wrote: > TPID can be set by set_switch_config aq, change the TPID setting > by set_switch_config on new FW release. Hi Jingjing, Since you will already send a new version of the patchset, can you please address the checkpatch warnings in this patch too? Thanks,

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault

2017-06-26 Thread Nélio Laranjeiro
On Mon, Jun 26, 2017 at 01:55:33PM +0100, Ferruh Yigit wrote: > On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: > > On Sun, Jun 25, 2017 at 07:55:01AM +, Shachar Beiser wrote: > >> Missing room in flow allocation to store the drop specification. > >> Changing flow without storing the change in rt

Re: [dpdk-dev] [PATCH 6/6] service cores: enable event/sw with service

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Fri, 23 Jun 2017 10:06:19 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > keith.wi...@intel.com, bruce.richard...@intel.com, Harry van Haaren > > Subject: [PATCH 6/6] service cores: enable event/sw

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault

2017-06-26 Thread Ferruh Yigit
On 6/26/2017 2:41 PM, Nélio Laranjeiro wrote: > On Mon, Jun 26, 2017 at 01:55:33PM +0100, Ferruh Yigit wrote: >> On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: >>> On Sun, Jun 25, 2017 at 07:55:01AM +, Shachar Beiser wrote: Missing room in flow allocation to store the drop specification. >>

Re: [dpdk-dev] [PATCH v7 0/2] Balanced allocation of hugepages

2017-06-26 Thread Jerin Jacob
-Original Message- > Date: Mon, 26 Jun 2017 13:44:08 +0300 > From: Ilya Maximets > To: dev@dpdk.org, Sergio Gonzalez Monroy > , Thomas Monjalon , > Bruce Richardson > CC: David Marchand , Heetae Ahn > , Yuanhan Liu , Jianfeng > Tan , Neil Horman , Yulong > Pei , Jerin Jacob > Subjec

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault

2017-06-26 Thread Ferruh Yigit
On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: > On Sun, Jun 25, 2017 at 07:55:01AM +, Shachar Beiser wrote: >> Missing room in flow allocation to store the drop specification. >> Changing flow without storing the change in rte_flow. >> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in ha

Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it.

2017-06-26 Thread Thomas Monjalon
26/06/2017 14:50, Sergio Gonzalez Monroy: > On 26/06/2017 10:39, Thomas Monjalon wrote: > > 26/06/2017 11:14, Sergio Gonzalez Monroy: > >> On 23/06/2017 14:02, Thomas Monjalon wrote: > >>> 22/06/2017 17:15, Sergio Gonzalez Monroy: > Just fyi, the summary line should be lowercase apart from acr

[dpdk-dev] Inconsistent behaviour of rte_eth_dev_set_mtu API between ixgbe and i40e

2017-06-26 Thread Kavanagh, Mark B
Hi, In OvS-DPDK, we support single mbuf-segment jumbo frames. To date, we've supported this by creating a mempool containing mbufs of size "~user-defined-MTU", and configured the NIC by crafting an rte_eth_conf structure with jumbo_frame mode enabled, and the device's max_rx_pkt_len set accord

[dpdk-dev] [PATCH v2 0/3] next-eventdev: evendev pipeline sample app

2017-06-26 Thread David Hunt
This patchset introduces a sample application that demonstrates a pipeline model for packet processing. Running this sample app with 17.05-rc2 or later is recommended. Changes in patch v2: * Re-work based on comments on mailing list. No major functional changes. * Checkpatch cleanup of a coupl

[dpdk-dev] [PATCH v2 1/3] examples/eventdev_pipeline: added sample app

2017-06-26 Thread David Hunt
From: Harry van Haaren This commit adds a sample app for the eventdev library. The app has been tested with DPDK 17.05-rc2, hence this release (or later) is recommended. The sample app showcases a pipeline processing use-case, with event scheduling and processing defined per stage. The applicati

[dpdk-dev] [PATCH v2 2/3] doc: add eventdev pipeline to sample app ug

2017-06-26 Thread David Hunt
From: Harry van Haaren Add a new entry in the sample app user-guides, which details the working of the eventdev_pipeline. Signed-off-by: Harry van Haaren Signed-off-by: David Hunt --- doc/guides/sample_app_ug/eventdev_pipeline.rst | 188 + doc/guides/sample_app_ug/inde

[dpdk-dev] [PATCH v2 3/3] doc: add eventdev library to programmers guide

2017-06-26 Thread David Hunt
From: Harry van Haaren This commit adds an entry in the programmers guide explaining the eventdev library. The rte_event struct, queues and ports are explained. An API walktrough of a simple two stage atomic pipeline provides the reader with a step by step overview of the expected usage of the E

Re: [dpdk-dev] [PATCH v3 1/8] mk: use make silent flag to print HTML doc version

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of lbocc...@brocade.com > Sent: Friday, June 23, 2017 7:42 PM > To: dev@dpdk.org > Cc: Luca Boccassi > Subject: [dpdk-dev] [PATCH v3 1/8] mk: use make silent flag to print HTML > doc version > > From: Luca Boccassi

Re: [dpdk-dev] [PATCH v3 2/8] mk: fix excluding .doctrees when installing docs

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of lbocc...@brocade.com > Sent: Friday, June 23, 2017 7:42 PM > To: dev@dpdk.org > Cc: Luca Boccassi > Subject: [dpdk-dev] [PATCH v3 2/8] mk: fix excluding .doctrees when > installing docs > > From: Luca Boccassi

Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: added sample app

2017-06-26 Thread Hunt, David
Hi Jerin, I'm assisting Harry on the sample app, and have just pushed up a V2 patch based on your feedback. I've addressed most of your suggestions, comments below. There may still a couple of outstanding questions that need further discussion. Regards, Dave On 10/5/2017 3:12 PM, Jerin Jaco

Re: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in examples.dox

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of lbocc...@brocade.com > Sent: Friday, June 23, 2017 7:42 PM > To: dev@dpdk.org > Cc: Luca Boccassi > Subject: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in examples.dox > > From: Luca Boccassi > > The res

Re: [dpdk-dev] [PATCH v3 5/8] mk: sort headers before wildcard inclusion

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of lbocc...@brocade.com > Sent: Friday, June 23, 2017 7:42 PM > To: dev@dpdk.org > Cc: Luca Boccassi > Subject: [dpdk-dev] [PATCH v3 5/8] mk: sort headers before wildcard > inclusion > > From: Luca Boccassi > > I

Re: [dpdk-dev] [PATCH] (pkgtgen-dpdk) doc: Fix broken link to pktgen-dpdk documentation

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of McCullough, Harrison > Sent: Friday, June 23, 2017 6:07 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] (pkgtgen-dpdk) doc: Fix broken link to pktgen- > dpdk documentation > > The `setup.sh` script is now loc

Re: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in examples.dox

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Monday, June 26, 2017 3:49 PM > To: lbocc...@brocade.com; dev@dpdk.org > Cc: Luca Boccassi > Subject: Re: [dpdk-dev] [PATCH v3 4/8] mk: sort list of files in > examples.dox > > > > > ---

Re: [dpdk-dev] [PATCH v5 19/19] eal: change whitelist / blacklist command line doc

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Wednesday, June 21, 2017 12:36 AM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v5 19/19] eal: change whitelist / blacklist > command line doc > > The use of these comma

Re: [dpdk-dev] [PATCH] doc: fix typos in virtio howto guide

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Monday, June 19, 2017 11:14 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH] doc: fix typos in virtio howto guide > > Signed-off-by: Yong Wang Acked-by: John McNamara

Re: [dpdk-dev] [PATCH 06/10] doc: change the dpaa2 helper repository path

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Thursday, June 22, 2017 2:57 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; shreyansh.j...@nxp.com > Subject: [dpdk-dev] [PATCH 06/10] doc: change the dpaa2 helper repository > path > > changi

Re: [dpdk-dev] [PATCH] doc: update ipv4 multicast sample application guide

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Friday, June 23, 2017 8:24 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: update ipv4 multicast sample application > guide > > Add a note to indicate that only first four ports ca

Re: [dpdk-dev] [PATCH] doc: fix a typo in sample apps guide.

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, June 17, 2017 9:14 PM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] doc: fix a typo in sample apps guide. > > This patch fixes a trivial typo in the sample apps

[dpdk-dev] [PATCH] net/bond: change link status check to no-wait

2017-06-26 Thread Declan Doherty
In the 802.3ad periodic callback function the link status of all slaves is checked using rte_eth_link_get function. Depending on the slave device this function can block for up to 9 seconds and therefore could cause issues with the LACP Daemon state machine and control patches handling. This patch

Re: [dpdk-dev] [PATCH] bond: update the NTT flag when partner's state changes from slow to fast

2017-06-26 Thread Declan Doherty
On 22/05/2017 7:40 AM, zhangsha (A) wrote: From eddd395916002cca1c2f83a01d368b95295f2adf Mon Sep 17 00:00:00 2001 From: Sha Zhang Date: Mon, 22 May 2017 14:33:37 +0800 Subject: [PATCH] bond: update the NTT flag when partner's state changes from slow to fast According to the standard, state mach

Re: [dpdk-dev] [PATCH v5 01/12] bus: add bus iterator to find a bus

2017-06-26 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:21:59AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > This helper allows to iterate over all registered buses and find one > matching data used as parameter. > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_ve

Re: [dpdk-dev] [PATCH v7 0/2] Balanced allocation of hugepages

2017-06-26 Thread Sergio Gonzalez Monroy
On 26/06/2017 11:44, Ilya Maximets wrote: So, what do you think about this version? Is it ready for merge or some additional changes needed? I was just having another look at it and was wondering if we should re-set the old policy instead of DEFAULT? Also noticed that we probably should incr

Re: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output

2017-06-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gabriel Carrillo > Sent: Tuesday, June 6, 2017 5:43 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: add new targets to "make help" output > > Commit aafaea3d3b70 ("devtools:

Re: [dpdk-dev] [PATCH] eventdev: add producer enqueue hint

2017-06-26 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, June 12, 2017 6:46 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Van Haaren, Harry > ; hemant.agra...@nxp.com; Eads, Gage > ; nipun.gu...@nxp.com; Vangati, Narender > ; Rao, Nikhil ; Jerin J

Re: [dpdk-dev] [PATCH v5 02/12] bus: add device iterator method

2017-06-26 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:00AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/include/rte_bus.h | 19 +++ > lib/librte_eal/common/include/rte_dev.h | 21 + > 2 files

Re: [dpdk-dev] [PATCH v5 03/12] bus: add helper to find which bus holds a device

2017-06-26 Thread Bruce Richardson
On Mon, Jun 26, 2017 at 02:22:01AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c | 25 > + > li

[dpdk-dev] [PATCH v2 0/2] net/softnic: sw fall-back for traffic management

2017-06-26 Thread Jasvinder Singh
The SoftNIC PMD provides SW fall-back option for the NICs not supporting the Traffic Management (TM) features. SoftNIC PMD overview: - The SW fall-back is based on the existing librte_sched DPDK library. - The TM-agnostic port (the underlay device) is wrapped into a TM-aware softnic port (the o

[dpdk-dev] [PATCH v2 1/2] net/softnic: add softnic PMD for traffic management

2017-06-26 Thread Jasvinder Singh
Softnic PMD implements HQoS scheduler as software fallback solution for the hardware with no HQoS support. When application call rx function on this device, it simply invokes underlay device rx function. On the egress path, softnic tx function enqueues the packets into QoS scheduler. The packets ar

[dpdk-dev] [PATCH v2 2/2] net/softnic: add traffic management ops

2017-06-26 Thread Jasvinder Singh
The traffic management specific functions of the softnic driver are supplied through set of pointers contained in the generic structure of type 'rte_tm_ops'. These functions help to build and manage the hierarchical QoS scheduler for traffic management. Signed-off-by: Jasvinder Singh Signed-off-b

[dpdk-dev] [PATCH v2 00/27] Crypto operation restructuring

2017-06-26 Thread Pablo de Lara
This patchset attempts to correct and improve the current crypto operation (rte_crypto_op) and symmetric crypto operation (rte_crypto_sym_op) structures, shrinking their sizes to fit both structures into two 64-byte cache lines (with extra space for the IV and other user data) as one of the goals.

[dpdk-dev] [PATCH v2 01/27] cryptodev: move session type to generic crypto op

2017-06-26 Thread Pablo de Lara
Session type (operation with or without session) is not something specific to symmetric operations. Therefore, the variable is moved to the generic crypto operation structure. Signed-off-by: Pablo de Lara --- doc/guides/prog_guide/cryptodev_lib.rst | 21 ++--- doc/guides/rel_

[dpdk-dev] [PATCH v2 03/27] cryptodev: remove opaque data pointer in crypto op

2017-06-26 Thread Pablo de Lara
Storing a pointer to the user data is unnecessary, since user can store additional data, after the crypto operation. Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_test_latency.c | 36 +-- doc/guides/prog_guide/cryptodev_lib.rst | 3 +-- doc/guides/rel

[dpdk-dev] [PATCH v2 02/27] cryptodev: replace enums with 1-byte variables

2017-06-26 Thread Pablo de Lara
Instead of storing some crypto operation flags, such as operation status, as enumerations, store them as uint8_t, for memory efficiency. Also, reserve extra 5 bytes in the crypto operation, for future additions. Signed-off-by: Pablo de Lara --- doc/guides/rel_notes/release_17_08.rst | 3 +++ li

[dpdk-dev] [PATCH v2 05/27] cryptodev: remove useless alignment

2017-06-26 Thread Pablo de Lara
rte_crypto_op and rte_crypto_sym_op structures were marked as cache aligned. However, since these structures are always initialized in a mempool, this alignment is useless, since the mempool forces the alignment of its objects. Signed-off-by: Pablo de Lara --- lib/librte_cryptodev/rte_crypto.h

[dpdk-dev] [PATCH v2 04/27] cryptodev: do not store pointer to op specific params

2017-06-26 Thread Pablo de Lara
Instead of storing a pointer to operation specific parameters, such as symmetric crypto parameters, use a zero-length array, to mark that these parameters will be stored after the generic crypto operation structure, which was already assumed in the code, reducing the memory footprint of the crypto

[dpdk-dev] [PATCH v2 06/27] cryptodev: add crypto op helper macros

2017-06-26 Thread Pablo de Lara
In order to facilitate the access to the private data, after the crypto operation, two new macros have been implemented: - rte_crypto_op_ctod_offset(c,t,o), which returns a pointer to "o" bytes after the start of the crypto operation (rte_crypto_op) - rte_crypto_op_ctophys_offset(c, o), which

[dpdk-dev] [PATCH v2 07/27] crypto/qat: fix KASUMI authentication

2017-06-26 Thread Pablo de Lara
QAT PMD was assuming that cipher IV was always prepended, before the input buffer, but it is not necessary to have it there, only the auth IV (COUNT and FRESH) and the input buffer needs to be contiguous, with the direction bit after. If AAD (containing the IV for authentication) is not just befor

[dpdk-dev] [PATCH v2 08/27] test/crypto: move IV to crypto op private data

2017-06-26 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- tes

[dpdk-dev] [PATCH v2 09/27] test/crypto-perf: move IV to crypto op private data

2017-06-26 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- tes

[dpdk-dev] [PATCH v2 10/27] app/crypto-perf: move IV to crypto op private data

2017-06-26 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- app

[dpdk-dev] [PATCH v2 11/27] examples/l2fwd-crypto: move IV to crypto op private data

2017-06-26 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- exa

[dpdk-dev] [PATCH v2 12/27] examples/ipsec-secgw: move IV to crypto op private data

2017-06-26 Thread Pablo de Lara
Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- exa

  1   2   >