[dpdk-dev] [PATCH 0/2] fix flow rules copy functions

2017-07-24 Thread Matan Azrad
some issue seen when trying to test failsafe plug out and in. Matan Azrad (2): app/testpmd: fix flow rule copy functions ethdev: fix flow rule copy functions app/test-pmd/config.c | 16 ++-- lib/librte_ether/rte_flow.c | 16 ++-- 2 files changed, 20 insertions(

[dpdk-dev] [PATCH 1/2] app/testpmd: fix flow rule copy functions

2017-07-24 Thread Matan Azrad
The corrupted code checks only RAW flow item type special case for returning its size but doesn't deal with any other flow item type and returns 0 for all the others. This bug leaves the flow descriptor empty for non RAW types. The fix takes the correct size to any regular types from appropriate

[dpdk-dev] [PATCH 2/2] ethdev: fix flow rule copy functions

2017-07-24 Thread Matan Azrad
The corrupted code checks only RAW flow item type special case for returning its size but doesn't deal with any other flow item type and returns 0 for all the others. This bug leaves the flow descriptor empty for non RAW types. The fix takes the correct size to any regular types from appropriate

[dpdk-dev] [PATCH 1/4] doc: update release notes for DPAA2 eventdev

2017-07-24 Thread Hemant Agrawal
announcing the addition of DPAA2 eventdev Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_17_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index 6083c71..e2de82b 100644 --- a/doc/gui

[dpdk-dev] [PATCH 2/4] doc: update the dpaa2 eventdev extra paths

2017-07-24 Thread Hemant Agrawal
The DPDK helper for NXP devices is not dpdk-extras Signed-off-by: Hemant Agrawal --- doc/guides/eventdevs/dpaa2.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/eventdevs/dpaa2.rst b/doc/guides/eventdevs/dpaa2.rst index 3382d59..0970b26 100644 --- a/doc/gu

[dpdk-dev] [PATCH 4/4] doc: update dpaa2 PMD document

2017-07-24 Thread Hemant Agrawal
added features, limitations and copyright. Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa2.rst | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst index 6965121..207962e 100644 --- a/doc/guides/nics/d

[dpdk-dev] [PATCH 3/4] doc: update release notes for dpaa2 changes

2017-07-24 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_17_08.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index e2de82b..7235c39 100644 --- a/doc/guides/rel_notes/release_17_08.rst +++ b/d

[dpdk-dev] [PATCH] crypto/dpaa2_sec: reduce init log prints

2017-07-24 Thread Hemant Agrawal
From: Shreyansh Jain Signed-off-by: Shreyansh Jain --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index f422937..03f5050 100644 ---

[dpdk-dev] [PATCH] net/dpaa2: enable Tx congestion state check

2017-07-24 Thread Hemant Agrawal
For larger packet size congestion is observed on Tx Queues. This patch enables Tx Queue congestion state check support. If congested, try to resend the packet few times. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- drivers/net/dpaa2/dpaa

[dpdk-dev] [PATCH v5 02/12] eal/pci: export match function

2017-07-24 Thread Santosh Shukla
Export rte_pci_match() function as it needed in the followup patch. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Maxime Coquelin --- v4 --> v5: - Changed DPDK_17.08 to DPDK_17.11 in _version.map lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++ lib/librte_eal

[dpdk-dev] [PATCH v5 01/12] eal/pci: introduce PCI driver iova as va flag

2017-07-24 Thread Santosh Shukla
Introducing RTE_PCI_DRV_IOVA_AS_VA flag. Flag used when driver needs to operate in iova=va mode. Why driver need iova=va mapping? On NPU style co-processors like Octeontx, the buffer recycling has been done in HW, unlike SW model. Here is the data flow: 1) On control path, Fill the HW mempool wit

[dpdk-dev] [PATCH v5 00/12] Infrastructure to detect iova mapping on the bus

2017-07-24 Thread Santosh Shukla
v5: Introducing RTE_PCI_DRV_IOVA_AS_VA flag for autodetection of iova va mapping. If a PCI driver demand for IOVA as VA scheme then the driver can add it in the PCI driver registration function. Algorithm to select IOVA as VA for PCI bus case: 0. If no device bound then return with RTE_IOVA_D

[dpdk-dev] [PATCH v5 03/12] eal/pci: get iommu class

2017-07-24 Thread Santosh Shukla
Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- v3 --> v4: - Created a separate patch per suggestion fro

[dpdk-dev] [PATCH v5 07/12] eal: introduce iova mode helper api

2017-07-24 Thread Santosh Shukla
Introducing rte_eal_iova_mode() helper API. This API used by non-eal library for detecting iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/bsdapp/eal/rte_eal_version

[dpdk-dev] [PATCH v5 08/12] linuxapp/eal: auto detect iova mode

2017-07-24 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Auto detect iova mapping mode, based on the result of rte_bus_scan_iommu_class. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/linuxapp/eal/eal.c | 15 +-- 1 file

[dpdk-dev] [PATCH v5 05/12] linuxapp/eal_pci: get iommu class

2017-07-24 Thread Santosh Shukla
Get iommu class of PCI device on the bus and returns preferred iova mapping mode for that bus. Algorithm for iova scheme selection for PCI bus: 0. If no device bound then return with RTE_IOVA_DC mapping mode, else goto 1). 1. Look for device attached to vfio kdrv and has .drv_flag set to RTE_PCI_D

[dpdk-dev] [PATCH v5 06/12] bus: get iommu class

2017-07-24 Thread Santosh Shukla
API(rte_bus_get_iommu_class) helps to automatically detect and select appropriate iova mapping scheme for iommu capable device on that bus. Algorithm for iova scheme selection for bus: 0. Iterate through bus_list. 1. Collect each bus iova mode value and update into 'mode' var. 2. Mode selection sc

[dpdk-dev] [PATCH v5 04/12] bsdapp/eal_pci: get iommu class

2017-07-24 Thread Santosh Shukla
Bsdapp case returns default iova mode. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- v3 --> v4: - Removed rte_pci_get_iommu_class api declaration. Now that sits into separate patch [03/12]. lib/librte_eal/bsdapp/eal/eal_pci.c | 10 ++

[dpdk-dev] [PATCH v5 11/12] linuxapp/eal_memory: honor iova mode in virt2phy

2017-07-24 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/

[dpdk-dev] [PATCH v5 10/12] linuxapp/eal_vfio: honor iova mode before mapping

2017-07-24 Thread Santosh Shukla
Check iova mode and accordingly map iova to pa or va. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_

[dpdk-dev] [PATCH v5 09/12] bsdapp/eal: auto detect iova mapping mode

2017-07-24 Thread Santosh Shukla
- Moving late bus scanning to up..just after eal_parsing. - Mapping mode would be default for bsdapp. It supports only one pass through mode (RTE_KDRV_NIC_UIO) Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/bsdapp/eal/eal.c | 15 +

[dpdk-dev] [PATCH v5 12/12] eal/rte_malloc: honor iova mode in virt2phy

2017-07-24 Thread Santosh Shukla
Check iova mode and accordingly return phy addr. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- lib/librte_eal/common/rte_malloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/li

[dpdk-dev] query related to DPDK QOS-SCHED sample application

2017-07-24 Thread Mahesh Ishwar Mathad
Hi Team, System Configuration: NIC: Intel Corporation 82576 (IGB) NUMA node:1 Kernel version :4.5.0 DPDK version: 16.07.2 I am trying to execute DPDK QOS-SCHED application: ./build/qos_sched -c 0x0e -n 1 -- --pfc "0,1,3,2" --cfg ./profile.cfg EAL: Detected 4 lcore(s) PMD: bnxt_rte_pmd_init()

Re: [dpdk-dev] [PATCH 0/2] fix flow rules copy functions

2017-07-24 Thread Adrien Mazarguil
On Mon, Jul 24, 2017 at 10:10:20AM +0300, Matan Azrad wrote: > some issue seen when trying to test failsafe plug out and in. > > Matan Azrad (2): > app/testpmd: fix flow rule copy functions > ethdev: fix flow rule copy functions > > app/test-pmd/config.c | 16 ++-- > lib/l

[dpdk-dev] [PATCH v2] net/i40e: fix sync phy type by adding retry

2017-07-24 Thread David Hunt
Some phy's take longer than others to come up. Add a retry to give more phy's a chance to come up before returning an error. Fixes: 2209c3e2c275 ("net/i40e: avoid PCI probing failure when using bogus SFP") Signed-off-by: David Hunt --- drivers/net/i40e/i40e_ethdev.c | 12 +--- 1 file ch

[dpdk-dev] [PATCH v2] eal: disable NUMA related warnings on non-NUMA systems

2017-07-24 Thread Hemant Agrawal
Disable multiple NUMA warnings on non-NUMA systems. "EAL: eal_parse_sysfs_value(): cannot open sysfs value /sys/bus/pci/devices/:00:00.0/numa_node EAL: numa_node is invalid or not present. Set it 0 as default EAL: cannot open /proc/self/numa_maps, consider that all memory is in

[dpdk-dev] [PATCH v3] eal: disable NUMA related warnings on non-NUMA systems

2017-07-24 Thread Hemant Agrawal
Disable multiple NUMA warnings on non-NUMA systems. "EAL: eal_parse_sysfs_value(): cannot open sysfs value /sys/bus/pci/devices/:00:00.0/numa_node EAL: numa_node is invalid or not present. Set it 0 as default EAL: cannot open /proc/self/numa_maps, consider that all memory is in

Re: [dpdk-dev] [PATCH v5] ether: add support for vtune task tracing

2017-07-24 Thread Jerin Jacob
-Original Message- > Date: Wed, 19 Jul 2017 11:54:45 +0300 > From: ilia.kura...@intel.com > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, konstantin.anan...@intel.com, > keith.wi...@intel.com, dmitry.gala...@intel.com, Ilia Kurakin > > Subject: [PATCH v5] ether: add support for

[dpdk-dev] next techboard meeting (26th, July)

2017-07-24 Thread Hemant Agrawal
Hi all, The next meeting of the techboard will happen on IRC #dpdk-board, at 3pm UTC, this Wednesday 26th of July. Any topics to be referred to the tech board for discussion at that meeting should be emailed to techbo...@dpdk.org The agenda is: 0. Release blocking issues? 1. stra

Re: [dpdk-dev] [PATCH v3] eal: disable NUMA related warnings on non-NUMA systems

2017-07-24 Thread Jerin Jacob
-Original Message- > Date: Mon, 24 Jul 2017 14:50:27 +0530 > From: Hemant Agrawal > To: tho...@monjalon.net > CC: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] eal: disable NUMA related warnings on > non-NUMA systems > X-Mailer: git-send-email 2.7.4 > > Disable multiple NUMA warnings on

Re: [dpdk-dev] query related to DPDK QOS-SCHED sample application

2017-07-24 Thread Dumitrescu, Cristian
Hi Mahesh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mahesh Ishwar > Mathad > Sent: Monday, July 24, 2017 9:55 AM > To: users ; dev@dpdk.org > Subject: [dpdk-dev] query related to DPDK QOS-SCHED sample application > > Hi Team, > > System Configuration: >

[dpdk-dev] [INTERNAL REVIEW 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-07-24 Thread Rasesh Mody
This patch modifies the recovery flow to allow ongoing PCIe transactions to be completed. To achieve this, the load sequence is changed such that the "final_cleanup" notification is sent while the FID_enable is cleared. This change ensures that the chip cleanup actions takes place from previous dri

[dpdk-dev] [INTERNAL REVIEW 2/7] net/qede: fix incorrect queue id for 100G

2017-07-24 Thread Rasesh Mody
From: Harish Patil 'commit 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")' introduced a regression where default RSS configuration is incorrect in the case of 100G mode. Currently we are passing absolute queue ids while creating RX/TX queues. But in CMT mode we need to provide

[dpdk-dev] [INTERNAL REVIEW 4/7] net/qede: fix inner L3/L4 chksum offload for tunnel frames

2017-07-24 Thread Rasesh Mody
From: Harish Patil Force recalculation of tunnel L4 chksum when inner L3/L4 chskum gets updated due to HW offload. Fixes: aab21617502e ("net/qede: add Tx offloads for MPLS-in-UDP packets") Signed-off-by: Harish Patil --- drivers/net/qede/qede_rxtx.c | 29 ++--- 1 fil

[dpdk-dev] [INTERNAL REVIEW 3/7] net/qede/base: fix for adapter specific stats

2017-07-24 Thread Rasesh Mody
Handle different MAC statistic fields between two chip variants by reading the MAC counters from the adapter suitable statistics bins. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c |7 +- drivers/net/qede/base/ecore_dev_ap

[dpdk-dev] [INTERNAL REVIEW 6/7] net/qede: fix chip details print

2017-07-24 Thread Rasesh Mody
Fix chip details printed as part of print adapter info Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_e

[dpdk-dev] [INTERNAL REVIEW 5/7] doc: list NPAR as supported feature in qede

2017-07-24 Thread Rasesh Mody
From: Shahed Shaikh Existing qede PMD code already supports NPAR feature. So adding this in "Supported Features" section after testing it with latest DPDK. Also, add myself to the list of maintainers of qede PMD Signed-off-by: Shahed Shaikh --- MAINTAINERS |1 + doc/guides/ni

[dpdk-dev] [INTERNAL REVIEW 7/7] net/qede: update PMD version 2.5.2.1

2017-07-24 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index 510b6e2..a3254b1 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethde

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Nipun Gupta
Hi Nikhil/Edas, > -Original Message- > From: Nikhil Rao [mailto:nikhil@intel.com] > Sent: Friday, July 07, 2017 3:23 > To: jerin.ja...@caviumnetworks.com > Cc: gage.e...@intel.com; dev@dpdk.org; tho...@monjalon.net; > bruce.richard...@intel.com; harry.van.haa...@intel.com; Hemant Agraw

Re: [dpdk-dev] [INTERNAL REVIEW 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-07-24 Thread Mody, Rasesh
Please ignore this patch-set with 'INTERNAL REVIEW' subject prefix. Sending a follow up with proper subject prefix. Thanks! -Rasesh > -Original Message- > From: Rasesh Mody [mailto:rasesh.m...@cavium.com] > Sent: Monday, July 24, 2017 3:10 AM > To: dev@dpdk.org > Cc: Mody, Rasesh ; Dept-

[dpdk-dev] [PATCH 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-07-24 Thread Rasesh Mody
This patch modifies the recovery flow to allow ongoing PCIe transactions to be completed. To achieve this, the load sequence is changed such that the "final_cleanup" notification is sent while the FID_enable is cleared. This change ensures that the chip cleanup actions takes place from previous dri

[dpdk-dev] [PATCH 2/7] net/qede: fix incorrect queue id for 100G

2017-07-24 Thread Rasesh Mody
From: Harish Patil 'commit 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")' introduced a regression where default RSS configuration is incorrect in the case of 100G mode. Currently we are passing absolute queue ids while creating RX/TX queues. But in CMT mode we need to provide

[dpdk-dev] [PATCH 3/7] net/qede/base: fix for adapter specific stats

2017-07-24 Thread Rasesh Mody
Handle different MAC statistic fields between two chip variants by reading the MAC counters from the adapter suitable statistics bins. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c |7 +- drivers/net/qede/base/ecore_dev_ap

[dpdk-dev] [PATCH 5/7] doc: list NPAR as supported feature in qede

2017-07-24 Thread Rasesh Mody
From: Shahed Shaikh Existing qede PMD code already supports NPAR feature. So adding this in "Supported Features" section after testing it with latest DPDK. Also, add myself to the list of maintainers of qede PMD Signed-off-by: Shahed Shaikh --- MAINTAINERS |1 + doc/guides/ni

[dpdk-dev] [PATCH 4/7] net/qede: fix inner L3/L4 chksum offload for tunnel frames

2017-07-24 Thread Rasesh Mody
From: Harish Patil Force recalculation of tunnel L4 chksum when inner L3/L4 chskum gets updated due to HW offload. Fixes: aab21617502e ("net/qede: add Tx offloads for MPLS-in-UDP packets") Signed-off-by: Harish Patil --- drivers/net/qede/qede_rxtx.c | 29 ++--- 1 fil

[dpdk-dev] [PATCH 6/7] net/qede: fix chip details print

2017-07-24 Thread Rasesh Mody
Fix chip details printed as part of print adapter info Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_e

[dpdk-dev] [PATCH 7/7] net/qede: update PMD version 2.5.2.1

2017-07-24 Thread Rasesh Mody
Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index 510b6e2..a3254b1 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethde

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Jerin Jacob
-Original Message- > Date: Mon, 24 Jul 2017 10:10:50 + > From: Nipun Gupta > To: Nikhil Rao , "jerin.ja...@caviumnetworks.com" > > CC: "gage.e...@intel.com" , "dev@dpdk.org" > , "tho...@monjalon.net" , > "bruce.richard...@intel.com" , > "harry.van.haa...@intel.com" , Hemant Agrawa

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-24 Thread Herbert Guan
"poly128_t" is an arm data type provided in GCC later than 4.9.0. But it's not defined in earlier GCC. To make the code get compiled with early version GCC, this patch is provided. In this way, "rte_v128u8_t" do is having the same definition as poly128_t in this patch. But in GCC 4.9.0 and l

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Van Haaren, Harry
> From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Sent: Monday, July 24, 2017 11:11 AM > To: Rao, Nikhil ; jerin.ja...@caviumnetworks.com > Cc: Eads, Gage ; dev@dpdk.org; tho...@monjalon.net; > Richardson, Bruce > ; Van Haaren, Harry ; > Hemant > Agrawal ; Vangati, Narender > ; Gujjar, > Abhina

[dpdk-dev] [PATCH] net/i40e: fix PF notify issue when VF not up

2017-07-24 Thread Xiaoyun Li
This patch modifies PF notify error to warning when not starting up VF. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- drivers/net/i40e/i40e_pf.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i4

Re: [dpdk-dev] query related to DPDK QOS-SCHED sample application

2017-07-24 Thread Mahesh Ishwar Mathad
Hi Team, Thanks for the response, $ ./build/qos_sched -c 0xe -n 4 -- --pfc "0,1,3,2" --cfg "profile.cfg"EAL: Detected 4 lcore(s) PMD: bnxt_rte_pmd_init() called for (null) EAL: PCI device :01:00.0 on NUMA socket -1 EAL: probe driver: 8086:10c9 rte_igb_pmd EAL: PCI device :01:00.1 on NU

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, July 24, 2017 15:54 > To: Nipun Gupta > Cc: Nikhil Rao ; gage.e...@intel.com; dev@dpdk.org; > tho...@monjalon.net; bruce.richard...@intel.com; > harry.van.haa...@intel.com; Hemant Agrawal ; >

Re: [dpdk-dev] [PATCH] mlx5: fix get link settings call for speed and duplex values

2017-07-24 Thread Nélio Laranjeiro
Hi Gowrishankar, Sorry, it took me a little time to test this patch, nice catch. Small format points, the title should be net/mlx5 and there is a complain with checkpatch see below. On Tue, Jul 18, 2017 at 11:58:34AM +0530, Gowrishankar wrote: > From: Gowrishankar Muthukrishnan > > mlx5 pmd do

Re: [dpdk-dev] [PATCH v5] ether: add support for vtune task tracing

2017-07-24 Thread Kurakin, Ilia
Hi Jerin, Thank you for your comments. > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, July 24, 2017 12:28 PM > To: Kurakin, Ilia > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Wiles, Keith ; Galanov, Dmitry > > Subject: Re: [PATCH v5] ether

[dpdk-dev] [PATCH 3/3] doc: update mlx guides

2017-07-24 Thread Shahaf Shuler
Update the guides with: * New supported features. * Supported OFED and FW versions. * Quick start guide. * Performance tunning guide. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/nics/mlx4.rst | 161 +++--- doc/guides/nics/mlx5.r

[dpdk-dev] [PATCH 1/3] doc: update mlx5 supported features

2017-07-24 Thread Shahaf Shuler
Supported features which were not included: * ARMv8 * Extended stats Not supported features which were wrongly included: * Inner L3 checksum * Inner L4 checksum Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 4 ++-- 1 file changed, 2 ins

[dpdk-dev] [PATCH 2/3] doc: update release notes for mlx driver

2017-07-24 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- doc/guides/rel_notes/release_17_08.rst | 126 + 1 file changed, 126 insertions(+) diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst index ef51ebbe8..cdb156962

[dpdk-dev] [PATCH] eventdev: add dev id checks to config functions

2017-07-24 Thread Harry van Haaren
This commit adds checks to verify the device ID is valid to the following functions. Given that they are non-datapath, these checks are always performed. This commit also updates the event/octeontx test-cases to have the correct signed-ness, as the API has changes this change is required in order

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Nipun Gupta
> -Original Message- > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > Sent: Monday, July 24, 2017 16:03 > To: Nipun Gupta ; Rao, Nikhil ; > jerin.ja...@caviumnetworks.com > Cc: Eads, Gage ; dev@dpdk.org; > tho...@monjalon.net; Richardson, Bruce ; > Hemant Agrawal ; Vangati,

Re: [dpdk-dev] Issue with TX of Jumbo frames on 10G interfaces ONLY

2017-07-24 Thread Bruce Richardson
On Fri, Jul 14, 2017 at 05:38:45AM +, Yeddula, Avinash wrote: > Hi All, > > In order to support Jumbo frames for our application, I made the below > changes. The intention, here is to use "linked-mbufs instead of using > 1 single 9k MBUF". > > With the below changes, I'm able to send/receive

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-24 Thread Van Haaren, Harry
> From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Sent: Monday, July 24, 2017 2:07 PM > To: Van Haaren, Harry ; Rao, Nikhil > ; > jerin.ja...@caviumnetworks.com > Cc: Eads, Gage ; dev@dpdk.org; tho...@monjalon.net; > Richardson, Bruce > ; Hemant Agrawal ; > Vangati, Narender > ; Gujjar, Abhinan

Re: [dpdk-dev] Question on mlx5 PMD txq memory registration

2017-07-24 Thread Bruce Richardson
On Sun, Jul 23, 2017 at 12:03:41PM +0300, Sagi Grimberg wrote: > > > > I don't understand the security argument. Its completely private to the > > > driver. anything under librte is equivalent to an OS wrt networking, so I > > > fail to > > > see what is the security feature your talking about. >

[dpdk-dev] [PATCH v2 0/2] fix flow rules copy functions

2017-07-24 Thread Matan Azrad
some issue seen when trying to test failsafe plug out and in. The V2 fixes some checkpatch issues. Matan Azrad (2): app/testpmd: fix flow rule copy functions ethdev: fix flow rule copy functions app/test-pmd/config.c | 16 ++-- lib/librte_ether/rte_flow.c | 16 ++-

[dpdk-dev] [PATCH v2 1/2] app/testpmd: fix flow rule copy functions

2017-07-24 Thread Matan Azrad
The corrupted code checks only RAW flow item type special case for returning its size but doesn't deal with any other flow item type and returns 0 for all the others. This bug leaves the flow descriptor empty for non RAW types. The fix takes the correct size to any regular types from appropriate

[dpdk-dev] [PATCH v2 2/2] ethdev: fix flow rule copy functions

2017-07-24 Thread Matan Azrad
The corrupted code checks only RAW flow item type special case for returning its size but doesn't deal with any other flow item type and returns 0 for all the others. This bug leaves the flow descriptor empty for non RAW types. The fix takes the correct size to any regular types from appropriate

[dpdk-dev] [PATCH] net/vmxnet3: restore correct filtering

2017-07-24 Thread Charles (Chas) Williams
We should only restore shadow_vfta when hw_vlan_filter is active. Otherwise, we should restore the previous filtering behavior. Fixes: f003fc383487("vmxnet3: enable vlan filtering") Cc: sta...@dpdk.org Signed-off-by: Chas Williams --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 - 1 file chang

[dpdk-dev] [PATCH v2] net/mlx5: fix get link settings call for speed and duplex values

2017-07-24 Thread Gowrishankar
From: Gowrishankar Muthukrishnan ETHTOOL_GLINKSETTINGS ioctl call in mlx5 pmd returns inconsistent link status due to which any application relying on it would not function correctly. Changes: v2 - coding style update Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") Cc: sta.

Re: [dpdk-dev] [INTERNAL REVIEW 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-07-24 Thread Thomas Monjalon
24/07/2017 13:18, Mody, Rasesh: > Please ignore this patch-set with 'INTERNAL REVIEW' subject prefix. Sending a > follow up with proper subject prefix. Please update patchwork as well.

Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias

2017-07-24 Thread Adrien Mazarguil
On Wed, Jul 12, 2017 at 02:38:52PM +0100, Harry van Haaren wrote: > With this commit, the correct method to use git fixline to indicate > a fix of a previous commit has changed. The new rules require the > author of the original code that is being fixed to be on CC. > > The logic behind this impro

Re: [dpdk-dev] Issue with TX of Jumbo frames on 10G interfaces ONLY

2017-07-24 Thread Yeddula, Avinash
Thanks Bruce for replying, I kind of figured it out. Like you mentioned I do see some performance dip with linked-mbufs, I believe this expected, is there a way to minimize the impact, all I need is to enable linked-mbuf". Thanks -Avinash -Original Message- From: Bruce Richardson [mai

[dpdk-dev] [PATCH] cryptodev: fix session init return value

2017-07-24 Thread Pablo de Lara
When calling rte_cryptodev_sym_session_init(), if there was an error, it returned -1, regardless the error. Instead, it should return the specific error code, which can be valuable for the application for error handling. Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") Signe

[dpdk-dev] [PATCH v6] ether: add support for vtune task tracing

2017-07-24 Thread ilia . kurakin
From: Ilia Kurakin The patch adds tracing of loop iterations that yielded no packets in a DPDK application. It is using ITT task API: https://software.intel.com/en-us/node/544206 We suppose the flow of using this tracing would assume the user has ITT lib and header on machine and re-build DP

[dpdk-dev] [PATCH] doc: add how to enable empty cycles profiling

2017-07-24 Thread ilia . kurakin
From: Ilia Kurakin Programmer's Guide: section "Profile Your Application" updated with how to enable ITT tasks collection. Based on patch: http://dpdk.org/dev/patchwork/patch/27158/ Signed-off-by: Ilia Kurakin --- doc/guides/prog_guide/profile_app.rst | 34 ++ 1

[dpdk-dev] [PATCH] net/i40e: new API to add VF MAC address from PF

2017-07-24 Thread Wenzhuo Lu
Currently, on i40e the parameter 'pool' of API rte_eth_dev_mac_addr_add means the VMDq pool, not VF. So, it's wrong to use it to set the VF MAC address. As this API is also used by the VMDq example, ideally we need a parameter to tell the pool is VMDq or VF. But it's hard to change it because of th

[dpdk-dev] [pktgen PATCH] remove Intel from DPDK name

2017-07-24 Thread Thomas Monjalon
DPDK is not called Intel DPDK since 2014. It can be renamed in DPDK pktgen as well. Signed-off-by: Thomas Monjalon --- README.md | 18 +- changelog.txt | 4 ++-- docs/source/commands.rst| 12 ++-- docs/source/running.rst | 2 +- g

[dpdk-dev] [PATCH] net/ixgbe: add support of 2.5G and 5G

2017-07-24 Thread Wei Dai
This patch adds support of 2.5G and 5G link on some new ixgbe devices. It is based on 17.08-rc2 . Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_type.h | 2 ++ drivers/net/ixgbe/ixgbe_ethdev.c| 8 2 files changed, 10 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_

[dpdk-dev] [PATCH 1/2] net/bnxt: check current vlan anti spoof value before setting new value

2017-07-24 Thread Ajit Khaparde
If the current VLAN anti spoof setting is same as the new value, the firmware can return an error. Call the HWRM command to update the new setting if it is different from the current value. Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") Signed-off-by: Ajit Khaparde ---

[dpdk-dev] [PATCH 0/2] fixes to bnxt PMD

2017-07-24 Thread Ajit Khaparde
Couple of fixes to the bnxt PMD against the dpdk-next-net tree. Please apply. net/bnxt: check current vlan anti spoof value before setting new value net/bnxt: fix arguments to _rte_eth_dev_callback_process drivers/net/bnxt/rte_pmd_bnxt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[dpdk-dev] [PATCH 2/2] net/bnxt: fix arguments to _rte_eth_dev_callback_process

2017-07-24 Thread Ajit Khaparde
The callback arguments to _rte_eth_dev_callback_process() are swapped. Fix them. Fixes: d6af1a13d7a1 ("ethdev: add return values to callback process API") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] doubts on dpdk qos-sched sample application

2017-07-24 Thread Mahesh Ishwar Mathad
Hi Team, $ ./build/qos_sched -c 0xe -n 4 -- --pfc "0,1,3,2" --cfg "profile.cfg"EAL: Detected 4 lcore(s) PMD: bnxt_rte_pmd_init() called for (null) EAL: PCI device :01:00.0 on NUMA socket -1 EAL: probe driver: 8086:10c9 rte_igb_pmd EAL: PCI device :01:00.1 on NUMA socket -1 EAL: prob