Hi Matan,
thanks
On Sun, Aug 27, 2017 at 10:23:14AM +0300, Matan Azrad wrote:
> The corrupted code used wrongly snprintf return value as the
> number of characters actually copied, in spite of the meanning
> is the number of characters which would be generated for the
> given input.
>
> It cause
Hi Cristian,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard
> Sent: Wednesday, August 23, 2017 3:32 PM
> To: Dumitrescu, Cristian ; dev@dpdk.org;
> Yigit, Ferruh ; Ananyev, Konstantin
> ; adrien.mazarg...@6wind.com
> Subject: Re: [dpdk-dev] [
On 7/18/2017 3:56 PM, Dai, Wei wrote:
> HI, Srini
>
> Sorry for late response.
>
> As I have pointed out that Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw)
> unconditionally,
> I think it is no need to call hw->phy.ops.init(hw) after
> ixgbe_pf_reset_hw(hw) at least for 82599.
> I also thi
On 8/17/2017 7:33 PM, Wenzhuo Lu wrote:
> In testpmd, it's wrong to call rte_eth_dev_mac_addr_add to add a MAC
> address for a VF. Because this API is used to add a MAC address for
> a VMDq pool.
>
> v3:
> - split the patch to 2. One for adding a new API. One for fixing the CLI.
>
> Wenzhuo Lu (
Hi Raslan,
Redoing the review with the remarks from Thomas in mind.
On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> Added hotplug in testpmd, to be able to test hotplug function
> in the PMD's.
>
> Signed-off-by: Raslan Darawsheh
> ---
> app/test-pmd/cmdline.c | 44
On 8/28/2017 10:55 AM, Gaëtan Rivet wrote:
> Hi Raslan,
>
> Redoing the review with the remarks from Thomas in mind.
>
> On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
>> Added hotplug in testpmd, to be able to test hotplug function
>> in the PMD's.
>>
>> Signed-off-by: Raslan
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Wednesday, August 23, 2017 12:17 PM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org; Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH] service: add new
> `rte_service_lcore_count_services` API
>
> This new API returns the number of
28/08/2017 07:00, Jerin Jacob:
> From: Shahaf Shuler
> > Friday, August 25, 2017 1:32 PM, Jerin Jacob:
> > > >
> > > > The new API does not have an equivalent for the below Tx flags:
> > > >
> > > > * ETH_TXQ_FLAGS_NOREFCOUNT
> > > > * ETH_TXQ_FLAGS_NOMULTMEMP
> > >
> > > IMO, it make sense to ke
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Wednesday, August 23, 2017 4:10 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry ; Pavan Nikhilesh
>
> Subject: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.
>
> This API can be used to test if an lcore(EA
28/08/2017 12:30, Ferruh Yigit:
> On 8/28/2017 10:55 AM, Gaëtan Rivet wrote:
> > Hi Raslan,
> >
> > Redoing the review with the remarks from Thomas in mind.
> >
> > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> >> Added hotplug in testpmd, to be able to test hotplug function
On Mon, Aug 28, 2017 at 10:55:05AM +, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> > Sent: Wednesday, August 23, 2017 12:17 PM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org; Pavan Nikhilesh
> > Subject: [dpdk-dev] [PATCH] service: add new
> >
On Mon, Aug 28, 2017 at 11:30:47AM +0100, Ferruh Yigit wrote:
> On 8/28/2017 10:55 AM, Gaëtan Rivet wrote:
> > Hi Raslan,
> >
> > Redoing the review with the remarks from Thomas in mind.
> >
> > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> >> Added hotplug in testpmd, to be
On 8/24/2017 2:17 PM, Nélio Laranjeiro wrote:
> On Wed, Aug 23, 2017 at 10:10:58AM +0300, Shahaf Shuler wrote:
>> Extend debug logs verbosity by printing the full completion with error
>> along with the entire txq in case of error. For the Rx case no logs were
>> added since such errors are counted
On 8/23/2017 9:44 AM, Beilei Xing wrote:
> Since there's no specific version number to distinguish
> DPDK pf and Linux kernel pf, DPDK vf won't recognize if
> host is DPDK pf or kernel pf. The specific virtual channel
> commands for DPDK pf and code of DPDK version can be deleted.
Is DPDK i40e PF
On 8/23/2017 9:49 AM, Rongqiang XIE wrote:
> In enic_alloc_consistent() function, if the value mze malloc
> faile, !mze is true, free the rz should return NULL.
>
> Signed-off-by: Rongqiang XIE
Reviewed-by: Ferruh Yigit
On Mon, Aug 28, 2017 at 10:59:51AM +, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> > Sent: Wednesday, August 23, 2017 4:10 PM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry ; Pavan Nikhilesh
> >
> > Subject: [dpdk-dev] [PATCH] eal: added new `rt
On 8/28/2017 12:31 PM, Ferruh Yigit wrote:
> On 8/23/2017 9:49 AM, Rongqiang XIE wrote:
>> In enic_alloc_consistent() function, if the value mze malloc
>> faile, !mze is true, free the rz should return NULL.
>>
>> Signed-off-by: Rongqiang XIE
>
> Reviewed-by: Ferruh Yigit
Applied to dpdk-next-n
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann
> Sent: Monday, August 28, 2017 2:31 PM
> To: Bie, Tiwei
> Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com;
> Wang, Zhihong ; Yang, Zhiyong
>
> Subject: Re: [dpdk-dev] [PATCH] vh
On 8/24/2017 2:57 AM, Jingjing Wu wrote:
> As no matter the PF host driver is DPDK or other kernel drivers,
> they are sharing the same virtchnnl interfaces to communicate to
> VFs. To follow the generic interface, DPDK PF need to set ITR
> index according to the rxitr_idx from virtchnnl instead of
On 8/23/2017 2:05 PM, Gaetan Rivet wrote:
> The sub_device iterator macro should follow the general gist of the
> tailq API for an easier understanding and safer use.
>
> Once the loop has finished, the iterator should be set to NULL.
> If no sub_device was iterated upon, the iterator should still
On 8/25/2017 7:43 PM, Patil, Harish wrote:
<..>>
> Subject: [dpdk-dev] [PATCH] net/qede:fix the bug about pointer params
> may NULL
>
>> In function qede_rss_reta_update(),the pointer params returned from
>> call to function rte_zmalloc() may be NULL and will be dereferenced.
>> So, should judg
From: Ivan Malov
efx_rx_scale_tbl_set() takes the number of entries in the scale table
to be set, not the size of the table in bytes; currently this bug does
not make any damage since the size argument is used to wrap the loop
on the input table when filling in an MCDI request in case if the tabl
From: Mark Spender
This supports filters which match all unicast or multicast
inner frames in VXLAN, GENEVE, or NVGRE packets.
(Additional fields to match on can be added easily.)
Signed-off-by: Mark Spender
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andrew Lee
---
drivers/net/sfc/base/ef1
checkpatches.sh generates errors etc because of a bit different
coding style in base driver.
Andrew Rybchenko (1):
net/sfc/base: provide information about supported tunnels
Mark Spender (3):
net/sfc/base: use proper MCDI command for encap. filters
net/sfc/base: support filters for encapsula
VXLAN/NVGRE (and Geneve) support is available on SFN8xxx with
full-feature firmware variant running.
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andrew Lee
Reviewed-by: Andy Moreton
Reviewed-by: Mark Spender
---
drivers/net/sfc/base/ef10_nic.c | 10 ++
drivers/net/sfc/base/efx.h
From: Mark Spender
MC_CMD_FILTER_OP_IN_EXT is needed to set filters for encapsulated packets.
Signed-off-by: Mark Spender
Signed-off-by: Andrew Rybchenko
Reviewed-by: Andrew Lee
Reviewed-by: Andy Moreton
---
drivers/net/sfc/base/ef10_filter.c | 112 ++---
1 f
From: Mark Spender
On Medford, with full-featured firmware running, encapsulated
packets may not be delivered unless filters are inserted for
them, as ordinary filters are not applied to encapsulated
packets. So filters for encapsulated packets need to be
inserted for each class of encapsulated p
On 8/25/2017 8:21 PM, David Harton wrote:
> Some compilers generate warnings for duplicate symbols for the
> set of filter lists current defined in ixgbe_ethdev.h.
> This commits moves the defintion and declaration to the source
> file that actually uses them and provides a function to
> initialize
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Monday, August 28, 2017 12:33 PM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore`
> API.
>
> On Mon, Aug 28, 2017 at 10:59:51AM +, Van
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Wednesday, August 23, 2017 2:13 PM
> To: Ananyev, Konstantin ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the
> new offloads API
>
> Wednesday, August 23, 2017 3:2
This patchet showcases the definition and usage of the rte_security
APIs described in the RFC v1 sent earlier.
The data path and configuration path is similar to what was proposed in
version 1. However, rte_security_configure API is removed, as it looked
redundant.
Also the rte_security.x files
On Monday 28 August 2017 07:53 PM, Narayana Prasad Athreya wrote:
This patchet showcases the definition and usage of the rte_security
APIs described in the RFC v1 sent earlier.
The data path and configuration path is similar to what was proposed in
version 1. However, rte_security_configure AP
On Sun, Aug 27, 2017 at 06:54:35PM +0530, Jerin Jacob wrote:
> Hi All,
>
> The next meeting of the tech board will happen on IRC #dpdk-board, at 3pm
> UTC, on 29th of August(Tuesday)
>
> Agenda:
>
> 1) Discussion on next tree requests
> a) Next tree for IPSec offload and maintainership
> http:/
On Mon, Aug 28, 2017 at 01:49:37PM +, Van Haaren, Harry wrote:
> > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com]
> > Sent: Monday, August 28, 2017 12:33 PM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com]
> Sent: Monday, August 28, 2017 4:10 PM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore`
> API.
>
> On Mon, Aug 28,
On Mon, Aug 28, 2017 at 03:24:06PM +, Van Haaren, Harry wrote:
>
>
> > -Original Message-
> > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com]
> > Sent: Monday, August 28, 2017 4:10 PM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev]
Hi Jeff,
On Tue, Aug 22, 2017 at 02:56:04PM +, Guo, Jia wrote:
> a. about uevent mechanism
>
> As we know, uevent is come from the kobject of the kernel side, every kobject
> would have its own uevent, and a sysfs folder identify a kobject,
> such as cpu,usb,pci,pci-express,virio, these bus
This new API returns the number of services that are running on a specific
service core. It allows an application to decide which service core to run
a new service on.
Signed-off-by: Pavan Nikhilesh
---
v2 changes:
- reword the commit title according to the check-git-log.sh
- modify return t
On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> NFP PMD has just had support for SRIOV VFs until now. This patchset adds
> support for the PF, but just for being used as another DPDK port. No VF
> management is added by now.
>
> NFP is a programmable device and it supports virtual NICs (vNICs) thr
On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> Using NSPU interface for fw upload. Firmware file needs to be
> installed in specific path inside system firmware directory.
>
> NSPU buffer is used for writing the firmware before sending the
> command.
>
> Signed-off-by: Alejandro Lucero
<...>
On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> Firmware has symbols helping to configure things like number of
> PF ports, vNIC BARs addresses inside NFP memories, or ethernet
> link state. Different firmware apps have different things to map
> and likely different internal NFP addresses to use.
>
On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> Configuring the NFP PMD for using the PF requires access through the
> NSPU interface for device configuration. This patch adds a specific probe
> function for the PF which uses the NSPU interface. Just basic NSPU access
> is done by now reading the N
On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> A NFP PF PCI devices can have PCI ID 4000 or 6000.
>
> Signed-off-by: Alejandro Lucero
<...>
> @@ -2682,6 +2682,10 @@ static int nfp_pf_pci_probe(struct rte_pci_driver
> *pci_drv __rte_unused,
> static const struct rte_pci_id pci_id_nfp_pf_net_m
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Monday, August 28, 2017 9:27 AM
> To: David Harton (dharton) ;
> konstantin.anan...@intel.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: eliminate duplicate filterlist
> symbols
>
> On 8/25
Hi Radu,
Few questions comments from me below.
Thanks
Konstantin
>
> Signed-off-by: Radu Nicolau
> ---
> config/common_base | 1 +
> drivers/net/ixgbe/Makefile | 4 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 +
> drivers/net/ixgbe/ixgbe_ethdev.h
Any log messages during bus initialization maybeZZ lost because
the bus registration constructor is called befor the logging constructor.
Fixes: a97725791eec ("bus: introduce bus abstraction")
Signed-off-by: Stephen Hemminger
---
Patch against current but also should be applied to stable.
lib/l
Any log messages during bus initialization maybe lost because
the bus registration constructor is called before the logging constructor.
Fixes: a97725791eec ("bus: introduce bus abstraction")
Signed-off-by: Stephen Hemminger
---
v2 - fix commit message typos
lib/librte_eal/common/eal_common_log
If mmap fails, it will return the value MAP_FAILED. Checking for this
return code allows us to properly identify mmap failures and report
them as such to the calling function.
Signed-off-by: Seth Howell
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++
1 file changed, 2 insertions(+)
diff --
If mmap fails, it will return the value MAP_FAILED. Checking for this
return code allows us to properly identify mmap failures and report
them as such to the calling function.
Signed-off-by: Seth Howell
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++
1 file changed, 2 insertions(+)
diff --
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Monday, August 28, 2017 7:22 PM
> To: Xing, Beilei ; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/3] remove unused code of DPDK version
>
> On 8/23/2017 9:44 AM, Beilei Xing wrote:
> > Since there's no sp
From: root
This feature enable queue regions configuration for RSS in PF/VF,
so that different traffic classes or different packet
classification types can be separated to different queues in
different queue regions.This patch can set queue region range,
it include queue number in a region and th
There is a bug in vf clear xstats command, it do not
record the statics data in offset struct member.So, vf
need to keep record of xstats data from pf and update
the statics according to offset.
Fixes: da61cd0849766 ("i40evf: add extended stats")
Signed-off-by: Wei Zhao
---
app/test-pmd/config.
Add a new support of reset stats statics in vf port.
Signed-off-by: Wei Zhao
---
drivers/net/i40e/i40e_ethdev_vf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index cded04a..fd6b2d7 100644
--- a/drivers/net/i40e/i40e_
From: root
There is a bug in vf clear xstats command, it do not
record the statics data in offset struct member.So, vf
need to keep record of xstats data from pf and update
the statics according to offset.
Fixes: da61cd0849766 ("i40evf: add extended stats")
Signed-off-by: Wei Zhao
---
Change
From: root
Add a new support of reset stats statics in vf port.
Signed-off-by: Wei Zhao
---
drivers/net/i40e/i40e_ethdev_vf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index d7a9c03..393 100644
--- a/drivers/n
There is a bug in vf clear xstats command, it do not
record the statics data in offset struct member.So, vf
need to keep record of xstats data from pf and update
the statics according to offset.
Fixes: da61cd0849766 ("i40evf: add extended stats")
Signed-off-by: Wei Zhao
---
Changes in v2:
fi
Add a new support of reset stats statics in vf port.
Signed-off-by: Wei Zhao
---
drivers/net/i40e/i40e_ethdev_vf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index d7a9c03..393 100644
--- a/drivers/net/i40e/i40e_
In function cmd_show_bonding_config_parsed() used number represent
the bond type,in order more detailed,add bond type description
otherwise we may confused about the number type.
And also,the primary port just use in mode active backup and tlb,
so,when the mode is active backup or tlb show the prim
i40e HW date is gotten wrongly in i40evf_dev_stop
function, it may cause device can't be stopped.
This patch is to fix the issue.
Fixes: 185993420249 ("net/i40e: fix VF add/del MAC")
Cc: sta...@dpdk.org
Signed-off-by: Beilei Xing
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 i
> -Original Message-
> From: Yigit, Ferruh
> Sent: Monday, August 28, 2017 8:28 PM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Zhang, Helin ; Lu, Wenzhuo
> ; Chen, Jing D ;
> sta...@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix itr setting in PF
>
> On 8/24/2017
Hi Jens,
> I'm still not sure I understand the use case. So just for my
> understanding: users need to distinct between "the device is going away
> temporarily, keep the connection" and "we're shutting down for good", is
> that it?
Yes, exactly.
> Maybe it's just me or maybe it means you could e
Monday, August 28, 2017 5:12 PM, Ananyev, Konstantin:
> > Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin:
> > >
> > > Hmm, and why we would need to reconfigure our device in the middle
> > > of rx queue setup?
> >
> > The reason is the old Rx offloads API is configured on device configure.
62 matches
Mail list logo
