Re: [dpdk-dev] [PATCH v3] examples/l3fwd: pass flow arguments when start app

2017-10-24 Thread Thomas Monjalon
24/10/2017 03:38, Wu, Jingjing: > From: Li, Xiaoyun > > To make the performance can be tuning on different NICs or platforms. We > > need to make the number of descriptors as arguments when starting l3fwd > > application. > > > > Signed-off-by: Xiaoyun Li > > Agree to this change. > > Reviewed-

Re: [dpdk-dev] [PATCH] app/testpmd: refine xstats show

2017-10-24 Thread Ferruh Yigit
On 10/23/2017 4:47 PM, Ferruh Yigit wrote: > On 10/20/2017 10:09 AM, Elza Mathew wrote: >> When using "show port xstats all" command to show xstats, the output >> is usually too long to obtain what you really want, especially when >> multi-queue is enabled. >> >> Added an option to set whether zero

Re: [dpdk-dev] [PATCH] power: fix power example app response time

2017-10-24 Thread Thomas Monjalon
23/10/2017 17:21, David Hunt: > A delay in the loop waiting for the virtio-serial commands in the > vm_power_manager app was causing a lag in the response time. This was > set to 1 second, and has now been changed to 1ms. > > Fixes: f14791a8126e ("examples/vm_power_mgr: add policy to channels") >

Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help text

2017-10-24 Thread Thomas Monjalon
19/10/2017 14:27, Hunt, David: > Hi Marko, > > On 19/10/2017 10:34 AM, Marko Kovacevic wrote: > > From: David Hunt > > > > Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI") > > > > Signed-off-by: Marko Kovacevic > > --- > Thanks for the patch. Looks good to me. > > Acked

Re: [dpdk-dev] [PATCH] examples/qos_sched: fix uninitialized scalar variable

2017-10-24 Thread Thomas Monjalon
24/10/2017 11:09, Jasvinder Singh: > Fix problem with uninitialized rx/tx deferred_start flags of the struct > rte_eth_rxconf/txconf by initializing with 0 value (deferred start of > the rx/tx queues is turned off). This setting allows device rx/tx > queues to start with rte_eth_dev_start(). > > C

Re: [dpdk-dev] [PATCH 1/2] examples/kni: check if pci_dev isn't NULL before using it

2017-10-24 Thread Thomas Monjalon
21/10/2017 02:26, Ferruh Yigit: > On 10/16/2017 4:45 AM, Tomasz Duszynski wrote: > > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev > > dereferencing it will cause segmentation fault as by default > > it's set to NULL in rte_eth_dev_info_get(). > > > > Signed-off-by: Tomasz Duszynsk

Re: [dpdk-dev] [PATCH v2 00/15] bnxt patchset

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:19 PM, Ajit Khaparde wrote: > The first patch updates the HWRM API to version 1.8.2 > Some of the patches fix issues reported by Coverity. > > Please apply. > > Ajit Khaparde (15): > net/bnxt: update HWRM to 1.8.2 > net/bnxt: fix tx_offload capability > net/bnxt: fix rx_offl

Re: [dpdk-dev] [PATCH v2 01/15] net/bnxt: update HWRM to 1.8.2

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 2:19 PM, Ajit Khaparde wrote: > This patch updates the HWRM API to version 1.8.2 > > Signed-off-by: Ajit Khaparde > -- > v1->v2: Trim down the patch size to avoid unused structures > --- > drivers/net/bnxt/bnxt_ethdev.c |2 +- > drivers/net/bnxt/bnxt_hwrm.c |

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 3:35 AM, Gaetan Rivet wrote: > This flag was deprecated in the previous release, and this is its removal. This change was in wait list, but it would be much more better if not received just before rc2, but in early stages in the release, at worst before rc1. Although patch looks goo

[dpdk-dev] [PATCH v2] net/mlx5: fix Tx doorbell memory barrier

2017-10-24 Thread Yongseok Koh
Configuring UAR as IO-mapped makes maximum throughput decline by noticeable amount. If UAR is configured as write-combining register, a write memory barrier is needed on ringing a doorbell. rte_wmb() is mostly effective when the size of a burst is comparatively small. Revert the register back to wr

[dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Wu, Xiaoban
Dear All, I am trying to run some DPDK applications with the QL45611H NIC, however I am facing a problem I don't know how to solve, could somebody please help me? I am using ubuntu 14.04 with kernel 3.16 on a Dell server. I downloaded the driver and firmware from http://driverdownloads.qlogi

Re: [dpdk-dev] [PATCH] mbuf: rename deprecated VLAN flags

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 9:09 AM, Olivier MATZ wrote: > Hi Ferruh, > > On Mon, Oct 23, 2017 at 07:08:25PM -0700, Ferruh Yigit wrote: >> On 10/23/2017 5:16 AM, Olivier Matz wrote: >>> PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. >>> As explained in [1], these flags were kept to let the appl

Re: [dpdk-dev] [PATCH 0/3] Break dependency on bus infrastructure*

2017-10-24 Thread Gaëtan Rivet
Hello Declan, On Fri, Oct 20, 2017 at 10:21:10PM +0100, Declan Doherty wrote: > This patch set breaks the dependency of the cryptodev library on both the > virtual and PCI device infrastructure. > > It introduces new bus independent crypto PMD driver assist functions for > parsing initialisatio

Re: [dpdk-dev] [PATCH 1/3] cryptodev: add new APIs to assist PMD initialisation

2017-10-24 Thread Gaëtan Rivet
On Tue, Oct 24, 2017 at 04:09:19PM +0200, Tomasz Duszynski wrote: > Hi Declan, > > Some comments inline. > > On Fri, Oct 20, 2017 at 10:21:11PM +0100, Declan Doherty wrote: > > Adds new PMD assist functions which are bus independent for driver to > > create and destroy new device instances. > > >

Re: [dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Patil, Harish
-Original Message- From: dev on behalf of "Wu, Xiaoban" Date: Tuesday, October 24, 2017 at 5:36 PM To: "us...@dpdk.org" , "dev@dpdk.org" Subject: [dpdk-dev] problem with Qlogic NIC QL45611H >Dear All, > > >I am trying to run some DPDK applications with the QL45611H NIC, however >I am fa

Re: [dpdk-dev] [PATCH] net/liquidio: add support for promiscuous mode

2017-10-24 Thread Ferruh Yigit
On 10/11/2017 12:47 AM, Shijith Thotton wrote: > From: Intiyaz Basha > > Signed-off-by: Intiyaz Basha > Signed-off-by: Shijith Thotton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 0/3] RFC: implement VF reset for i40e, e1000 and ixgbe

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 6:16 AM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > These patches were originally sent by Wenzhuo Lu: > > http://dpdk.org/dev/patchwork/patch/14009/ > http://dpdk.org/dev/patchwork/patch/14010/ > http://dpdk.org/dev/patchwork/patch/14011/ > > The current rte_eth_dev_

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Ferruh Yigit
On 9/19/2017 5:45 AM, Pascal Mazon wrote: > Hi, > > The patch looks mainly ok to me. > > I'll put some comments inline. > > On 18/09/2017 20:47, Ferruh Yigit wrote: >> From: Vipin Varghese >> >> tap speed argument is not working without generating any error. > Can you describe the error, paste

Re: [dpdk-dev] problem with Qlogic NIC QL45611H

2017-10-24 Thread Wu, Xiaoban
Dear Harish, Thanks very much for your reply and help. I have never enabled IOMMU. I have enabled those two flags and run the program again, now the error message is: EAL: PCI device :82:00.0 on NUMA socket 1 EAL: probe driver: 1077:1644 net_qede [qede_common_dev_init:2198(82:00.0:dpdk-

[dpdk-dev] [PATCH] maintainers: update for fm10k

2017-10-24 Thread Xiao Wang
Signed-off-by: Xiao Wang --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c072d03..01a344e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,7 +393,8 @@ F: doc/guides/nics/intel_vf.rst F: doc/guides/nics/features/i40e*.ini

Re: [dpdk-dev] [PATCH] maintainers: update for fm10k

2017-10-24 Thread Zhang, Helin
> -Original Message- > From: Wang, Xiao W > Sent: Wednesday, October 25, 2017 7:23 PM > To: Zhang, Helin > Cc: Yigit, Ferruh; dev@dpdk.org; Wang, Xiao W > Subject: [PATCH] maintainers: update for fm10k > > Signed-off-by: Xiao Wang Acked-by: Helin Zhang > --- > MAINTAINERS | 3 ++- >

[dpdk-dev] [PATCH] doc: more clarification for i40e 16 bytes desc

2017-10-24 Thread Wenzhuo Lu
The description of i40e 16 bytes descriptor is not clear enough. Add more details. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index a0946e6..e0237a8 100

[dpdk-dev] [PATCH v5] ethdev: allow returning error on VLAN offload ops

2017-10-24 Thread Ferruh Yigit
From: David Harton Some devices may not support or fail setting VLAN offload configuration based on dynamic circumstances so the vlan_offload_set_t vector is modified to return an int so the caller can determine success or not. rte_eth_dev_set_vlan_offload is updated to return the value provided

Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build system

2017-10-24 Thread Hemant Agrawal
On 10/24/2017 7:45 PM, Akhil Goyal wrote: Signed-off-by: Akhil Goyal Signed-off-by: Radu Nicolau --- config/common_base | 5 + lib/Makefile | 5 + mk/rte.app.mk | 1 + 3 files changed, 11 insertions(+) diff --git a/config/common_base b/config/common_base index d9471e8..f5d0

Re: [dpdk-dev] [PATCH v5 06/11] ethdev: support security APIs

2017-10-24 Thread Hemant Agrawal
On 10/24/2017 7:45 PM, Akhil Goyal wrote: From: Declan Doherty rte_flow_action type and ethdev updated to support rte_security sessions for crypto offload to ethernet device. Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel Signed-off-by: Radu Nicolau Signed-off-by: Declan Dohert

Re: [dpdk-dev] [PATCH v5 01/11] lib/rte_security: add security library

2017-10-24 Thread Hemant Agrawal
Hi Akhil, Some minor comments. On 10/24/2017 7:45 PM, Akhil Goyal wrote: rte_security library provides APIs for security session create/free for protocol offload or offloaded crypto operation to ethernet device. Signed-off-by: Akhil Goyal Signed-off-by: Boris Pismenny Signed-off-by:

Re: [dpdk-dev] [PATCH 2/3] cryptodev: break dependency on virtual device bus

2017-10-24 Thread Tomasz Duszynski
On Fri, Oct 20, 2017 at 10:21:12PM +0100, Declan Doherty wrote: > Removes any dependency of librte_cryptodev on the virtual device > infrastructure code and removes the functions which were virtual > device specific. > > Updates all virtual PMDs to remove dependencies on rte_cryptodev_vdev.h > and

Re: [dpdk-dev] Issue with MTU/max_rx_pkt_len handling by different NICs/PMD drivers

2017-10-24 Thread Nitin Katiyar
Thanks Stephen for reply. I agree that it is advisory for device driver. I am also reporting the issue with PMD dpdk drivers. We see different behavior with 2 NICs which we have tested with OVS-DPDK (i.e. Fortville and Niantic). And by looking at other PMD driver, there could be issue with other

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-10-24 Thread Pascal Mazon
On 25/10/2017 03:24, Ferruh Yigit wrote: > On 9/19/2017 5:45 AM, Pascal Mazon wrote: >> Hi, >> >> The patch looks mainly ok to me. >> >> I'll put some comments inline. >> >> On 18/09/2017 20:47, Ferruh Yigit wrote: >>> From: Vipin Varghese >>> >>> tap speed argument is not working without generati

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-24 Thread Li, Xiaoyun
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Li, Xiaoyun > Sent: Friday, October 20, 2017 09:03 > To: Richardson, Bruce ; Thomas Monjalon > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Lu, Wenzhuo ; Zhang, Helin > ; ophi...@mellanox.com > Subject: Re: [dpd

<    1   2   3