Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-16 Thread Olivier Matz
Hi Xueming, On Tue, Jan 09, 2018 at 10:11:08PM +0800, Xueming Li wrote: > This patch introduce new DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM_TSO flag for > devices that support tunnel agnostic TX checksum and tso offloading. > > Checksum offset and TSO header length are calculated based on mbuf > inner le

Re: [dpdk-dev] [PATCH v2] member: fix memory leak on error

2018-01-16 Thread Wang, Yipeng1
>-Original Message- >From: Burakov, Anatoly >Sent: Friday, January 12, 2018 9:23 AM >To: dev@dpdk.org >Cc: Wang, Yipeng1 ; Gobriel, Sameh > >Subject: [PATCH v2] member: fix memory leak on error > >rte_member may have allocated a tailq entry or setum before failure, >so free them. > >Fixes:

Re: [dpdk-dev] [PATCH] crypto/dpaa: retire fq while detaching with session

2018-01-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Tuesday, January 16, 2018 11:08 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Alok Makhariya > Subject: [PATCH] crypto/dpaa: retire fq while detaching with session > > F

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update incremental checksum

2018-01-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, January 16, 2018 10:56 AM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: RE: [PATCH] examples/ipsec-secgw: update incremental checksum ... > > Acked-by: Radu Nicolau Applie

Re: [dpdk-dev] [PATCH v3 3/8] net/failsafe: support probed sub-devices getting

2018-01-16 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Tuesday, January 16, 2018 6:54 PM > On Tue, Jan 16, 2018 at 04:15:36PM +, Matan Azrad wrote: > > Hi Gaetan > > > > From: Gaëtan Rivet, Tuesday, January 16, 2018 4:41 PM > > > On Tue, Jan 16, 2018 at 12:27:57PM +, Matan Azrad wrote: > > > > Hi Gaetan > > > > >

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-16 Thread Rybalchenko, Kirill
Hi Adrien, after some discussion we found that change I've done in Mellanox PMD is not really necessary: size of array flow_types_mask[] is still 1 and the loop in patch for (i = 0; i < RTE_FLOW_MASK_ARRAY_SIZE; i++) info->flow_types_mask[i] = 0ULL; will work exactly in the same way a

Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-16 Thread Xueming(Steven) Li
Hi Olivier, Thanks for looking into this. > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, January 17, 2018 1:10 AM > To: Xueming(Steven) Li > Cc: Thomas Monjalon ; Jingjing Wu > ; Yongseok Koh ; Shahaf Shuler > ; dev@dpdk.org > Subject: Re: [P

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2018-01-16 Thread Thomas Monjalon
16/01/2018 17:01, Ferruh Yigit: > On 1/16/2018 11:49 AM, Ferruh Yigit wrote: > > On 1/16/2018 11:27 AM, Thomas Monjalon wrote: > >> 21/12/2017 19:10, Ferruh Yigit: > >>> On 12/20/2017 7:52 PM, Wei Zhao wrote: > This patch add inforation about i40e queue region > realted to release notes,

Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets

2018-01-16 Thread Thomas Monjalon
16/01/2018 16:05, Burakov, Anatoly: > On 16-Jan-18 12:20 PM, Thomas Monjalon wrote: > > 16/01/2018 12:56, Burakov, Anatoly: > >> On 12-Jan-18 11:50 AM, Thomas Monjalon wrote: > >>> 12/01/2018 12:44, Burakov, Anatoly: > On 11-Jan-18 10:20 PM, Thomas Monjalon wrote: > > 22/12/2017 13:41, Ana

Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets

2018-01-16 Thread Burakov, Anatoly
On 16-Jan-18 5:34 PM, Thomas Monjalon wrote: 16/01/2018 16:05, Burakov, Anatoly: On 16-Jan-18 12:20 PM, Thomas Monjalon wrote: 16/01/2018 12:56, Burakov, Anatoly: On 12-Jan-18 11:50 AM, Thomas Monjalon wrote: 12/01/2018 12:44, Burakov, Anatoly: On 11-Jan-18 10:20 PM, Thomas Monjalon wrote:

[dpdk-dev] [PATCH v7 02/15] app/eventdev: add pipeline test setup and destroy

2018-01-16 Thread Pavan Nikhilesh
Pipeline test has the queue and all types queue variants. Introduce test_pipeline_common* to share the common code between those tests. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/Makefile | 2 ++ app/test-eventdev/test_pipeline_common.c | 44 ++

[dpdk-dev] [PATCH v7 01/15] app/eventdev: add packet distribution logs

2018-01-16 Thread Pavan Nikhilesh
Add logs for packet distribution across worker cores to be printed along with the test results. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v7 Changes: - Fix release notes format. - Split documentation patch into two chunks to reduce message body size. v6 Changes: -

[dpdk-dev] [PATCH v7 03/15] app/eventdev: add mempool setup and destroy

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 29 + app/test-eventdev/test_pipeline_common.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/te

[dpdk-dev] [PATCH v7 04/15] app/eventdev: add pipeline opt dump and check functions

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_common.c | 84 app/test-eventdev/test_pipeline_common.h | 3 ++ 2 files changed, 87 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eve

[dpdk-dev] [PATCH v7 05/15] app/eventdev: add pipeline ethport setup and destroy

2018-01-16 Thread Pavan Nikhilesh
Add common ethdev port setup and destroy along with event dev destroy. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_common.c | 91 app/test-eventdev/test_pipeline_common.h | 3 ++ 2 files changed, 94 insertions(+

[dpdk-dev] [PATCH v7 06/15] app/eventdev: add event port setup and Rx adapter setup

2018-01-16 Thread Pavan Nikhilesh
Setup one port per worker and link to all queues and setup producer port based on Rx adapter capabilities. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_common.c | 114 +++ app/test-eventdev/test_pipeline_common.h | 5

[dpdk-dev] [PATCH v7 08/15] app/eventdev: launch pipeline lcores

2018-01-16 Thread Pavan Nikhilesh
The event master lcore's test termination and the logic to print the mpps are common for the queue and all types queue test. Move them as the common function. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_common.c | 67 +++

[dpdk-dev] [PATCH v7 07/15] app/eventdev: add Tx service setup

2018-01-16 Thread Pavan Nikhilesh
Setup one port event port for Tx and link the respective event queue. Register the Tx function as a service to be called from a service core. The Tx function dequeues the events from the event queue and transmits the packet to its respective ethernet port. Signed-off-by: Pavan Nikhilesh Acked-by:

[dpdk-dev] [PATCH v7 09/15] app/eventdev: add pipeline queue test

2018-01-16 Thread Pavan Nikhilesh
This is a pipeline queue test case that aims at testing the following: 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The pipeline queue test configures the eventdev with Q queues and P ports, where Q is (nb_ethdev * nb_stages)

[dpdk-dev] [PATCH v7 10/15] app/eventdev: add pipeline queue worker functions

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_common.h | 80 + app/test-eventdev/test_pipeline_queue.c | 288 ++- 2 files changed, 367 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_

[dpdk-dev] [PATCH v7 11/15] app/eventdev: add pipeline atq test

2018-01-16 Thread Pavan Nikhilesh
This is a pipeline test case that aims at testing the following with ``all types queue`` eventdev scheme. 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The atq queue test functions as same as ``pipeline_queue`` test. The diffe

[dpdk-dev] [PATCH v7 12/15] app/eventdev: add pipeline atq worker functions

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/test_pipeline_atq.c | 280 +- 1 file changed, 279 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c index 6c9ac6

[dpdk-dev] [PATCH v7 15/15] doc: update 18.02 release notes

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_18_02.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index b2dc39cfe..2a243cb47 100644 --- a/doc/guides/rel_notes/release_18_02.rst

Re: [dpdk-dev] [PATCH v6 14/14] doc: update 18.02 release notes

2018-01-16 Thread Pavan Nikhilesh
On Tue, Jan 16, 2018 at 04:04:32PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > > Sent: Tuesday, January 16, 2018 3:40 PM > > To: jerin.ja...@caviumnetworks.com; santosh.shu...@caviumnetworks.com; Van > >

[dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal

2018-01-16 Thread Anatoly Burakov
There will be a new function added in v18.05 that will return number of detected sockets, which will change the ABI. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/re

Re: [dpdk-dev] [PATCH v3 1/2] crypto/mrvl: sync compilation with musdk-17.10

2018-01-16 Thread Ferruh Yigit
On 1/9/2018 11:47 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski >> Sent: Tuesday, January 9, 2018 9:09 AM >> To: dev@dpdk.org >> Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; >> jianbo..

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-16 Thread Adrien Mazarguil
On Tue, Jan 16, 2018 at 03:54:57PM +0100, george@gmail.com wrote: > Hi Adrien, > > Thanks for your insights and sorry for omitting the cover letter (this is > my first patch in DPDK). No problem, don't worry about that. Remember to put as much context as close as possible to the related chang

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-16 Thread Adrien Mazarguil
Hi Kirill, On Tue, Jan 16, 2018 at 05:23:05PM +, Rybalchenko, Kirill wrote: > Hi Adrien, > after some discussion we found that change I've done > in Mellanox PMD is not really necessary: size of array > flow_types_mask[] is still 1 and the loop in patch > > for (i = 0; i < RTE_FLOW_MASK_AR

[dpdk-dev] [PATCH v2] doc: add eventdev pipeline sample app to release notes

2018-01-16 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- This patch depends on http://dpdk.org/dev/patchwork/patch/33429 patchset. doc/guides/rel_notes/release_18_02.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index

[dpdk-dev] [PATCH v2] checkpatches.sh: Add checks for ABI symbol addition

2018-01-16 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i

[dpdk-dev] [PATCH v4 00/15] common ethdev linkstatus functions

2018-01-16 Thread Stephen Hemminger
While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It also was a good chance to introduce atomic exchange pr

[dpdk-dev] [PATCH v4 01/15] eal: introduce atomic exchange operation

2018-01-16 Thread Stephen Hemminger
To handle atomic update of link status (64 bit), every driver was doing its own version using cmpset. Atomic exchange is a useful primitive in its own right; therefore make it a EAL routine. Signed-off-by: Stephen Hemminger --- .../common/include/arch/x86/rte_atomic.h | 24 +++ ...

[dpdk-dev] [PATCH v4 02/15] ethdev: add linkstatus get/set helper functions

2018-01-16 Thread Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 22 +++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v4 03/15] net/virtio: use eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use the new comon code in ethdev to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 67 -- 1 file changed, 13 insertions(+), 54 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/vi

[dpdk-dev] [PATCH v4 04/15] net/vmxnet3: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_link_update helper. Also remove no longer necessary include of rte_atomic.h Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 86 +++- 1 file changed, 16 insertions(+), 70 deletions(-) diff --git a/drivers/net/vmxnet3/vmx

[dpdk-dev] [PATCH v4 05/15] net/dpaa2: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new helper function to update the link status. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 75 1 file changed, 7 insertions(+), 68 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev

[dpdk-dev] [PATCH v4 06/15] net/nfp: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set helper function. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_net.c | 77 +-- 1 file changed, 7 insertions(+), 70 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 0501

[dpdk-dev] [PATCH v4 07/15] net/e1000: use rte_eth_linkstatus helpers

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set API. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 71 -- drivers/net/e1000/igb_ethdev.c | 70 +++-- 2 files changed, 11 insertions(+), 130 deletions(-) diff --

[dpdk-dev] [PATCH v4 08/15] net/ixgbe: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use the new helper functions from eth_dev for handling atomic link_info update. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++- 1 file changed, 17 insertions(+), 79 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/

[dpdk-dev] [PATCH v4 11/15] net/liquidio: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use the new link update API, and cleanup the logic in the the link update routine. Tested-by: Shijith Thotton Signed-off-by: Stephen Hemminger --- drivers/net/liquidio/lio_ethdev.c | 53 ++- 1 file changed, 8 insertions(+), 45 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v4 09/15] net/sfc: use new rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 21 +++-- drivers/net/sfc/sfc_ev.c | 20 ++-- 2 files changed, 5 insertions(+), 36 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v4 10/15] net/i40e: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use new rte_linkstatus update API Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 43 +-- drivers/net/i40e/i40e_ethdev_vf.c | 18 ++-- 2 files changed, 7 insertions(+), 54 deletions(-) diff --git a/drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v4 14/15] net/octeontx: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Common function matches this drivers usage. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 4f

[dpdk-dev] [PATCH v4 13/15] net/szedata: use _rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Yet another driver which was not returing correct value on link change. Since this driver can't be built on x86 could not even do a compile test. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(

Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets

2018-01-16 Thread Thomas Monjalon
16/01/2018 18:38, Burakov, Anatoly: > On 16-Jan-18 5:34 PM, Thomas Monjalon wrote: > > 16/01/2018 16:05, Burakov, Anatoly: > >> On 16-Jan-18 12:20 PM, Thomas Monjalon wrote: > >>> 16/01/2018 12:56, Burakov, Anatoly: > On 12-Jan-18 11:50 AM, Thomas Monjalon wrote: > > 12/01/2018 12:44, Bura

[dpdk-dev] [PATCH v4 15/15] net/enic: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
This driver was not doing atomic update of link status information. And the return value was different than others. The hardware also does not do autonegotiation (at least on Linux). Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_ethdev.c | 5 ++--- drivers/net/enic/enic_main.c |

[dpdk-dev] [PATCH v4 12/15] net/thunderx: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new helper function. Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index 72dc8ae24ba9..94a2a9b7683d 10

[dpdk-dev] [BUG] failsafe depending on return value from PMD link_update function.

2018-01-16 Thread Stephen Hemminger
While doing link status refactoring, I noticed that the eth_dev_link_update function return value is unused by common code (in rte_eth_dev_link_get); but is being expected by failsafe driver. The return values are not consistent across drivers, and link update function is only valid if device i

[dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-16 Thread Stephen Hemminger
While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It also was a good chance to introduce atomic exchange pr

[dpdk-dev] [PATCH v5 01/15] eal: introduce atomic exchange operation

2018-01-16 Thread Stephen Hemminger
To handle atomic update of link status (64 bit), every driver was doing its own version using cmpset. Atomic exchange is a useful primitive in its own right; therefore make it a EAL routine. Signed-off-by: Stephen Hemminger --- .../common/include/arch/x86/rte_atomic.h | 24 +++ ...

[dpdk-dev] [PATCH v5 02/15] ethdev: add linkstatus get/set helper functions

2018-01-16 Thread Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 22 +++ lib/librte_ether/rte_ethdev.h

[dpdk-dev] [PATCH v5 03/15] net/virtio: use eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use the new comon code in ethdev to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 65 +++--- 1 file changed, 12 insertions(+), 53 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/vi

[dpdk-dev] [PATCH v5 04/15] net/vmxnet3: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_link_update helper. Also remove no longer necessary include of rte_atomic.h Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 86 +++- 1 file changed, 16 insertions(+), 70 deletions(-) diff --git a/drivers/net/vmxnet3/vmx

[dpdk-dev] [PATCH v5 05/15] net/dpaa2: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new helper function to update the link status. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 75 1 file changed, 7 insertions(+), 68 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev

[dpdk-dev] [PATCH v5 06/15] net/nfp: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set helper function. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_net.c | 77 +-- 1 file changed, 7 insertions(+), 70 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 0501

[dpdk-dev] [PATCH v5 08/15] net/ixgbe: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use the new helper functions from eth_dev for handling atomic link_info update. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++- 1 file changed, 17 insertions(+), 79 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/

[dpdk-dev] [PATCH v5 07/15] net/e1000: use rte_eth_linkstatus helpers

2018-01-16 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set API. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 69 +++-- drivers/net/e1000/igb_ethdev.c | 70 +++--- 2 files changed, 10 insertions(+), 129 deletions(-) diff --

[dpdk-dev] [PATCH v5 09/15] net/sfc: use new rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 21 +++-- drivers/net/sfc/sfc_ev.c | 20 ++-- 2 files changed, 5 insertions(+), 36 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v5 10/15] net/i40e: use rte_eth_linkstatus functions

2018-01-16 Thread Stephen Hemminger
Use new rte_linkstatus update API Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 43 +-- drivers/net/i40e/i40e_ethdev_vf.c | 18 ++-- 2 files changed, 7 insertions(+), 54 deletions(-) diff --git a/drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v5 11/15] net/liquidio: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use the new link update API, and cleanup the logic in the the link update routine. Tested-by: Shijith Thotton Signed-off-by: Stephen Hemminger --- drivers/net/liquidio/lio_ethdev.c | 53 ++- 1 file changed, 8 insertions(+), 45 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v5 12/15] net/thunderx: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Use new helper function. Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index 72dc8ae24ba9..94a2a9b7683d 10

[dpdk-dev] [PATCH v5 13/15] net/szedata: use _rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Yet another driver which was not returing correct value on link change. Since this driver can't be built on x86 could not even do a compile test. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(

[dpdk-dev] [PATCH v5 15/15] net/enic: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
This driver was not doing atomic update of link status information. And the return value was different than others. The hardware also does not do autonegotiation (at least on Linux). Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_ethdev.c | 5 ++--- drivers/net/enic/enic_main.c |

[dpdk-dev] [PATCH v5 14/15] net/octeontx: use rte_eth_linkstatus_set

2018-01-16 Thread Stephen Hemminger
Common function matches this drivers usage. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 4f

[dpdk-dev] [PATCH] doc: update pcap documentation

2018-01-16 Thread Ferruh Yigit
Add note about PMD expects the network interfaces provided to be up, documented behavior to set expectations right. Also added minor fix. Signed-off-by: Ferruh Yigit --- Cc: Vipin Varghese Cc: Michael Glynn --- doc/guides/nics/pcap_ring.rst | 8 +++- 1 file changed, 7 insertions(+), 1 del

Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-16 Thread Shahaf Shuler
Hi Oliver, Xueming, Tuesday, January 16, 2018 7:29 PM, Xueming(Steven) Li: > > Hi Xueming, > > > > On Tue, Jan 09, 2018 at 10:11:08PM +0800, Xueming Li wrote: > > > */ > > > #define DEV_TX_OFFLOAD_SECURITY 0x0002 > > > +/**< Device supports arbitrary tunnel chksum and tso offloading

[dpdk-dev] [PATCH v1] drivers/net/ena: Copy PCI info to rte_eth_dev

2018-01-16 Thread sodey
From: Souvik Dey We need to add the pci_dev info to the rte_eth_dev structure during the eth_ena_dev_init. Informantions like driver_name and numa_node will not be populated otherwise. Signed-off-by: Souvik Dey --- drivers/net/ena/ena_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-16 Thread Ananyev, Konstantin
Hi Matan, > > Hi Konstantin > From: Ananyev, Konstantin, Monday, January 15, 2018 8:44 PM > > Hi Matan, > > > Hi Konstantin > > > From: Ananyev, Konstantin, Monday, January 15, 2018 1:45 PM > > > > Hi Matan, > > > > > Hi Konstantin > > > > > From: Ananyev, Konstantin, Friday, January 12, 2018 2:

Re: [dpdk-dev] [PATCH v1] drivers/net/ena: Copy PCI info to rte_eth_dev

2018-01-16 Thread Ferruh Yigit
On 1/16/2018 7:06 PM, so...@rbbn.com wrote: > From: Souvik Dey > > We need to add the pci_dev info to the rte_eth_dev structure > during the eth_ena_dev_init. Informantions like driver_name > and numa_node will not be populated otherwise. stacktrace is like: eth_ena_pci_probe rte_eth_dev_pci_

Re: [dpdk-dev] [PATCH v4] igb_uio: allow multi-process access

2018-01-16 Thread Ferruh Yigit
On 1/1/2018 10:00 PM, Xiao Wang wrote: > In some case, one device are accessed by different processes via > different BARs, so one uio device may be opened by more than one > process, for this case we just need to enable interrupt once, and > pci_clear_master only when the last process closed. > >

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2018-01-16 Thread Ferruh Yigit
On 11/30/2017 7:35 AM, Yuanhan Liu wrote: > The ethdev name is taken from the "name" parameter from the helper > function rte_eth_dev_allocate(name). The name is given by the caller, > thus, there is no way to guarantee all the callers will follow the > same syntax, leaving us the port name is not

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-16 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM > Hi Matan, > > > > > Hi Konstantin > > From: Ananyev, Konstantin, Monday, January 15, 2018 8:44 PM > > > Hi Matan, > > > > Hi Konstantin > > > > From: Ananyev, Konstantin, Monday, January 15, 2018 1:45 PM > > > > > Hi M

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

2018-01-16 Thread Thomas Monjalon
> > > This patch add inforation about i40e queue region realted to release > > > notes, it has been missed before in v17.11 release notes. This feature > > > has been implemented in v17.11. > > > > > > Signed-off-by: Wei Zhao > > Acked-by: Helin Zhang > Applied to dpdk-next-net-intel, with minor

Re: [dpdk-dev] [PATCH v3] doc: add i40e update

2018-01-16 Thread Thomas Monjalon
10/01/2018 03:01, Beilei Xing: > --- a/doc/guides/rel_notes/release_18_02.rst > +++ b/doc/guides/rel_notes/release_18_02.rst > +* **Updated i40e driver to support MPLSoUDP/MPLSoGRE.** > + > + Updated i40e PMD to support MPLSoUDP/MPLSoGRE with MPLSoUDP/MPLSoGRE > + supporting profiles which can be

Re: [dpdk-dev] [PATCH v3 3/8] net/failsafe: support probed sub-devices getting

2018-01-16 Thread Gaëtan Rivet
Hi Matan, On Tue, Jan 16, 2018 at 05:20:27PM +, Matan Azrad wrote: > Hi Gaetan > > > > > In 18.05, or 18.08 there should be an EAL function that would be > > > > able to identify a device given a specific ID string (very close to an > > rte_devargs). > > > > Currently, this API does not ex

Re: [dpdk-dev] [BUG] failsafe depending on return value from PMD link_update function.

2018-01-16 Thread Gaëtan Rivet
Hi Stephen, On Tue, Jan 16, 2018 at 10:29:06AM -0800, Stephen Hemminger wrote: > While doing link status refactoring, I noticed that the eth_dev_link_update > function > return value is unused by common code (in rte_eth_dev_link_get); but is being > expected > by failsafe driver. > > The return

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-16 Thread Gaëtan Rivet
Hi Yuanhan, On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > This patch documents the new devargs syntax, which is going to be > implemented in DPDK v18.05. > > The new devargs proposal is introduced for having a consistent > interface for: > > - whitelisting/blacklisting devices >

Re: [dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2018-01-16 Thread Thomas Monjalon
22/12/2017 15:25, Adrien Mazarguil: > Such a change is unlikely to be accepted for 18.02 in any case, therefore if > the proposed workaround is deemed too risky, I offer to remove this patch > from the series. What do you suggest? Series applied without this patch. Please let's fix it in 18.05.

Re: [dpdk-dev] [PATCH v1 0/6] Address various issues with exported headers

2018-01-16 Thread Thomas Monjalon
21/12/2017 13:59, Adrien Mazarguil: > Adrien Mazarguil (6): > devtools: update check-includes exceptions > net/i40e: fix issue in exported header > flow_classify: fix issue in exported header > member: fix issue in exported header > fix missing includes in exported headers > net: fix rt

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-16 Thread Thomas Monjalon
17/01/2018 00:19, Gaëtan Rivet: > Hi Yuanhan, > > On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > > +The ``devargs`` can be used for whitelisting/blacklisting devices, > > identifying > > +DPDK ports and attaching/deatching devices. They all share the same syntax. > > + > > +It is

Re: [dpdk-dev] [PATCH v4] igb_uio: allow multi-process access

2018-01-16 Thread Thomas Monjalon
16/01/2018 20:43, Ferruh Yigit: > On 1/1/2018 10:00 PM, Xiao Wang wrote: > > In some case, one device are accessed by different processes via > > different BARs, so one uio device may be opened by more than one > > process, for this case we just need to enable interrupt once, and > > pci_clear_mast

Re: [dpdk-dev] [PATCH v2 1/2] vfio: expose clear group function for internal usages

2018-01-16 Thread Thomas Monjalon
15/01/2018 06:11, Hemant Agrawal: > other vfio based module e.g. fslmc will also need to use > the clear_group call. > So, exposing it and renaming it to *rte_vfio_clear_group* > > Signed-off-by: Hemant Agrawal > Acked-by: Anatoly Burakov Series applied, thanks

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-16 Thread Gaëtan Rivet
On Wed, Jan 17, 2018 at 12:22:43AM +0100, Thomas Monjalon wrote: > 17/01/2018 00:19, Gaëtan Rivet: > > Hi Yuanhan, > > > > On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > > > +The ``devargs`` can be used for whitelisting/blacklisting devices, > > > identifying > > > +DPDK ports and

Re: [dpdk-dev] [PATCH 1/2] eal: make max vfio groups configurable

2018-01-16 Thread Thomas Monjalon
12/01/2018 18:24, Burakov, Anatoly: > On 29-Dec-17 7:58 AM, Pavan Nikhilesh wrote: > > Make max vfio groups compile-time configurable so that platforms can > > choose vfio group limit. > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Anatoly Burakov Series applied, thanks

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-16 Thread Thomas Monjalon
17/01/2018 00:46, Gaëtan Rivet: > On Wed, Jan 17, 2018 at 12:22:43AM +0100, Thomas Monjalon wrote: > > 17/01/2018 00:19, Gaëtan Rivet: > > > It might be a nitpick, but the driver specific properties might not > > > follow the key/value pair syntax. At least for the fail-safe, a custom > > > parsing

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

2018-01-16 Thread Lu, Wenzhuo
Hi Matan, > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Tuesday, January 16, 2018 4:16 PM > To: Lu, Wenzhuo ; Thomas Monjalon > ; Gaetan Rivet ; Wu, > Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, > Bruce ; Ananyev, Konstantin > > Subject: RE: [dpd

Re: [dpdk-dev] [PATCH 4/6] ethdev: introduce TX common tunnel offloads

2018-01-16 Thread Yongseok Koh
> On Jan 9, 2018, at 6:11 AM, Xueming Li wrote: > > This patch introduce new DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM_TSO flag for > devices that support tunnel agnostic TX checksum and tso offloading. > > Checksum offset and TSO header length are calculated based on mbuf > inner length l*_len, outer_l

Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq

2018-01-16 Thread Yang, Zhiyong
> -Original Message- > From: Chen, Junjie J > Sent: Tuesday, January 16, 2018 3:39 PM > To: Yang, Zhiyong ; y...@fridaylinux.org; > maxime.coque...@redhat.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq > > Hi > > > > > @@ -227,6 +227,7 @@

Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-16 Thread Tonghao Zhang
On Mon, Jan 15, 2018 at 4:57 PM, Tonghao Zhang wrote: > On Mon, Jan 15, 2018 at 12:57 PM, Dai, Wei wrote: >>> -Original Message- >>> From: xiangxia.m@gmail.com [mailto:xiangxia.m@gmail.com] >>> Sent: Sunday, January 14, 2018 6:04 PM >>> To: Dai, Wei ; Xing, Beilei >>> Cc: dev@dpd

[dpdk-dev] [PATCH] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-16 Thread Junjie Chen
dequeue zero copy change buf_addr and buf_iova of mbuf, and return to mbuf pool without restore them, it breaks vm memory if others allocate mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova. Signed-off-by: Junjie Chen --- lib/librte_vhost/virtio_net.c | 21 +++

Re: [dpdk-dev] [PATCH 12/12 v3] doc: add DPAA eventdev guide

2018-01-16 Thread Nipun Gupta
Yes done :) > -Original Message- > From: Kovacevic, Marko [mailto:marko.kovace...@intel.com] > Sent: Tuesday, January 16, 2018 21:03 > To: Nipun Gupta ; jerin.ja...@caviumnetworks.com; > dev@dpdk.org > Cc: Sunil Kumar Kori ; Hemant Agrawal > > Subject: RE: [dpdk-dev] [PATCH 12/12 v3] doc:

Re: [dpdk-dev] [PATCH 1/6 v2] event/dpaa2: replace static with dynamic logging

2018-01-16 Thread Nipun Gupta
Hi Jerin, Please do not apply this version on dpdk-eventdev-next as there is some compilation issue when both the DPAA series for eventdev support and this series are applied (though they are compileable independently). I will fix this and send a new version by today EOD. Thanks, Nipun > ---

[dpdk-dev] [PATCH v8 0/3] support c11 memory model barrier in librte_ring

2018-01-16 Thread Jia He
To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" on any architectures so far. The reason why providing 2 options is due to the performance benchmark di

[dpdk-dev] [PATCH v8 1/3] eal/arm64: remove the braces {} for dmb() and dsb()

2018-01-16 Thread Jia He
for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Fixes: 84733fd0d75e ("eal/arm64: fix memory barrier definition") Signed-off-by: Jia He Acked-by: Jerin Jacob ---

[dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

2018-01-16 Thread Jia He
Move the common part of rte_ring.h into rte_ring_generic.h. Move the memory barrier part into update_tail(). No functional changes here. Signed-off-by: Jia He Suggested-by: Jerin Jacob Suggested-by: Ananyev Konstantin Acked-by: Jerin Jacob Acked-by: Olivier Matz --- lib/librte_eventdev/rte_

[dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-16 Thread Jia He
To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [1]). CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" on any architectures so far. The reason why providing 2 options is due to the performan

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-16 Thread Shreyansh Jain
On Wednesday 17 January 2018 12:07 AM, Stephen Hemminger wrote: While reviewing drivers, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good

[dpdk-dev] [PATCH 0/6 v3] support atomic queues in dpaa2 ethernet with eventdev

2018-01-16 Thread Nipun Gupta
These patches assume that DPAA2 series is already applied [1]. This patch series supports atomic queues in DPAA2 Ethernet driver with eventdev. Also other changes such as dynamic logging is supported with these changes. Patch 1 - support dynamic logging in eventdev Patch 2,3,4 - Cleanups and perf

[dpdk-dev] [PATCH 1/6 v3] event/dpaa2: replace static with dynamic logging

2018-01-16 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 83 --- drivers/event/dpaa2/dpaa2_eventdev.h | 12 - drivers/event/dpaa2/dpaa2_eventdev_logs.h | 37 ++ drivers/event/dpaa2/dpaa2_hw_dpcon.c |

[dpdk-dev] [PATCH 3/6 v3] event/dpaa2: use dqrr index to cosume the DQRR entry

2018-01-16 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 542bccc..65c2c7a 100644 --- a/drivers/event/dpaa2/

<    1   2   3   4   >