Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue

It seems that the patch has been applied by Thomas. Please check mail list. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, February 5, 2018 3:53 PM > To: dev@dpdk.org > Cc: shah...@mellanox.com; Lu, Wenzhuo ; Wu, > Yanglong > Subjec

[dpdk-dev] [PATCH] net/i40e: fix issue about interrupt

This patch fixes interval error and corrects macros when enable rx interrupt mode. The patch also fixes a logical error during support multiple driver. Fixes: be6c228d4da3 ("i40e: support Rx interrupt") Fixes: b20aa3aee390 ("net/i40e: fix multiple driver support issue") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs

On Sat, Feb 03, 2018 at 09:55:23AM -0500, David C Harton wrote: > virtio_dev_free_mbufs was recently modified to free the > virtqueues but failed to check whether the array was > allocated. Added a check to ensure vqs was non-null. > > Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing"

[dpdk-dev] [PATCH v2] net/i40e: fix issue about interrupt

This patch fixes interval error and corrects macros when enable rx interrupt mode. The patch also fixes a logical error during support multiple driver. Fixes: be6c228d4da3 ("i40e: support Rx interrupt") Fixes: b20aa3aee390 ("net/i40e: fix multiple driver support issue") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [PATCH] net/tap: allow user MAC to be passed as args

Hi Pascal, Waiting for your inputs in changing the function argument from int32_t to uint64_t. Thanks Vipin Varghese > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Varghese, Vipin > Sent: Friday, February 2, 2018 9:50 AM > To: Pascal Mazon ; dev@dpdk.org > C

[dpdk-dev] [PATCH v4 1/4] net/i40e: add warnings when writing global registers

Add warnings when writing global registers. Signed-off-by: Beilei Xing Cc: sta...@dpdk.org --- doc/guides/nics/i40e.rst | 12 drivers/net/i40e/i40e_ethdev.c | 15 +++ drivers/net/i40e/i40e_ethdev.h | 43 ++ 3 files changed, 7

[dpdk-dev] [PATCH v4 2/4] net/i40e: add debug logs when writing global registers

Add debug logs when writing global registers. Signed-off-by: Beilei Xing Cc: sta...@dpdk.org --- drivers/net/i40e/i40e_ethdev.c | 127 + drivers/net/i40e/i40e_ethdev.h | 8 +++ 2 files changed, 87 insertions(+), 48 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v4 3/4] net/i40e: fix multiple driver support issue

This patch provides the option to disable writing some global registers in PMD, in order to avoid affecting other drivers, when multiple drivers run on the same NIC and control different physical ports. Because there are few global resources shared among different physical ports. Fixes: ec246eeb5d

[dpdk-dev] [PATCH v4 0/4] net/i40e: fix multiple driver support issue

DPDK i40e PMD will modify some global registers during initialization and post initialization, there'll be impact during use of 700 series Ethernet Adapter with both Linux kernel and DPDK PMD. This patchset adds logs for global configuration and adds device args to disable global configuration and

[dpdk-dev] [PATCH v4 4/4] net/i40e: fix interrupt conflict when using multi-driver

There's interrupt conflict when using DPDK and Linux i40e on different ports of the same Ethernet controller, this patch fixes it by switching from IntN to Int0 if multiple drivers are used. Fixes: be6c228d4da3 ("i40e: support Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- do

Re: [dpdk-dev] [PATCH] vhost: support non multiqueue guests

Hi Alan, On 01/31/2018 03:42 PM, alangordonde...@gmail.com wrote: From: Alan Dewar Performance of vhost interfaces can be improved by having multiple TX/RX queue-pairs. QEMU can be told to use multiple queue-pairs for a vhost interface when starting the guest VM. The DPDK will also configure

Re: [dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs

On 02/03/2018 03:55 PM, David C Harton wrote: virtio_dev_free_mbufs was recently modified to free the virtqueues but failed to check whether the array was allocated. Added a check to ensure vqs was non-null. Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing") Cc: olivier.m...@6wind

[dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration

The port_conf for the DCB configuration should inherit the same configuration of the port. Fix:0074d02fc("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- v2: changing patch accoding to review --- v3: changing patch accoding to comments --- app/test-pmd/testpmd.c | 3

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration

Monday, February 5, 2018 10:48 AM, Yanglong Wu: > Fix:0074d02fc("app/testpmd: convert to new Rx offloads API") The fix line is still wrong. Use the one I suggested. > Signed-off-by: Yanglong Wu > --- > v2: > changing patch accoding to review > --- > v3: > changing patch accoding to comments > --

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix documentation for testpmd ddp add del function

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Thursday, February 1, 2018 5:25 PM > To: Rybalchenko, Kirill; dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill; Chilikin, Andrey; Xing, Beilei; Wu, > Jingjing > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH] mk: add debug target

On Fri, Feb 02, 2018 at 10:07:31AM +0100, Thomas Monjalon wrote: > 01/02/2018 18:04, Ferruh Yigit: > > On 1/30/2018 11:40 PM, Thomas Monjalon wrote: > > > 16/12/2017 01:13, Ferruh Yigit: > > >> Add "debug" target to build library with debug symbols and optimization > > >> disabled. > > >> > > >> Th

Re: [dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

Hi Herbert, On Wed, Jan 31, 2018 at 03:39:19PM +0800, Herbert Guan wrote: > 1) Add native PN option '-march=native' to allow automatic detection. >Set 'arm_force_native_march' to 'true' in config/arm/meson.build >to use native PN option. > 2) Add implementer_pn option for part num selectio

Re: [dpdk-dev] [PATCH v1] mk: support building with renamed makefile

On Mon, Jan 22, 2018 at 10:59:05AM +, Marko Kovacevic wrote: > The build system made a recursive call to "make" after > creating the build directory. This recursive call used > the hard-coded filename "Makefile", which prevented > builds from working if the file was renamed and make > called us

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

> -Original Message- > From: Zhao1, Wei > Sent: Friday, February 2, 2018 3:30 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Zhao1, Wei > > Subject: [PATCH v3] doc: add a user guidance document for igb > > This patch add a user guidance document specific for igb nic. > By now, a doc like

[dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration

The port_conf for the DCB configuration should inherit the same configuration of the port. Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- v2: changing patch accoding to review --- v3: changing patch accoding to comments --- v4: changing patch acc

[dpdk-dev] [PATCH v2] mk: support renamed Makefile in external project

The build system made a recursive call to "make" after creating the build directory. This recursive call used the hard-coded filename "Makefile", which prevented builds from working if the file was renamed and make called using "make -f". Taking the filename from MAKEFILES_LIST make variable fixes

[dpdk-dev] [PATCH v4] app/testpmd: fix port DCB configuration

The port_conf for the DCB configuration should inherit the same configuration of the port. Fixes: 0074d02fca21("app/testpmd: convert to new Rx offloads API") Signed-off-by: Yanglong Wu Acked-by: Shahaf Shuler --- v2: changing patch accoding to review --- v3: changing patch accoding to comments

Re: [dpdk-dev] [PATCH v2] mk: support renamed Makefile in external project

On Mon, Feb 05, 2018 at 09:53:53AM +, Marko Kovacevic wrote: > The build system made a recursive call to "make" after > creating the build directory. This recursive call used > the hard-coded filename "Makefile", which prevented > builds from working if the file was renamed and make > called us

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

On 02-Feb-18 8:51 PM, Ravi Kerur wrote: On Fri, Feb 2, 2018 at 12:21 PM, Ravi Kerur > wrote: On Fri, Feb 2, 2018 at 2:28 AM, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 01-Feb-18 7:26 PM, Ravi Kerur wrote: On Thu, Fe

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

On 02-Feb-18 7:28 PM, Yongseok Koh wrote: On Tue, Dec 26, 2017 at 05:19:25PM +, Walker, Benjamin wrote: On Fri, 2017-12-22 at 09:13 +, Burakov, Anatoly wrote: On 21-Dec-17 9:38 PM, Walker, Benjamin wrote: SPDK will need some way to register for a notification when pages are allocated o

Re: [dpdk-dev] [PATCH 2/2] net/sfc: add support for meson build

On Sat, Feb 03, 2018 at 06:33:51PM +0300, Andrew Rybchenko wrote: > On 02/02/2018 07:18 PM, Bruce Richardson wrote: > > On Fri, Feb 02, 2018 at 12:43:58PM +, Andrew Rybchenko wrote: > > > From: Ivan Malov > > > > > > Signed-off-by: Ivan Malov > > > Signed-off-by: Andrew Rybchenko > > > ---

Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

On 02-Feb-18 5:08 PM, Thomas Monjalon wrote: 02/02/2018 11:31, Burakov, Anatoly: On 02-Feb-18 9:08 AM, Thomas Monjalon wrote: 01/02/2018 18:04, Burakov, Anatoly: On 01-Feb-18 12:10 AM, Thomas Monjalon wrote: 17/01/2018 12:15, Anatoly Burakov: Acked-by: Cristian Dumitrescu Fixes: c7e4a134e7

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

On Mon, Feb 05, 2018 at 10:03:35AM +, Burakov, Anatoly wrote: > On 02-Feb-18 7:28 PM, Yongseok Koh wrote: > > On Tue, Dec 26, 2017 at 05:19:25PM +, Walker, Benjamin wrote: > > > On Fri, 2017-12-22 at 09:13 +, Burakov, Anatoly wrote: > > > > On 21-Dec-17 9:38 PM, Walker, Benjamin wrote:

Re: [dpdk-dev] [PATCH] vhost: support non multiqueue guests

Hi Maxime, Just confirming that the commit that you suggested fixes the problem that I was seeing. Many thanks for your help. Regards Alan On Mon, Feb 5, 2018 at 8:42 AM, Maxime Coquelin wrote: > Hi Alan, > > On 01/31/2018 03:42 PM, alangordonde...@gmail.com wrote: >> >> From: Alan Dewar >> >>

[dpdk-dev] [PATCH v1] mk: fix external build failure

Updated the make build to fix external build issues Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project") Cc: sta...@dpdk.org Signed-off-by: Marko Kovacevic --- mk/internal/rte.extvars.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/internal/rte.extv

Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

05/02/2018 11:06, Burakov, Anatoly: > On 02-Feb-18 5:08 PM, Thomas Monjalon wrote: > > 02/02/2018 11:31, Burakov, Anatoly: > >> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote: > >>> 01/02/2018 18:04, Burakov, Anatoly: > On 01-Feb-18 12:10 AM, Thomas Monjalon wrote: > > 17/01/2018 12:15, Anato

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

On 2/4/2018 3:33 PM, Pavan Nikhilesh wrote: > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > used. > > Signed-off-by: Pavan Nikhilesh > --- > > v2 Changes: > - fixed compilation issues caused by using experimental API in both meson and > make. > > drivers/net/octe

[dpdk-dev] [RFC v2] ether: support deferred queue setup

According to exist implementation, rte_eth_[rx|tx]_queue_setup will always return fail if device is already started(rte_eth_dev_start). This can't satisfied the usage when application want to deferred setup part of the queues while keep traffic running on those queues already be setup. example: r

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

On 05-Feb-18 10:18 AM, Nélio Laranjeiro wrote: On Mon, Feb 05, 2018 at 10:03:35AM +, Burakov, Anatoly wrote: On 02-Feb-18 7:28 PM, Yongseok Koh wrote: On Tue, Dec 26, 2017 at 05:19:25PM +, Walker, Benjamin wrote: On Fri, 2017-12-22 at 09:13 +, Burakov, Anatoly wrote: On 21-Dec-17

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

05/02/2018 11:22, Marko Kovacevic: > Updated the make build to fix external build issues Please explain what is the issue. > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project") > Cc: sta...@dpdk.org No need to Cc stable when fixing a bug which is not in a major release.

Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

> -Original Message- > From: Rybalchenko, Kirill > Sent: Thursday, February 1, 2018 8:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Chilikin, Andrey ; Xing, Beilei > ; Wu, Jingjing > Subject: [PATCH v3] net/i40e: fix multiple DDP packages should not be > allowed

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

On Mon, Feb 05, 2018 at 10:34:00AM +, Ferruh Yigit wrote: > On 2/4/2018 3:33 PM, Pavan Nikhilesh wrote: > > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > > used. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2 Changes: > > - fixed compilation issues caus

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

> 05/02/2018 11:22, Marko Kovacevic: > > Updated the make build to fix external build issues > > Please explain what is the issue. > > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project") > > Cc: sta...@dpdk.org > > No need to Cc stable when fixing a bug which is not in a m

[dpdk-dev] [PATCH v3] net/octeontx: register fpa as platform HW mempool

Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is used. Signed-off-by: Pavan Nikhilesh Acked-by: Santosh Shukla --- v3 Changes: - spilt meson specific changes to a separate patch. v2 Changes: - fixed compilation issues caused by using experimental API in both meso

[dpdk-dev] [PATCH] net/octeontx: add allow experimental define as flag to meson

Add ALLOW_EXPERIMENTAL_API define as cflag to meson. Signed-off-by: Pavan Nikhilesh --- In reference to http://dpdk.org/dev/patchwork/patch/34955/ drivers/net/octeontx/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeontx/meson.build b/drivers/net/octeontx/mes

[dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability

TAP device is supporting multi segments Tx, however this capability is not reported when querying the TAP device. This commit adds this capability report. Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/tap/rte_eth_tap.c | 6

[dpdk-dev] [PATCH] drivers/raw: fix incorrect device start

Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Cc: shreyansh.j...@nxp.com Device can only be started if firmware is loaded, as per Skeleton rawdev driver semantics. This patch fixes original implementation which attempted to start the device without loading firmware. Signed-off-by: Shreyans

[dpdk-dev] [PATCH v2] raw/skeleton_rawdev: fix incorrect device start

Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Cc: shreyansh.j...@nxp.com Device can only be started if firmware is loaded, as per Skeleton rawdev driver semantics. This patch fixes original implementation which attempted to start the device without loading firmware. Signed-off-by: Shreyans

[dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test

Device can only be started if firmware is loaded, as per Skeleton rawdev driver semantics. This patch fixes original implementation which attempted to start the device without loading firmware. Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Cc: shreyansh.j...@nxp.com Signed-off-by: Shreyans

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote: > 02/02/2018 17:46, Adrien Mazarguil: > > --- a/drivers/net/mlx4/Makefile > > +++ b/drivers/net/mlx4/Makefile > > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > > > > # Library name. > > LIB = librte_pmd_mlx4.a > > -LIB_GLU

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

On Sun, Feb 04, 2018 at 09:03:09PM +0530, Pavan Nikhilesh wrote: > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > used. > > Signed-off-by: Pavan Nikhilesh > --- > > v2 Changes: > - fixed compilation issues caused by using experimental API in both meson and > make. >

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

On Mon, Feb 05, 2018 at 10:34:00AM +, Ferruh Yigit wrote: > On 2/4/2018 3:33 PM, Pavan Nikhilesh wrote: > > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > > used. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2 Changes: > > - fixed compilation issues ca

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for memory hotplug changes

On Thu, Jan 18, 2018 at 10:32:28AM +, Anatoly Burakov wrote: > Due to coming changes outlined in memory hotplug RFC, there will > be several API/ABI changes. > > Signed-off-by: Anatoly Burakov > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 4/4] event/dpaa: fix portal allocation

On 2/5/2018 10:51 AM, Nipun Gupta wrote: Checking if portal has been allocated is now required at the caller of rte_dpaa_portal_init() API. This patch adds check in the dpaa eventdev driver. Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Signed-off-by: Nipun Gupt

Re: [dpdk-dev] [PATCH 3/4] event/dpaa: rename dpaa vdev with dpaa1

On 2/5/2018 10:51 AM, Nipun Gupta wrote: DPAA2 eventdev is named as event_dpaa2 which conflicts with event_dpaa when both are compiled in together. So event_dpaa is required to renamed. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Signed-off-by: Nipun Gupta --- doc/

[dpdk-dev] [PATCH] net/mlx5: fix link speed

When the link is down, mlx5 kernel driver reports the link speed as -1 (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it will be re-queried again due to the link_speed is not 0, due to following code: 1201 if (((link->link_speed == 0) && link->link_status) || 1202

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Mon, Feb 05, 2018 at 12:24:02PM +0100, Adrien Mazarguil wrote: > On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote: > > 02/02/2018 17:46, Adrien Mazarguil: > > > --- a/drivers/net/mlx4/Makefile > > > +++ b/drivers/net/mlx4/Makefile > > > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.

[dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

Input validation is not applied consistently in vhost_user.c. This suggests that not everyone has the same security model in mind when working on the code. Make the security model explicit so that everyone can understand and follow the same model when modifying the code. Signed-off-by: Stefan Ha

[dpdk-dev] [PATCH 2/8] vhost: avoid enum fields in VhostUserMsg

The VhostUserMsg struct binary representation must match the vhost-user protocol specification since this struct is read from and written to the socket. The VhostUserMsg.request union contains enum fields. Enum binary representation is implementation-defined according to the C standard and it is

[dpdk-dev] [PATCH 0/8] vhost: input validation enhancements

This patch series addresses missing input validation that I came across when reviewing vhost_user.c. The first patch explains the security model and the rest fixes places with missing checks. Now is a good time to discuss the security model if anyone disagrees or has questions about what Patch 1

[dpdk-dev] [PATCH 3/8] vhost: validate untrusted memory.nregions field

Check if memory.nregions is valid right away. This eliminates the possibility of bugs when memory.nregions is used later on in vhost_user_set_mem_table(). Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/vhost_user.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_vhost/

[dpdk-dev] [PATCH 6/8] vhost: fix msg->payload union typo in vhost_user_set_vring_addr()

vhost_user_set_vring_addr() uses the msg->payload.addr union member, not msg->payload.state. Luckily the offset of the 'index' field is identical in both structs, so there was never any buggy behavior. Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/vhost_user.c | 2 +- 1 file changed, 1 in

[dpdk-dev] [PATCH 7/8] vhost: validate virtqueue size

Check the virtqueue size constraints so that invalid values don't cause bugs later on in the code. For example, sometimes the virtqueue size is stored as unsigned int and sometimes as uint16_t, so bad things happen if it is ever larger than 65535. Signed-off-by: Stefan Hajnoczi --- lib/librte_v

[dpdk-dev] [PATCH 4/8] vhost: clear out unused SCM_RIGHTS file descriptors

The number of file descriptors received is not stored by vhost_user.c. vhost_user_set_mem_table() assumes that memory.nregions matches the number of file descriptors received, but nothing guarantees this: for (i = 0; i < memory.nregions; i++) close(pmsg->fds[i]); Another questionable code

[dpdk-dev] [PATCH 5/8] vhost: reject invalid log base mmap_offset values

If the log base mmap_offset is larger than mmap_size then it points outside the mmap region. We must not write to memory outside the mmap region, so validate mmap_offset in vhost_user_set_log_base(). Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/vhost_user.c | 9 + 1 file changed,

[dpdk-dev] [PATCH 8/8] vhost: check for memory_size + mmap_offset overflow

If memory_size + mmap_offset overflows then the memory region is bogus. Do not use the overflowed mmap_size value for mmap(). Signed-off-by: Stefan Hajnoczi --- lib/librte_vhost/vhost_user.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_u

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcelo Ricardo Leitner > Sent: Monday, February 5, 2018 12:14 PM > To: Adrien Mazarguil > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > ; Nelio Laranjeiro > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue > libra

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx: add debug checks to glue structure

On Fri, Feb 02, 2018 at 05:46:12PM +0100, Adrien Mazarguil wrote: > This code should catch mistakes early if a glue structure member is added > without a corresponding implementation in the library. > > Signed-off-by: Adrien Mazarguil > --- > drivers/net/mlx4/mlx4.c | 9 + > drivers/net/

Re: [dpdk-dev] [PATCH] net/mlx5: fix link speed

On Mon, Feb 05, 2018 at 08:01:44PM +0800, Yuanhan Liu wrote: > When the link is down, mlx5 kernel driver reports the link speed as -1 > (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it > will be re-queried again due to the link_speed is not 0, due to following > code: > > 1201

Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build

On Sat, Feb 03, 2018 at 01:46:34PM +, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > v2: > - use includes to extend include directories set > - limit to x86 architecture > - specify include directories in base driver bui

[dpdk-dev] [PATCH v3 1/2] doc: update mlx PMD release notes

Signed-off-by: Shahaf Shuler --- On v3: - No change. On v2: - No change. --- doc/guides/rel_notes/release_18_02.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index 689080be

[dpdk-dev] [PATCH v3 2/2] doc: update mlx5 required OFED version

Signed-off-by: Shahaf Shuler --- On v3: - Highlighted flow counters are supported only in MLNX_OFED. On v2: - Updated the OFED version for mlx4 guide as well. --- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build

On 02/05/2018 03:30 PM, Bruce Richardson wrote: On Sat, Feb 03, 2018 at 01:46:34PM +, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- v2: - use includes to extend include directories set - limit to x86 architecture - specify in

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Mon, Feb 05, 2018 at 12:24:23PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcelo Ricardo Leitner > > Sent: Monday, February 5, 2018 12:14 PM > > To: Adrien Mazarguil > > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > > ; Nelio Laranjeiro > >

[dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check

The vdev_netvsc driver does periodic detection of PCI devices matched to the netvsc existed interfaces. When it finds a match, the PCI address is written to the pipe of the associated fail-safe PMD instance and a positive value is returned to the periodic check which is wrongly considered as error

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Mon, Feb 05, 2018 at 12:24:23PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcelo Ricardo Leitner > > Sent: Monday, February 5, 2018 12:14 PM > > To: Adrien Mazarguil > > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > > ; Nelio Laranjeiro > >

[dpdk-dev] [PATCH v4 6/6] test: fix memory leak in timer perf autotest

Fixes: 277afaf3dbcb ("app/test: add timer_perf") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_timer_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/test_timer_perf.c b/test/test/test_timer_perf.c index afa3a06..0fe2b74 100644 --- a/test/test/test_tim

[dpdk-dev] [PATCH v4 3/6] test: fix memory leak in ring autotest

Get rid of global static ring variable and don't reuse rings between test runs. Fixes: 4e32101f9b01 ("ring: support freeing") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Olivier Matz --- Notes: v3: fix commit message to point to approriat

[dpdk-dev] [PATCH v4 1/6] test: fix memory leak in bitmap test

Fixes: c7e4a134e769 ("test: verify bitmap operations") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- Notes: v4: put ack after signoff test/test/test_bitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test/test_bitmap

[dpdk-dev] [PATCH v4 2/6] test: fix memory leak in reorder autotest

Add a teardown function that frees allocated resources. Fixes: d0c9b58d7156 ("app/test: new reorder unit test") Cc: sergio.gonzalez.mon...@intel.com Cc: reshma.pat...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v4: fix Reshma Pattan's email address test/test/te

[dpdk-dev] [PATCH v4 5/6] test: fix memory leak in table autotest

Always deallocate allocated resources after the test is done. Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- Notes: v4: put ack after signoff test/test/te

[dpdk-dev] [PATCH v4 4/6] test: fix memory leak in ring perf autotest

Fixes: ac3fb3019c52 ("app: rework ring tests") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Olivier Matz --- Notes: v2: remove static ring variable test/test/test_ring_perf.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff

Re: [dpdk-dev] [PATCH v3 1/2] doc: update mlx PMD release notes

On Mon, Feb 05, 2018 at 02:31:11PM +0200, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler > --- > > On v3: > - No change. > > On v2: > - No change. > > --- > doc/guides/rel_notes/release_18_02.rst | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/doc/

Re: [dpdk-dev] [PATCH v3 2/2] doc: update mlx5 required OFED version

On Mon, Feb 05, 2018 at 02:31:12PM +0200, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler > --- > > On v3: > - Highlighted flow counters are supported only in MLNX_OFED. > > On v2: > - Updated the OFED version for mlx4 guide as well. > --- > doc/guides/nics/mlx4.rst | 2 +- > doc/guides/

[dpdk-dev] Crash during rte_acl_classify while other core is building the filter context using rte_acl_build()

Hi, How to resolve the following crash without using lock in dpdk ? Crash occurs while a core is doing rte_acl_classify() for a packet when other core is trying to build the same filter context using rte_acl_build(). How to resolve this issue without using lock as lock affects the performance ?

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx: add debug checks to glue structure

On Mon, Feb 05, 2018 at 10:27:10AM -0200, Marcelo Ricardo Leitner wrote: > On Fri, Feb 02, 2018 at 05:46:12PM +0100, Adrien Mazarguil wrote: > > This code should catch mistakes early if a glue structure member is added > > without a corresponding implementation in the library. > > > > Signed-off-b

Re: [dpdk-dev] [PATCH] net/mlx5: fix link speed

Monday, February 5, 2018 2:29 PM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix link speed > > On Mon, Feb 05, 2018 at 08:01:44PM +0800, Yuanhan Liu wrote: > > When the link is down, mlx5 kernel driver reports the link speed as -1 > > (UNKNOWN_SPEED). We need turn it to 0 for such case, o

Re: [dpdk-dev] Crash during rte_acl_classify while other core is building the filter context using rte_acl_build()

Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohanraj Venkat > Sent: Monday, February 5, 2018 1:30 PM > To: dev@dpdk.org > Subject: [dpdk-dev] Crash during rte_acl_classify while other core is > building the filter context using rte_acl_build() > > Hi,

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Mon, Feb 05, 2018 at 10:58:06AM -0200, Marcelo Ricardo Leitner wrote: > On Mon, Feb 05, 2018 at 12:24:23PM +, Van Haaren, Harry wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcelo Ricardo > > > Leitner > > > Sent: Monday, February 5, 2018 12:14 PM > > > To: Adrien Maza

Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

Hi Beilei, > -Original Message- > From: Xing, Beilei > Sent: Monday 5 February 2018 10:41 > To: Rybalchenko, Kirill ; dev@dpdk.org > Cc: sta...@dpdk.org; Chilikin, Andrey ; Wu, > Jingjing > Subject: RE: [PATCH v3] net/i40e: fix multiple DDP packages should not be > allowed > > > @@ -1628

Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build

On Mon, Feb 05, 2018 at 03:33:54PM +0300, Andrew Rybchenko wrote: > On 02/05/2018 03:30 PM, Bruce Richardson wrote: > > On Sat, Feb 03, 2018 at 01:46:34PM +, Andrew Rybchenko wrote: > > > From: Ivan Malov > > > > > > Signed-off-by: Ivan Malov > > > Signed-off-by: Andrew Rybchenko > > > ---

Re: [dpdk-dev] [PATCH] net/mlx4: fix Rx pkt offloads nonfrag indication

On Tue, Jan 30, 2018 at 07:02:51PM +0200, Moti Haimovsky wrote: > This patch fixes the missing RTE_PTYPE_L4_NONFRAG on non-fragmented > IP packets with unrecognized payload type. > > Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads") > Cc: sta...@dpdk.org > > Signed-off-by: Moti Ha

Re: [dpdk-dev] [PATCH v1] mk: fix external build failure

05/02/2018 11:53, Kovacevic, Marko: > > 05/02/2018 11:22, Marko Kovacevic: > > > Updated the make build to fix external build issues > > > > Please explain what is the issue. > > > > > Fixes: 3a5c339d51a4 ("mk: support renamed Makefile in external project") > > > Cc: sta...@dpdk.org > > > > No n

[dpdk-dev] [PATCH v2 2/3] app/testpmd: fix port topology in RSS fwd config

The testpmd user can configure port topology mode to define the port topology between the testpmd forward ports(paired, chained and loop). When multi-queue ports are configured by the user, the testpmd streams are created by rss_fwd_config_setup() function, this function doesn't take into account

[dpdk-dev] [PATCH v2 0/3] testpmd: fix rss forward config

V2: split the fix patch to 2 patches. Matan Azrad (3): app/testpmd: fix port index in RSS fwd config app/testpmd: fix port topology in RSS fwd config app/testpmd: use dedicated function to get Tx port app/test-pmd/config.c | 85 +-- 1 file c

[dpdk-dev] [PATCH v2 3/3] app/testpmd: use dedicated function to get Tx port

A new function was added to get a Tx port index as a function of the topology mode and the Rx port index. Use this function to get the Tx port index of simple stream. Signed-off-by: Matan Azrad --- app/test-pmd/config.c | 31 +++ 1 file changed, 3 insertions(+), 28 d

[dpdk-dev] [PATCH v2 1/3] app/testpmd: fix port index in RSS fwd config

When multi-queue ports are configured by the user, the testpmd streams are created by rss_fwd_config_setup() function. This function may configure to the streams either invalid Rx ports or invalid Tx ports. An invalid Tx port is configured when the number of ports is odd. In this case, the last T

Re: [dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test

05/02/2018 12:31, Shreyansh Jain: > Device can only be started if firmware is loaded, as per Skeleton > rawdev driver semantics. This patch fixes original implementation > which attempted to start the device without loading firmware. > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Cc: s

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx4: fix Rx pkt offloads nonfrag indication

Monday, February 5, 2018 4:07 PM, Adrien Mazarguil > indication > > On Tue, Jan 30, 2018 at 07:02:51PM +0200, Moti Haimovsky wrote: > > This patch fixes the missing RTE_PTYPE_L4_NONFRAG on non-fragmented > IP > > packets with unrecognized payload type. > > > > Fixes: aee4a03fee4f ("net/mlx4: enhan

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

05/02/2018 14:44, Adrien Mazarguil: > On Mon, Feb 05, 2018 at 10:58:06AM -0200, Marcelo Ricardo Leitner wrote: > > On Mon, Feb 05, 2018 at 12:24:23PM +, Van Haaren, Harry wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marcelo Ricardo > > > > Leitner > > > > Sent: Monday, F

[dpdk-dev] [PATCH] doc: update the usage for shared library

Add note information to intimate about use of option '-d' for shared library in DPDK application. Signed-off-by: Vipin Varghese --- doc/guides/nics/build_and_test.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/build_and_test.rst b/doc/guides/nics/build_and_test.rst

Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage

On 2/1/2018 12:58 PM, Maxime Coquelin wrote: > > > On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: >> These patches fix a recent regression in librte_vhost that breaks the >> vhost_scsi example application. vhost_user.c assumes all devices are vhost >> net >> backends when handling the VIRTIO_NE

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

On 2/1/2018 2:47 PM, Yuanhan Liu wrote: > On Wed, Jan 31, 2018 at 05:48:28PM +, Stefan Hajnoczi wrote: >> The vhost_scsi example application negotiates the >> VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing >> vrings. >> >> In particular, commit e37ff954405addb8ea422426

[dpdk-dev] [PATCH] doc: update multiple instance info for NULL crypto

Add foot note & example to inform user how to use multiple instance. Signed-off-by: Vipin Varghese --- doc/guides/cryptodevs/null.rst | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/doc/guides/cryptodevs/null.rst b/doc/guides/cryptodevs/null.rst index 03

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

On Mon, Feb 05, 2018 at 03:16:21PM +0100, Thomas Monjalon wrote: > 05/02/2018 14:44, Adrien Mazarguil: > > On Mon, Feb 05, 2018 at 10:58:06AM -0200, Marcelo Ricardo Leitner wrote: > > > On Mon, Feb 05, 2018 at 12:24:23PM +, Van Haaren, Harry wrote: > > > > > From: dev [mailto:dev-boun...@dpdk.o

  1   2   >