[dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-10 Thread Ophir Munk
Prior to this commit the vdev_netvsc PMD was creating tap and failsafe devices with long names, such as "net_tap_net_vdev_netvsc0" or "net_failsafe_net_vdev_netvsc0". Long names containing more than 32 characters may be rejected by some APIs (e.g. membuf pool creation). This commits fixes this issu

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Wodkowski, PawelX
> # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \ > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index d84513e7f..2acfc908c 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Maxime Coquelin
Hi Pawel, On 04/10/2018 09:32 AM, Wodkowski, PawelX wrote: # all source are stored in SRCS-y SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \ diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c index d84513e7f..2acfc908c 100644 --- a/lib/librt

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, April 10, 2018 9:44 AM > To: Wodkowski, PawelX ; Zhang, Roy Fan > ; dev@dpdk.org > Cc: jianjay.z...@huawei.com; Tan, Jianfeng > Subject: Re: [PATCH] lib/librte_vhost: fix bugs > > Hi Pawel, >

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Maxime Coquelin
On 04/10/2018 09:47 AM, Wodkowski, PawelX wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Tuesday, April 10, 2018 9:44 AM To: Wodkowski, PawelX ; Zhang, Roy Fan ; dev@dpdk.org Cc: jianjay.z...@huawei.com; Tan, Jianfeng Subject: Re: [PATCH] lib/

Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: fix creating short name devices

2018-04-10 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Tuesday, April 10, 2018 10:20 AM > Prior to this commit the vdev_netvsc PMD was creating tap and failsafe > devices with long names, such as "net_tap_net_vdev_netvsc0" or > "net_failsafe_net_vdev_netvsc0". > Long names containing more than 32 characters may be rejected b

Re: [dpdk-dev] [PATCH v3] net/vhost: fix segfault when creating vdev dynamically

2018-04-10 Thread Chen, Junjie J
Thanks for report, I just summited this patch to fix: https://dpdk.org/dev/patchwork/patch/37765/ > > Hi, > > On Fri, Mar 30, 2018 at 02:58:31PM +0800, Junjie Chen wrote: > >When creating vdev dynamically, vhost pmd driver starts directly > >without checking TX/RX queues are ready or not, and t

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link status initialization

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:13:36AM +0300, Shahaf Shuler wrote: > Following commit 7ba5320baa32 ("net/mlx5: fix link status behavior") > The initial link status is no longer set as part of the port start. > > When LSC interrupts are enabled, ethdev layer reads the link status > directly from the de

Re: [dpdk-dev] [PATCH] ethdev: fix link status query

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote: > When application works with LSC interrupts the ethdev layer skips > the PMD callback and update according to the link status exists on > device data. It is because it assumes the link status on the device data > is the correct one sin

Re: [dpdk-dev] [PATCH] ethdev: fix link status query

2018-04-10 Thread Thomas Monjalon
10/04/2018 10:20, Nélio Laranjeiro: > On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote: > > When application works with LSC interrupts the ethdev layer skips > > the PMD callback and update according to the link status exists on > > device data. It is because it assumes the link status

Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-04-10 Thread Thomas Monjalon
Hi, 21/03/2018 12:11, Anoob Joseph: > Adding support for IPsec events in rte_eth_event framework. In inline > IPsec offload, the per packet protocol defined variables, like ESN, > would be managed by PMD. In such cases, PMD would need IPsec events > to notify application about various conditions l

Re: [dpdk-dev] [dpdk-dev, v1, 3/3] doc: update cryptodev documentation for set/get private data

2018-04-10 Thread Akhil Goyal
Hi Abhinandan, One minor comment. Series Acked-by: Akhil Goyal On 4/4/2018 12:04 PM, Abhinandan Gujjar wrote: Signed-off-by: Abhinandan Gujjar --- doc/guides/prog_guide/cryptodev_lib.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/guides/prog_guide/c

Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Tan, Jianfeng
Hi Junjie, I think the code is still buggy. As vhost thread and master thread are separately invoking new_device() and dev_start(). On 4/10/2018 10:18 PM, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing

2018-04-10 Thread Maxime Coquelin
On 04/09/2018 07:57 PM, Fan Zhang wrote: Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") This patch fixes the parsing of cryptodev id in the cmdline. Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 5 - 1 file changed, 5 deletions(-) di

Re: [dpdk-dev] [PATCH] vhost/crypto: fix session id printf

2018-04-10 Thread Maxime Coquelin
On 04/09/2018 08:21 PM, Fan Zhang wrote: Fixes: 85a2d5cab96f ("vhost/crypto: add virtio-crypto user message structure") Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_vhost/vhost_cry

Re: [dpdk-dev] [PATCH] vhost/crypto: fix makefile

2018-04-10 Thread Maxime Coquelin
On 04/09/2018 08:01 PM, Fan Zhang wrote: Fixes: 7b5ad7beee17 ("vhost/crypto: update makefile") Signed-off-by: Fan Zhang --- lib/librte_vhost/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 2cc65f95e.

[dpdk-dev] [PATCH v6 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-04-10 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patchset allows individual PMDs to specify their preferred parameter values, and if so indicated by a

[dpdk-dev] [PATCH v6 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-04-10 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton Revi

[dpdk-dev] [PATCH v6 2/4] net/e1000: add TxRx tuning parameters

2018-04-10 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton Revi

[dpdk-dev] [PATCH v6 3/4] net/i40e: add TxRx tuning parameters

2018-04-10 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton Revi

[dpdk-dev] [PATCH v6 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-10 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tuned parameter values. Signed-off-by: Remy Horton Acke

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Jasvinder Singh
IP_Pipeline app is not supported in FreeBSD environment. Therefore, skip it while building the sample apps on FreeBSD. Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface") Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") Signed-off-by: Jasvinder Singh Acked-by: Cristian Du

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 9, 2018 11:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix freebsd build error > > 09/04/2018 14:06, Jasvind

[dpdk-dev] DPDK techboard minutes of March 28

2018-04-10 Thread Thomas Monjalon
Meeting notes for the DPDK technical board meeting held on 2018-03-28 at 3pm UTC Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Olivier Matz - Thomas Monjalon 1/ Backup maintainers for som

[dpdk-dev] [PATCH] eal/ipc: stop async IPC loop on callback request

2018-04-10 Thread Anatoly Burakov
EAL did not stop processing further asynchronous requests on encountering a request that should trigger the callback. This resulted in erasing valid requests but not triggering them. Fix this by stopping the loop once we have a request that we can trigger. Also, remove unnecessary check for trigge

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Thomas Monjalon
10/04/2018 11:51, Jasvinder Singh: > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > skip it while building the sample apps on FreeBSD. [...] > --- a/examples/ip_pipeline/Makefile > +++ b/examples/ip_pipeline/Makefile > @@ -67,6 +67,13 @@ RTE_TARGET ?= x86_64-native-linuxapp-g

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: Add tunnel encap/decap actions

2018-04-10 Thread Adrien Mazarguil
On Mon, Apr 09, 2018 at 05:10:35PM +0100, Mohammad Abdul Awal wrote: > On 06/04/2018 21:26, Adrien Mazarguil wrote: > > On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote: > > > Add new flow action types and associated action data structures to > > > support the encapsulation and decaps

[dpdk-dev] [PATCH] vfio: fix device hotplug when several devices per group

2018-04-10 Thread Anatoly Burakov
We only need to perform DMA mapping for first device in first group. At the time of mapping, we haven't yet added the device into the group, so the count is expected to be zero. Fixes: 810bfa64c673 ("vfio: fix index for tracking devices in a group") Fixes: a9c349e3a100 ("vfio: fix device unplug wh

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, April 10, 2018 11:15 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build > error > > 10/04/2018 11:51,

Re: [dpdk-dev] [dpdk-dev, v1, 1/5] eventdev: add caps API and PMD callbacks for crypto adapter

2018-04-10 Thread Akhil Goyal
It would be good if we have a cover letter and description in the commit message. The patchset does not apply on eventdev subtree. Could you please rebase. I think there is a need to add struct rte_crypto_op in the rte_event word 1 union as you are adding crypto event. All crypto drivers would

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow RSS queue index check error

2018-04-10 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 10, 2018 10:19 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix flow RSS queue index check error > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Monday,

[dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-04-10 Thread Tosatti, Giovanni
This patch adds a " --restore" option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver. --- /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py +++ /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: Add tunnel encap/decap actions

2018-04-10 Thread Shahaf Shuler
Hi, Adding small comment on top of Adrien's Tuesday, April 10, 2018 1:20 PM, Adrien Mazarguil: > On Mon, Apr 09, 2018 at 05:10:35PM +0100, Mohammad Abdul Awal wrote: > > On 06/04/2018 21:26, Adrien Mazarguil wrote: > > > On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote: > > > > Add

Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-04-10 Thread Tosatti, Giovanni
--- /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py +++ /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dp +++ dk-16.07/tools/dpdk-devbind.py @@ -91,6 +91,9 @@ -u, --unbind: Unbind a device (Equivalent to \"-b

Re: [dpdk-dev] [PATCH] net/vhost: fix vhost invalid state

2018-04-10 Thread Jens Freimann
On Tue, Apr 10, 2018 at 10:18:09AM -0400, Junjie Chen wrote: dev_start sets *dev_attached* after setup queues, this sets device to invalid state since no frontend is attached. Also destroy_device set *started* to zero which makes *allow_queuing* always zero until dev_start get called again. Actua

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-10 Thread Neil Horman
On Mon, Apr 09, 2018 at 04:38:11PM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dumitrescu, Cristian > > Sent: Monday, April 9, 2018 4:59 PM > > To: Stephen Hemminger ; Singh, Jasvinder > > ; Richardson, Bruce > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH v7] net/virtio-user: add support for server mode

2018-04-10 Thread Maxime Coquelin
On 04/08/2018 02:36 AM, Tan, Jianfeng wrote: -Original Message- From: Yang, Zhiyong Sent: Friday, April 6, 2018 5:26 PM To:dev@dpdk.org Cc: Yang, Zhiyong;maxime.coque...@redhat.com; Tan, Jianfeng; Bie, Tiwei; Wang, Zhihong; Wang, Dong1;tho...@monjalon.net Subject: [PATCH v7] net/virti

[dpdk-dev] [PATCH v2] app/test: enhance cryptodev scheduler unit tests

2018-04-10 Thread Reshma Pattan
Unit Test Cases for MultiCore mode, Failover mode, Packet Distribution mode are added to improve code coverage Signed-off-by: Jananee Parthasarathy --- V2: Remove hard coding of core numbers in vdev init and add parsing for cmd line core mask. --- test/test/test_cryptodev.c | 127 +++

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Thomas Monjalon
10/04/2018 12:25, Singh, Jasvinder: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/04/2018 11:51, Jasvinder Singh: > > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > > skip it while building the sample apps on FreeBSD. > > [...] > > > --- a/examples/ip_pipeli

Re: [dpdk-dev] [PATCH] table: fix build error with gcc 8

2018-04-10 Thread Van Haaren, Harry
+CC Neil from other reply > From: Dumitrescu, Cristian > Sent: Monday, April 9, 2018 6:27 PM > To: Ananyev, Konstantin ; Van Haaren, Harry > ; Stephen Hemminger ; > Singh, Jasvinder ; Richardson, Bruce > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] table: fix build error with gcc 8 > > >

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Bruce Richardson
On Tue, Apr 10, 2018 at 02:19:38PM +0200, Thomas Monjalon wrote: > 10/04/2018 12:25, Singh, Jasvinder: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 10/04/2018 11:51, Jasvinder Singh: > > > > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > > > > skip it while bu

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error

2018-04-10 Thread Thomas Monjalon
10/04/2018 11:51, Jasvinder Singh: > IP_Pipeline app is not supported in FreeBSD environment. Therefore, > skip it while building the sample apps on FreeBSD. > > Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface") > Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") > > Sign

Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-04-10 Thread Burakov, Anatoly
On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote: This patch adds a " --restore" option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver. Hi Giovanni, Nitpicking the commit message, but I believe "unbind" here is a bit of a misnomer - one does not "unbind to

Re: [dpdk-dev] [PATCH v6 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-04-10 Thread Thomas Monjalon
10/04/2018 11:43, Remy Horton: > Changes in v6: > * Updated/corrected testpmd documentation > * Carried forward acks/review You forgot my ack on ethdev patch.

[dpdk-dev] [PATCH v2 3/5] ethdev: introduce tunnel type MPLS-in-GRE and MPLS-in-UDP

2018-04-10 Thread Xueming Li
This patch adds new tunnel type for MPLS-in-GRE and MPLS-in-UDP. MPLS-in-GRE protocol link: https://tools.ietf.org/html/rfc4023 MPLS-in-UDP protocol link: https://tools.ietf.org/html/rfc7510 Signed-off-by: Xueming Li --- lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.

[dpdk-dev] [PATCH v2 1/5] doc: remove RSS configuration change announcement

2018-04-10 Thread Xueming Li
Remove deprecation as implementation of RSS level provided in Adrien's patch set: http://www.dpdk.org/dev/patchwork/patch/37399/ Signed-off-by: Xueming Li --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/g

[dpdk-dev] [PATCH v2 0/5] introduce new tunnel types

2018-04-10 Thread Xueming Li
v2: - Split patch set into public and mlx5 two series, this one is the first. v1: - Support new tunnel type MPLS-in-GRE and MPLS-in-UDP - Remove deprecation notes of rss level This patchset introduced new tunnel type and related testpmd code: - New tunnel type VXLAN-GPE https://datatracker.ietf.

[dpdk-dev] [PATCH v2 2/5] ethdev: introduce new tunnel VXLAN-GPE

2018-04-10 Thread Xueming Li
VXLAN-GPE enables VXLAN for all protocols. Protocol link: https://datatracker.ietf.org/doc/draft-ietf-nvo3-vxlan-gpe/ Signed-off-by: Xueming Li --- lib/librte_ether/rte_eth_ctrl.h | 3 ++- lib/librte_ether/rte_flow.c | 1 + lib/librte_ether/rte_flow.h | 27 ++

[dpdk-dev] [PATCH v2 5/5] app/testpmd: add more GRE extension support to csum engine

2018-04-10 Thread Xueming Li
This patch adds GRE checksum and sequence extension supports in addtion to key extension to csum forwarding engine. Signed-off-by: Xueming Li --- app/test-pmd/csumonly.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-p

[dpdk-dev] [PATCH v2 4/5] app/testpmd: introduce new tunnel VXLAN-GPE

2018-04-10 Thread Xueming Li
Add VXLAN-GPE support to csum forwarding engine and rte flow. Signed-off-by: Xueming Li --- app/test-pmd/cmdline_flow.c | 24 ++ app/test-pmd/config.c | 2 + app/test-pmd/csumonly.c | 83 +-- app/test-pmd/parameters

[dpdk-dev] [PATCH] net/sfc: use default FEC mode

2018-04-10 Thread Andrew Rybchenko
All FEC modes are supported and allowed, but none are explicitly requested. This effectively means that FEC mode is determined solely form cable requirements and link partner capabilities / requirements. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_port.c | 10 ++ 1 file chan

Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding

2018-04-10 Thread Burakov, Anatoly
On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote: This patch adds a " --restore" option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver. --- /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py +++ /opt/Perfo

Re: [dpdk-dev] [PATCH v3] ethdev: return diagnostic when setting MAC address

2018-04-10 Thread Thomas Monjalon
06/04/2018 18:03, Ferruh Yigit: > On 4/6/2018 4:34 PM, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the PMD. > > > > The new default MAC address is now copied

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-10 Thread Zhang, Qi Z
Hi Konrad: Sorry for late reply. > -Original Message- > From: Jankowski, Konrad > Sent: Thursday, April 5, 2018 1:12 AM > To: Zhang, Qi Z ; Dai, Wei ; Xing, > Beilei ; Wu, Jingjing ; > dev@dpdk.org > Subject: RE: [PATCH] net/i40evf: regression fix - reenable interrupts in > handle

[dpdk-dev] [PATCH 1/3] net/vdev_netvsc: remove specified devices IP check

2018-04-10 Thread Matan Azrad
If the netvsc driver starts in blacklist mode, it does not automatically probe IP associated netvsc devices. Therefore, the only way to probe them is to specify them by the EAL command line, using the "force" parameter to skip the IP check in the driver. >From now on, the user does not need to add

[dpdk-dev] [PATCH 2/3] net/vdev_netvsc: add check for specifying by 1 way

2018-04-10 Thread Matan Azrad
There are now 2 ways to specify a netvsc device by the EAL command line - either by the interface name or by the MAC address. The user should not specify a netvsc device using more than 1 way, Thus, if a device is specified in more than 1 way, the driver stops to probe it. Validate it in the driv

[dpdk-dev] [PATCH 0/3] vdev_netvsc: improve the device args parameters meaning

2018-04-10 Thread Matan Azrad
After some experience with the device running, it is better to change the meaning of the "force" parameter in whitelist mode. Matan Azrad (3): net/vdev_netvsc: remove specified devices IP check net/vdev_netvsc: add check for specifying by 1 way net/vdev_netvsc: prefer netvsc devices in scan

[dpdk-dev] [PATCH 3/3] net/vdev_netvsc: prefer netvsc devices in scan

2018-04-10 Thread Matan Azrad
There is an option to run a non-netvsc device as a netvsc device only when the "force" parameter is set to 1 in the EAL command line. Consequently, more than one device may be found to be matching the "mac" parameter specifying the device. Prefer netvsc devices to be scanned before any non-netvsc

[dpdk-dev] [PATCH v2 00/15] mlx5 Rx tunnel offloading

2018-04-10 Thread Xueming Li
v2: - Split into 2 series: public api and mlx5, this one is the second. - Rebased on Adrien's rte flow overhaul: http://www.dpdk.org/ml/archives/dev/2018-April/095774.html v1: - Support new tunnel type MPLS-in-GRE and MPLS-in-UDP - Remove deprecation notes of rss level This patchset supports MLX

[dpdk-dev] [PATCH v2 04/15] net/mlx5: support Rx tunnel type identification

2018-04-10 Thread Xueming Li
This patch introduced tunnel type identification based on flow rules. If flows of multiple tunnel types built on same queue, RTE_PTYPE_TUNNEL_MASK will be returned, bits in flow mark could be used as tunnel type identifier. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 12

[dpdk-dev] [PATCH v2 02/15] net/mlx5: support GRE tunnel flow

2018-04-10 Thread Xueming Li
Support GRE tunnel type flow. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 69 +++- 1 file changed, 62 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 394760418..026952b46 100644

Re: [dpdk-dev] [PATCH v6] ethdev: replace bus specific struct with generic dev

2018-04-10 Thread Thomas Monjalon
09/04/2018 14:09, Ferruh Yigit: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way to get this informat

[dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-10 Thread Xueming Li
Adjust flow priority mapping to adapt new hardware 16 verb flow priorites support: 0-3: RTE FLOW tunnel rule 4-7: RTE FLOW non-tunnel rule 8-15: PMD control flow Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 10 drivers/net/mlx5/mlx5.h | 8 +++ drivers/net/mlx5/

[dpdk-dev] [PATCH v2 03/15] net/mlx5: support L3 vxlan flow

2018-04-10 Thread Xueming Li
This patch add L3 vxlan support, no inner L2 header comparing to standard vxlan protocol. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 026952b46.

[dpdk-dev] [PATCH v2 05/15] net/mlx5: support tunnel inner checksum offloads

2018-04-10 Thread Xueming Li
This patch support tunnel inner checksum offloads. By creating tunnel flow, once tunnel packet type(RTE_PTYPE_TUNNEL_xxx) identified, PKT_RX_IP_CKSUM_XXX and PKT_RX_L4_CKSUM_XXX represent checksum result of inner headers, outer L3 and L4 header checksum are always valid as soon as tunnel identified

[dpdk-dev] [PATCH v2 06/15] net/mlx5: split flow RSS handling logic

2018-04-10 Thread Xueming Li
This patch split out flow RSS hash field handling logic to dedicate function. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 94 +--- 1 file changed, 53 insertions(+), 41 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/m

[dpdk-dev] [PATCH v2 08/15] net/mlx5: add hardware flow debug dump

2018-04-10 Thread Xueming Li
Dump verb flow detail including flow spec type and size for debugging purpose. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 68 --- drivers/net/mlx5/mlx5_rxq.c | 25 +--- drivers/net/mlx5/mlx5_utils.h | 6 3 files chang

[dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-10 Thread Xueming Li
Tunnel RSS level of flow RSS action offers user a choice to do RSS hash calculation on inner or outer RSS fields. Testpmd flow command examples: GRE flow inner RSS: flow create 0 ingress pattern eth / ipv4 proto is 47 / gre / end actions rss queues 1 2 end level 1 / end GRE tunnel flow outer RS

[dpdk-dev] [PATCH v2 10/15] net/mlx5: allow flow tunnel ID 0 with outer pattern

2018-04-10 Thread Xueming Li
Tunnel w/o tunnel id pattern could match any non-tunneled packet, this patch allowed tunnel w/o tunnel id pattern after proper outer spec. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH v2 12/15] doc: update mlx5 guide on tunnel offloading

2018-04-10 Thread Xueming Li
Remove tunnel limitations, add new hardware tunnel offload features. Signed-off-by: Xueming Li --- doc/guides/nics/mlx5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index b1bab2ce2..c256f85f3 100644 --- a/doc/guid

[dpdk-dev] [PATCH v2 09/15] net/mlx5: introduce VXLAN-GPE tunnel type

2018-04-10 Thread Xueming Li
Add VXLAN-GPE support to rte flow. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 95 +++- drivers/net/mlx5/mlx5_rxtx.c | 3 +- 2 files changed, 95 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/m

[dpdk-dev] [PATCH v2 11/15] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-04-10 Thread Xueming Li
This patch supports new tunnel type MPLS-in-GRE and MPLS-in-UDP. Flow pattern example: ipv4 proto is 47 / gre proto is 0x8847 / mpls ipv4 / udp dst is 6635 / mpls / end Signed-off-by: Xueming Li --- drivers/net/mlx5/Makefile| 5 ++ drivers/net/mlx5/mlx5.c | 15 + drivers/net/

[dpdk-dev] [PATCH v2 15/15] net/mlx5: support RSS configuration in isolated mode

2018-04-10 Thread Xueming Li
Enable RSS related configuration in isolated mode. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 2124439b3..ad36d51c6 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx

[dpdk-dev] [PATCH v2 13/15] net/mlx5: setup RSS flow regardless of queue count

2018-04-10 Thread Xueming Li
In some environments it is desirable to have the NIC perform RSS normally on the packet regardless of the number of queues configured. The RSS hash result that is stored in the mbuf can then be used by the application to make decisions about how to distribute workloads to threads, secondary process

[dpdk-dev] [PATCH v2 14/15] net/mlx5: fix invalid flow item check

2018-04-10 Thread Xueming Li
This patch fixed invalid flow item check. Fixes: 4f1a88e3f9b0 ("net/mlx5: standardize on negative errno values") Cc: nelio.laranje...@6wind.com Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH] eal/ipc: stop async IPC loop on callback request

2018-04-10 Thread Tan, Jianfeng
On 4/10/2018 6:03 PM, Anatoly Burakov wrote: EAL did not stop processing further asynchronous requests on encountering a request that should trigger the callback. This resulted in erasing valid requests but not triggering them. That means one wakeup could process multiple replies, and followi

Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup

2018-04-10 Thread Thomas Monjalon
Hi, Please replace ether and etherdev by ethdev (in title and text). 08/04/2018 04:42, Qi Zhang: > The patch let etherdev driver expose the capability flag through > rte_eth_dev_info_get when it support runtime queue configuraiton, typo: configuration > then base on the flag rte_eth_[rx|tx]_que

Re: [dpdk-dev] [PATCH v2 4/5] app/testpmd: introduce new tunnel VXLAN-GPE

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:00:35PM +0800, Xueming Li wrote: > Add VXLAN-GPE support to csum forwarding engine and rte flow. > > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline_flow.c | 24 ++ > app/test-pmd/config.c | 2 + > app/test-pmd/csumonly.c

Re: [dpdk-dev] [PATCH v2 0/4] rte_flow extension for vSwitch acceleration

2018-04-10 Thread Thomas Monjalon
Adrien, How this series integrate with yours? Please, we need your review here. 01/04/2018 23:19, Qi Zhang: > v2: > - fix couple typoes in code, doc and commit log > > This patch extend rte_flow API. > The purpose is to provide necessary programming interface for virtual > switch software (su

Re: [dpdk-dev] [PATCH] rawdev: add to meson build

2018-04-10 Thread Bruce Richardson
On Mon, Apr 09, 2018 at 08:07:41PM +0530, Shreyansh Jain wrote: > On Wednesday 04 April 2018 03:42 PM, Bruce Richardson wrote: > > Add librte_rawdev to the meson build of DPDK. > > > > Signed-off-by: Bruce Richardson > > --- > > config/rte_config.h | 3 +++ > > lib/librte_rawdev/meso

Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support

2018-04-10 Thread Bruce Richardson
On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > The make based build system has crc+crypto instruction > support for the default arm64 build. > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > This patch fixes the disparity with meson build flags for armv8. > A

Re: [dpdk-dev] [PATCH] eal/ipc: stop async IPC loop on callback request

2018-04-10 Thread Burakov, Anatoly
On 10-Apr-18 2:53 PM, Tan, Jianfeng wrote: On 4/10/2018 6:03 PM, Anatoly Burakov wrote: EAL did not stop processing further asynchronous requests on encountering a request that should trigger the callback. This resulted in erasing valid requests but not triggering them. That means one wakeup

Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support

2018-04-10 Thread Richardson, Bruce
Resend, fixing "To" recipients. > -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, April 10, 2018 3:17 PM > To: Jerin Jacob > Cc: dev@dpdk.org; herbert.g...@arm.com; pbhagavat...@caviumnetworks.com; > hemant.agra...@nxp.com; sta...@dpdk.org;

Re: [dpdk-dev] [PATCH] app/test: enhance power manager unit tests

2018-04-10 Thread Hunt, David
Hi Reshma, On 6/4/2018 2:51 PM, Reshma Pattan wrote: Unit Testcases are added for power_acpi_cpu_freq, power_kvm_vm_test to improve coverage Signed-off-by: Jananee Parthasarathy --- test/test/test_power_acpi_cpufreq.c | 2 +- test/test/test_power_kvm_vm.c | 62 ++

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-04-10 Thread Jankowski, Konrad
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, April 10, 2018 2:26 PM > To: Jankowski, Konrad ; Dai, Wei > ; Xing, Beilei ; Wu, Jingjing > ; dev@dpdk.org > Subject: RE: [PATCH] net/i40evf: regression fix - reenable interrupts in > handler > > Hi Konrad: > Sorry fo

Re: [dpdk-dev] [RFC 0/2] TAP TSO Implementation

2018-04-10 Thread Ferruh Yigit
On 4/9/2018 11:37 PM, Ophir Munk wrote: > Patch sent for this release. > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Monday, April 09, 2018 7:39 PM >> To: Ophir Munk ; dev@dpdk.org; Pascal Mazon >> >> Cc: Thomas Monjalon ; Olga Shern >> >> Subject

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:34:01PM +0800, Xueming Li wrote: > Adjust flow priority mapping to adapt new hardware 16 verb flow > priorites support: > 0-3: RTE FLOW tunnel rule > 4-7: RTE FLOW non-tunnel rule > 8-15: PMD control flow This commit log is inducing people in error, this amount of priori

Re: [dpdk-dev] [PATCH v2 03/15] net/mlx5: support L3 vxlan flow

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:34:03PM +0800, Xueming Li wrote: > This patch add L3 vxlan support, no inner L2 header comparing to > standard vxlan protocol. > > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_flow.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a

Re: [dpdk-dev] [RFC 00/24] vhost: add virtio-vhost-user transport

2018-04-10 Thread Wang, Wei W
On Tuesday, April 10, 2018 5:39 PM, Stefan Hajnoczi wrote: > Wei: Are you still interested in this? > > In order to make further progress a review of this patch series is required. > > If it's not a priority for you, that's fine too. We can leave it and > pick it up (or replace it with somethin

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-04-10 Thread Ferruh Yigit
On 4/6/2018 11:32 PM, Scott Branden wrote: > > > On 18-04-06 02:31 PM, Ferruh Yigit wrote: >> On 4/6/2018 7:10 PM, Scott Branden wrote: >>> Hi Ferruh, >>> >>> Somehow I did not receive your other email so Ajit fowarded it to me.  So I >>> am >>> responding to it here. >>> >>> Sorry for the previ

Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64

2018-04-10 Thread Thomas Monjalon
06/04/2018 20:25, Pavan Nikhilesh: > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > 06/04/2018 13:01, Pavan Nikhilesh: > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > > Pleas

Re: [dpdk-dev] [PATCH] hash: fix missing spinlock unlock in add key

2018-04-10 Thread Thomas Monjalon
> > Fix missing spinlock unlock during add key when key is already present. > > > > Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel > > TSX") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH v1] mk: fix make defconfig on FreeBSD

2018-04-10 Thread David Hunt
Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig") Signed-off-by: David Hunt --- mk/rte.sdkconfig.mk | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk index 0664725ee..7b1684375 100644 --- a/mk/r

Re: [dpdk-dev] [PATCH v2] ip_frag: fix double free of chained mbufs

2018-04-10 Thread Thomas Monjalon
Please, any review? 19/03/2018 15:25, Allain Legacy: > The first mbuf and the last mbuf to be visited in the preceding loop > are not set to NULL in the fragmentation table. This creates the > possibility of a double free when the fragmentation table is later freed > with rte_ip_frag_table_destro

Re: [dpdk-dev] [PATCH] eal/ipc: stop async IPC loop on callback request

2018-04-10 Thread Tan, Jianfeng
On 4/10/2018 10:17 PM, Burakov, Anatoly wrote: On 10-Apr-18 2:53 PM, Tan, Jianfeng wrote: On 4/10/2018 6:03 PM, Anatoly Burakov wrote: EAL did not stop processing further asynchronous requests on encountering a request that should trigger the callback. This resulted in erasing valid request

Re: [dpdk-dev] [PATCH v2 04/15] net/mlx5: support Rx tunnel type identification

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:34:04PM +0800, Xueming Li wrote: > This patch introduced tunnel type identification based on flow rules. > If flows of multiple tunnel types built on same queue, > RTE_PTYPE_TUNNEL_MASK will be returned, bits in flow mark could be used > as tunnel type identifier. I don'

Re: [dpdk-dev] [PATCH v2 01/15] net/mlx5: support 16 hardware priorities

2018-04-10 Thread Xueming(Steven) Li
Hi Nelio, > -Original Message- > From: Nélio Laranjeiro > Sent: Tuesday, April 10, 2018 10:42 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 01/15] net/mlx5: support 16 hardware priorities > > On Tue, Apr 10, 2018 at 09:34:01PM +0800, Xueming Li

Re: [dpdk-dev] [PATCH v2 05/15] net/mlx5: support tunnel inner checksum offloads

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:34:05PM +0800, Xueming Li wrote: > This patch support tunnel inner checksum offloads. By creating tunnel > flow, once tunnel packet type(RTE_PTYPE_TUNNEL_xxx) identified, Where is the code creating the tunnel flow? > PKT_RX_IP_CKSUM_XXX and PKT_RX_L4_CKSUM_XXX represent

Re: [dpdk-dev] [PATCH v2 06/15] net/mlx5: split flow RSS handling logic

2018-04-10 Thread Nélio Laranjeiro
On Tue, Apr 10, 2018 at 09:34:06PM +0800, Xueming Li wrote: > This patch split out flow RSS hash field handling logic to dedicate > function. > > Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 94 > +--- > 1

Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces

2018-04-10 Thread Ferruh Yigit
On 4/6/2018 3:12 PM, Matej Vido wrote: > NFB cards employ multiple Ethernet ports. > Until now, Ethernet port-related operations were performed on all of them > (since the whole card was represented as a single port). > With new NFB-200G2QL card, this is no longer viable. > > Since there is no fix

  1   2   3   >