On 04/17/2018 04:12 PM, Ferruh Yigit wrote:
Make CRC stripping default behavior, deprecate flag
DEV_RX_OFFLOAD_CRC_STRIP.
Signed-off-by: Ferruh Yigit
Acked-by: Andrew Rybchenko
On 4/17/2018 1:58 PM, Iremonger, Bernard wrote:
> Hi Scott, Ajit,
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ajit Khaparde
>> Sent: Monday, April 16, 2018 9:51 PM
>> To: dev@dpdk.org
>> Cc: Scott Branden
>> Subject: [dpdk-dev] [PATCH] igb_uio: only che
This patchset contains the first compression PMD written under the DPDK
compression API, compressdev. The ISA-L compression driver utilizes
Intel's ISA-L compression library. It therefore has dependencies on both
compressdev and the ISA-L library, v2.22.0.
V2:
- Changes to keep in compliance wit
Signed-off-by: Lee Daly
---
config/common_base | 5 +
doc/guides/rel_notes/release_18_05.rst | 6 ++
drivers/Makefile | 2 ++
drivers/compress/Makefile | 8 +++
drivers/compress/isal/Makefile
Signed-off-by: Lee Daly
---
drivers/compress/isal/Makefile| 1 +
drivers/compress/isal/isal_compress_pmd.c | 96 ++-
drivers/compress/isal/isal_compress_pmd_ops.c | 25 ++
drivers/compress/isal/isal_compress_pmd_private.h | 24 ++
drive
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd_ops.c | 62 +--
drivers/compress/isal/isal_compress_pmd_private.h | 12 +
2 files changed, 69 insertions(+), 5 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
b/drivers/compre
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd.c | 187 ++
drivers/compress/isal/isal_compress_pmd_ops.c | 96 ++-
drivers/compress/isal/isal_compress_pmd_private.h | 12 ++
3 files changed, 292 insertions(+), 3 deletions(-)
diff --g
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd_ops.c | 110 +-
drivers/compress/isal/isal_compress_pmd_private.h | 2 +
2 files changed, 110 insertions(+), 2 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
b/drivers/compress
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd_ops.c | 33 +--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
b/drivers/compress/isal/isal_compress_pmd_ops.c
index 1690c34..0fcb899 100644
-
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd.c | 56 ++-
drivers/compress/isal/isal_compress_pmd_ops.c | 2 +
2 files changed, 49 insertions(+), 9 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd.c
b/drivers/compress/isal/isal
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd.c | 108 +-
drivers/compress/isal/isal_compress_pmd_ops.c | 25 +
drivers/compress/isal/isal_compress_pmd_private.h | 2 +
3 files changed, 133 insertions(+), 2 deletions(-)
diff --git a/dr
Signed-off-by: Lee Daly
---
drivers/compress/isal/isal_compress_pmd.c | 58 +++
drivers/compress/isal/isal_compress_pmd_ops.c | 8
drivers/compress/isal/isal_compress_pmd_private.h | 2 +
3 files changed, 68 insertions(+)
diff --git a/drivers/compress/isal/
On 4/17/2018 2:12 PM, Ferruh Yigit wrote:
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: Ferruh Yigit
>
> ---
> v2:
> * Make CRC behavior active in this release
>
> v3:
> * Distribute switch into next two releases for more smooth transition
Signed-off-by: Lee Daly
---
MAINTAINERS| 6 ++
doc/guides/compressdevs/features/default.ini | 42 +++
doc/guides/compressdevs/index.rst | 12
doc/guides/compressdevs/overview.rst | 12
doc/guides/compr
Signed-off-by: Lee Daly
---
MAINTAINERS | 5 ++
devtools/test-build.sh| 4 ++
doc/guides/compressdevs/features/isal.ini | 40 +
doc/guides/compressdevs/index.rst | 1 +
doc/guides/compressdevs/isal.rst | 94
IXGBE vector PMD was re-enabled for 32 bits, but only for gcc.
This commit enables it for icc too.
Fixes: e6672d2f0f88 ("net/ixgbe: enable ixgbe vector PMD for i686")
Cc: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
config/defconfig_i686-native-linuxapp-icc | 5 -
1 file changed, 5 dele
Make CRC stripping default behavior, deprecate flag
DEV_RX_OFFLOAD_CRC_STRIP.
Signed-off-by: Ferruh Yigit
Acked-by: Andrew Rybchenko
---
v2:
* Make CRC behavior active in this release
v3:
* Distribute switch into next two releases for more smooth transition
v18.08: add new flag to keep crc, a
On 4/17/2018 12:53 PM, Thomas Monjalon wrote:
> 17/04/2018 13:23, Ferruh Yigit:
>> On 4/17/2018 9:33 AM, Shahaf Shuler wrote:
>>> According to
>>>
>>> commit 315ee8374e0e ("doc: reduce initial offload API rework scope
>>> to drivers")
>>>
>>> All PMDs should have moved to the new o
Tuesday, April 17, 2018 4:40 PM, Ferruh Yigit:
> Subject: [PATCH v4] doc: announce ethdev CRC strip flag deprecation
>
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: Ferruh Yigit
> Acked-by: Andrew Rybchenko
> ---
> v2:
> * Make CRC behavior
Hi,
> -Original Message-
> From: Gujjar, Abhinandan S
> Sent: Monday, April 16, 2018 10:36 AM
> To: Akhil Goyal ; De Lara Guarch, Pablo
> ; Doherty, Declan
> ; jerin.ja...@caviumnetworks.com;
> hemant.agra...@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender ; Rao, Nikhil
>
> Subject: RE: [v3
> -Original Message-
> From: Dai, Wei
> Sent: Monday, April 16, 2018 4:14 PM
> To: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Zhang, Qi Z ; Lin,
> Xueqin
> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: fix segfault in configuring VF VLAN strip
>
> This patch fixe
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, April 17, 2018 2:34 PM
> To: Iremonger, Bernard ; Ajit Khaparde
> ; dev@dpdk.org
> Cc: Scott Branden
> Subject: Re: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in
> supported
> by linux kernel
>
> On 4/17/2018 1:58 PM
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, April 17, 2018 12:25 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v2 3/4] net/netvsc: add documentation
>
> Matching documentation for new netvsc
Hi Li,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, April 16, 2018 11:46 PM
> To: Xueming Li
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing
> ; Yongseok Koh ; Olivier MATZ
> ; Shahaf Shuler ; Yigit,
> Ferruh
> Subject: Re: [d
> -Original Message-
> From: Gujjar, Abhinandan S
> Sent: Monday, April 16, 2018 7:55 AM
> To: De Lara Guarch, Pablo ; Doherty, Declan
> ; jerin.ja...@caviumnetworks.com;
> hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org
> Cc: Vangati, Narender ; Gujjar, Abhinandan S
> ; Rao, Ni
On 17-Apr-18 12:47 PM, Thomas Monjalon wrote:
I see no reason to accept this patch, replacing strdup by snprintf,
given that we have strlcpy.
Please do a v3 with strlcpy.
OK. Please also fix the typo in patch headline :)
--
Thanks,
Anatoly
On 4/17/2018 10:07 AM, Alejandro Lucero wrote:
>
> On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou wrote:
Fixes: c7e9729da6b5 ("net/nfp: support CPP")
>> Signed-off-by: Yangchao Zhou
> Acked-by: Alejandro Lucero
Applied to dpdk-next-net/master, thanks.
> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, April 17, 2018 9:56 PM
> To: Thomas Monjalon ; Xueming(Steven) Li
>
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing
> ; Yongseok
> Koh ; Olivier MATZ ; Shahaf
> Shuler ;
> Yigit, Ferruh
> Subject: RE: [dpdk-dev] [PATCH v
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday, April 17, 2018 8:14 AM
> To: jerin.ja...@caviumnetworks.com; Carrillo, Erik G
>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] eventdev: fix icc build
>
> ICC complains about variable being used before its
On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote:
> Support for PCAP MAC address using physical interface MAC.
> Support for getting proper link status, speed and duplex.
>
> Signed-off-by: Juhamatti Kuusisaari
> ---
> config/common_base | 1 +
> drivers/net/pcap/rte_eth_pcap.c | 5
Hi Abhinandan,
I have not reviewed the patch completely. But I have below query for
further review.
On 4/4/2018 12:26 PM, Abhinandan Gujjar wrote:
Signed-off-by: Abhinandan Gujjar
Signed-off-by: Nikhil Rao
Signed-off-by: Gage Eads
---
[..snip..]
+
+int __rte_experimental
+rte_event_crypt
On 4/17/2018 10:16 AM, Alejandro Lucero wrote:
> This patch allows to use another MAC address than the one coming
> with the NIC by default.
>
> The change requires to tell the vNIC after writing into the port
> BAR space. The change will fail if the port is enabled and the
> vNIC does not support
"port config all rss all" command will fail on PMD that not support any
of hard coding RSS hash types. This patch changed hard coding hash types
to supported types retrieved from device info.
Signed-off-by: Xueming Li
---
app/test-pmd/cmdline.c | 7 +++
1 file changed, 7 insertions(+)
diff
Add supported RSS hash function check in device configuration to
have better error verbosity for application developers.
Signed-off-by: Xueming Li
---
lib/librte_ether/rte_ethdev.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/libr
Hi Lu,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li
> Sent: Sunday, April 8, 2018 1:33 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Thomas Monjalon ;
> Yongseok Koh ; Olivier MATZ
> ; Shahaf Shuler
> Cc: Xueming Li ; Yigit, Ferruh
> ; dev@dpdk.org
> Su
New test created to measure offload cost.
Changes were introduced in API, turbo software driver
and test application.
Signed-off-by: KamilX Chalupnik
v2:
- logging macros reverted
---
app/test-bbdev/test_bbdev_perf.c | 333 ++-
drivers/baseband/turbo_sw/bbde
Optimization of Turbo Software driver:
- resource-hungry piece of code removed or optimized
- validation of decoder/encoder parameters put under debug flug
Signed-off-by: KamilX Chalupnik
v2:
- logging macros fixed
---
drivers/baseband/turbo_sw/bbdev_turbo_software.c | 170 ++--
On 06/04/2018 9:27 PM, Adrien Mazarguil wrote:
On Fri, Apr 06, 2018 at 01:24:03PM +0100, Declan Doherty wrote:
Introduces a new action type RTE_FLOW_ACTION_TYPE_METADATA which enables
metadata extraction from a packet into a specified metadata container
for consumption on further pipeline stages
On 06/04/2018 9:26 PM, Adrien Mazarguil wrote:
On Fri, Apr 06, 2018 at 01:24:02PM +0100, Declan Doherty wrote:
Add group action type which defines a terminating action which
allows a matched flow to be redirect to a group. This allows logical
flow table hierarchies to be managed through rte_flow
Splitting Queue Groups into UL/DL Groups in Turbo Software
Driver. The are independent for Decode/Encode
Signed-off-by: KamilX Chalupnik
v2:
- logging macros fixed
---
app/test-bbdev/test_bbdev.c | 29 +---
drivers/baseband/null/bbdev_null.c
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Monday, April 16, 2018 10:14 AM
> To: Hemant Agrawal ; dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; dpdk-
> u...@nxp1.onmicrosoft.com
> Subject: Re: [PATCH 1/2] crypto/dpaa_sec: improve the error checking
>
> On
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Monday, April 16, 2018 10:15 AM
> To: Hemant Agrawal ; dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; dpdk-
> u...@nxp1.onmicrosoft.com
> Subject: Re: [PATCH 2/2] crypto/dpaa2_sec: improve error handling
>
> On 4/5
V5:
- Removed duplicated testpmd patch in other pathset.
- More comments on PKT_TX_TUNNEL_IP and PKT_TX_TUNNEL_UDP
V4:
- Removed DEV_TX_OFFLOAD_GENERIC_TNL_CKSUM and DEV_TX_OFFLOAD_GENERIC_TNL_TSO
- Replaced with DEV_TX_OFFLOAD_IP_TNL_TSO
- Removed PKT_TX_OUTER_UDP
- Splited PKT_TX_TUNNEL_UNKNOWN
Update Turbo Software driver for Wireless Baseband Device:
- support for optional CRC overlap in decode processing implemented
- function scaling input LLR values to specific range [-16, 16] added
- sizes of the internal buffers used by decoding were increased due to
problem with memory for large
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Wednesday, April 11, 2018 10:16 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> akhil.go...@nxp.com; dpdk...@nxp1.onmicrosoft.com
> Subject: [PATCH] examples/l2fwd-crypto: fix the default aead assign
This patch introduce new TX offload flags for device that supports
IP or UDP tunneled packet L3/L4 checksum and TSO offload.
The support from the device is for inner and outer checksums on
IPV4/TCP/UDP and TSO for *any packet with the following format*:
/ [optional IPv4/IPv6] / [optional TCP/UDP
"show port cap" and "csum parse tunnel" command support TX generic
tunnel offloads
Signed-off-by: Xueming Li
---
app/test-pmd/cmdline.c | 14 --
app/test-pmd/config.c | 17 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app
On Tue, Apr 17, 2018 at 03:22:06PM +0200, Thomas Monjalon wrote:
> 12/04/2018 07:16, Junjie Chen:
> > From: "Chen, Junjie"
> >
> > Sometimes gcc does not inline the function despite keyword *inline*,
> > we obeserve rte_movX is not inline when doing performance profiling,
> > so use *always_inlin
On 06/04/2018 9:26 PM, Adrien Mazarguil wrote:
On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote:
Add new flow action types and associated action data structures to
support the encapsulation and decapsulation of the virtual tunnel
endpoints.
The RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP ac
On Tue, Apr 17, 2018 at 02:17:19PM +0100, Jasvinder Singh wrote:
> The destination string may not have a null termination if
> the source string's length is equal to the sizeof(tap->name).
>
> Fix by replacing strncpy with strlcpy that guarantees NULL-termination.
>
> Coverty issue: 272603
> Fixe
On Tue, Apr 17, 2018 at 02:28:25PM +0100, Jasvinder Singh wrote:
> The destination string may not have a null termination if
> the source string's length is equal to the sizeof(pipeline->name).
>
> Fix by replacing strncpy with strlcpy that guarantees NULL-termination.
>
> Coverty issue: 272606
>
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Wednesday, April 11, 2018 10:16 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ;
> akhil.go...@nxp.com; dpdk...@nxp1.onmicrosoft.com
> Subject: [PATCH] examples/l2fwd-crypto: fix the default aead assign
> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Monday, April 9, 2018 9:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Hemant Agrawal
>
> Subject: [PATCH] test/crypto-perf: add missing SPDX identifier
>
> Cc: pablo.de.lara.gua...@intel.com
>
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Tuesday, April 17, 2018 4:08 PM
> To: 'Hemant Agrawal' ; dev@dpdk.org
> Subject: RE: [PATCH] test/crypto-perf: add missing SPDX identifier
>
>
>
> > -Original Message-
> > From: Hemant Agrawal [mailto:hemant.agra...@nxp
Hi Li,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li
> Sent: Friday, April 13, 2018 12:02 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Thomas Monjalon ; Adrien
> Mazarguil
> Cc: Xueming Li ; Nelio Laranjeiro
> ; Shahaf Shuler ;
> dev@dpdk.org; Olivier M
Hi Li,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li
> Sent: Friday, April 13, 2018 12:02 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Thomas Monjalon ; Adrien
> Mazarguil
> Cc: Xueming Li ; Nelio Laranjeiro
> ; Shahaf Shuler ;
> dev@dpdk.org; Olivier M
From: Ivan Malov
Fixes: 4ec1fc3ba881 ("net/sfc: add basic stubs for RSS support on driver
attach")
Cc: sta...@dpdk.org
Signed-off-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/sfc/sfc.c b/drivers/net
Disclaimer: this patch must not be confused with the CLI library [1]
(work in progress) that will eventually supersede librte_cmdline itself
with a different API.
Rather, it modifies librte_cmdline to delegate all the heavy lifting
(terminal and history handling), strips unused features and re-imp
VXLAN-GPE enables VXLAN for all protocols. Protocol link:
https://www.ietf.org/id/draft-ietf-nvo3-vxlan-gpe-05.txt
Signed-off-by: Xueming Li
Acked-by: Adrien Mazarguil
Acked-by: Thomas Monjalon
Acked-by: Mohammad Abdul Awal
---
doc/guides/prog_guide/rte_flow.rst | 12
lib/librte_
Add VXLAN-GPE support to csum forwarding engine and rte flow.
Signed-off-by: Xueming Li
Acked-by: Adrien Mazarguil
Acked-by: Thomas Monjalon
---
app/test-pmd/cmdline_flow.c | 24 +
app/test-pmd/config.c | 2 +
app/test-pmd/csumonly.c
Remove deprecation as implementation of RSS level provided in Adrien's
patch set: http://www.dpdk.org/dev/patchwork/patch/37399/
Signed-off-by: Xueming Li
Acked-by: Adrien Mazarguil
Acked-by: Thomas Monjalon
---
doc/guides/rel_notes/deprecation.rst | 4
1 file changed, 4 deletions(-)
dif
v5:
- Fixed VXLAN-GPE comment alignment
v4:
- Update testpmd doc for flow VXLAN-GPE paramter.
v3:
- Change VXLAN-GPE definition order to avoid ABI compatibility issue.
v2:
- Split patch set into public and mlx5 two series, this one is the first.
v1:
- Support new tunnel type MPLS-in-GRE and MPLS-in
This patch adds GRE checksum and sequence extension supports in addtion
to key extension to csum forwarding engine.
Signed-off-by: Xueming Li
Acked-by: Thomas Monjalon
---
app/test-pmd/csumonly.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/app/test-
This patch supports new 16 Verbs flow priorities by trying to create a
simple flow of priority 15. If 16 priorities not available, fallback to
traditional 8 priorities.
Verb priority mapping:
8 priorities>=16 priorities
Control flow: 4-7 8-15
User
v4:
- Fix RSS level according to value defination
- Add "Inner RSS" column to NIC feature doc
- Fixed flow creation error in case of ipv4 rss on ipv6 pattern
- new patch: enforce IP protocol of GRE to be 47.
- Removed MPLS-in-UDP and MPLS-in-GRE replated patchset
- Removed invalid RSS type check
v3
This patch introduced tunnel type identification based on flow rules.
If flows of multiple tunnel types built on same queue,
RTE_PTYPE_TUNNEL_MASK will be returned, user application could use bits
in flow mark as tunnel type identifier.
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_flow.c
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_flow.c | 101 ---
1 file changed, 94 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 39c19abce..771d5f14d 100644
--- a/drivers/net/mlx5/mlx5_fl
This patch support L3 VXLAN, no inner L2 header comparing to standard
VXLAN protocol. L3 VXLAN using specific overlay UDP destination port to
discriminate against standard VXLAN, FW has to be configured to support
it:
sudo mlxconfig -d -y s IP_OVER_VXLAN_EN=1
sudo mlxconfig -d -y s IP_OVER_VX
This patch split out flow RSS hash field handling logic to dedicate
function.
Signed-off-by: Xueming Li
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_flow.c | 126 +++
1 file changed, 68 insertions(+), 58 deletions(-)
diff --git a/drivers/net/mlx5
Tunnel RSS level of flow RSS action offers user a choice to do RSS hash
calculation on inner or outer RSS fields. Testpmd flow command examples:
GRE flow inner RSS:
flow create 0 ingress pattern eth / ipv4 proto is 47 / gre / end
actions rss queues 1 2 end level 1 / end
GRE tunnel flow outer RS
This patch cleanup tunnel checksum offloads.
Once tunnel packet type(RTE_PTYPE_TUNNEL_xxx) identified,
PKT_RX_IP_CKSUM_XXX and PKT_RX_L4_CKSUM_XXX represent checksum result of
inner headers, outer L3 and L4 header checksum are always valid as soon
as tunnel identified. If no tunnel identified, PKT
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_flow.c | 99 +++-
drivers/net/mlx5/mlx5_rxtx.c | 3 +-
2 files changed, 99 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 371d029c8..1a7601cd
Dump verb flow detail including flow spec type and size for debugging
purpose.
Signed-off-by: Xueming Li
---
drivers/net/mlx5/mlx5_flow.c | 68 ---
drivers/net/mlx5/mlx5_rxq.c | 25 +---
drivers/net/mlx5/mlx5_utils.h | 6
3 files chang
Tunnel w/o tunnel id pattern could match any non-tunneled packet,
this patch allowed tunnel w/o tunnel id pattern after proper outer spec.
Signed-off-by: Xueming Li
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_flow.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/
VXLAN-GPE enables VXLAN for all protocols. Protocol link:
https://www.ietf.org/id/draft-ietf-nvo3-vxlan-gpe-05.txt
Signed-off-by: Xueming Li
Acked-by: Adrien Mazarguil
Acked-by: Thomas Monjalon
Acked-by: Mohammad Abdul Awal
---
doc/guides/prog_guide/rte_flow.rst | 12
lib/librte_
Remove tunnel limitations, add new hardware tunnel offload features.
Signed-off-by: Xueming Li
---
doc/guides/nics/features/default.ini | 1 +
doc/guides/nics/features/mlx5.ini| 3 +++
doc/guides/nics/mlx5.rst | 22 --
3 files changed, 24 insertions(+), 2 de
Hi Bernard,
> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, April 17, 2018 11:16 PM
> To: Xueming(Steven) Li ; Lu, Wenzhuo
> ; Wu, Jingjing
> ; Thomas Monjalon ; Adrien
> Mazarguil
>
> Cc: Nélio Laranjeiro ; Shahaf Shuler
> ; dev@dpdk.org;
> Olivier Matz
> Subject: R
This patchset fixes a few Coverity fixes in EAL introduced
by recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272600 - negative return not handled
- 272607 - error condition not handled
One of existing coverity issues is not fixed by this patchset:
- 272585 - memory leak
due to bei
Coverity issue: 272607
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxap
Value returned by rte_socket_id_by_idx() may be negative, which would
result in negative array index access.
Coverity issue: 272600
Fixes: b666f17858a3 ("mem: read hugepage counts from node-specific sysfs path")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/li
This patchset fixes a number of Coverity issues introduced
in recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272564 - error condition not checked
- 272579 - dereference before null check
- 272586 - error condition not checked
There are two additional issues reported by coverity:
-
We get pointer to mask before we check if fbarray is NULL. Fix
by moving getting mask pointer to until after NULL check.
Coverity issue: 272579
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/comm
sysconf() may return a negative value, check for it.
Coverity issue: 272586
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_fbarray.c | 3 +++
1 file changed, 3 insertions(+)
di
Coverity issue: 272564
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_fbarray.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_fbarray.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_fbarray.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_fbarray.c
b/lib/librte_eal/common/eal_common_fbarray.c
index f65875d..8aa9013 100644
--- a/lib/librte_eal/common/eal_
I have seen that VFIO also requires explicitly to set the right permissions
for non-root users to VFIO groups under /dev/vfio.
I assume then that running OVS or other DPDK apps as non-root is possible,
although requiring those explicit permissions changes, and therefore this
patch is necessary.
A
Hi Bernard,
> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, April 17, 2018 10:25 PM
> To: Xueming(Steven) Li ; Lu, Wenzhuo
> ; Wu, Jingjing
> ; Thomas Monjalon ; Yongseok Koh
> ;
> Olivier MATZ ; Shahaf Shuler
> Cc: Yigit, Ferruh ; dev@dpdk.org
> Subject: RE: [dpdk-dev
This patchset fixes a few Coverity issues introduced
when various parts of DPDK IPC were added, and explains
away other reported issues.
Coverity issues fixed:
- 272595 - return without mutex unlock
- 272609 - fd leak
Coverity issues intentionally not fixed:
- 260407 - strcpy into fixed size buff
gettimeofday() returning a negative value is highly unlikely,
but if it ever happens, we will exit without unlocking the mutex.
Arguably at that point we'll have bigger problems, but fix this
issue anyway.
Coverity issue: 272595
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: anatol
This also silences (or should silence) a few Coverity false
positives where we used strcpy before (Coverity complained
about not checking buffer size, but source buffers were
always known to be sized correctly).
Coverity issue: 260407
Coverity issue: 272565
Coverity issue: 272582
Fixes: bacaa2754
Coverity issue: 272609
Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_proc.c
b/lib/librte_eal
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/malloc_mp.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/lib/librte_eal/common/malloc_mp.c
b/lib/librte_eal/common/malloc_mp.c
index 72b1f4c..931c14b 100644
--- a/lib/librte_eal/common/mallo
Technically, while the pointer would've been invalid if msl_idx
were invalid, we wouldn't have actually attempted to access the
pointer until verifying the index. Fix it by moving array access
to after we've verified validity of the index.
Coverity issue: 272574
Fixes: 66cc45e293ed ("mem: replace
Return from rte_socket_id_by_idx() may be negative, which would
result in negative array index.
Coverity issue: 272590
Fixes: 1403f87d4fb8 ("malloc: enable memory hotplug support")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/malloc_heap.c | 4
1
Return value from rte_socket_id_by_idx() may be negative, which would
result in negative index access.
Additionally, return value was of mismatched type (function returns
signed int, socket id was unsigned).
Coverity issue: 272571
Coverity issue: 272597
Fixes: 30bc6bf0d516 ("malloc: add function
This patchset fixes a few Coverity issues in malloc
introduced by recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272571 - negative return not handled
- 272597 - negative return not handled
- 272574 - use value before verification
- 272590 - negative return not handled
- 272566 - pos
Previous code checked for both first/last elements being NULL,
but if they weren't, the expectation was that they're both
non-NULL, which will be the case under normal conditions, but
may not be the case due to heap structure corruption.
Coverity issue: 272566
Fixes: bb372060dad4 ("malloc: make h
This patchset fixes a host of coverity issues in memory subsystem
introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wro
Coverity issue: 272601
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/libr
Normally, tailq entry should have a valid fd by the time we attempt
to map the segment. However, in case it doesn't, we're leaking fd,
so fix it.
Coverity issue: 272570
Fixes: 2a04139f66b4 ("eal: add single file segments option")
Cc: anatoly.bura...@intel.com
Signed-off-by: Anatoly Burakov
---
101 - 200 of 295 matches
Mail list logo
