Re: [dpdk-dev] [PATCH v2] net/bonding: add add/remove mac addrs

Hi From: Chas Williams > On Mon, Jun 18, 2018 at 2:58 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > > > On Mon, 18 Jun 2018 15:27:16 +0300 > > Alex Kiselev wrote: > > > > > +static const struct ether_addr null_mac_addr; > > > + > > > +/* > > > + * Add additional MAC addresses to

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE encap/decap support

Small comment, > -Original Message- > Signed-off-by: Nelio Laranjeiro > --- > app/test-pmd/cmdline.c | 113 + > app/test-pmd/cmdline_flow.c | 129 > app/test-pmd/testpmd.c | 15 +++ > app/test

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > Signed-off-by: Nelio Laranjeiro > --- > app/test-pmd/cmdline.c | 129 ++ > app/test-pmd/cmdline_flow.c | 139 > app/t

Re: [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

On Mon, Jun 18, 2018 at 03:40:53PM +0100, Ferruh Yigit wrote: > On 6/18/2018 10:38 AM, Nélio Laranjeiro wrote: > > On Mon, Jun 18, 2018 at 10:05:03AM +0100, Ferruh Yigit wrote: > >> On 6/18/2018 9:52 AM, Nelio Laranjeiro wrote: > >>> This series adds an easy and maintainable configuration version s

[dpdk-dev] [PATCH] net/ena: fix FreeBSD build

The FreeBSD define was removed from platform file when HAL was upgraded to newer version. In file included from dpdk/drivers/net/ena/ena_ethdev.c:45: from dpdk/drivers/net/ena/ena_ethdev.h:42: from dpdk/drivers/net/ena/base/ena_com.h:37: dpdk/drivers/net/ena/base/

Re: [dpdk-dev] compilation of ENA PMD on FreeBSD

Hi Thomas, I uploaded patch which is fixing this issue: http://patches.dpdk.org/patch/41256/ Thanks, Michal 2018-06-18 22:30 GMT+02:00 Thomas Monjalon : > +Cc more > > 18/06/2018 22:28, Thomas Monjalon: >> Hi, >> >> There is an error when building DPDK master on FreeBSD: >> >> drivers/net/ena/b

Re: [dpdk-dev] VLAN of SRIOV VF with DPDK

Hi, Am also facing similar issue with i40evf pmd. Is there any solution for this ? If we configure port in trunk mode, it's not able to send/receive packets which are VLAN tagged. Without VLAN tagging its working fine. If we configure port in access mode, its able to send/receive packets without

Re: [dpdk-dev] [PATCH v2] net/pcap: rx_iface_in stream type support

I'm really not sure that just setting the pcaps/dumpers.num_of_queue w/o actually creating multiple queues is good enough. If one uses N queues there are good changes he is using N cores. To be consistent with DPDK behavior it should be safe to concurrently tx to different queues. If pcap_sendpac

Re: [dpdk-dev] [PATCH] net/ena: fix FreeBSD build

19/06/2018 09:58, Michal Krawczyk: > The FreeBSD define was removed from platform file when HAL was upgraded > to newer version. > > In file included from dpdk/drivers/net/ena/ena_ethdev.c:45: >from dpdk/drivers/net/ena/ena_ethdev.h:42: >from dpdk/drivers/net/ena/ba

[dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

add functions to add/remove MAC addresses Signed-off-by: Alex Kiselev --- drivers/net/bonding/rte_eth_bond_api.c | 12 ++- drivers/net/bonding/rte_eth_bond_pmd.c | 127 - drivers/net/bonding/rte_eth_bond_private.h | 8 ++ 3 files changed, 142 insertions(+),

Re: [dpdk-dev] [PATCH 04/22] ethdev: enable hotplug on multi-process

On 19-Jun-18 4:22 AM, Zhang, Qi Z wrote: -Original Message- From: Burakov, Anatoly Sent: Monday, June 18, 2018 4:18 PM To: Zhang, Qi Z ; tho...@monjalon.net Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh ; Shelton, Benjamin H ; Vangati, Narender Subject: Re:

Re: [dpdk-dev] [PATCH v2] net/bonding: add add/remove mac addrs

> From: Chas Williams >> On Mon, Jun 18, 2018 at 2:58 PM Stephen Hemminger < >> step...@networkplumber.org> wrote: >> > On Mon, 18 Jun 2018 15:27:16 +0300 >> > Alex Kiselev wrote: >> > >> > > +static const struct ether_addr null_mac_addr; >> > > + >> > > +/* >> > > + * Add additional MAC addres

Re: [dpdk-dev] [PATCH v2] net/bonding: add add/remove mac addrs

> On Mon, 18 Jun 2018 15:27:16 +0300 > Alex Kiselev wrote: >> +/* >> + * Remove additional MAC addresses from the slave >> + */ >> +int >> +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev, >> + uint16_t slave_port_id) >> +{ >> + int i, ret; >> + struct ether_a

[dpdk-dev] [PATCH v3] net/i40e: illegal pactket checking

Some illegal packets will lead to TX/RX hang and can't recover automatically. This patch check those illegal packets and protect TX/RX from hanging. Signed-off-by: Yanglong Wu --- v2: fix coding style issue and error --- v3: rework as comments --- drivers/net/i40e/i40e_rxtx.c | 15 +++---

Re: [dpdk-dev] maintenance on DPDK patchwork today

Hi, Thanks to Ali's help, it is now fixed in patchwork. Thanks again for reporting the issue. 19/06/2018 01:47, Dan Gora: > Hi Thomas, > > I did manage to get in.. I forgot that the "username" is not actually > your email adress (it would be nice if it worked with both...), so my > password wo

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

Hi Alex Please see comments below. From: Alex Kiselev > add functions to add/remove MAC addresses > Signed-off-by: Alex Kiselev > --- > drivers/net/bonding/rte_eth_bond_api.c | 12 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 127 > - > drivers/net/bonding

[dpdk-dev] [PATCH] net/i40e: illegal pactket checking

Some illegal packets will lead to TX/RX hang and can't recover automatically. This patch check those illegal packets and protect TX/RX from hanging. Signed-off-by: Yanglong Wu --- v2: fix coding style issue and spelling error --- v3: rework as comments --- drivers/net/i40e/i40e_rxtx.c | 15 +

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

Hi Matan. > Hi Alex > Please see comments below. >> + >> + ret = rte_eth_dev_mac_addr_add(slave_port_id, mac_addr, 0); >> + if (ret < 0) { >> + /* rollback */ >> + for (i--; i > 0; i--) >> + > In case of failure in the first mac a

Re: [dpdk-dev] [Bug 60] rte_event_port_unlink() causes subsequent events to end up in wrong port

> I think this should handle the unlink case you mention, however perhaps you > have identified a genuine bug. If you have more info or a sample config / app > that easily demonstrates the issue that would help reproduce/debug here? Hi Harry, The bug report includes a simple test application

Re: [dpdk-dev] [Bug 60] rte_event_port_unlink() causes subsequent events to end up in wrong port

> No related to this question, Are you planning to use rte_event_port_unlink() > in fastpath? > Does rte_event_stop() works for you, if it is in slow path. Hi Jerin, Sorry for missing your question earlier. We need rte_event_port_link() / rte_event_port_unlink() for doing load balancing, so call

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

On 18-Jun-18 8:53 PM, Dariusz Stojaczyk wrote: Since secondary process' address space is highly dictated by the primary process' mappings, it doesn't make much sense to use base-virtaddr for secondary processes. This patch is intended to fix PCI resource mapping in secondary processes using the

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

On 18-Jun-18 9:12 PM, Stojaczyk, DariuszX wrote: -Original Message- From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] Sent: Monday, June 18, 2018 9:33 PM On Mon, Jun 18, 2018 at 8:03 PM, Stojaczyk, DariuszX mailto:dariuszx.stojac...@intel.com> > wrote: Can you po

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support

On Tue, Jun 19, 2018 at 07:09:28AM +, Ori Kam wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > > Signed-off-by: Nelio Laranjeiro > > --- > > app/test-pmd/cmdline.c | 129 ++ > > app/tes

Re: [dpdk-dev] [PATCH v3 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

On Mon, Jun 18, 2018 at 04:28:05PM +, Iremonger, Bernard wrote: > Hi Nelio, > > > -Original Message- > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Monday, June 18, 2018 3:37 PM > > To: dev@dpdk.org; Adrien Mazarguil ; Lu, > > Wenzhuo ; Wu, Jingjing ; > > Irem

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

On Mon, Jun 18, 2018 at 02:02:10PM -0700, Stephen Hemminger wrote: > On Mon, 18 Jun 2018 10:52:54 +0200 > Nelio Laranjeiro wrote: > > > > > +struct vxlan_encap_conf vxlan_encap_conf = { > > + .select_ipv4 = 1, > > + .vni = "\x00\x00\x00", > > + .udp_src = RTE_BE16(1), > > Overall looks g

Re: [dpdk-dev] [PATCH 1/2] net/pcap: multiple queues fix

On 6/19/2018 10:45 AM, Ido Goshen wrote: > See Inline prefixed with [ido] > > -Original Message- > From: Ferruh Yigit > Sent: Monday, June 18, 2018 11:25 AM > To: Ido Goshen > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] net/pcap: multiple queues fix > > On 6/16/2018 4:36 PM, ido goshen

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

Hi Bruce, Pablo, Any comments on this series? Thanks, Anoob On 14/06/18 17:18, Anoob Joseph wrote: This patchset modularizes l2fwd application to prepare it for eventmode additions. This patchset doesn't change the code flow or logic, except for few minor improvements. Some of the newly added

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

On Tue, Jun 19, 2018 at 03:34:29PM +0530, Anoob Joseph wrote: > Hi Bruce, Pablo, > > Any comments on this series? > > Thanks, > Anoob > > On 14/06/18 17:18, Anoob Joseph wrote: > > This patchset modularizes l2fwd application to prepare it for eventmode > > additions. This patchset doesn't change

Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja command error

On Tue, Jun 19, 2018 at 09:37:44AM +0800, Gavin Hu wrote: > On some linux distributions, eg: CentOS, the ninja executable has a > different name: ninja-build, this patch is to check and adapt to it > accordingly. > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found > > Fixes: a5

Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs

From: Alex Kiselev > Hi Matan. > > > Hi Alex > > > Please see comments below. > > > >> + > >> + ret = rte_eth_dev_mac_addr_add(slave_port_id, mac_addr, 0); > >> + if (ret < 0) { > >> + /* rollback */ > >> + for (i--; i > 0; i--

Re: [dpdk-dev] [PATCH v11 6/6] devtools: expand meson cross compiling test coverage

On Tue, Jun 19, 2018 at 09:37:46AM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc, also the build dirs are changed to *-host-$c, > indicating

Re: [dpdk-dev] [PATCH v11 6/6] devtools: expand meson cross compiling test coverage

On Tue, Jun 19, 2018 at 09:37:46AM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc, also the build dirs are changed to *-host-$c, > indicating

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

On Tue, Jun 19, 2018 at 10:24 AM, Burakov, Anatoly < anatoly.bura...@intel.com> wrote: > On 18-Jun-18 9:12 PM, Stojaczyk, DariuszX wrote: > >> >> >> -Original Message- >>> From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] >>> Sent: Monday, June 18, 2018 9:33 PM >>> >>> On Mon,

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

On 19-Jun-18 11:23 AM, Alejandro Lucero wrote: On Tue, Jun 19, 2018 at 10:24 AM, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 18-Jun-18 9:12 PM, Stojaczyk, DariuszX wrote: -Original Message- From: Alejandro Lucero [mailto:al

Re: [dpdk-dev] [PATCH v1 2/2] examples/l3fwd-power: simple app update to support new API

Hi Liang, On 8/6/2018 10:57 AM, Liang Ma wrote: Add the support for new traffic pattern aware power control power management API. Example: ./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P --config="(0,0,xx),(1,0,xx)" --empty-poll Suggest expanding out each of the ab

[dpdk-dev] [PATCH v12 0/6] Fix the cross compiling errors

1. Pre-v5 of this patch set(two patches) is to fix the GNU Makefile based cross compiling errors and add a guiding doc for this. 2. v6 add 5 more new patches to cover meson cross fixes 3. v7 Some minor changes to address the comments: a) trim the commit message b) at the start of the scri

[dpdk-dev] [PATCH v12 2/6] doc: add a guide doc for cross compiling from x86

From: gavin hu This is the guide for cross compiling ARM64 DPDK from X86 hosts. Signed-off-by: Gavin Hu Reviewed-by: Steve Capper Reviewed-by: Honnappa Nagarahalli Acked-by: Marko Kovacevic --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 137 + doc/guides/linux_

[dpdk-dev] [PATCH v12 1/6] mk: fix makefile based cross build errors

From: gavin hu The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was enabled when the cross compiler gcc is greater than 7.0, but for the host side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the host cc compiler is clang, it should not be enabled. The fix

[dpdk-dev] [PATCH v12 3/6] build: fix the meson build warning

This is to fix the unnecessary warning output, it is not consistent with the configurations of other platforms. WARNING: Cross file does not specify strip binary, result will not be stripped. Fixes: e53a5299d2 ("build: support vendor specific ARM cross builds") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v12 4/6] devtools: fix the missing ninja command error

On some linux distributions, eg: CentOS, the ninja executable has a different name: ninja-build, this patch is to check and adapt to it accordingly. ./devtools/test-meson-builds.sh: line 24: ninja: command not found Fixes: a55277a788 ("devtools: add test script for meson builds") Cc: sta...@dpdk.

[dpdk-dev] [PATCH v12 6/6] devtools: expand meson cross compiling test coverage

The default test script covers only default host cc compiler, either gcc or clang, the fix is to increase the coverage by adding one more to cover clang and the others for gcc. Fixes: a55277a788 ("devtools: add test script for meson builds") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-b

[dpdk-dev] [PATCH v12 5/6] build: fix the meson cross compile error

The following error hits if host cc compiler is clang(default one in most linux distributions) and the cross compiler is gcc. The root cause is: the hybride compilers add the warning options to the meson project as project arguments, which apply for both host compiling and cross compiling. But som

Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja command error

Hi Bruce, Thanks for your review, I submitted v12 patch to address all your new comments. BTW, do you know why pwclient can NOT work successfully today? It worked fine at my side previously, any changes at the server side? The error is below: xmlrpc.client.ProtocolError: Best Regards, Gavin

[dpdk-dev] [PATCH] kni: fix build with gcc 8.1

Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is enabled. build error: In function ‘strncpy’, inlined from ‘igb_get_drvinfo’ at .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2: .../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output may be trun

Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes

On Tue, Jun 19, 2018 at 11:27 AM, Burakov, Anatoly < anatoly.bura...@intel.com> wrote: > On 19-Jun-18 11:23 AM, Alejandro Lucero wrote: > >> >> >> On Tue, Jun 19, 2018 at 10:24 AM, Burakov, Anatoly < >> anatoly.bura...@intel.com > wrote: >> >> On 18-Jun-18 9:1

Re: [dpdk-dev] [PATCH] net/mlx5: fix error number handling

On Mon, Jun 18, 2018 at 05:06:41PM +, Yongseok Koh wrote: > > > On Jun 7, 2018, at 12:39 AM, Nélio Laranjeiro > > wrote: > > > > On Wed, Jun 06, 2018 at 11:39:27AM -0700, Yongseok Koh wrote: > >> On Wed, Jun 06, 2018 at 08:55:01AM +0200, Nélio Laranjeiro wrote: > >>> On Tue, Jun 05, 2018 at

Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja command error

On Tue, Jun 19, 2018 at 10:41:06AM +, Gavin Hu wrote: > Hi Bruce, > > Thanks for your review, I submitted v12 patch to address all your new > comments. > > BTW, do you know why pwclient can NOT work successfully today? > It worked fine at my side previously, any changes at the server side?

Re: [dpdk-dev] [PATCH v12 6/6] devtools: expand meson cross compiling test coverage

On Tue, Jun 19, 2018 at 06:36:57PM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc. > > Fixes: a55277a788 ("devtools: add test script for mes

Re: [dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC

On 6/11/2018 4:25 PM, Stephen Hemminger wrote: > On Fri, 8 Jun 2018 23:57:09 +0100 > Ferruh Yigit wrote: > >> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. >> >> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release >> default behavior in PMDs is to keep the CRC until this flag removed > > T

Re: [dpdk-dev] [PATCH v2 1/4] mbuf: add accessor function for private data area

On 06/19/2018 02:35 AM, Dan Gora wrote: Add an inline accessor function to return the starting address of the private data area in the supplied mbuf. This allows applications to easily access the private data area between the struct rte_mbuf and the data buffer in the specified mbuf without crea

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header

On 06/19/2018 04:04 AM, Ferruh Yigit wrote: Macro moved to header to be able to convert logging usage in header. And since it has been moved to public header changed naming and added RTE prefix, ethdev_log -> RTE_ETHDEV_LOG Also need to add logtype variable to map file since logging macro used f

[dpdk-dev] [PATCH] net/mlx5: fix Rss level validation

When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- driver

[dpdk-dev] [PATCH] net/mlx5: fix Rss level validation

When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- driver

Re: [dpdk-dev] [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic

On 06/19/2018 04:04 AM, Ferruh Yigit wrote: Replace RTE_PMD_DEBUG_TRACE with RTE_ETHDEV_LOG. RTE_PMD_DEBUG_TRACE is using hardcoded PMD logtype and ERR log level, controlled by compile time flags. RTE_ETHDEV_LOG is using dynamic ethdev_logtype. Also a few minor cleanups, like - use %u for unsig

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

Hi Tomasz, Pablo, > -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Wednesday, June 13, 2018 11:11 AM > To: De Lara Guarch, Pablo > Cc: Tomasz Duszynski ; Doherty, Declan > ; > akhil.go...@nxp.com; ravi1.ku...@amd.com; jerin.ja...@caviumnetworks.com; > Zha

Re: [dpdk-dev] [PATCH 01/16] config: add Cavium CPT PMD skeleton

Hi Anoob, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 3:57 AM > To: Anoob Joseph > Cc: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > ; Nithin Dabilpuram ; > Ankur Dwivedi ; Murthy NSSR > ; Narayana Prasad > ;

Re: [dpdk-dev] [PATCH 03/16] crypto/cpt/base: add hardware initialization API for CPT

> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 4:14 AM > To: Anoob Joseph > Cc: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > ; Nithin Dabilpuram ; > Ankur Dwivedi ; Murthy NSSR > ; Narayana Prasad > ; Ragotha

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03:34:29PM +0530, Anoob Joseph wrote: Hi Bruce, Pablo, Any comments on this series? Thanks, Anoob

Re: [dpdk-dev] [PATCH 05/22] ethdev: introduce device lock

Hi Stephen: > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, June 16, 2018 12:09 AM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; Burakov, Anatoly ; > Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, B

Re: [dpdk-dev] [PATCH 04/16] crypto/cpt/base: add hardware enq/deq API for CPT

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 5:45 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad > ; Nithin Dabilpuram > ; Ragothama

Re: [dpdk-dev] [PATCH 04/16] crypto/cpt/base: add hardware enq/deq API for CPT

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 5:45 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad > ; Nithin Dabilpuram > ; Ragothama

Re: [dpdk-dev] [PATCH 10/16] crypto/cpt: add driver initializations

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 5:45 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > Cc: Srisivasubramanian Srinivasan > ; Ankur Dwivedi > ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad

Re: [dpdk-dev] [PATCH 11/16] crypto/cpt: add the basic device callback functions

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 5:45 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > Cc: Srisivasubramanian Srinivasan > ; Ankur Dwivedi > ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad

Re: [dpdk-dev] [PATCH 15/16] doc: add Cavium's CPT guide

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, June 8, 2018 5:45 PM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > Cc: Ragothaman Jayaraman ; Ankur > Dwivedi ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad > ; Nithin

[dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping CRC should advertise this offload capability. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs are to keep the CRC until this flag removed Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Se

Re: [dpdk-dev] [RFC] P4 enablement in DPDK

Hi Antonin, Thanks very much for your input and your help going forward! More comments inline below. From: anto...@barefootnetworks.com [mailto:anto...@barefootnetworks.com] Sent: Saturday, June 16, 2018 12:26 AM To: Dumitrescu, Cristian Cc: dev@dpdk.org; Daly, Dan Subject: Re: [dpdk-dev] [RFC

[dpdk-dev] A bug in DPDK ENA driver

Hi! I’m trying to launch NFF-GO (https://github.com/intel-go/nff-go) on AWS instances and faced a problem (Program received signal SIGFPE, Arithmetic exception.) which was caused by: 0x006f703c in ena_rss_init_default (adapter=0x7fffef399200) at /home/ec2-user/projects/src/github.co

[dpdk-dev] [PATCH 04/31] net/bnxt: set min and max descriptor count for Tx and Rx rings

Set min and max descriptor count for Tx and Rx rings. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 3 +++ drivers/net/bnxt/bnxt_ethdev.c | 4 2 files changed, 7 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 35c3073dd..d25bf78af 1006

[dpdk-dev] [PATCH 01/31] net/bnxt: fix clear port stats

PORT_CLR_STATS is not allowed for VFs, NPAR, MultiHost functions or when SR-IOV is enabled. Don't send the HWRM command in such cases. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 4 drivers/n

[dpdk-dev] [PATCH 03/31] net/bnxt: Rx processing optimization

1) Use nb_rx_pkts instead of checking producer indices of Rx and aggregator rings to decide if any Rx completions were processed. 2) Post Rx buffers early in Rx processing instead of waiting for the budgeted burst quota. 3) Ring Rx CQ DB after Rx buffers are posted. Signed-off-by: Ajit Khaparde -

[dpdk-dev] [PATCH 00/31] bnxt patchset

Patchset against dpdk-next-net contains bug fixes, some code refactoring and style cleanup. Please apply. Ajit Khaparde (15): net/bnxt: fix clear port stats net/bnxt: add Tx batching support net/bnxt: Rx processing optimization net/bnxt: set min and max descriptor count for Tx and Rx ring

[dpdk-dev] [PATCH 08/31] net/bnxt: add support for VF id 0xd800

Add support for StingRay VF device 0xd800 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 1b52425e6..5d7f29cf4 100644 --- a/drivers/net/bn

[dpdk-dev] [PATCH 02/31] net/bnxt: add Tx batching support

Batch more than one Tx requests such that only one completion is generarted by the HW. We request a Tx completion for first and last Tx request in the batch. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.h | 12 ++ drivers/net/bnxt/bnxt_txq.h | 1 + drivers/net/bnxt/bnxt_txr.c

[dpdk-dev] [PATCH 07/31] net/bnxt: fix HW Tx checksum offload check

Add more checks for checksum calculation offload. Also check for tunnel frames and select the proper buffer descriptor size. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-off-by: Xiaoxin Peng Signed-off-by: Ajit Khaparde Reviewed-by: Jason He Reviewed-by: Qin

[dpdk-dev] [PATCH 06/31] net/bnxt: set ring coalesce parameters for Stratus NIC

Set ring coalesce parameters for Stratus NIC. Other skews don't necessarily need this. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 19 drivers/net/bnxt/bnxt_ethdev.c | 11 + drivers/net/bnxt/bnxt_hwrm.c | 51 +++

[dpdk-dev] [PATCH 11/31] net/bnxt: code cleanup style of bnxt rxr

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_rxr Signed-off-by: Scott Branden Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 58 - drivers/net/bnxt/bnxt_rxr.h | 6 +++-- 2 fi

[dpdk-dev] [PATCH 10/31] net/bnxt: code cleanup style of bnxt cpr

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_cpr Signed-off-by: Scott Branden Reviewed-by: Ajit Khaparde Reviewed-by: Qingmin Liu Reviewed-by: Ray Jui --- drivers/net/bnxt/bnxt_cpr.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-

[dpdk-dev] [PATCH 05/31] net/bnxt: fix dev close operation

We are not cleaning up all the memory and also not unregistering the driver during device close operation. This patch fixes the issue. Fixes: 893074951314 (net/bnxt: free memory in close operation) Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 23

[dpdk-dev] [PATCH 12/31] net/bnxt: code cleanup style of rte pmd bnxt file

From: Scott Branden Cleanup alignment, brackets, debug string style of rte_pmd_bnxt Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 97 + drivers/net/bnxt/rte_pmd_bnxt.h | 69 +++--

[dpdk-dev] [PATCH 14/31] net/bnxt: code cleanup style of bnxt vnic

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_vnic Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c | 26 +- drivers/net/bnxt/bnxt_vnic.h | 8 ++-- 2 files changed, 19 insertions(+), 15 deleti

[dpdk-dev] [PATCH 13/31] net/bnxt: code cleanup style of bnxt stats

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_stats Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_stats.c | 84 ++- drivers/net/bnxt/bnxt_stats.h | 27 +- 2 files changed, 7

[dpdk-dev] [PATCH 09/31] net/bnxt: fix rx/tx queue start/stop operations

Packets destined to the to-be-stopped queue should not be dropped (neither in HW nor in the driver), so re-program the RSS Table without this queue on stop and add it back to the table on start unless it is a Representor VF. Since 0th entry is used for default ring, use fw_grp_id + 1 to change the

[dpdk-dev] [PATCH 23/31] net/bnxt: check for invalid vnic id

From: Jay Ding Add checking for VNIC id before sending message to firmware in bnxt_hwrm_vnic_plcmode_cfg(). Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnx

[dpdk-dev] [PATCH 16/31] net/bnxt: code cleanup style of bnxt rxq

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_rxq Signed-off-by: Scott Branden Reviewed-by: Randy Schacher Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 22 +- drivers/net/bnxt/bnxt_rxq.h | 12 +++- 2 files changed, 2

[dpdk-dev] [PATCH 15/31] net/bnxt: code cleanup style of bnxt txq

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_txq Signed-off-by: Scott Branden Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txq.c | 24 ++-- drivers/net/bnxt/bnxt_txq.h | 9 + 2 files changed, 19 insertions(+), 14 deletions(-)

[dpdk-dev] [PATCH 17/31] net/bnxt: code cleanup style of bnxt vnic

code cleanup style of bnxt_vnic. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c index 5d9d369a3..d5d81fd36 100644 --- a/drivers/net/bnxt/bnxt_vnic.c +++

[dpdk-dev] [PATCH 18/31] net/bnxt: code cleanup style of bnxt txr

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_txr Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 5 +++-- drivers/net/bnxt/bnxt_txr.h | 9 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 19/31] net/bnxt: code cleanup style of bnxt ring

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_ring Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ring.c | 79 ++-- drivers/net/bnxt/bnxt_ring.h | 40 +++--- 2 files chan

[dpdk-dev] [PATCH 21/31] net/bnxt: move function check zero bytes to bnxt util.h

From: Scott Branden Move check_zero_bytes into new bnxt_util.h file. Signed-off-by: Scott Branden Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c | 1 + drivers/net/bnxt/bnxt_filter.c | 9 - drivers/net/bnxt/bnxt_filter.h | 1 -

[dpdk-dev] [PATCH 20/31] net/bnxt: code cleanup style of bnxt ethdev

From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_ethdev Signed-off-by: Scott Branden Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 204 ++--- 1 file changed, 112 insertions(+), 92 del

[dpdk-dev] [PATCH 22/31] net/bnxt: filter/flow refactoring

In preparation of more rte_flow support it has been decided to separate out filter and flow into their own files. Functionally the same. Signed-off-by: Michael Wildt Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/Makefile |1 + drivers/net/bnxt/bnxt_fil

[dpdk-dev] [PATCH 26/31] net/bnxt: Revert reset of L2 filter id in clear_ntuple_filter

From: Somnath Kotur The L2 filter id is needed in many scenarios particularly when we are repurposing the same ntuple filter with different destination queues. Fixes: 1383434c9089("net/bnxt: reset L2 filter id once filter is freed") Cc: ajit.khapa...@broadcom.com Signed-off-by: Somnath Kotur --

[dpdk-dev] [PATCH 24/31] net/bnxt: update HWRM API to v1.9.2.9

From: Rob Miller update HWRM API to v1.9.2.9 Signed-off-by: Rob Miller Reviewed-by: Scott Branden Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Randy Schacher Signed-off-by: Rob Miller --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 113 - 1 file changed, 111 i

[dpdk-dev] [PATCH 25/31] net/bnxt: fix Tx with multiple mbuf

From: Xiaoxin Peng When using multi-mbuf to xmit large packets, we need to use total packet lengths (sum of all segments) to set txbd->flags_type. Packets will not be sent when using tx_pkt->data_len(The first segment of packets). Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@

[dpdk-dev] [PATCH 27/31] net/bnxt: check filter type before clearing it

In bnxt_free_filter_mem(), check the filter type and call the appropriate HWRM command to clear the filter from HW. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_fil

[dpdk-dev] [PATCH 29/31] net/bnxt: fix incorrect IO address handling in Tx

rte_mbuf_data_iova returns a 64-bit address. But we are incorrectly using only 32-bits of that. Use rte_cpu_to_le_64 instead of rte_cpu_to_le_32 Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 4 ++-- 1 fil

[dpdk-dev] [PATCH 31/31] net/bnxt: fix to move a flow to a different queue

From: Somnath Kotur While moving a flow to a different destination queue, the l2_filter_id being passed to the FW command was incorrect. Fix it by re-using the matching filter's l2_filter_id since that is supposed to be the same in this case. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter o

[dpdk-dev] [PATCH 28/31] net/bnxt: fix set MTU

There is no need to update hardware configuration if new MTU is not greater than the max data the mbuf can accommodate. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 12 +--- 1 file changed, 9 inse

[dpdk-dev] [PATCH 30/31] net/bnxt: allocate RSS context only if RSS mode is enabled.

allocate RSS context only if RSS mode is enabled. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 1145bc195..dfae6e2d2 10064

Re: [dpdk-dev] [PATCH v1 3/7] compress/octeontx: add xform and stream create support

> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, June 5, 2018 11:35 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathr...@caviumnetworks.com; mcha...@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject:

  1   2   >