Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-02 Thread Jens Freimann
Hi Bernard, On Mon, Oct 01, 2018 at 01:13:32PM +, Iremonger, Bernard wrote: Hi Jens, -Original Message- From: Jens Freimann [mailto:jfreim...@redhat.com] Sent: Friday, September 21, 2018 2:27 PM To: dev@dpdk.org Cc: ai...@redhat.com; jan.scheur...@ericsson.com; Richardson, Bruce ;

[dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

2018-10-02 Thread Jens Freimann
This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footprint utilization from va

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-02 Thread Thomas Monjalon
02/10/2018 09:19, Jens Freimann: > On Mon, Oct 01, 2018 at 01:13:32PM +, Iremonger, Bernard wrote: > >./devtools/check-git-log.sh -1 > >Headline too long: > >app/testpmd: add forwarding mode to simulate a noisy neighbour > > I'm sorry, I failed to use checkpatches.sh correctly :) I did

Re: [dpdk-dev] [PATCH] net/softnic: add flow flush API

2018-10-02 Thread Singh, Jasvinder
> --- a/drivers/net/softnic/rte_eth_softnic_flow.c > +++ b/drivers/net/softnic/rte_eth_softnic_flow.c > @@ -1915,6 +1915,50 @@ pmd_flow_destroy(struct rte_eth_dev *dev, > return 0; > } > > +static int > +pmd_flow_flush(struct rte_eth_dev *dev, > + struct rte_flow_error *error) > +{

Re: [dpdk-dev] [PATCH v3 00/15] bnxt patchset

2018-10-02 Thread Ferruh Yigit
On 9/29/2018 2:59 AM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. > > v1->v2: > net/bnxt: get rid of ff pools array and use the vnic info array instead > - Fix access to uninitialized variable. > - Rectify the wrong 'Fixes' reference. > > net/bnxt: update HWRM version > - Update from 1

Re: [dpdk-dev] [PATCH v2 1/2] eal: add eal option to configure iova mode

2018-10-02 Thread Ferruh Yigit
On 10/1/2018 5:00 PM, Eric Zhang wrote: > > > On 09/26/2018 08:42 AM, Burakov, Anatoly wrote: >> On 18-Sep-18 8:10 PM, eric zhang wrote: >>> From: Santosh Shukla >>> >>> In the case of user don't want to use bus iova scheme and want >>> to override. >>> >>> For that, Adding eal option --iova-mod

Re: [dpdk-dev] [PATCH v6 5/5] vhost: message handling implemented as a callback array

2018-10-02 Thread Maxime Coquelin
Hi Nikolay, On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote: Introduce vhost_message_handlers, which maps the message request type to the message handler. Then replace the switch construct with a map and call. Failing vhost_user_set_features is fatal and all processing should stop immediately an

[dpdk-dev] [PATCH v6 01/10] examples/power: add checks around hypervisor

2018-10-02 Thread David Hunt
Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent. Signed-off-by: David Hunt Acked-by: Anatoly Bu

[dpdk-dev] [PATCH v6 03/10] lib/power: add changes for host commands/policies

2018-10-02 Thread David Hunt
This patch does a couple of things: * Adds a new message type for removing policies (PKT_POLICY_REMOVE) Used when we want to remove a previously created policy. * Adds a core_type bool to the channel packet struct to specify whether the type of core we want to control is cirtual or phys

[dpdk-dev] [PATCH v6 04/10] examples/power: add necessary changes to guest app

2018-10-02 Thread David Hunt
The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type). Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/guest_cli/

[dpdk-dev] [PATCH v6 02/10] examples/power: allow for number of vms to be zero

2018-10-02 Thread David Hunt
Previously the vm_power_manager app required to have some vms defined, so the call to get_all_vm() always set the noVms variable. Now we're accepting policies from the host OS (without any VMs defined), so it is now valid to have zero VMs. This patch initialises the relevant variables to zero just

[dpdk-dev] [PATCH v6 0/10] add json power policy interface for containers

2018-10-02 Thread David Hunt
The current vm_power_manager example app has the capability to accept power policies from virtual machines via virtio-serial channels. These power policies allow a virtual machine to give information to the power manager to allow the power manager take care of the power management of the virtual m

[dpdk-dev] [PATCH v6 06/10] examples/power: increase allowed number of clients

2018-10-02 Thread David Hunt
Now that we're handling host policies, containers and virtual machines, we'll rename MAX_VMS to MAX_CLIENTS, and increase from 4 to 64 Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.h | 4 ++-- examples/vm_power_manager/channel_monitor.c | 10

[dpdk-dev] [PATCH v6 07/10] examples/power: add json string handling

2018-10-02 Thread David Hunt
Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson, a C library for encoding, decoding and m

[dpdk-dev] [PATCH v6 08/10] examples/power: clean up verbose messages

2018-10-02 Thread David Hunt
Some messages appearing several times a second, removing as they are unnecessary. Other less severe messages change from INFO to DEBUG Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_monitor.c | 19 +-- 1 file changed, 5 insertions(+), 1

[dpdk-dev] [PATCH v6 05/10] examples/power: add host channel to power manager

2018-10-02 Thread David Hunt
This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.c | 109 +

[dpdk-dev] [PATCH v6 10/10] doc/vm_power_manager: add JSON interface API info

2018-10-02 Thread David Hunt
Also added meson/ninja build info Signed-off-by: David Hunt Acked-by: Marko Kovacevic --- .../sample_app_ug/vm_power_management.rst | 300 +- 1 file changed, 298 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample

[dpdk-dev] [PATCH v6 09/10] examples/power: add meson/ninja build support

2018-10-02 Thread David Hunt
Add meson.build in vm_power_manager and the guest_cli subdirectory. Building can be achieved by going to the build directory, and using meson configure -Dexamples=vm_power_manager,vm_power_manager/guest_cli Then, when ninja is invoked, it will build dpdk-vm_power_manger and dpdk-guest_cli Work s

Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI

2018-10-02 Thread Ferruh Yigit
On 10/2/2018 3:29 AM, Hyong Youb Kim wrote: > On Mon, Oct 01, 2018 at 03:01:40PM +0100, Ferruh Yigit wrote: >> On 9/26/2018 4:06 AM, John Daley wrote: >>> From: Hyong Youb Kim >>> >>> Since the following commit, PKT_RX_VLAN indicates the presence of >>> mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. >

Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI

2018-10-02 Thread Ferruh Yigit
On 9/26/2018 4:06 AM, John Daley wrote: > From: Hyong Youb Kim > > Since the following commit, PKT_RX_VLAN indicates the presence of > mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. > > commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") > Cc: olivier.m...@6wind.com > > Signed-off-by: Hyong

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 1 Oct 2018 17:11:50 +0100 > From: Ferruh Yigit > To: Jerin Jacob > CC: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Andrew Rybchenko > , dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/4] ethde

Re: [dpdk-dev] [PATCH v6 4/5] vhost: unify message handling function signature

2018-10-02 Thread Maxime Coquelin
On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote: Each vhost-user message handling function will return an int result which is described in the new enum vh_result: error, OK and reply. All functions will now have two arguments, virtio_net double pointer and VhostUserMsg pointer. Signed-off-by:

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-02 Thread Jens Freimann
On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote: 02/10/2018 09:19, Jens Freimann: On Mon, Oct 01, 2018 at 01:13:32PM +, Iremonger, Bernard wrote: >./devtools/check-git-log.sh -1 >Headline too long: >app/testpmd: add forwarding mode to simulate a noisy neighbour I'm s

Re: [dpdk-dev] [PATCH v8 01/21] mem: add length to memseg list

2018-10-02 Thread Burakov, Anatoly
On 01-Oct-18 6:01 PM, Stephen Hemminger wrote: On Mon, 1 Oct 2018 13:56:09 +0100 Anatoly Burakov wrote: diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h index aff0688dd..1d8b0a6fe 100644 --- a/lib/librte_eal/common/include/rte

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-02 Thread Ferruh Yigit
On 10/1/2018 4:59 PM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 1 Oct 2018 14:46:39 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Wenzhuo Lu >> , Jingjing Wu , Bernard >> Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Andrew Rybchenko >> >> CC: d

[dpdk-dev] [PATCH] mbuf: clarify QINQ flag usage

2018-10-02 Thread Ferruh Yigit
Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN should be also set. Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also should be set. So that appllication can rely on PKT_RX_QINQ flag to access both

[dpdk-dev] [PATCH v2 00/17] vhost: add postcopy live-migration support

2018-10-02 Thread Maxime Coquelin
In this v2: - Rebase on top of Nikolay message handling series. It requires passing an extra parameter to message handlers ( the fd of the socket as set_mem_table needs to send an intermediate reply). - Preliminary patches to fix issues with message handling rework not handling replies properly. -

[dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks

2018-10-02 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. Fixes: 4e601952cae6 ("vhost: message

[dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies

2018-10-02 Thread Maxime Coquelin
VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_LOG_BASE require replies, so their handlers should return VH_RESULT_REPLY, not VH_RESULT_OK. Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature") Signed-off-by: Maxime Coquelin --- lib/librte_vhos

[dpdk-dev] [PATCH v2 03/17] vhost: fix error handling when mem table gets updated

2018-10-02 Thread Maxime Coquelin
When the memory table gets updated, the rings addresses need to be translated again. If it fails, we need to exit cleanly by unmapping memory regions. Fixes: d5022533c20a ("vhost: retranslate vring addr when memory table changes") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/librt

[dpdk-dev] [PATCH v2 04/17] vhost: define postcopy protocol flag

2018-10-02 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index b02673d4a..b3cc6990d 100644 --- a/lib/librte_vhost/rte_vhost.h +++ b/lib

[dpdk-dev] [PATCH v2 06/17] vhost: pass socket fd to message handling callbacks

2018-10-02 Thread Maxime Coquelin
This is not used for now, but will be needed for the special handling of VHOST_USER_SET_MEM_TABLE message once postcopy will be supported. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 71 +++ 1 file changed, 47 insertions(+), 24 deletions(-)

[dpdk-dev] [PATCH v2 08/17] vhost: add config flag for postcopy feature

2018-10-02 Thread Maxime Coquelin
Postcopy live-migration features relies on userfaultfd, which was only introduced in kernel v4.3. This patch introduces a new define to allow building vhost library on kernels not supporting userfaultfd. With legacy build system, user has to explicitly set CONFIG_RTE_LIBRTE_VHOST_POSTCOPY to 'y'.

[dpdk-dev] [PATCH v2 09/17] vhost: introduce postcopy's advise message

2018-10-02 Thread Maxime Coquelin
This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 2 ++ lib/librte_vhost/vhost_user.c | 44 +++ lib/librte_vhost

[dpdk-dev] [PATCH v2 05/17] vhost: add number of fds to vhost-user messages and use it

2018-10-02 Thread Maxime Coquelin
As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This is preliminary work to support sending fds to Qemu. Signed-off-by: Dr. David Alan Gilbert Si

[dpdk-dev] [PATCH v2 07/17] vhost: enable fds passing when sending vhost-user messages

2018-10-02 Thread Maxime Coquelin
Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v2 11/17] vhost: register new regions with userfaultfd

2018-10-02 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index bd468ca12..2f681d291 10

[dpdk-dev] [PATCH v2 10/17] vhost: add support for postcopy's listen message

2018-10-02 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 19 +++ lib/librte_vhost/vhost_user.h | 4 +++- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v2 12/17] vhost: avoid useless VhostUserMemory copy

2018-10-02 Thread Maxime Coquelin
The VHOST_USER_SET_MEM_TABLE payload is copied when handled, whereas it could directly be referenced. This is not very important, but next, we'll need to update the payload and send it back to Qemu. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost

[dpdk-dev] [PATCH v2 15/17] vhost: enable postcopy protocol feature

2018-10-02 Thread Maxime Coquelin
Enable postcopy protocol feature except if dequeue zero-copy is enabled. In this case, guest memory requires to be populated, which is not compatible with userfaultfd. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 7 +++ lib/librte_

[dpdk-dev] [PATCH v2 13/17] vhost: send userfault range addresses back to qemu

2018-10-02 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 49 --- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 515d3c61c..b207de6e0

[dpdk-dev] [PATCH v2 14/17] vhost: add support to postcopy's end request

2018-10-02 Thread Maxime Coquelin
The master sends this message before stopping handling userfaults, so that the backend closes the userfaultfd. The master waits for the slave to acknowledge the request with an empty 64bits payload for synchronization purpose. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v2 17/17] net/vhost: add parameter to enable postcopy support

2018-10-02 Thread Maxime Coquelin
Introduce a new postcopy-support parameter to Vhost PMD that passes the RTE_VHOST_USER_POSTCOPY_SUPPORT flag at vhost device register time. Flag should only be set if application does not prefault guest memory using, for example, mlockall() syscall. Default value is 0, meaning that postcopy suppo

[dpdk-dev] [PATCH v2 16/17] vhost: add flag to enable postcopy live-migration

2018-10-02 Thread Maxime Coquelin
Postcopy live-migration feature require the application to not populate the guest memory. As the vhost library cannot prevent the application to that (e.g. preventing the application to call mlockall()), the feature is disabled by default. The application should only enable the feature if it does

Re: [dpdk-dev] [PATCH] mbuf: clarify QINQ flag usage

2018-10-02 Thread Andrew Rybchenko
On 10/2/18 1:17 PM, Ferruh Yigit wrote: Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN should be also set. Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also should be set. So that appllication c

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-02 Thread Thomas Monjalon
02/10/2018 10:59, Jens Freimann: > On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote: > >02/10/2018 09:19, Jens Freimann: > >> On Mon, Oct 01, 2018 at 01:13:32PM +, Iremonger, Bernard wrote: > >> >./devtools/check-git-log.sh -1 > >> >Headline too long: > >> >app/testpmd: a

Re: [dpdk-dev] [PATCH 3/3] event/dpaa2: support for crypto adapter

2018-10-02 Thread Gujjar, Abhinandan S
Acked-By: Abhinandan Gujjar > -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 25, 2018 8:42 AM > To: akhil.go...@nxp.com > Cc: dev@dpdk.org; hemant.agra...@nxp.com; De Lara Guarch, Pablo > ; Gujjar, Abhinandan S > > Subject: Re: [dpdk-dev] [PATCH 3/3] event/dpaa2: sup

Re: [dpdk-dev] [PATCH 4/4] ethdev: add Tx offload outer L4 checksum definitions

2018-10-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 1 Oct 2018 14:45:39 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Wenzhuo Lu > , Jingjing Wu , Bernard > Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Andrew Rybchenko > , Olivier Matz > CC: dev@dpdk.org > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v11 0/7] hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
hi, stephen Thanks for your review, my answer as below. On 10/1/2018 5:00 PM, Stephen Hemminger wrote: On Sun, 30 Sep 2018 19:29:56 +0800 Jeff Guo wrote: Hotplug is an important feature for use-cases like the datacenter device's fail-safe and for SRIOV Live Migration in SDN/NFV. It could bri

Re: [dpdk-dev] [PATCH] doc: update the doc for adding EAL option

2018-10-02 Thread Burakov, Anatoly
Hi Eric, Ferruh has already mention that this should be part of the patch adding the --iova-mode flag, not separate (or at the very least be in the same patchset!). In addition, the commit headline is very vague. Suggested rewording: doc: document --iova-mode EAL flag On 01-Oct-18 4:54 PM,

[dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove

2018-10-02 Thread Ferruh Yigit
rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on v17.08 as experimental Commit a3ee360f4440 ("eal: add hotplug add/remove device") When __rte_experimental tag created, APIs tagged with it on v18.02 Commit 77b7b81e32e9 ("add experimental tag to appropriate functions") After rte

Re: [dpdk-dev] [PATCH] doc: update the doc for adding EAL option

2018-10-02 Thread Thomas Monjalon
02/10/2018 11:59, Burakov, Anatoly: > This looks like a gap in our documentation. There should be a place > where we can describe all EAL parameters. Since they can be OS-specific, > it probably should be somewhere under Linux/FreeBSD GSG. Thoughts? I agree

Re: [dpdk-dev] [PATCH] mbuf: clarify QINQ flag usage

2018-10-02 Thread Ferruh Yigit
On 10/2/2018 10:44 AM, Andrew Rybchenko wrote: > On 10/2/18 1:17 PM, Ferruh Yigit wrote: >> Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags >> set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN >> should be also set. >> >> Clarify mbuf documentations that when PKT_RX_QIN

Re: [dpdk-dev] [PATCH v11 0/7] hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
hi, jerin Thanks for your comment and reply as below. On 10/1/2018 5:55 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 1 Oct 2018 11:00:12 +0200 From: Stephen Hemminger To: Jeff Guo Cc: bruce.richard...@intel.com, ferruh.yi...@intel.com, konstantin.anan...@intel.com, gaetan.r

Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove

2018-10-02 Thread Andrew Rybchenko
On 10/2/18 2:04 PM, Ferruh Yigit wrote: rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on v17.08 as experimental Commit a3ee360f4440 ("eal: add hotplug add/remove device") When __rte_experimental tag created, APIs tagged with it on v18.02 Commit 77b7b81e32e9 ("add experimental

Re: [dpdk-dev] [PATCH v8 1/4] lib/librte_power: traffic pattern aware power control

2018-10-02 Thread Liang, Ma
Hi Dave, Please check comment below. On 28 Sep 11:47, Hunt, David wrote: > Hi Liang, > > > On 17/9/2018 2:30 PM, Liang Ma wrote: > >1. Abstract > > > >For packet processing workloads such as DPDK polling is continuous. > >This means CPU cores always show 100% busy independent of how much w

Re: [dpdk-dev] [PATCH v8 2/4] examples/l3fwd-power: simple app update for new API

2018-10-02 Thread Liang, Ma
On 28 Sep 12:19, Hunt, David wrote: > Hi Liang, > > A few tweaks below: > > > On 17/9/2018 2:30 PM, Liang Ma wrote: > >Add the support for new traffic pattern aware power control > >power management API. > > > >Example: > >./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 >

Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove

2018-10-02 Thread Ferruh Yigit
On 10/2/2018 11:08 AM, Andrew Rybchenko wrote: > On 10/2/18 2:04 PM, Ferruh Yigit wrote: >> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on >> v17.08 as experimental >> Commit a3ee360f4440 ("eal: add hotplug add/remove device") >> >> When __rte_experimental tag created, APIs ta

Re: [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

2018-10-02 Thread Ferruh Yigit
On 9/28/2018 5:21 PM, Thomas Monjalon wrote: > These functions are quite old and are the only available replacement > for the deprecated attach/detach functions. > > Note: some new functions may (again) replace these hotplug functions, > in future, with better parameters. > > Signed-off-by: Thoma

Re: [dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private

2018-10-02 Thread Raslan Darawsheh
Hi, what I'm really doing is simply do some private array for all the fd's that each process will allocate it separately which will allow that each process will be able to access the fd's for the queues in order not to overwrite the shared ones and it's working for me this way. Now coming to

[dpdk-dev] [PATCH v4 1/2] net/tap: change queue fd to be pointers to process private

2018-10-02 Thread Raslan Darawsheh
change the fds for the queues to be pointers and add new process private structure and make the queue fds point to it. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 63 --- drivers/net/tap/rte_eth_tap.h | 9 +-- drivers/net/tap/t

[dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-02 Thread Raslan Darawsheh
In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP created by the primary pro

[dpdk-dev] [PATCH v2] mbuf: clarify QINQ flag usage

2018-10-02 Thread Ferruh Yigit
Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN should be also set. Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also should be set. So that appllication can rely on PKT_RX_QINQ flag to access both

Re: [dpdk-dev] [PATCH v2] mbuf: clarify QINQ flag usage

2018-10-02 Thread Andrew Rybchenko
On 10/2/18 2:36 PM, Ferruh Yigit wrote: Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN should be also set. Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also should be set. So that appllication c

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-02 Thread Thomas Monjalon
02/10/2018 12:34, Raslan Darawsheh: > @@ -2056,6 +2179,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > TAP_LOG(NOTICE, "Initializing pmd_tap for %s as %s", > name, tap_name); > > + /* Register IPC feed callback */ > + ret = rte_mp_action_register(TAP_MP_

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-02 Thread Thomas Monjalon
02/10/2018 12:34, Raslan Darawsheh: > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > @@ -67,6 +67,10 @@ New Features >SR-IOV option in Hyper-V and Azure. This is an alternative to the previous >vdev_netvsc, tap, and failsafe drivers combination

Re: [dpdk-dev] [PATCH v3] ethdev: get rxq interrupt fd

2018-10-02 Thread Ferruh Yigit
On 9/29/2018 3:12 AM, Xiaoyun Li wrote: > Some users want to use their own epoll instances to control both > DPDK rxq interrupt fds and their own other fds. So added a function > to get rxq interrupt fd based on port id and queue id. > > Signed-off-by: Xiaoyun Li Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-02 Thread Raslan Darawsheh
It should be as of per device so we should do it for each port alone since several ports can have different queues. Moreover, if the port that has the registration was closed or unplugged we'll not be able to sync qeues for other ports. Kindest regards, Raslan Darawsheh -Original Message-

[dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask

2018-10-02 Thread Jerin Jacob
Fixes missing PKT_TX_UDP_SEG, PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. Also sort them in bit wise order to recognize missing items later. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Fixes: 1c3b7c33e977 ("mbuf: add Tx off

[dpdk-dev] [PATCH v2 1/2] ethdev: add SCTP Rx checksum offload support

2018-10-02 Thread Jerin Jacob
Added SCTP Rx checksum offload support Signed-off-by: Jerin Jacob --- v2: - Fix printf formatting error(Ferruh Yigit) --- app/test-pmd/config.c | 9 + doc/guides/nics/features.rst | 4 ++-- lib/librte_ethdev/rte_ethdev.c | 1 + lib/librte_ethdev/rte_ethdev.h | 1 + 4 files cha

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-02 Thread Marco Varlese
On Mon, 2018-10-01 at 12:24 +0100, Luca Boccassi wrote: > On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote: > > > On Mon, 01 Oct 2018 10:46:02 +0100 > > > Luca Boccassi wrote: > > > > > > > On Mon, 2018-10-01 at 10:25

Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

2018-10-02 Thread Iremonger, Bernard
Hi Jens, > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Tuesday, October 2, 2018 8:44 AM > To: dev@dpdk.org > Cc: ai...@redhat.com; jan.scheur...@ericsson.com; Richardson, Bruce > ; tho...@monjalon.net; > maxime.coque...@redhat.com; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process

2018-10-02 Thread Thomas Monjalon
02/10/2018 12:50, Raslan Darawsheh: > From: Thomas Monjalon > > 02/10/2018 12:34, Raslan Darawsheh: > > > @@ -2056,6 +2179,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > > > > > > TAP_LOG(NOTICE, "Initializing pmd_tap for %s as %s", > > > > > > name, tap_

Re: [dpdk-dev] [PATCH v6 1/8] net/mvneta: add neta PMD skeleton

2018-10-02 Thread Ferruh Yigit
On 10/1/2018 10:26 AM, Andrzej Ostruszka wrote: > From: Zyta Szpak > > Add neta pmd driver skeleton providing base for the further > development. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Yelena Krivosheev > Signed-off-by: Dmitri Epshtein > Signed-off-by: Zyta Szpak > Signed-off-b

Re: [dpdk-dev] [PATCH v6 2/8] net/mvneta: add Rx/Tx support

2018-10-02 Thread Ferruh Yigit
On 10/1/2018 10:26 AM, Andrzej Ostruszka wrote: > From: Zyta Szpak > > Add part of PMD for actual reception/transmission. > > Signed-off-by: Yelena Krivosheev > Signed-off-by: Dmitri Epshtein > Signed-off-by: Zyta Szpak <...> > @@ -0,0 +1,850 @@ > +#include "mvneta_rxtx.h" > + > +uint64_t c

Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

2018-10-02 Thread Kevin Traynor
On 10/02/2018 08:44 AM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > As there's going to be a v9 anyway, you can also fix the bel

Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-10-02 Thread Bruce Richardson
On Tue, Oct 02, 2018 at 01:02:26PM +0200, Marco Varlese wrote: > On Mon, 2018-10-01 at 12:24 +0100, Luca Boccassi wrote: > > On Mon, 2018-10-01 at 12:06 +0100, Bruce Richardson wrote: > > > On Mon, Oct 01, 2018 at 12:42:09PM +0200, Timothy Redaelli wrote: > > > > On Mon, 01 Oct 2018 10:46:02 +0100

[dpdk-dev] [PATCH v12 1/7] bus: add hot-unplug handler

2018-10-02 Thread Jeff Guo
A hot-unplug failure and app crash can be caused, when a device is hot-unplugged but the application still try to access the device by reading or writing from the BARs, which is already invalid but still not timely be unmap or released. This patch introduces bus ops to handle hot-unplug failures.

[dpdk-dev] [PATCH v12 2/7] bus/pci: implement hot-unplug handler ops

2018-10-02 Thread Jeff Guo
This patch implements the ops to handle hot-unplug on the PCI bus. For UIO PCI, it could avoids BARs read/write errors by creating a new dummy memory to remap the memory where the failure is. For VFIO or other kernel driver, it could specific implement function to handle hot-unplug case by case. S

[dpdk-dev] [PATCH v12 0/7] hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
Hotplug is an important feature for use-cases like the datacenter device's fail-safe and for SRIOV Live Migration in SDN/NFV. It could bring higher flexibility and continuality to networking services in multiple use-cases in the industry. So let's see how DPDK can help users implement hotplug solut

[dpdk-dev] [PATCH v12 4/7] bus/pci: implement sigbus handler ops

2018-10-02 Thread Jeff Guo
This patch implements the ops for the PCI bus sigbus handler. It finds the PCI device that is being hot-unplugged and calls the relevant ops of the hot-unplug handler to handle the hot-unplug failure of the device. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v12->v11: no change. --- drive

[dpdk-dev] [PATCH v12 3/7] bus: add sigbus handler

2018-10-02 Thread Jeff Guo
When a device is hot-unplugged, a sigbus error will occur of the datapath can still read/write to the device. A handler is required here to capture the sigbus signal and handle it appropriately. This patch introduces a bus ops to handle sigbus errors. Each bus can implement its own case-dependent

[dpdk-dev] [PATCH v11 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-02 Thread Jeff Guo
The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure of the corresponding device by invoke the hot-unplug handler. It could prevent the applicat

[dpdk-dev] [PATCH v12 5/7] bus: add helper to handle sigbus

2018-10-02 Thread Jeff Guo
This patch aims to add a helper to iterate over all buses to find the relevant bus to handle the sigbus error. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v12->v11: no change. --- lib/librte_eal/common/eal_common_bus.c | 43 ++ lib/librte_eal/common/eal_pri

[dpdk-dev] [PATCH v11 7/7] testpmd: use hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
This patch use testpmd for example, to show how an app smoothly handle failure when device be hot-unplug. Except app should enabled the device event monitor and register the hotplug event’s callback, it also need enable hotplug handle mechanism before running. Once app detect the removal event, the

[dpdk-dev] [PATCH v12 1/7] bus: add hot-unplug handler

2018-10-02 Thread Jeff Guo
A hot-unplug failure and app crash can be caused, when a device is hot-unplugged but the application still try to access the device by reading or writing from the BARs, which is already invalid but still not timely be unmap or released. This patch introduces bus ops to handle hot-unplug failures.

[dpdk-dev] [PATCH v12 0/7] hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
Hotplug is an important feature for use-cases like the datacenter device's fail-safe and for SRIOV Live Migration in SDN/NFV. It could bring higher flexibility and continuality to networking services in multiple use-cases in the industry. So let's see how DPDK can help users implement hotplug solut

[dpdk-dev] [PATCH v12 2/7] bus/pci: implement hot-unplug handler ops

2018-10-02 Thread Jeff Guo
This patch implements the ops to handle hot-unplug on the PCI bus. For UIO PCI, it could avoids BARs read/write errors by creating a new dummy memory to remap the memory where the failure is. For VFIO or other kernel driver, it could specific implement function to handle hot-unplug case by case. S

[dpdk-dev] [PATCH v12 3/7] bus: add sigbus handler

2018-10-02 Thread Jeff Guo
When a device is hot-unplugged, a sigbus error will occur of the datapath can still read/write to the device. A handler is required here to capture the sigbus signal and handle it appropriately. This patch introduces a bus ops to handle sigbus errors. Each bus can implement its own case-dependent

[dpdk-dev] [PATCH v12 5/7] bus: add helper to handle sigbus

2018-10-02 Thread Jeff Guo
This patch aims to add a helper to iterate over all buses to find the relevant bus to handle the sigbus error. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v12->v11: no change. --- lib/librte_eal/common/eal_common_bus.c | 43 ++ lib/librte_eal/common/eal_pri

[dpdk-dev] [PATCH v12 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-02 Thread Jeff Guo
The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure of the corresponding device by invoke the hot-unplug handler. It could prevent the applicat

[dpdk-dev] [PATCH v12 7/7] testpmd: use hot-unplug failure handle mechanism

2018-10-02 Thread Jeff Guo
This patch use testpmd for example, to show how an app smoothly handle failure when device be hot-unplug. Except app should enabled the device event monitor and register the hotplug event’s callback, it also need enable hotplug handle mechanism before running. Once app detect the removal event, the

[dpdk-dev] [PATCH v12 4/7] bus/pci: implement sigbus handler ops

2018-10-02 Thread Jeff Guo
This patch implements the ops for the PCI bus sigbus handler. It finds the PCI device that is being hot-unplugged and calls the relevant ops of the hot-unplug handler to handle the hot-unplug failure of the device. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v12->v11: no change. --- drive

[dpdk-dev] [PATCH v2 2/4] eal: modify device event callback process func

2018-10-02 Thread Jeff Guo
This patch modify the device event callback process function name to be more explicit, change the variable to be const. And more, because not only eal device helper will use the callback, but also vfio bus will use the callback to handle hot-unplug, so exposure the API out from private eal. The bus

[dpdk-dev] [PATCH v2 1/4] eal: add a new req notifier to eal interrupt

2018-10-02 Thread Jeff Guo
Add a new req notifier in eal interrupt for enable vfio hotplug. Signed-off-by: Jeff Guo --- v3->v2: change some code sytle to make consistent. --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++ 2 files c

[dpdk-dev] [PATCH v2 0/4] Enable hotplug in vfio

2018-10-02 Thread Jeff Guo
As we may know that the process of hotplug is different between igb_uio and vfio. For igb_uio, it could use uevent notification and memory failure handle mechanism for hot-unplug. But for vfio, when device is be hot-unplugged, the uevent can not be detected immediately, because of the vfio kernel m

[dpdk-dev] [PATCH v2 3/4] pci: add req handler field to generic pci device

2018-10-02 Thread Jeff Guo
There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, they could be useful for device error monitoring. And these corresponding interrupt handler is different from the other interrupt handler that register in PMDs, so a new int

[dpdk-dev] [PATCH v2 4/4] vfio: enable vfio hotplug by req notifier handler

2018-10-02 Thread Jeff Guo
When device is be hot-unplugged, the vfio kernel module will sent req notifier to request user space to release the allocated resources at first. After that, vfio kernel module will detect the device disappear, and then delete the device in kernel. This patch aim to add req notifier processing to

Re: [dpdk-dev] [PATCH v2 1/5] net/bnx2x: fix logging to include dev name

2018-10-02 Thread Ferruh Yigit
On 9/29/2018 6:42 AM, Mody, Rasesh wrote: > Fix PMD logging scheme to include device name in the messages printed. > > Fixes: 540a211084a7 ("bnx2x: driver core") > Cc: sta...@dpdk.org > > Signed-off-by: Rasesh Mody Series applied to dpdk-next-net/master, thanks.

[dpdk-dev] DPDK passthrough to container in virtual machine

2018-10-02 Thread Periyasamy Palanisamy
Hi, I'm trying to do OVS DPDK vhost port passthrough to a container resides in the VM. Here are steps followed: 1. Add DPDK port into OVS integration bridge. 2. Bring up an Ubuntu VM using virsh with vhostuser interface configuration. 3. In th

  1   2   3   >