Re: [dpdk-dev] [PATCH] bus/vdev: fix uninitialized device bus

2018-10-22 Thread Thomas Monjalon
22/10/2018 07:47, Qi Zhang: > Device bus should be initialized after bus scan. > While it does not happened when scan vdev from secondary process, > that cause segment fault at rte_dev_probe when call dev->bus->xxx. > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") > Cc: sta...@d

Re: [dpdk-dev] [PATCH v5 0/3] security: support for pdcp

2018-10-22 Thread Hemant Agrawal
On 10/18/2018 8:10 PM, Thomas Monjalon wrote: > 16/10/2018 16:35, Akhil Goyal: >>> Akhil Goyal (3): >>> security: support pdcp protocol >>> crypto/dpaa2_sec: add sample pdcp descriptor apis >>> crypto/dpaa2_sec: support pdcp offload >>> >>>doc/guides/prog_guide/rte_security.rst

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-22 Thread Mattias Rönnblom
On 2018-10-19 12:16, Laatz, Kevin wrote: On 03/10/2018 20:06, Mattias Rönnblom wrote: On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara Power + +    if (!telemetry->request_client) { +    TELEMETRY_LOG_ERR("No client has been chosen to write to"); +    return -1; +    } > + +    if (

[dpdk-dev] [PATCH v6 3/3] crypto/dpaa2_sec: support pdcp offload

2018-10-22 Thread Hemant Agrawal
From: Akhil Goyal PDCP session configuration for lookaside protocol offload and data path is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 258 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 208 ++

[dpdk-dev] [PATCH v6 1/3] security: support pdcp protocol

2018-10-22 Thread Hemant Agrawal
From: Akhil Goyal Packet Data Convergence Protocol (PDCP) is added in rte_security for 3GPP TS 36.323 for LTE. The patchset provide the structure definitions for configuring the PDCP sessions and relevant documentation is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal Acked-b

[dpdk-dev] [PATCH v6 0/3] security: support for pdcp

2018-10-22 Thread Hemant Agrawal
Security library currently only has support for IPSec protocol. This patchset defines structures for pdcp protocol in rte_security and provide a sample driver implementation for lookaside protocol offload to support PDCP. Changes in v6: - fix doxygen and clang compilation errors Changes in v5: -

[dpdk-dev] [PATCH v6 2/3] crypto/dpaa2_sec: add sample pdcp descriptor apis

2018-10-22 Thread Hemant Agrawal
From: Akhil Goyal DPAA2 SEC platform can support look aside protocol offload for PDCP protocol. The relevant APIs for configuring the hardware for PDCP is added for various modes and crypto algorithms. Signed-off-by: Hemant Agrawal Signed-off-by: Horia Geanta Neag Signed-off-by: Alex Porosanu

Re: [dpdk-dev] [PATCH] vhost: avoid memory barriers when no descriptors dequeued

2018-10-22 Thread Tiwei Bie
On Fri, Oct 19, 2018 at 04:00:58PM +0200, Maxime Coquelin wrote: > In both split and packed dequeue paths, flush_shadow_used_ring > and vhost_ring_call variants gets called even if not packets > have been dequeued, and so no descriptors updates happened. > > It has an impact on CPU pipeline, as me

Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer

2018-10-22 Thread Thomas Monjalon
22/10/2018 07:49, Qi Zhang: > After we insert a devargs into devargs_list, following bus->scan may > destroy it due to another rte_devargs_insert. Its better not to use > a devargs pointer after it has been inserted. I think the problem is in: rte_devargs_insert(struct rte_devargs *da) { int

Re: [dpdk-dev] [PATCH] eal: fix NULL device argument pointer reference

2018-10-22 Thread Thomas Monjalon
22/10/2018 08:15, Qi Zhang: > dev->devargs is not initialized for PCI device, so use dev->bus to > replace dev->devargs->bus to avoid segment fault when hotplug remove > a PCI device. It is not really specific to PCI device. The devargs is not initialized if the device is probed by default policy

[dpdk-dev] Change ether_addr to avoid conflict

2018-10-22 Thread Lewis Donzis
Please consider changing “struct ether_addr” in rte_ether.h to “struct rte_ether_addr”, in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h. This is kind of a pain for us since we would like to include ethernet.h in order to get some other definitions, but we ca

Re: [dpdk-dev] [PATCH] test: reduce duration for timer autotest

2018-10-22 Thread Parthasarathy, JananeeX M
Hi Reshma, >-Original Message- >From: Pattan, Reshma >Sent: Wednesday, October 10, 2018 9:54 PM >To: Parthasarathy, JananeeX M ; >dev@dpdk.org >Cc: rsanf...@akamai.com >Subject: RE: [PATCH] test: reduce duration for timer autotest > >Hi > >> -Original Message- >> From: Parthasarath

[dpdk-dev] [PATCH v1] net/i40e: enable the loopback function if it is X722 MAC

2018-10-22 Thread Haiyue Wang
In FVL, there was an issue and it didn't support the loopback function before FW 5.0. For FPK (X722) it should work. So it needs to distinguish between the devices by checking MAC type. Fixes: 689bba33272d (i40e: add VEB switching support) Fixes: bce83974ba2c (net/i40e: set Tx loopback from PF)

Re: [dpdk-dev] Build DPDK for different target machine.

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 5:24 PM, Shubhachint, Chaitanya wrote: > Hello, > > I am trying to build DPDK library set (shared) so that there are somewhat > portable. I want to build them once on a designated build machine and run > them on other machines of similar architecture. I can build DPDK and use it >

Re: [dpdk-dev] [PATCH v8] linuxapp, eal: Fix the memory leak issue of logid

2018-10-22 Thread Thomas Monjalon
12/09/2018 03:31, Ziye Yang: > From: Ziye Yang > > This patch is used to fix the memory leak issue of logid. > We use the ASAN test in SPDK when intergrating DPDK and > find this memory leak issue. > > Signed-off-by: Ziye Yang > --- > - logid = strrchr(argv[0], '/'); > - logid = strdup(

Re: [dpdk-dev] [dpdk-users] IPV4/IPV6 TCP/UDP Pseudo Header Checksum APIs

2018-10-22 Thread Ferruh Yigit
On 10/20/2018 7:30 AM, Shyam Shrivastav wrote: > Yes you are right, I misread, following code (ipv4 case) assumes no ip > options while calculating pseudo hdr length field > > psd_hdr.len = rte_cpu_to_be_16( > (uint16_t)(rte_be_to_cpu_16(ipv4_hdr->total_length) >

[dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS

2018-10-22 Thread Wei Zhao
Some user and tester require flow RSS to support more types, so and "all" and "none" to make configuration more easy for users. Signed-off-by: Wei Zhao --- app/test-pmd/config.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index bf3cd0a..f

Re: [dpdk-dev] [PATCH] vhost: avoid memory barriers when no descriptors dequeued

2018-10-22 Thread Maxime Coquelin
On 10/22/2018 09:15 AM, Tiwei Bie wrote: On Fri, Oct 19, 2018 at 04:00:58PM +0200, Maxime Coquelin wrote: In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It

[dpdk-dev] [PATCH v2 0/2] Add and identify shaper profile parameters

2018-10-22 Thread Rosen Xu
v2 updates: == - Updated commmand section - Updated the documentation v1 updates: == - Added committed and peak parameters As struct rte_tm_shaper_params defined, the command line of test-pmd should include committed and peak parameters, but right now the command line doesn't i

[dpdk-dev] [PATCH v2 2/2] [PATCH v2 2/2] doc/guides/testpmd_app_ug: update documentation for added shaper profile parameters

2018-10-22 Thread Rosen Xu
Update documentation for committed and peak parameters of shaper profile Signed-off-by: Rosen Xu --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/t

[dpdk-dev] [PATCH v2 1/2] [PATCH v2 1/2] app/test-pmd: add and identify shaper profile parameters

2018-10-22 Thread Rosen Xu
As struct rte_tm_shaper_params defined, the command line of test-pmd should include committed and peak parameters, but right now the command line doesn't identify whether it's committed or peak parameter. This patch identifies and adds the clarify definition Signed-off-by: Rosen Xu iFixes: bddc2f

Re: [dpdk-dev] [PATCH] app/test-pmd: add and identify shaper profile parameters

2018-10-22 Thread Xu, Rosen
> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, October 16, 2018 23:01 > To: Xu, Rosen > Cc: Lu, Wenzhuo ; Yigit, Ferruh > ; Singh, Jasvinder ; > dev@dpdk.org > Subject: RE: [PATCH] app/test-pmd: add and identify shaper profile > parameters > > > > > Can you also upd

Re: [dpdk-dev] [PATCH] app/test-pmd: add and identify shaper profile parameters

2018-10-22 Thread Xu, Rosen
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, September 25, 2018 19:56 > To: Xu, Rosen ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Yigit, Ferruh > Subject: RE: [PATCH] app/test-pmd: add and identify shaper profile > parameters > > > > > -Original

Re: [dpdk-dev] [PATCH] doc: spelling fixes

2018-10-22 Thread Kovacevic, Marko
> Trivial pelling errors found by codespell. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/eventdevs/opdl.rst | 2 +- > doc/guides/nics/axgbe.rst | 2 +- > doc/guides/nics/enic.rst | 2 +- > doc/guides/nics/mvpp2.rst | 2 +- > doc/guides/nics/virtio.rst| 2 +- > 5 file

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-22 Thread Burakov, Anatoly
On 19-Oct-18 5:43 PM, Alejandro Lucero wrote: Invoking the right pci read/write functions is based on interrupt handler type. However, this is not configured for secondary processes precluding to use those functions. This patch fixes the issue using the driver name the device is bound to instead

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-22 Thread Laatz, Kevin
Hi Mattias, Thanks for the input and clarification. I will include these changes in the v6. Regards, Kevin On 22/10/2018 08:11, Mattias Rönnblom wrote: On 2018-10-19 12:16, Laatz, Kevin wrote: On 03/10/2018 20:06, Mattias Rönnblom wrote: On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara

Re: [dpdk-dev] [PATCH v5 4/4] net/mlx5: support e-switch flow count action

2018-10-22 Thread Ferruh Yigit
On 10/18/2018 7:29 PM, Moti Haimovsky wrote: > +/** > + * Parse flower action section in the message retrieving the requested > + * attribute from the first action that provides it. > + * > + * @param opt > + * flower section in the Netlink message received. > + * @param rta_type > + * The back

Re: [dpdk-dev] testpmd crashes with Invalid NUMA socket, default to 0

2018-10-22 Thread Burakov, Anatoly
On 22-Oct-18 7:34 AM, Kenvish Butani wrote: Hi All, I am new to dpdk, and trying it to integrate DPDK with one of my server having intel nic's and 24 core cpu. I am trying to run testpmd app and it gets crashed with below logs ++ # ./testpmd-cc-on-local -c 0

Re: [dpdk-dev] [PATCH v2 13/14] crypto/caam_jr: add security offload

2018-10-22 Thread Thomas Monjalon
19/10/2018 04:17, Thomas Monjalon: > 12/10/2018 16:40, Gagandeep Singh: > > From: Hemant Agrawal > > > > This patch provides the support for protocol offload > > to the hardware. following security operations are > > added: > > - session_create > > - session_destroy > > - capabilities_get > >

Re: [dpdk-dev] testpmd crashes with Invalid NUMA socket, default to 0

2018-10-22 Thread Kenvish Butani
Thanks a lot for your prompt reply ! JFYI, The invalid NUma socket was resolved by manually changing the entry to 0 echo 0 > /sys/bus/pci/devices/\:01\:00.0/uio/uio0/device/numa_node echo 0 > /sys/bus/pci/devices/\:01\:00.1/uio/uio1/device/numa_node # ./testpmd-cc-on-local -c 0xF -n 1 --

Re: [dpdk-dev] [PATCH] doc/qos_meter: update application information

2018-10-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Varghese, Vipin > Sent: Saturday, October 20, 2018 3:11 PM > To: Dumitrescu, Cristian ; dev@dpdk.org; > Singh, Jasvinder > Cc: Byrne, Stephen1 > Subject: RE: [PATCH] doc/qos_meter: update application information > > Hi Cristian, > > If rewording for 0 to

Re: [dpdk-dev] [PATCH v3 0/7] Improve core EAL musl compatibility

2018-10-22 Thread Thomas Monjalon
04/10/2018 12:20, Anatoly Burakov: > This patchset fixes numerous issues with musl compatibility > in the core EAL libraries. It does not fix anything beyond > core EAL (so, PCI driver is still broken, so are a few other > drivers), but it's a good start. > > Tested on container with Alpine Linux.

Re: [dpdk-dev] [PATCH v2 0/2] Add and identify shaper profile parameters

2018-10-22 Thread Singh, Jasvinder
> -Original Message- > From: Xu, Rosen > Sent: Monday, October 22, 2018 9:47 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; Xu, > Rosen ; Yigit, Ferruh > Subject: [PATCH v2 0/2] Add and identify shaper profile parameters > > v2 updates: >

Re: [dpdk-dev] testpmd crashes with Invalid NUMA socket, default to 0

2018-10-22 Thread Burakov, Anatoly
On 22-Oct-18 10:28 AM, Kenvish Butani wrote: Thanks a lot for your prompt reply ! JFYI, The invalid NUma socket was resolved by manually changing the entry to 0 echo 0 > /sys/bus/pci/devices/\:01\:00.0/uio/uio0/device/numa_node echo 0 > /sys/bus/pci/devices/\:01\:00.1/uio/uio1/device/

Re: [dpdk-dev] [PATCH v2 13/14] crypto/caam_jr: add security offload

2018-10-22 Thread Hemant Agrawal
Gagan is working on it. On 10/22/2018 2:56 PM, Thomas Monjalon wrote: > 19/10/2018 04:17, Thomas Monjalon: >> 12/10/2018 16:40, Gagandeep Singh: >>> From: Hemant Agrawal >>> >>> This patch provides the support for protocol offload >>> to the hardware. following security operations are >>> added:

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/linuxapp: improve segment list preallocation

2018-10-22 Thread Thomas Monjalon
05/10/2018 10:29, Anatoly Burakov: > Current code to preallocate segment lists is trying to do > everything in one go, and thus ends up being convoluted, > hard to understand, and, most importantly, does not scale beyond > initial assumptions about number of NUMA nodes and number of > page sizes, a

Re: [dpdk-dev] [PATCH] bus/vdev: fix uninitialized device bus

2018-10-22 Thread Thomas Monjalon
22/10/2018 09:02, Thomas Monjalon: > 22/10/2018 07:47, Qi Zhang: > > Device bus should be initialized after bus scan. > > While it does not happened when scan vdev from secondary process, > > that cause segment fault at rte_dev_probe when call dev->bus->xxx. > > > > Fixes: cdb068f031c6 ("bus/vdev:

Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS

2018-10-22 Thread Iremonger, Bernard
Hi Zhao, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Monday, October 22, 2018 8:49 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH] app/testpmd: support more types for flow R

Re: [dpdk-dev] [PATCH] eal: fix NULL device argument pointer reference

2018-10-22 Thread Thomas Monjalon
22/10/2018 09:30, Thomas Monjalon: > 22/10/2018 08:15, Qi Zhang: > > dev->devargs is not initialized for PCI device, so use dev->bus to > > replace dev->devargs->bus to avoid segment fault when hotplug remove > > a PCI device. > > It is not really specific to PCI device. > The devargs is not initi

[dpdk-dev] [PATCH v6 00/13] introduce telemetry library

2018-10-22 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

[dpdk-dev] [PATCH v6 01/13] eal: add option register infrastructure

2018-10-22 Thread Kevin Laatz
This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of EAL init. This infrastructure allows libraries that depend on EAL to be initialized as part of EAL init, removing circular dependency iss

[dpdk-dev] [PATCH v6 03/13] telemetry: initial telemetry infrastructure

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds the infrastructure and initial code for the telemetry library. The telemetry init is registered with eal_init(). We can then check to see if --telemetry was passed as an eal option. If --telemetry was parsed, then we call telemetry init at the end of eal init.

[dpdk-dev] [PATCH v6 05/13] telemetry: add client feature and sockets

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a clien

[dpdk-dev] [PATCH v6 04/13] telemetry: add initial connection socket

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-

[dpdk-dev] [PATCH v6 02/13] eal: make get runtime dir function public

2018-10-22 Thread Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used from outside EAL. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- Note: I have added rte_eal_get_runtime_dir() to the 18.11 version in the .map file instead of the EXPERIMENTAL section as the function already exis

[dpdk-dev] [PATCH v6 07/13] telemetry: update metrics before sending stats

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent pat

[dpdk-dev] [PATCH v6 08/13] telemetry: format json response when sending stats

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

[dpdk-dev] [PATCH v6 06/13] telemetry: add parser for client socket messages

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent

[dpdk-dev] [PATCH v6 09/13] telemetry: add tests for telemetry api

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in t

[dpdk-dev] [PATCH v6 11/13] doc: add telemetry documentation

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: K

[dpdk-dev] [PATCH v6 13/13] build: add dependency on telemetry to apps in meson

2018-10-22 Thread Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these changes, the --telemetry flag will not be recognised and applications will fail to run if they want to enable telemetry. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- app/mes

[dpdk-dev] [PATCH v6 12/13] usertools: add client python script for telemetry

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py ". This

[dpdk-dev] [PATCH v6 10/13] telemetry: add ability to disable selftest

2018-10-22 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to enable/disable the selftest. This functionality will be extended in future to make the enabling/disabling more dynamic and remove this 'hardcoded' approach. We are temporarily using this approach due to the design changes (vdev vs eal) made to t

Re: [dpdk-dev] testpmd crashes with Invalid NUMA socket, default to 0

2018-10-22 Thread Kenvish Butani
Thanks a lot Anatoly for your inputs ! *This got fixed by reserving total of "512" hugepages.* Thanks a lot :) Appreciate. Thanks, --Kenvish On Mon, Oct 22, 2018 at 3:16 PM Burakov, Anatoly wrote: > On 22-Oct-18 10:28 AM, Kenvish Butani wrote: > > Thanks a lot for your prompt reply ! > > > >

Re: [dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 9:35 AM, Jeff Guo wrote: > > On 10/19/2018 12:06 AM, Ferruh Yigit wrote: >> On 10/18/2018 7:27 AM, Jeff Guo wrote: >>> When a device is hot-unplugged, pci_remove will be invoked unexpectedly >>> before pci_release, it will caused kernel hung issue which will throw the >>> error info

Re: [dpdk-dev] testpmd crashes with Invalid NUMA socket, default to 0

2018-10-22 Thread Burakov, Anatoly
On 22-Oct-18 12:08 PM, Kenvish Butani wrote: Thanks a lot Anatoly for your inputs ! *This got fixed by reserving total of "512" hugepages.* Thanks a lot :) Appreciate. You're welcome :) Thanks, --Kenvish On Mon, Oct 22, 2018 at 3:16 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>>

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-22 Thread Hideyuki Yamashita
Hello Thomas, Thanks for your info. What is the difference between using rte_eth_dev_get_port_by_name and RTE_ETH_FOREACH_MATCHING_DEV? I think using rte_eth_dev_get_port_by_name is workable. (In fact I modified my code already and it worked with no problem) So my question is "what is the dif

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-22 Thread Thomas Monjalon
Hi, The better approach is using RTE_ETH_FOREACH_MATCHING_DEV for 2 reasons: - it is a loop, so work if multiple ports are matching - it uses devargs parameter, which is what the user requests Note: your code assumes that the ethdev name is devargs.name. It can be true by chance,

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-10-22 Thread Ferruh Yigit
On 8/23/2018 9:58 AM, Andrew Rybchenko wrote: > On 22.08.2018 19:55, Ferruh Yigit wrote: >> On 8/14/2018 1:57 AM, Lu, Wenzhuo wrote: >>> Hi Andrew, >>> -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Monday, August 13, 2018 4:39 PM To:

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-10-22 Thread Thomas Monjalon
22/10/2018 14:01, Ferruh Yigit: > On 8/23/2018 9:58 AM, Andrew Rybchenko wrote: > > On 22.08.2018 19:55, Ferruh Yigit wrote: > >> On 8/14/2018 1:57 AM, Lu, Wenzhuo wrote: > >>> Hi Andrew, > >>> > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] >

Re: [dpdk-dev] [PATCH v6 11/13] doc: add telemetry documentation

2018-10-22 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kevin Laatz > Sent: Monday, October 22, 2018 12:00 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > step...@networkplumber.org; gaetan.ri...@6wind.com; > shreyansh.j...@nxp.com; tho...@monjalon.net; > mattias.ron

Re: [dpdk-dev] [PATCH v2 2/2] [PATCH v2 2/2] doc/guides/testpmd_app_ug: update documentation for added shaper profile parameters

2018-10-22 Thread Kovacevic, Marko
> Update documentation for committed and peak parameters of shaper > profile > > Signed-off-by: Rosen Xu > --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Doc patch is ok just the commit heading is a but long Running git log c

Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation

2018-10-22 Thread Verma, Shally
>-Original Message- >From: dev On Behalf Of Akhil Goyal >Sent: 16 October 2018 18:51 >To: Saxena, Akash ; pablo.de.lara.gua...@intel.com >Cc: dev@dpdk.org; Verma, Shally ; Verma, Ayuj > >Subject: Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification >at rsa verify operati

[dpdk-dev] [PATCH v6 0/7] replace attach/detach functions

2018-10-22 Thread Thomas Monjalon
The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RT

Re: [dpdk-dev] [PATCH v2 02/14] crypto/caam_jr: add HW tuning options

2018-10-22 Thread Gagandeep Singh
Hi > -Original Message- > From: Thomas Monjalon > Sent: Friday, October 19, 2018 2:42 PM > To: Gagandeep Singh > Cc: dev@dpdk.org; Akhil Goyal ; Hemant Agrawal > > Subject: Re: [dpdk-dev] [PATCH v2 02/14] crypto/caam_jr: add HW tuning > options > > 12/10/2018 16:40, Gagandeep Singh: >

[dpdk-dev] [PATCH v6 1/7] bus/vdev: add iteration filter on name

2018-10-22 Thread Thomas Monjalon
A virtual device can be matched with following syntax: bus=vdev,name=X Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- drivers/bus/vdev/vdev_params.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_params.c

[dpdk-dev] [PATCH v6 3/7] ethdev: allow iterating with pure class filter

2018-10-22 Thread Thomas Monjalon
If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a devargs filter referencing only some ethdev parameters. The format (from the new devargs syntax) is: class=eth,paramY=Y

[dpdk-dev] [PATCH v6 5/7] ethdev: remove deprecated attach/detach functions

2018-10-22 Thread Thomas Monjalon
The hotplug attach/detach features are implemented in EAL layer. There is a new ethdev iterator to retrieve ports from ethdev layer. As announced earlier, the (buggy) ethdev functions are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v6 6/7] eal: remove deprecated attach/detach functions

2018-10-22 Thread Thomas Monjalon
These hotplug functions were deprecated and have some new replacements. As announced earlier, the oldest ones are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 5 --- doc/guides/rel_notes/release_18_11.rst | 6 +++ lib

[dpdk-dev] [PATCH v6 2/7] ethdev: add iterator to match devargs input

2018-10-22 Thread Thomas Monjalon
The iterator will return the ethdev port ids matching a devargs string. It is recommended to use the macro RTE_ETH_FOREACH_MATCHING_DEV() for usage convenience. The class string is prefixed with '+' in order to skip the validation of the parameter keys. It is tolerated for the compatibility with t

[dpdk-dev] [PATCH v6 7/7] app/testpmd: check not detaching device twice

2018-10-22 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. After detaching, the pointer, which maps a port to its device, is resetted. This way, it is possible to check whether a port is still associated to a (not removed) device. Signed-off-by: Thomas Mon

[dpdk-dev] [PATCH v6 4/7] doc: replace doxygen example in contribution guide

2018-10-22 Thread Thomas Monjalon
The provided example of doxygen header is about a deprecated function. It is replaced by rte_spinlock_trylock() which is small and good enough for the purpose. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/contributing/documentation.rst | 15 +-- 1 file

Re: [dpdk-dev] [PATCH v12 5/5] doc: update release notes for empty poll library

2018-10-22 Thread Kovacevic, Marko
Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 1:23 AM, Dan Gora wrote: > Update KNI example to add the command line flag '-m' to enable > a function to continuously monitor the Ethernet link status of > the physical link and update the link status of the corresponding > interfaces with rte_kni_update_link(). > > Signed-off-by: D

[dpdk-dev] [PATCH] mem: fix resource leak

2018-10-22 Thread Anatoly Burakov
Segment preallocation code allocates an array of structures on the heap but does not free the memory afterwards. Fix it by freeing it at the end of the function, and changing control flow to always go through that code path. Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") Coverity

Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 1:23 AM, Dan Gora wrote: > Hi All, > > Attached is version 5 of a patchset to add a new API function to > set the link status on kernel interfaces created with the KNI kernel > module. > > v5 > > * Update Kernel NIC Interface document with new rte_kni option, move > kernel mo

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Andrew Rybchenko
On 10/17/18 11:43 AM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko Sent: Wednesday, October 17, 2018 10:56 AM To: Ori Kam ; wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; ferruh.yi...@intel.com; step...@networkplumber.org; Adrien Mazarguil Cc: dev@

Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface

2018-10-22 Thread Thomas Monjalon
22/10/2018 15:03, Ferruh Yigit: > On 10/19/2018 1:23 AM, Dan Gora wrote: > > Hi All, > > > > Attached is version 5 of a patchset to add a new API function to > > set the link status on kernel interfaces created with the KNI kernel > > module. > > > > v5 > > > > * Update Kernel NIC Interface

Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface

2018-10-22 Thread Ferruh Yigit
On 10/22/2018 2:08 PM, Thomas Monjalon wrote: > 22/10/2018 15:03, Ferruh Yigit: >> On 10/19/2018 1:23 AM, Dan Gora wrote: >>> Hi All, >>> >>> Attached is version 5 of a patchset to add a new API function to >>> set the link status on kernel interfaces created with the KNI kernel >>> module. >>> >>>

[dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters

2018-10-22 Thread Thomas Monjalon
The new ethdev iterator lacks the support of filtering by representor port id or by MAC address. Changes in v3: - improve comment for representor_id Changes in v2: - fix list parsing in kvargs - support mac= parameter Thomas Monjalon (4): kvargs: support list value ethdev: move repre

[dpdk-dev] [PATCH v3 2/4] ethdev: move representor parsing functions

2018-10-22 Thread Thomas Monjalon
The functions for representor devargs parsing were static in the file rte_ethdev.c. In order to reuse them in the file rte_class_eth.c, they are moved to the files ethdev_private.c/.h. A log is fixed by adding a missing line feed. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- l

[dpdk-dev] [PATCH v3 1/4] kvargs: support list value

2018-10-22 Thread Thomas Monjalon
If a value contains a comma, rte_kvargs_tokenize() will split here. In order to support list syntax [a,b] as value, an extra parsing of the square brackets is added. Signed-off-by: Thomas Monjalon --- lib/librte_kvargs/rte_kvargs.c | 14 ++ test/test/test_kvargs.c| 21 +++

[dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Thomas Monjalon
The MAC addresses of a port can be matched with devargs. As the conflict between rte_ether.h and netinet/ether.h is not resolved, the MAC parsing is done with a rte_cmdline function. As a result, cmdline library becomes a dependency of ethdev. Signed-off-by: Thomas Monjalon --- lib/Makefile

[dpdk-dev] [PATCH v3 3/4] ethdev: support representor id as iterator filter

2018-10-22 Thread Thomas Monjalon
The representor id is added in rte_eth_dev_data in order to be able to match a port with its representor id in devargs. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- drivers/net/i40e/i40e_vf_representor.c | 1 + drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + drivers/net/

Re: [dpdk-dev] [PATCH v5 0/5] kni: add API to set link status on kernel interface

2018-10-22 Thread Thomas Monjalon
22/10/2018 15:14, Ferruh Yigit: > On 10/22/2018 2:08 PM, Thomas Monjalon wrote: > > 22/10/2018 15:03, Ferruh Yigit: > >> On 10/19/2018 1:23 AM, Dan Gora wrote: > >>> Hi All, > >>> > >>> Attached is version 5 of a patchset to add a new API function to > >>> set the link status on kernel interfaces c

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 22, 2018 4:06 PM > To: Ori Kam ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; ferruh.yi...@intel.com; > step...@networkplumber.org; Adrien Mazarguil > > Cc: dev@dpdk.org; Dekel Peled ; T

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Andrew Rybchenko
On 10/22/18 4:19 PM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, October 22, 2018 4:06 PM To: Ori Kam ; wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; ferruh.yi...@intel.com; step...@networkplumber.org; Adrien Mazarguil Cc: dev@dpdk.

[dpdk-dev] [PATCH v3 00/15] Introducing the NXP CAAM job ring driver

2018-10-22 Thread Gagandeep Singh
v2->v3 change-log: * fix CONFIG_RTE_LIBRTE_SECURITY=n compilation. v1->v2 change-log: * Most of the checkpatch warnings and erros are removed * CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS and CONFIG_RTE_PMD_CAAM_JR_DEBUG flags removed * local unlikely macro removed * extra spaces removed and function

[dpdk-dev] [PATCH v3 01/15] crypto/caam_jr: introduce basic driver

2018-10-22 Thread Gagandeep Singh
The caam_jr poll mode crypto driver is supported for NXP SEC 4.x+ (CAAM) hardware accelerator. This driver is by default supported on LE platforms, if it is used on BE platforms like LS104X, config option CONFIG_RTE_LIBRTE_PMD_CAAM_JR_BE can be enabled. This patch add skeleton for caam jobring dri

[dpdk-dev] [PATCH v3 04/15] crypto/caam_jr: add UIO specific operations

2018-10-22 Thread Gagandeep Singh
caam_jr need support from kernel caam driver for job ring initialisation. So to access register space for job ring and allow re configure and map to userspace UIO interface is used. This also allows to handle the caam interrupts from the user space. This patch adds UIO specific operations Signed-

[dpdk-dev] [PATCH v3 06/15] crypto/caam_jr: add device basic ops

2018-10-22 Thread Gagandeep Singh
This patch adds following device operations - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 98 +++- 1 file changed, 97

[dpdk-dev] [PATCH v3 03/15] crypto/caam_jr: add routines to configure HW

2018-10-22 Thread Gagandeep Singh
This patch add routines for configuring the hw to support various features. These routines will be used by the PMD ops. The patch also defines structure and macros used to access hw capabilities. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/cry

[dpdk-dev] [PATCH v3 02/15] crypto/caam_jr: add HW tuning options

2018-10-22 Thread Gagandeep Singh
caam_jr hardware can be tuned for multiple settings like ring depth, coalescing, notification types, cache size etc. These parameter can be used for performance tuning for various platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/

[dpdk-dev] [PATCH v3 07/15] crypto/caam_jr: add queue pair config ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add following ops for configuring queues - queue_pair_setup - queue_pair_release - queue_pair_count Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 64 1 file ch

[dpdk-dev] [PATCH v3 08/15] crypto/caam_jr: add session configuration methods

2018-10-22 Thread Gagandeep Singh
This patch add support to create session configuration of various types i.e. cipher, auth and aead etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 214 +++ 1 file changed, 214 insertions(

[dpdk-dev] [PATCH v3 09/15] crypto/caam_jr: add device cababilities

2018-10-22 Thread Gagandeep Singh
add device capabilities for supported algorithms, key length etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/Makefile | 1 + drivers/crypto/caam_jr/caam_jr.c | 2 + drivers/crypto/caam_jr/caam_jr_

[dpdk-dev] [PATCH v3 05/15] crypto/caam_jr: add basic job ring routines

2018-10-22 Thread Gagandeep Singh
This patch adds following job ring routines - init_job_ring (configure hw/sw resources) - shutdown_job_ring (releases hw/sw resources) - close_job_ring (flush job ring) Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c |

[dpdk-dev] [PATCH v3 10/15] crypto/caam_jr: add enqueue dequeue operations

2018-10-22 Thread Gagandeep Singh
This patch add support for : 1. creating run time sec hw decriptors for a given request. 2. enqueue operation to the caam jr ring 3. dequeue operation from the caam jr ring in poll mode 4. creating a crypto protocol descriptor for session - first time. Signed-off-by: Gagandeep Singh Signed-off-by

[dpdk-dev] [PATCH v3 11/15] crypto/caam_jr: add scatter gather

2018-10-22 Thread Gagandeep Singh
This patch add the scatter gather feature for auth-only, cipher-only and cipher-auth operations Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 375 ++- 1 file changed, 374 insertions(+), 1 de

[dpdk-dev] [PATCH v3 12/15] crypto/caam_jr: add statistics ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the following statistics operations: - stats_get - stats_reset Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 54 1 file changed, 54 insertions(+

  1   2   >